contrib/gin-gonic/gin: support globalconfig.ServiceName() #767
Labels
apm:ecosystem
contrib/* related feature requests or bugs
proposal
more in depth change that requires full team approval
Comments
gbbr
changed the title
gbbr
added
apm:ecosystem
|
I'd be happy if you were to open a PR for this. And yes, I agree with you that the signature of |
marcind
added a commit
to marcind/dd-trace-go
that referenced
this issue
Nov 17, 2020
This change adds support for `globalconfig.ServiceName()` to the gin trace middleware. Because this middleware does not follow the same pattern as other http frameworks and requires a service parameter to be passed in we use the empty string value as an indicator that the default service name should be used. Fixes DataDog#767
knusbaum
pushed a commit
that referenced
this issue
Dec 10, 2020
This change adds support for `globalconfig.ServiceName()` to the gin trace middleware. Because this middleware does not follow the same pattern as other http frameworks and requires a service parameter to be passed in we use the empty string value as an indicator that the default service name should be used. Fixes #767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now the gin trace middleware requires passing in a service name and it does not reference
globalconfig.ServiceName(). Consider adding support for using the value ofglobalconfig.ServiceName()if the serviceName value passed into the middleware factory function is"". This will allow callers to opt into using the global service name without requiring a new overload to the middleware factory.I can send a PR if this is something worth considering.
Also, consider changing the middleware factory signature and behavior to match that of other server tracer wrappers for a potential
v2.The text was updated successfully, but these errors were encountered: