contrib/gin-gonic/gin: support globalconfig.ServiceName() #767
Labels
apm:ecosystem
contrib/* related feature requests or bugs
proposal
more in depth change that requires full team approval
Right now the gin trace middleware requires passing in a service name and it does not reference
globalconfig.ServiceName()
. Consider adding support for using the value ofglobalconfig.ServiceName()
if the serviceName value passed into the middleware factory function is""
. This will allow callers to opt into using the global service name without requiring a new overload to the middleware factory.I can send a PR if this is something worth considering.
Also, consider changing the middleware factory signature and behavior to match that of other server tracer wrappers for a potential
v2
.The text was updated successfully, but these errors were encountered: