Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/globalconfig: wrong mutex type acquired for SetServiceName #658

Closed
vikpattabi opened this issue May 9, 2020 · 5 comments · Fixed by #659
Closed

internal/globalconfig: wrong mutex type acquired for SetServiceName #658

vikpattabi opened this issue May 9, 2020 · 5 comments · Fixed by #659
Labels
bug unintended behavior that has to be fixed
Milestone
1.24.0

Comments

@vikpattabi
Copy link
Contributor

vikpattabi commented May 9, 2020 •
edited
Loading

dd-trace-go/internal/globalconfig/globalconfig.go

Line 50 in 435545b

cfg.mu.RLock()

I would expect the SetServiceName function should acquire a write mutex in the above line. Happy to submit a PR for this if this seems reasonable.
@gbbr
Copy link
Contributor

gbbr commented May 11, 2020

You're right, thanks for catching this!

@gbbr gbbr added the bug unintended behavior that has to be fixed label May 11, 2020
@gbbr gbbr changed the title globalconfig.go: wrong mutex type acquired for SetServiceName internal/globalconfig: wrong mutex type acquired for SetServiceName May 11, 2020
@vikpattabi
Copy link
Contributor Author

Yup, absolutely! Looks like I might need some permission to put up a PR to fix?

@gbbr
Copy link
Contributor

gbbr commented May 11, 2020

No permissions needed, just fork the repository and open a PR.

@gbbr gbbr added this to the 1.24.0 milestone May 11, 2020
@vikpattabi
Copy link
Contributor Author

PR here: #659

@vikpattabi vikpattabi mentioned this issue May 11, 2020
Merged
knusbaum pushed a commit that referenced this issue May 11, 2020
@vikpattabi
internal/globalconfig: fix wrong mutex acquired for SetServiceName (#659
28e8330 
)

Fixes #658
knusbaum pushed a commit that referenced this issue May 11, 2020
@vikpattabi @knusbaum
internal/globalconfig: fix wrong mutex acquired for SetServiceName (#659
cf152bd 
)

Fixes #658
@knusbaum
Copy link
Contributor

knusbaum commented May 11, 2020 •
edited
Loading

This is fixed in 1.24.0-rc.4 and 1.23.3

Thanks again, @vikpattabi

mingrammer pushed a commit to mingrammer/dd-trace-go that referenced this issue Dec 22, 2020
@vikpattabi @mingrammer
internal/globalconfig: fix wrong mutex acquired for SetServiceName (D…
1b10bce 
…ataDog#659)

Fixes DataDog#658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug unintended behavior that has to be fixed
Projects
None yet
Milestone
1.24.0
Development

Successfully merging a pull request may close this issue.

internal/globalconfig: fix wrong mutex acquired for SetServiceName vikpattabi/dd-trace-go
3 participants
@knusbaum @gbbr @vikpattabi