-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/globalconfig: wrong mutex type acquired for SetServiceName #658
Comments
You're right, thanks for catching this! |
gbbr
changed the title
globalconfig.go: wrong mutex type acquired for SetServiceName
internal/globalconfig: wrong mutex type acquired for SetServiceName
May 11, 2020
Yup, absolutely! Looks like I might need some permission to put up a PR to fix? |
No permissions needed, just fork the repository and open a PR. |
PR here: #659 |
knusbaum
pushed a commit
that referenced
this issue
May 11, 2020
knusbaum
pushed a commit
that referenced
this issue
May 11, 2020
This is fixed in Thanks again, @vikpattabi |
mingrammer
pushed a commit
to mingrammer/dd-trace-go
that referenced
this issue
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dd-trace-go/internal/globalconfig/globalconfig.go
Line 50 in 435545b
I would expect the
SetServiceName
function should acquire a write mutex in the above line. Happy to submit a PR for this if this seems reasonable.The text was updated successfully, but these errors were encountered: