ddtrace/tracer: add noDebugStack to config in when setting error tags

ddtrace/tracer/span.go

@@ -102,7 +102,9 @@ func (s *span) SetTag(key string, value interface{}) {
 	}
 	switch key {
 	case ext.Error:
-		s.setTagError(value, &errorConfig{})
+		s.setTagError(value, &errorConfig{
+			noDebugStack: s.noDebugStack,
+		})
 		return
 	}
 	if v, ok := value.(bool); ok {

ddtrace/tracer/span_test.go

@@ -204,6 +204,31 @@ func TestSpanSetTag(t *testing.T) {
 	assert.Equal("false", span.Meta["some.other.bool"])
 }
 
+func TestSpanSetTagError(t *testing.T) {
+	assert := assert.New(t)
+
+	span1 := newBasicSpan("web.request")
+	span1.setTagError(errors.New("error value with no trace"), &errorConfig{noDebugStack: true})
+	assert.Equal(int32(1), span1.Error)
+	assert.Equal("error value with no trace", span1.Meta[ext.ErrorMsg])
+	assert.Equal("*errors.errorString", span1.Meta[ext.ErrorType])
+	assert.Empty(span1.Meta[ext.ErrorStack])
+
+	span2 := newBasicSpan("web.request")
+	span2.setTagError(errors.New("error value with trace"), &errorConfig{noDebugStack: false})
+	assert.Equal(int32(1), span2.Error)
+	assert.Equal("error value with trace", span2.Meta[ext.ErrorMsg])
+	assert.Equal("*errors.errorString", span2.Meta[ext.ErrorType])
+	assert.NotEmpty(span2.Meta[ext.ErrorStack])
+
+	span3 := newBasicSpan("web.request")
+	span3.setTagError(errors.New("error value with trace, no given config"), &errorConfig{})
+	assert.Equal(int32(1), span3.Error)
+	assert.Equal("error value with trace, no given config", span3.Meta[ext.ErrorMsg])
+	assert.Equal("*errors.errorString", span3.Meta[ext.ErrorType])
+	assert.NotEmpty(span3.Meta[ext.ErrorStack])
+}
+
 func TestSpanSetDatadogTags(t *testing.T) {
 	assert := assert.New(t)
 

ddtrace/tracer/tracer_test.go

@@ -451,7 +451,7 @@ func TestTracerSpanGlobalTags(t *testing.T) {
 	assert.Equal("value", child.Meta["key"])
 }
 
-func TestTracerNoDebugStack(t *testing.T) {
+func TestTracerNoDebugStackFinish(t *testing.T) {
 	assert := assert.New(t)
 	tracer := newTracer(WithDebugStack(false))
 	s := tracer.StartSpan("web.request").(*span)
@@ -464,6 +464,19 @@ func TestTracerNoDebugStack(t *testing.T) {
 	assert.Empty(s.Meta[ext.ErrorStack])
 }
 
+func TestTracerNoDebugStackFinishSetTag(t *testing.T) {
+	assert := assert.New(t)
+	tracer := newTracer(WithDebugStack(false))
+	s := tracer.StartSpan("web.request").(*span)
+	err := errors.New("error value with no trace")
+	s.SetTag(ext.Error, err)
+
+	assert.Equal(int32(1), s.Error)
+	assert.Equal("error value with no trace", s.Meta[ext.ErrorMsg])
+	assert.Equal("*errors.errorString", s.Meta[ext.ErrorType])
+	assert.Empty(s.Meta[ext.ErrorStack])
+}
+
 func TestNewSpan(t *testing.T) {
 	assert := assert.New(t)