Skip to content

Commit

Permalink
Make log.UseLogger return undo func
Browse files Browse the repository at this point in the history
  • Loading branch information
felixge committed May 4, 2021
1 parent bc28e2a commit bce3c86
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
10 changes: 6 additions & 4 deletions internal/log/log.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,17 @@ var (
logger ddtrace.Logger = &defaultLogger{l: log.New(os.Stderr, "", log.LstdFlags)}
)

// UseLogger sets l as the active logger and returns the previously configured
// logger.
func UseLogger(l ddtrace.Logger) ddtrace.Logger {
// UseLogger sets l as the active logger and returns a function to restore the
// previous logger. The return value is mostly useful when testing.
func UseLogger(l ddtrace.Logger) (undo func()) {
Flush()
mu.Lock()
defer mu.Unlock()
old := logger
logger = l
return old
return func() {
logger = old
}
}

// SetLevel sets the given lvl for logging.
Expand Down
6 changes: 2 additions & 4 deletions profiler/profiler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,7 @@ func TestStart(t *testing.T) {

t.Run("options/GoodAPIKey/Agent", func(t *testing.T) {
rl := &log.RecordLogger{}
old := log.UseLogger(rl)
defer log.UseLogger(old)
defer log.UseLogger(rl)()

err := Start(WithAPIKey("12345678901234567890123456789012"))
defer Stop()
Expand All @@ -75,8 +74,7 @@ func TestStart(t *testing.T) {

t.Run("options/GoodAPIKey/Agentless", func(t *testing.T) {
rl := &log.RecordLogger{}
old := log.UseLogger(rl)
defer log.UseLogger(old)
defer log.UseLogger(rl)()

err := Start(
WithAPIKey("12345678901234567890123456789012"),
Expand Down

0 comments on commit bce3c86

Please sign in to comment.