wip test

ddtrace/tracer/rules_sampler.go

@@ -328,9 +328,9 @@ func (rs *traceRulesSampler) apply(span *span, atFinish bool) bool {
 		// TODO: technically, span.name/ service tags could change the span and cause other tag-less rules
 		//  to evaluate to true. However, previously this was disregarded. Should we keep the behaviour as it was before
 		//  or re-evaluate all the rules?
-		if atFinish && len(rule.Tags) == 0 {
-			continue
-		}
+		//if atFinish && len(rule.Tags) == 0 {
+		//	continue
+		//}
 		if rule.match(span) {
 			matched = true
 			rate = rule.Rate

ddtrace/tracer/span.go

@@ -483,7 +483,6 @@ func (s *span) Finish(opts ...ddtrace.FinishOption) {
 		// we have an active tracer
 		if t.rulesSampling.traces.enabled() {
 			t.rulesSampling.SampleTrace(s, true)
-
 		}
 	}
 

ddtrace/tracer/tracer.go

@@ -677,9 +677,9 @@ func (t *tracer) sample(span *span) {
 	if rs, ok := sampler.(RateSampler); ok && rs.Rate() < 1 {
 		span.setMetric(sampleRateMetricKey, rs.Rate())
 	}
-	if t.rulesSampling.SampleTrace(span, false) {
-		return
-	}
+	//if t.rulesSampling.SampleTrace(span, false) {
+	//	return
+	//}
 	t.prioritySampling.apply(span)
 }