-
Notifications
You must be signed in to change notification settings - Fork 435
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
all: commit full go.mod and go.sum files (#1188)
* all: commit full go.mod and go.sum To address repeated CI failure due to missing dependencies in go.mod leading to backward-incompatible upgrades, fully specify all dependencies in go.mod. The go.mod file was created by starting from the original go.mod, then applying all of the "go get" commands from .circleci/config.yml using go1.14, including an additional upgrade to google.golang.org/grpc@v1.32.0 to satisfy the requirements of internal/traceprof/testapp. Then I ran "go1.14 mod tidy". Wherever possible, the required versions of direct dependencies in go.mod should be the minimum that would 1) compile, 2) pass tests locally, and 3) didn't have security vulnerabilities listed on pkg.go.dev. This change may lead to breaking builds down-stream if users are upgraded (via our go.mod) to newer versions of libraries which ignore semver like grpc. However, unless and until integrations are moved to separate modules, we need to specify *some* minimum supported version of every dependency so that users of the integrations know which version to get and so that our CI is not constantly breaking. * CONTRIBUTING.md: remove advice to ignore go.mod and go.sum changes
- Loading branch information
Showing
4 changed files
with
1,181 additions
and
40 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.