-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow running exploration tests on mac #6474
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 470168 Passed, 3694 Skipped, 33h 1m 53.11s Total Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6474) - mean (68ms) : 65, 71
. : milestone, 68,
master - mean (69ms) : 65, 72
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6474) - mean (978ms) : 950, 1005
. : milestone, 978,
master - mean (977ms) : 950, 1003
. : milestone, 977,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6474) - mean (107ms) : 104, 109
. : milestone, 107,
master - mean (108ms) : 104, 112
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6474) - mean (676ms) : 662, 691
. : milestone, 676,
master - mean (679ms) : 665, 692
. : milestone, 679,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6474) - mean (91ms) : 89, 93
. : milestone, 91,
master - mean (91ms) : 89, 94
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6474) - mean (635ms) : 615, 654
. : milestone, 635,
master - mean (636ms) : 620, 652
. : milestone, 636,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6474) - mean (193ms) : 190, 196
. : milestone, 193,
master - mean (194ms) : 189, 198
. : milestone, 194,
section CallTarget+Inlining+NGEN
This PR (6474) - mean (1,101ms) : 1074, 1128
. : milestone, 1101,
master - mean (1,097ms) : 1072, 1122
. : milestone, 1097,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6474) - mean (278ms) : 272, 285
. : milestone, 278,
master - mean (278ms) : 274, 282
. : milestone, 278,
section CallTarget+Inlining+NGEN
This PR (6474) - mean (874ms) : 835, 912
. : milestone, 874,
master - mean (871ms) : 842, 901
. : milestone, 871,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6474) - mean (266ms) : 262, 270
. : milestone, 266,
master - mean (266ms) : 263, 270
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (6474) - mean (847ms) : 815, 880
. : milestone, 847,
master - mean (850ms) : 817, 884
. : milestone, 850,
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6474) (11.139M) : 0, 11139190
master (11.166M) : 0, 11165619
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6474) (7.304M) : 0, 7304460
master (7.232M) : 0, 7232435
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.555M) : 0, 7555239
section Manual
master (11.218M) : 0, 11218357
section Manual + Automatic
This PR (6474) (6.731M) : 0, 6730708
master (6.695M) : 0, 6694720
section DD_TRACE_ENABLED=0
master (10.195M) : 0, 10194994
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6474) (9.436M) : 0, 9436019
master (9.350M) : 0, 9350086
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6474) (6.392M) : 0, 6391857
master (6.223M) : 0, 6222880
section Trace stats
master (6.644M) : 0, 6644302
section Manual
master (9.490M) : 0, 9490052
section Manual + Automatic
This PR (6474) (5.914M) : 0, 5913586
master (5.826M) : 0, 5826117
section DD_TRACE_ENABLED=0
master (8.806M) : 0, 8806093
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6474) (9.947M) : 0, 9947304
master (10.038M) : 0, 10038108
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6474) (6.386M) : crit ,0, 6385666
master (6.759M) : 0, 6759031
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (7.327M) : 0, 7327150
section Manual
master (10.148M) : 0, 10147695
section Manual + Automatic
This PR (6474) (5.990M) : 0, 5990133
master (6.270M) : 0, 6270298
section DD_TRACE_ENABLED=0
master (9.572M) : 0, 9571995
|
Benchmarks Report for tracer 🐌Benchmarks for #6474 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Slower
|
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 | 1.147 | 802.84 | 920.51 | |
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 | 1.127 | 687.59 | 774.74 | |
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 | 1.119 | 629.69 | 704.32 |
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.132 | 450.26 | 397.80 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 451ns | 0.24ns | 0.929ns | 0.00815 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 554ns | 0.189ns | 0.709ns | 0.00776 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 629ns | 0.5ns | 1.94ns | 0.0918 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 500ns | 0.137ns | 0.512ns | 0.00963 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 688ns | 0.927ns | 3.59ns | 0.00935 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 803ns | 0.894ns | 3.46ns | 0.104 | 0 | 0 | 658 B |
#6474 | StartFinishSpan |
net6.0 | 399ns | 0.593ns | 2.3ns | 0.0081 | 0 | 0 | 576 B |
#6474 | StartFinishSpan |
netcoreapp3.1 | 557ns | 0.342ns | 1.33ns | 0.00781 | 0 | 0 | 576 B |
#6474 | StartFinishSpan |
net472 | 704ns | 0.659ns | 2.47ns | 0.0917 | 0 | 0 | 578 B |
#6474 | StartFinishScope |
net6.0 | 486ns | 0.261ns | 0.978ns | 0.00983 | 0 | 0 | 696 B |
#6474 | StartFinishScope |
netcoreapp3.1 | 775ns | 0.603ns | 2.33ns | 0.00923 | 0 | 0 | 696 B |
#6474 | StartFinishScope |
net472 | 920ns | 0.885ns | 3.43ns | 0.105 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #6474
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.119
670.27
599.13
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.119 | 670.27 | 599.13 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 671ns | 0.533ns | 2.06ns | 0.00985 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 922ns | 1.12ns | 4.32ns | 0.00951 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.14μs | 0.66ns | 2.38ns | 0.104 | 0 | 0 | 658 B |
#6474 | RunOnMethodBegin |
net6.0 | 599ns | 0.4ns | 1.5ns | 0.00989 | 0 | 0 | 696 B |
#6474 | RunOnMethodBegin |
netcoreapp3.1 | 862ns | 0.909ns | 3.4ns | 0.00928 | 0 | 0 | 696 B |
#6474 | RunOnMethodBegin |
net472 | 1.11μs | 1.18ns | 4.56ns | 0.104 | 0 | 0 | 658 B |
Summary of changes
platform was not part of the parameters, so it only tried with the default value (x64), which didn't work on mac
Reason for change
I want to be able to run exploration tests locally
Implementation details
Test coverage
Other details