[Tracing] Improve unit tests to assert baggage values when using multiple propagators #6471

zacharycmontoya · 2024-12-19T16:41:31Z

Summary of changes

Adds baggage propagator to our existing multi-propagator unit tests

Reason for change

For testing multiple propagators and the DD_TRACE_PROPAGATION_EXTRACT_FIRST, there's specific baggage interactions that need to be tested.

Implementation details

Test coverage

Updated unit tests.

Other details

datadog-ddstaging · 2024-12-19T17:15:36Z

Datadog Report

Branch report: zach.montoya/update-unit-tests-baggage
Commit report: a998790
Test service: dd-trace-dotnet

✅ 0 Failed, 236209 Passed, 2108 Skipped, 18h 20m 41.47s Total Time

…erate on SpanContext

…his updated interface is eaiser to use from instrumentations when there are no Spans for incoming headers, only span contexts.

- Rename the method from AddSpanLink to AddLink (this also mirrors the suggestion from OpenTelemetry Tracing API spec) - Return the Span object instead of returning nothing

…ltiple propagators

andrewlock · 2024-12-19T20:18:24Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6471) - mean (69ms)  : 64, 74
     .   : milestone, 69,
    master - mean (68ms)  : 66, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6471) - mean (978ms)  : 952, 1005
     .   : milestone, 978,
    master - mean (975ms)  : 958, 992
     .   : milestone, 975,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6471) - mean (108ms)  : 105, 110
     .   : milestone, 108,
    master - mean (107ms)  : 104, 110
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6471) - mean (678ms)  : 667, 688
     .   : milestone, 678,
    master - mean (678ms)  : 663, 693
     .   : milestone, 678,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6471) - mean (91ms)  : 89, 92
     .   : milestone, 91,
    master - mean (92ms)  : 90, 93
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6471) - mean (631ms)  : 614, 649
     .   : milestone, 631,
    master - mean (636ms)  : 621, 650
     .   : milestone, 636,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6471) - mean (194ms)  : 190, 197
     .   : milestone, 194,
    master - mean (194ms)  : 191, 197
     .   : milestone, 194,

    section CallTarget+Inlining+NGEN
    This PR (6471) - mean (1,099ms)  : 1072, 1126
     .   : milestone, 1099,
    master - mean (1,101ms)  : 1069, 1133
     .   : milestone, 1101,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6471) - mean (279ms)  : 275, 283
     .   : milestone, 279,
    master - mean (279ms)  : 274, 285
     .   : milestone, 279,

    section CallTarget+Inlining+NGEN
    This PR (6471) - mean (871ms)  : 840, 902
     .   : milestone, 871,
    master - mean (875ms)  : 843, 907
     .   : milestone, 875,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6471) - mean (267ms)  : 263, 271
     .   : milestone, 267,
    master - mean (268ms)  : 264, 272
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (6471) - mean (852ms)  : 816, 888
     .   : milestone, 852,
    master - mean (852ms)  : 826, 879
     .   : milestone, 852,

andrewlock · 2024-12-20T02:53:57Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6471) (10.781M)   : 0, 10780955
    master (11.080M)   : 0, 11079759
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6471) (7.022M)   : 0, 7022252
    master (7.154M)   : 0, 7154253
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.512M)   : 0, 7512246

    section Manual
    master (11.035M)   : 0, 11035311

    section Manual + Automatic
    This PR (6471) (6.528M)   : 0, 6528497
    master (6.611M)   : 0, 6611049

    section DD_TRACE_ENABLED=0
    master (10.155M)   : 0, 10155447

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6471) (9.424M)   : 0, 9424499
    master (9.567M)   : 0, 9566967
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6471) (6.301M)   : 0, 6301480
    master (6.361M)   : 0, 6360592

    section Trace stats
    master (6.540M)   : 0, 6540289

    section Manual
    master (9.643M)   : 0, 9642857

    section Manual + Automatic
    This PR (6471) (5.844M)   : 0, 5843728
    master (5.877M)   : 0, 5877320

    section DD_TRACE_ENABLED=0
    master (8.928M)   : 0, 8928120

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6471) (10.001M)   : 0, 10001073
    master (9.916M)   : 0, 9915888
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6471) (6.487M)   : 0, 6487269
    master (6.337M)   : 0, 6336520
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.963M)   : 0, 6963468

    section Manual
    master (9.842M)   : 0, 9842464

    section Manual + Automatic
    This PR (6471) (6.050M)   : 0, 6050242
    master (6.172M)   : 0, 6171910

    section DD_TRACE_ENABLED=0
    master (9.319M)   : 0, 9318507

andrewlock

Moar tests is better 👍

andrewlock · 2024-12-20T21:42:06Z

Benchmarks Report for tracer 🐌

Benchmarks for #6471 compared to master:

1 benchmarks are faster, with geometric mean 1.124
1 benchmarks are slower, with geometric mean 1.136
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.09μs	45.5ns	322ns	0.0161	0.00402	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.2μs	51.8ns	254ns	0.0206	0.0103	0	5.8 KB
master	`StartStopWithChild`	net472	16.4μs	42.4ns	164ns	1.03	0.29	0.0966	6.21 KB
#6471	`StartStopWithChild`	net6.0	7.97μs	42.2ns	215ns	0.0165	0.00826	0	5.61 KB
#6471	`StartStopWithChild`	netcoreapp3.1	10.2μs	55ns	286ns	0.0263	0.0105	0	5.8 KB
#6471	`StartStopWithChild`	net472	16.3μs	47.1ns	183ns	1.05	0.307	0.105	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	482μs	258ns	998ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	654μs	390ns	1.51μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	852μs	534ns	2.07μs	0.422	3.3 KB
#6471	`WriteAndFlushEnrichedTraces`	net6.0	468μs	270ns	1.01μs	0	2.7 KB
#6471	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	662μs	614ns	2.38μs	0	2.7 KB
#6471	`WriteAndFlushEnrichedTraces`	net472	852μs	438ns	1.7μs	0.431	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	156μs	910ns	8.03μs	0.147	14.49 KB
master	`SendRequest`	netcoreapp3.1	169μs	982ns	9.16μs	0.165	17.27 KB
master	`SendRequest`	net472	0.00116ns	0.000747ns	0.00279ns	0	0 b
#6471	`SendRequest`	net6.0	155μs	901ns	7.96μs	0.156	14.47 KB
#6471	`SendRequest`	netcoreapp3.1	168μs	976ns	8.95μs	0.159	17.27 KB
#6471	`SendRequest`	net472	0.00334ns	0.00119ns	0.00429ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	574μs	3.06μs	15.6μs	0.571	0	0	41.69 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	678μs	3.73μs	23.6μs	0.34	0	0	41.83 KB
master	`WriteAndFlushEnrichedTraces`	net472	836μs	4.21μs	18.4μs	8.33	2.5	0.417	53.26 KB
#6471	`WriteAndFlushEnrichedTraces`	net6.0	543μs	2.3μs	8.31μs	0.534	0	0	41.67 KB
#6471	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	674μs	3.57μs	18.6μs	0.329	0	0	41.8 KB
#6471	`WriteAndFlushEnrichedTraces`	net472	849μs	3.99μs	14.9μs	8.33	2.5	0.417	53.28 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.33μs	0.978ns	3.79ns	0.0138	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.75μs	1.51ns	5.84ns	0.0139	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.11μs	2.57ns	9.94ns	0.157	0.00105	987 B
#6471	`ExecuteNonQuery`	net6.0	1.29μs	0.985ns	3.68ns	0.0142	0	1.02 KB
#6471	`ExecuteNonQuery`	netcoreapp3.1	1.79μs	1.92ns	7.42ns	0.0133	0	1.02 KB
#6471	`ExecuteNonQuery`	net472	2.09μs	1.38ns	5.16ns	0.156	0.00104	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.17μs	0.621ns	2.32ns	0.0134	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.6μs	0.803ns	3.11ns	0.0129	976 B
master	`CallElasticsearch`	net472	2.52μs	2.71ns	10.5ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.37μs	1.17ns	4.54ns	0.0135	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.65μs	0.642ns	2.49ns	0.0138	1.02 KB
master	`CallElasticsearchAsync`	net472	2.66μs	0.975ns	3.65ns	0.166	1.05 KB
#6471	`CallElasticsearch`	net6.0	1.21μs	1.38ns	5.33ns	0.0139	976 B
#6471	`CallElasticsearch`	netcoreapp3.1	1.49μs	2.62ns	10.2ns	0.0135	976 B
#6471	`CallElasticsearch`	net472	2.62μs	2.76ns	10.7ns	0.157	995 B
#6471	`CallElasticsearchAsync`	net6.0	1.33μs	0.626ns	2.34ns	0.0134	952 B
#6471	`CallElasticsearchAsync`	netcoreapp3.1	1.61μs	0.551ns	2.06ns	0.0135	1.02 KB
#6471	`CallElasticsearchAsync`	net472	2.68μs	2.11ns	8.15ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.27μs	0.813ns	3.04ns	0.0133	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.71μs	0.785ns	2.94ns	0.0127	952 B
master	`ExecuteAsync`	net472	1.84μs	1.2ns	4.67ns	0.145	915 B
#6471	`ExecuteAsync`	net6.0	1.22μs	4.61ns	17.8ns	0.0133	952 B
#6471	`ExecuteAsync`	netcoreapp3.1	1.63μs	0.557ns	2.16ns	0.0132	952 B
#6471	`ExecuteAsync`	net472	1.89μs	1.4ns	5.43ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.31μs	1.85ns	6.68ns	0.0323	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.21μs	1.84ns	7.12ns	0.039	2.85 KB
master	`SendAsync`	net472	7.38μs	2.5ns	9.69ns	0.495	3.12 KB
#6471	`SendAsync`	net6.0	4.41μs	1.26ns	4.73ns	0.0308	2.31 KB
#6471	`SendAsync`	netcoreapp3.1	5.33μs	1.58ns	5.9ns	0.0374	2.85 KB
#6471	`SendAsync`	net472	7.28μs	1.63ns	6.1ns	0.495	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.45μs	0.807ns	3.02ns	0.0225	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.07μs	3.98ns	15.4ns	0.0216	1.64 KB
master	`EnrichedLog`	net472	2.76μs	1.32ns	5.13ns	0.249	1.57 KB
#6471	`EnrichedLog`	net6.0	1.61μs	3.68ns	13.8ns	0.0232	1.64 KB
#6471	`EnrichedLog`	netcoreapp3.1	2.27μs	0.58ns	2.17ns	0.0227	1.64 KB
#6471	`EnrichedLog`	net472	2.74μs	1.8ns	6.99ns	0.25	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	118μs	189ns	734ns	0.0574	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	123μs	141ns	545ns	0	0	4.28 KB
master	`EnrichedLog`	net472	152μs	144ns	557ns	0.69	0.23	4.46 KB
#6471	`EnrichedLog`	net6.0	115μs	182ns	681ns	0.0573	0	4.28 KB
#6471	`EnrichedLog`	netcoreapp3.1	120μs	174ns	672ns	0.06	0	4.28 KB
#6471	`EnrichedLog`	net472	153μs	150ns	582ns	0.688	0.229	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.99μs	0.995ns	3.85ns	0.03	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.18μs	1.41ns	5.44ns	0.0295	2.2 KB
master	`EnrichedLog`	net472	4.98μs	2.03ns	7.85ns	0.319	2.02 KB
#6471	`EnrichedLog`	net6.0	2.95μs	0.957ns	3.71ns	0.031	2.2 KB
#6471	`EnrichedLog`	netcoreapp3.1	4.23μs	1.31ns	4.74ns	0.0296	2.2 KB
#6471	`EnrichedLog`	net472	4.76μs	2.16ns	7.48ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.49μs	3.94ns	15.3ns	0.0161	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.72μs	1.31ns	5.07ns	0.0156	1.14 KB
master	`SendReceive`	net472	2.1μs	1.28ns	4.62ns	0.183	1.16 KB
#6471	`SendReceive`	net6.0	1.37μs	0.379ns	1.42ns	0.0157	1.14 KB
#6471	`SendReceive`	netcoreapp3.1	1.79μs	2.05ns	7.95ns	0.015	1.14 KB
#6471	`SendReceive`	net472	2.14μs	1.67ns	6.47ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.66μs	1.09ns	4.22ns	0.0212	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	4.13μs	1.42ns	5.48ns	0.0207	1.65 KB
master	`EnrichedLog`	net472	4.24μs	2.6ns	10.1ns	0.322	2.04 KB
#6471	`EnrichedLog`	net6.0	2.79μs	0.94ns	3.64ns	0.0223	1.6 KB
#6471	`EnrichedLog`	netcoreapp3.1	3.91μs	3.11ns	12ns	0.0215	1.65 KB
#6471	`EnrichedLog`	net472	4.4μs	4.12ns	15.9ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6471

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.136	482.04	547.36

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	396ns	0.401ns	1.5ns	0.00804	576 B
master	`StartFinishSpan`	netcoreapp3.1	564ns	1.08ns	4.19ns	0.0079	576 B
master	`StartFinishSpan`	net472	630ns	0.293ns	1.13ns	0.0916	578 B
master	`StartFinishScope`	net6.0	482ns	0.233ns	0.901ns	0.00967	696 B
master	`StartFinishScope`	netcoreapp3.1	756ns	0.288ns	1.12ns	0.0093	696 B
master	`StartFinishScope`	net472	855ns	0.595ns	2.3ns	0.104	658 B
#6471	`StartFinishSpan`	net6.0	392ns	0.194ns	0.75ns	0.00811	576 B
#6471	`StartFinishSpan`	netcoreapp3.1	556ns	0.324ns	1.21ns	0.00761	576 B
#6471	`StartFinishSpan`	net472	644ns	0.425ns	1.59ns	0.0917	578 B
#6471	`StartFinishScope`	net6.0	547ns	0.238ns	0.921ns	0.00991	696 B
#6471	`StartFinishScope`	netcoreapp3.1	800ns	0.581ns	2.25ns	0.0092	696 B
#6471	`StartFinishScope`	net472	918ns	0.523ns	2.02ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6471

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.124	738.21	656.54

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	737ns	0.742ns	2.87ns	0.00993	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	902ns	0.858ns	3.32ns	0.00948	696 B
master	`RunOnMethodBegin`	net472	1.08μs	0.56ns	2.17ns	0.104	658 B
#6471	`RunOnMethodBegin`	net6.0	657ns	0.362ns	1.4ns	0.00984	696 B
#6471	`RunOnMethodBegin`	netcoreapp3.1	923ns	0.666ns	2.58ns	0.00923	696 B
#6471	`RunOnMethodBegin`	net472	1.2μs	0.798ns	3.09ns	0.104	658 B

zacharycmontoya added 6 commits December 19, 2024 10:35

SpanLink API Update: Remove DecoratedSpan property so that we only op…

80e9f3a

…erate on SpanContext

Update Span.AddSpanLink API to accept a SpanLink instead of a Span. T…

342b5fc

…his updated interface is eaiser to use from instrumentations when there are no Spans for incoming headers, only span contexts.

Updates to make the SpanLink API more similar to the Activity API:

274ca46

- Rename the method from AddSpanLink to AddLink (this also mirrors the suggestion from OpenTelemetry Tracing API spec) - Return the Span object instead of returning nothing

Add small doc comment for new Span return

56fbd23

Delete SpanLink constructor that accepts a Span

f5451ff

Re-organize unit tests somewhat

57db143

zacharycmontoya force-pushed the zach.montoya/refactor-span-links branch from f6a9a08 to 57db143 Compare December 19, 2024 18:35

Standalone: Improve unit tests to assert baggage values when using mu…

0ac1b57

…ltiple propagators

zacharycmontoya force-pushed the zach.montoya/update-unit-tests-baggage branch from 030772e to 0ac1b57 Compare December 19, 2024 18:36

zacharycmontoya marked this pull request as ready for review December 19, 2024 18:36

zacharycmontoya requested a review from a team as a code owner December 19, 2024 18:37

lucaspimentel approved these changes Dec 19, 2024

View reviewed changes

lucaspimentel added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:tests unit tests, integration tests labels Dec 19, 2024

andrewlock approved these changes Dec 20, 2024

View reviewed changes

zacharycmontoya changed the base branch from zach.montoya/refactor-span-links to master December 20, 2024 21:55

zacharycmontoya added 3 commits December 20, 2024 13:56

Merge branch 'master' into zach.montoya/update-unit-tests-baggage

6b8c817

Merge branch 'master' into zach.montoya/update-unit-tests-baggage

8bd77bb

Merge branch 'master' into zach.montoya/update-unit-tests-baggage

a998790

zacharycmontoya merged commit 2b76447 into master Jan 2, 2025
98 of 102 checks passed

zacharycmontoya deleted the zach.montoya/update-unit-tests-baggage branch January 2, 2025 21:33

zacharycmontoya mentioned this pull request Jan 9, 2025

[Tracing] Add configuration to change the trace context propagation extract behavior (APMAPI-1009) #6320

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tracing] Improve unit tests to assert baggage values when using multiple propagators #6471

[Tracing] Improve unit tests to assert baggage values when using multiple propagators #6471

zacharycmontoya commented Dec 19, 2024 •

edited

Loading

datadog-ddstaging bot commented Dec 19, 2024 •

edited

Loading

andrewlock commented Dec 19, 2024 •

edited

Loading

andrewlock commented Dec 20, 2024

andrewlock left a comment

andrewlock commented Dec 20, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6471

Raw results

Faster 🎉 in #6471

Raw results

[Tracing] Improve unit tests to assert baggage values when using multiple propagators #6471

[Tracing] Improve unit tests to assert baggage values when using multiple propagators #6471

Conversation

zacharycmontoya commented Dec 19, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Dec 19, 2024 • edited Loading

Datadog Report

andrewlock commented Dec 19, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Dec 20, 2024

Throughput/Crank Report ⚡

andrewlock left a comment

Choose a reason for hiding this comment

andrewlock commented Dec 20, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6471

Raw results

Faster 🎉 in #6471

Raw results

zacharycmontoya commented Dec 19, 2024 •

edited

Loading

datadog-ddstaging bot commented Dec 19, 2024 •

edited

Loading

andrewlock commented Dec 19, 2024 •

edited

Loading

andrewlock commented Dec 20, 2024 •

edited

Loading