Exclude common failure in smoke tests #6469

andrewlock · 2024-12-19T14:23:32Z

Summary of changes

Retries a common error flake that we can't get to the bottom of.

Reason for change

The runtime sometimes crashes after the app completes and we've shut down, causing flake. We haven't managed to get to the bottom of it yet.

Implementation details

Retry the smoke tests once if we spot an error that looks like this:

ptrace(ATTACH, 14822) FAILED Operation not permitted

Test coverage

Hard to test - as long as it passes for now that's good enough I think

datadog-ddstaging · 2024-12-19T14:47:40Z

Datadog Report

Branch report: andrew/ci/shakes-fist-at-no-exceptions
Commit report: 3cf8254
Test service: dd-trace-dotnet

✅ 0 Failed, 458027 Passed, 2827 Skipped, 19h 38m 49.13s Total Time

andrewlock · 2024-12-19T15:09:46Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6469) - mean (68ms)  : 65, 71
     .   : milestone, 68,
    master - mean (68ms)  : 66, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6469) - mean (972ms)  : 943, 1002
     .   : milestone, 972,
    master - mean (973ms)  : 949, 997
     .   : milestone, 973,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6469) - mean (107ms)  : 105, 109
     .   : milestone, 107,
    master - mean (107ms)  : 105, 109
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6469) - mean (672ms)  : 657, 686
     .   : milestone, 672,
    master - mean (675ms)  : 657, 693
     .   : milestone, 675,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6469) - mean (90ms)  : 88, 93
     .   : milestone, 90,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6469) - mean (629ms)  : 612, 646
     .   : milestone, 629,
    master - mean (630ms)  : 614, 646
     .   : milestone, 630,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6469) - mean (193ms)  : 189, 197
     .   : milestone, 193,
    master - mean (193ms)  : 188, 199
     .   : milestone, 193,

    section CallTarget+Inlining+NGEN
    This PR (6469) - mean (1,098ms)  : 1066, 1131
     .   : milestone, 1098,
    master - mean (1,096ms)  : 1069, 1124
     .   : milestone, 1096,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6469) - mean (282ms)  : 277, 287
     .   : milestone, 282,
    master - mean (277ms)  : 272, 283
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6469) - mean (872ms)  : 845, 898
     .   : milestone, 872,
    master - mean (868ms)  : 841, 896
     .   : milestone, 868,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6469) - mean (266ms)  : 262, 271
     .   : milestone, 266,
    master - mean (266ms)  : 262, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6469) - mean (842ms)  : 807, 878
     .   : milestone, 842,
    master - mean (850ms)  : 814, 887
     .   : milestone, 850,

andrewlock · 2024-12-19T19:34:19Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6469) (11.140M)   : 0, 11139584
    master (11.166M)   : 0, 11165619
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6469) (7.262M)   : 0, 7261891
    master (7.232M)   : 0, 7232435
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.555M)   : 0, 7555239

    section Manual
    master (11.218M)   : 0, 11218357

    section Manual + Automatic
    This PR (6469) (6.696M)   : 0, 6696495
    master (6.695M)   : 0, 6694720

    section DD_TRACE_ENABLED=0
    master (10.195M)   : 0, 10194994

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6469) (9.668M)   : 0, 9668302
    master (9.350M)   : 0, 9350086
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6469) (6.455M)   : 0, 6455426
    master (6.223M)   : 0, 6222880

    section Trace stats
    master (6.644M)   : 0, 6644302

    section Manual
    master (9.490M)   : 0, 9490052

    section Manual + Automatic
    This PR (6469) (5.930M)   : 0, 5929929
    master (5.826M)   : 0, 5826117

    section DD_TRACE_ENABLED=0
    master (8.806M)   : 0, 8806093

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6469) (9.447M)   : 0, 9447031
    master (10.038M)   : 0, 10038108
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6469) (6.126M)   : crit ,0, 6126292
    master (6.759M)   : 0, 6759031
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.327M)   : 0, 7327150

    section Manual
    master (10.148M)   : 0, 10147695

    section Manual + Automatic
    This PR (6469) (5.638M)   : crit ,0, 5637697
    master (6.270M)   : 0, 6270298

    section DD_TRACE_ENABLED=0
    master (9.572M)   : 0, 9571995

andrewlock · 2024-12-20T01:26:14Z

Benchmarks Report for tracer 🐌

Benchmarks for #6469 compared to master:

1 benchmarks are faster, with geometric mean 1.146
4 benchmarks are slower, with geometric mean 1.178
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.94μs	45.2ns	329ns	0.0161	0.00805	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.3μs	57.6ns	387ns	0.0203	0.0101	0	5.8 KB
master	`StartStopWithChild`	net472	16.6μs	49.1ns	190ns	1.02	0.275	0.0729	6.21 KB
#6469	`StartStopWithChild`	net6.0	8.19μs	45.4ns	283ns	0.0177	0.00887	0	5.61 KB
#6469	`StartStopWithChild`	netcoreapp3.1	10.1μs	56.2ns	342ns	0.0151	0.00503	0	5.8 KB
#6469	`StartStopWithChild`	net472	16.3μs	51.3ns	199ns	1.04	0.312	0.0985	6.22 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	492μs	372ns	1.39μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	658μs	480ns	1.86μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	841μs	806ns	3.12μs	0.419	3.3 KB
#6469	`WriteAndFlushEnrichedTraces`	net6.0	493μs	313ns	1.17μs	0	2.7 KB
#6469	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	662μs	532ns	2.06μs	0	2.7 KB
#6469	`WriteAndFlushEnrichedTraces`	net472	848μs	528ns	1.98μs	0.425	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	158μs	1.22μs	11.9μs	0.132	14.47 KB
master	`SendRequest`	netcoreapp3.1	183μs	1.13μs	11.2μs	0.177	17.27 KB
master	`SendRequest`	net472	0.00649ns	0.00221ns	0.00855ns	0	0 b
#6469	`SendRequest`	net6.0	152μs	942ns	9.37μs	0.158	14.47 KB
#6469	`SendRequest`	netcoreapp3.1	172μs	1.11μs	10.9μs	0.169	17.27 KB
#6469	`SendRequest`	net472	0.00111ns	0.000777ns	0.00301ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	591μs	3.39μs	29.8μs	0.607	0	0	41.77 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	659μs	3.04μs	11.8μs	0.331	0	0	41.81 KB
master	`WriteAndFlushEnrichedTraces`	net472	841μs	3.59μs	13.4μs	8.75	2.5	0.417	53.31 KB
#6469	`WriteAndFlushEnrichedTraces`	net6.0	569μs	2.97μs	14.5μs	0.561	0	0	41.73 KB
#6469	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	671μs	2.73μs	12.2μs	0.324	0	0	41.86 KB
#6469	`WriteAndFlushEnrichedTraces`	net472	843μs	4.11μs	16.4μs	8.22	2.47	0.411	53.31 KB

Benchmarks.Trace.DbCommandBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6469

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0	1.139	1,194.13	1,360.00

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.2μs	1.58ns	5.9ns	0.0146	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.74μs	3.65ns	13.7ns	0.0131	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.19μs	1.56ns	5.85ns	0.156	0.00109	987 B
#6469	`ExecuteNonQuery`	net6.0	1.36μs	1.3ns	4.86ns	0.0143	0	1.02 KB
#6469	`ExecuteNonQuery`	netcoreapp3.1	1.76μs	1.73ns	6.7ns	0.0141	0	1.02 KB
#6469	`ExecuteNonQuery`	net472	2.13μs	2.06ns	7.96ns	0.156	0.00107	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.24μs	0.751ns	2.81ns	0.0137	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.63μs	1.46ns	5.46ns	0.0135	976 B
master	`CallElasticsearch`	net472	2.55μs	1.14ns	4.26ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.35μs	0.551ns	2.06ns	0.0129	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.67μs	0.96ns	3.59ns	0.0142	1.02 KB
master	`CallElasticsearchAsync`	net472	2.76μs	3.41ns	13.2ns	0.167	1.05 KB
#6469	`CallElasticsearch`	net6.0	1.28μs	0.683ns	2.56ns	0.0135	976 B
#6469	`CallElasticsearch`	netcoreapp3.1	1.53μs	1.69ns	6.53ns	0.0129	976 B
#6469	`CallElasticsearch`	net472	2.45μs	0.892ns	3.34ns	0.157	995 B
#6469	`CallElasticsearchAsync`	net6.0	1.29μs	0.872ns	3.38ns	0.0135	952 B
#6469	`CallElasticsearchAsync`	netcoreapp3.1	1.69μs	0.829ns	3.1ns	0.0136	1.02 KB
#6469	`CallElasticsearchAsync`	net472	2.66μs	1.34ns	5.02ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.17μs	0.484ns	1.81ns	0.013	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.66μs	0.981ns	3.67ns	0.0124	952 B
master	`ExecuteAsync`	net472	1.83μs	0.611ns	2.12ns	0.145	915 B
#6469	`ExecuteAsync`	net6.0	1.31μs	3.81ns	14.8ns	0.013	952 B
#6469	`ExecuteAsync`	netcoreapp3.1	1.63μs	1.07ns	4.12ns	0.0123	952 B
#6469	`ExecuteAsync`	net472	1.83μs	0.236ns	0.912ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.4μs	0.958ns	3.71ns	0.0309	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.3μs	1.78ns	6.65ns	0.0372	2.85 KB
master	`SendAsync`	net472	7.36μs	1.44ns	5.59ns	0.493	3.12 KB
#6469	`SendAsync`	net6.0	4.46μs	0.984ns	3.55ns	0.0312	2.31 KB
#6469	`SendAsync`	netcoreapp3.1	5.16μs	1.39ns	5ns	0.0386	2.85 KB
#6469	`SendAsync`	net472	7.44μs	2.81ns	10.9ns	0.494	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.54μs	0.428ns	1.54ns	0.0238	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.1μs	1.29ns	4.84ns	0.0212	1.64 KB
master	`EnrichedLog`	net472	2.74μs	1.49ns	5.75ns	0.249	1.57 KB
#6469	`EnrichedLog`	net6.0	1.47μs	0.733ns	2.74ns	0.0228	1.64 KB
#6469	`EnrichedLog`	netcoreapp3.1	2.09μs	0.889ns	3.2ns	0.0219	1.64 KB
#6469	`EnrichedLog`	net472	2.64μs	1.56ns	6.04ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	118μs	168ns	651ns	0.0593	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	122μs	166ns	644ns	0.0608	0	4.28 KB
master	`EnrichedLog`	net472	153μs	100ns	389ns	0.687	0.229	4.46 KB
#6469	`EnrichedLog`	net6.0	116μs	154ns	595ns	0.0575	0	4.28 KB
#6469	`EnrichedLog`	netcoreapp3.1	120μs	201ns	777ns	0	0	4.28 KB
#6469	`EnrichedLog`	net472	150μs	145ns	560ns	0.668	0.223	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.97μs	0.861ns	3.34ns	0.0311	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.13μs	2.47ns	9.59ns	0.0287	2.2 KB
master	`EnrichedLog`	net472	4.92μs	1.14ns	4.4ns	0.32	2.02 KB
#6469	`EnrichedLog`	net6.0	3.07μs	0.929ns	3.48ns	0.0306	2.2 KB
#6469	`EnrichedLog`	netcoreapp3.1	4.12μs	1.34ns	5ns	0.0293	2.2 KB
#6469	`EnrichedLog`	net472	4.95μs	1.14ns	4.28ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6469

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0	1.175	1,339.27	1,573.51

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.34μs	0.405ns	1.57ns	0.016	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.83μs	0.768ns	2.97ns	0.0155	1.14 KB
master	`SendReceive`	net472	2.11μs	1.62ns	6.29ns	0.183	1.16 KB
#6469	`SendReceive`	net6.0	1.57μs	0.664ns	2.39ns	0.0157	1.14 KB
#6469	`SendReceive`	netcoreapp3.1	1.81μs	3.44ns	13.3ns	0.0151	1.14 KB
#6469	`SendReceive`	net472	2.07μs	0.518ns	1.87ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.75μs	1.09ns	4.22ns	0.022	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.99μs	2.05ns	7.96ns	0.022	1.65 KB
master	`EnrichedLog`	net472	4.44μs	1.7ns	6.37ns	0.322	2.04 KB
#6469	`EnrichedLog`	net6.0	2.69μs	5.52ns	20.6ns	0.0225	1.6 KB
#6469	`EnrichedLog`	netcoreapp3.1	3.93μs	1.3ns	5.05ns	0.0216	1.65 KB
#6469	`EnrichedLog`	net472	4.33μs	2.47ns	9.57ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6469

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.233	550.11	678.22

Faster 🎉 in #6469

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.146	554.24	483.62

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	394ns	0.353ns	1.37ns	0.008	576 B
master	`StartFinishSpan`	netcoreapp3.1	550ns	0.348ns	1.3ns	0.00771	576 B
master	`StartFinishSpan`	net472	638ns	0.795ns	3.08ns	0.0917	578 B
master	`StartFinishScope`	net6.0	554ns	0.328ns	1.27ns	0.00975	696 B
master	`StartFinishScope`	netcoreapp3.1	674ns	0.368ns	1.43ns	0.00922	696 B
master	`StartFinishScope`	net472	895ns	2.3ns	8.9ns	0.104	658 B
#6469	`StartFinishSpan`	net6.0	394ns	0.311ns	1.2ns	0.00797	576 B
#6469	`StartFinishSpan`	netcoreapp3.1	678ns	0.535ns	2ns	0.00787	576 B
#6469	`StartFinishSpan`	net472	693ns	0.339ns	1.31ns	0.0915	578 B
#6469	`StartFinishScope`	net6.0	484ns	0.267ns	1.03ns	0.00968	696 B
#6469	`StartFinishScope`	netcoreapp3.1	744ns	0.617ns	2.39ns	0.00927	696 B
#6469	`StartFinishScope`	net472	870ns	0.626ns	2.34ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6469

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.169	584.44	683.19

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	589ns	2.18ns	8.43ns	0.00964	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	911ns	0.626ns	2.42ns	0.00916	696 B
master	`RunOnMethodBegin`	net472	1.09μs	0.511ns	1.91ns	0.104	658 B
#6469	`RunOnMethodBegin`	net6.0	684ns	0.454ns	1.76ns	0.00966	696 B
#6469	`RunOnMethodBegin`	netcoreapp3.1	933ns	0.477ns	1.85ns	0.00956	696 B
#6469	`RunOnMethodBegin`	net472	1.15μs	0.775ns	3ns	0.104	658 B

This reverts commit 01c3fdc.

link04

Ty 🤞.

andrewlock added the area:tests unit tests, integration tests label Dec 19, 2024

andrewlock requested a review from a team as a code owner December 19, 2024 14:23

kevingosse approved these changes Dec 19, 2024

View reviewed changes

andrewlock added 3 commits December 20, 2024 16:33

More exclusions

74cabe2

Revert "More exclusions"

3dcdc49

This reverts commit 01c3fdc.

Switch to retries instead

3cf8254

andrewlock force-pushed the andrew/ci/shakes-fist-at-no-exceptions branch from 01c3fdc to 3cf8254 Compare December 20, 2024 16:46

link04 approved these changes Dec 20, 2024

View reviewed changes

link04 merged commit 58d5516 into master Dec 20, 2024
100 of 102 checks passed

link04 deleted the andrew/ci/shakes-fist-at-no-exceptions branch December 20, 2024 19:08

github-actions bot added this to the vNext-v3 milestone Dec 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Exclude common failure in smoke tests #6469

Exclude common failure in smoke tests #6469

andrewlock commented Dec 19, 2024 •

edited

Loading

datadog-ddstaging bot commented Dec 19, 2024 •

edited

Loading

andrewlock commented Dec 19, 2024 •

edited

Loading

andrewlock commented Dec 19, 2024 •

edited

Loading

andrewlock commented Dec 20, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6469

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6469

Raw results

Raw results

Slower ⚠️ in #6469

Faster 🎉 in #6469

Raw results

Slower ⚠️ in #6469

Raw results

link04 left a comment

Exclude common failure in smoke tests #6469

Exclude common failure in smoke tests #6469

Conversation

andrewlock commented Dec 19, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

datadog-ddstaging bot commented Dec 19, 2024 • edited Loading

Datadog Report

andrewlock commented Dec 19, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Dec 19, 2024 • edited Loading

Throughput/Crank Report ⚡

andrewlock commented Dec 20, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6469

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6469

Raw results

Raw results

Slower ⚠️ in #6469

Faster 🎉 in #6469

Raw results

Slower ⚠️ in #6469

Raw results

link04 left a comment

Choose a reason for hiding this comment

andrewlock commented Dec 19, 2024 •

edited

Loading

datadog-ddstaging bot commented Dec 19, 2024 •

edited

Loading

andrewlock commented Dec 19, 2024 •

edited

Loading

andrewlock commented Dec 19, 2024 •

edited

Loading

andrewlock commented Dec 20, 2024 •

edited

Loading