-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASM] Error metric for unknown operator errors #6465
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6465) - mean (68ms) : 66, 71
. : milestone, 68,
master - mean (69ms) : 65, 72
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6465) - mean (976ms) : 946, 1007
. : milestone, 976,
master - mean (977ms) : 950, 1003
. : milestone, 977,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6465) - mean (107ms) : 105, 109
. : milestone, 107,
master - mean (108ms) : 104, 112
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6465) - mean (676ms) : 663, 688
. : milestone, 676,
master - mean (679ms) : 665, 692
. : milestone, 679,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6465) - mean (91ms) : 89, 93
. : milestone, 91,
master - mean (91ms) : 89, 94
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6465) - mean (631ms) : 612, 650
. : milestone, 631,
master - mean (636ms) : 620, 652
. : milestone, 636,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6465) - mean (194ms) : 189, 198
. : milestone, 194,
master - mean (194ms) : 189, 198
. : milestone, 194,
section CallTarget+Inlining+NGEN
This PR (6465) - mean (1,101ms) : 1074, 1128
. : milestone, 1101,
master - mean (1,097ms) : 1072, 1122
. : milestone, 1097,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6465) - mean (277ms) : 274, 281
. : milestone, 277,
master - mean (278ms) : 274, 282
. : milestone, 278,
section CallTarget+Inlining+NGEN
This PR (6465) - mean (870ms) : 834, 907
. : milestone, 870,
master - mean (871ms) : 842, 901
. : milestone, 871,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6465) - mean (266ms) : 263, 270
. : milestone, 266,
master - mean (266ms) : 263, 270
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (6465) - mean (854ms) : 821, 886
. : milestone, 854,
master - mean (850ms) : 817, 884
. : milestone, 850,
|
Datadog ReportBranch report: ✅ 0 Failed, 452477 Passed, 2810 Skipped, 20h 32m 20.13s Total Time New Flaky Tests (1)
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6465) (11.006M) : 0, 11006170
master (11.166M) : 0, 11165619
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6465) (7.169M) : 0, 7168911
master (7.232M) : 0, 7232435
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.555M) : 0, 7555239
section Manual
master (11.218M) : 0, 11218357
section Manual + Automatic
This PR (6465) (6.615M) : 0, 6614739
master (6.695M) : 0, 6694720
section DD_TRACE_ENABLED=0
master (10.195M) : 0, 10194994
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6465) (9.626M) : 0, 9625805
master (9.350M) : 0, 9350086
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6465) (6.484M) : 0, 6484247
master (6.223M) : 0, 6222880
section Trace stats
master (6.644M) : 0, 6644302
section Manual
master (9.490M) : 0, 9490052
section Manual + Automatic
This PR (6465) (5.985M) : 0, 5984629
master (5.826M) : 0, 5826117
section DD_TRACE_ENABLED=0
master (8.806M) : 0, 8806093
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6465) (10.022M) : 0, 10021828
master (10.038M) : 0, 10038108
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6465) (6.500M) : 0, 6499711
master (6.759M) : 0, 6759031
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (7.327M) : 0, 7327150
section Manual
master (10.148M) : 0, 10147695
section Manual + Automatic
This PR (6465) (6.090M) : 0, 6090342
master (6.270M) : 0, 6270298
section DD_TRACE_ENABLED=0
master (9.572M) : 0, 9571995
|
Benchmarks Report for tracer 🐌Benchmarks for #6465 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️Raw results
|
Thanks for your reviews! |
When we experience an "unknown matcher operator" error in the WAF, we should not increase the _dd.appsec.event_rules.error_count metric in the span.
Summary of changes
Reason for change
Implementation details
Test coverage
Other details