K8s Lib Injection tests: run on a matrix #6458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area:builds
andrewlock
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
If the tests pass, LGTM - you'll need to wait for this build and then retry the failing gitlab steps to test it...
@andrewlock The tests are working: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-dotnet/-/jobs/744193265 |
andrewlock
force-pushed
the
robertomonteromiguel/robertomonteromiguel/k8s_test_on_matrix
branch
from
b50f2b2 to
4b63337
Compare
|
It's blocked because the PR is out of date unfortunately :( Just rebased, should be good afterwards |
|
Urgh, I was wrong, looks like it's a separate recent issue, fixing it now... |
andrewlock
deleted the
robertomonteromiguel/robertomonteromiguel/k8s_test_on_matrix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR run the K8s Lib injection tests on a matrix.
Reason for change
This change is necessary because we are going to change the "one pipeline" and these changes could break dd-trace-js pipeline. We need to merge this PR before merging the "one pipeline".
it is the first PR to do this adaptation step by step.
Implementation details
Test coverage
Other details
Coming PRs to apply the change:
system-tests PR changing the K8s lib injection tests: DataDog/system-tests#3689
one pipeline PR: https://github.com/DataDog/libdatadog-build/pull/59/files
Final PR on dd-trace-dotnet: https://github.com/DataDog/dd-trace-dotnet/pull/6451/files