-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tracer] Fix git metadata retrieval #6444
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 456176 Passed, 2837 Skipped, 18h 58m 48.76s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6444) - mean (69ms) : 65, 72
. : milestone, 69,
master - mean (68ms) : 66, 71
. : milestone, 68,
section CallTarget+Inlining+NGEN
This PR (6444) - mean (978ms) : 953, 1002
. : milestone, 978,
master - mean (976ms) : 953, 998
. : milestone, 976,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6444) - mean (107ms) : 106, 109
. : milestone, 107,
master - mean (107ms) : 104, 110
. : milestone, 107,
section CallTarget+Inlining+NGEN
This PR (6444) - mean (679ms) : 667, 692
. : milestone, 679,
master - mean (679ms) : 662, 695
. : milestone, 679,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6444) - mean (91ms) : 90, 93
. : milestone, 91,
master - mean (91ms) : 89, 92
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6444) - mean (637ms) : 621, 653
. : milestone, 637,
master - mean (635ms) : 619, 651
. : milestone, 635,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6444) - mean (194ms) : 190, 199
. : milestone, 194,
master - mean (193ms) : 188, 198
. : milestone, 193,
section CallTarget+Inlining+NGEN
This PR (6444) - mean (1,102ms) : 1074, 1130
. : milestone, 1102,
master - mean (1,096ms) : 1070, 1122
. : milestone, 1096,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6444) - mean (279ms) : 275, 282
. : milestone, 279,
master - mean (279ms) : 275, 284
. : milestone, 279,
section CallTarget+Inlining+NGEN
This PR (6444) - mean (870ms) : 847, 894
. : milestone, 870,
master - mean (871ms) : 845, 896
. : milestone, 871,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6444) - mean (267ms) : 262, 273
. : milestone, 267,
master - mean (266ms) : 263, 269
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (6444) - mean (858ms) : 826, 890
. : milestone, 858,
master - mean (851ms) : 818, 884
. : milestone, 851,
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6444) (11.248M) : 0, 11247630
master (11.173M) : 0, 11172862
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6444) (7.316M) : 0, 7316472
master (7.214M) : 0, 7214402
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.560M) : 0, 7559850
section Manual
master (11.194M) : 0, 11193707
section Manual + Automatic
This PR (6444) (6.710M) : 0, 6710087
master (6.718M) : 0, 6717525
section DD_TRACE_ENABLED=0
master (10.296M) : 0, 10295976
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6444) (9.531M) : 0, 9530885
master (9.776M) : 0, 9776047
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6444) (6.352M) : 0, 6352339
master (6.425M) : 0, 6425271
section Trace stats
master (6.758M) : 0, 6757513
section Manual
master (9.661M) : 0, 9660549
section Manual + Automatic
This PR (6444) (5.912M) : 0, 5911882
master (6.039M) : 0, 6038872
section DD_TRACE_ENABLED=0
master (8.861M) : 0, 8860501
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6444) (9.841M) : 0, 9841118
master (9.399M) : 0, 9399211
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6444) (6.361M) : 0, 6360736
master (5.619M) : 0, 5618747
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (6.816M) : 0, 6816490
section Manual
master (9.559M) : 0, 9558747
section Manual + Automatic
This PR (6444) (5.904M) : 0, 5903525
master (6.022M) : 0, 6022498
section DD_TRACE_ENABLED=0
master (9.201M) : 0, 9201064
|
Benchmarks Report for tracer 🐌Benchmarks for #6444 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Slower
|
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 | 1.131 | 1,310.72 | 1,482.71 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendReceive |
net6.0 | 1.31μs | 0.911ns | 3.53ns | 0.0157 | 0 | 0 | 1.14 KB |
master | SendReceive |
netcoreapp3.1 | 1.93μs | 0.778ns | 3.01ns | 0.0154 | 0 | 0 | 1.14 KB |
master | SendReceive |
net472 | 2.21μs | 0.887ns | 3.44ns | 0.183 | 0 | 0 | 1.16 KB |
#6444 | SendReceive |
net6.0 | 1.48μs | 0.658ns | 2.46ns | 0.0163 | 0 | 0 | 1.14 KB |
#6444 | SendReceive |
netcoreapp3.1 | 1.81μs | 0.722ns | 2.8ns | 0.0154 | 0 | 0 | 1.14 KB |
#6444 | SendReceive |
net472 | 2.1μs | 1.94ns | 7.52ns | 0.183 | 0 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.75μs | 0.668ns | 2.41ns | 0.022 | 0 | 0 | 1.6 KB |
master | EnrichedLog |
netcoreapp3.1 | 3.9μs | 2.14ns | 8.29ns | 0.0216 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
net472 | 4.42μs | 3.49ns | 13.5ns | 0.322 | 0 | 0 | 2.04 KB |
#6444 | EnrichedLog |
net6.0 | 2.73μs | 0.994ns | 3.85ns | 0.0219 | 0 | 0 | 1.6 KB |
#6444 | EnrichedLog |
netcoreapp3.1 | 3.88μs | 1.27ns | 4.93ns | 0.0213 | 0 | 0 | 1.65 KB |
#6444 | EnrichedLog |
net472 | 4.48μs | 2.06ns | 7.98ns | 0.322 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6444
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472
1.174
631.01
741.05
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 | 1.174 | 631.01 | 741.05 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 402ns | 0.238ns | 0.921ns | 0.00805 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 616ns | 0.76ns | 2.95ns | 0.00768 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 631ns | 0.366ns | 1.42ns | 0.0916 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 556ns | 0.355ns | 1.38ns | 0.00982 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 733ns | 0.697ns | 2.7ns | 0.00919 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 849ns | 0.866ns | 3.35ns | 0.104 | 0 | 0 | 658 B |
#6444 | StartFinishSpan |
net6.0 | 399ns | 0.181ns | 0.677ns | 0.00808 | 0 | 0 | 576 B |
#6444 | StartFinishSpan |
netcoreapp3.1 | 633ns | 0.428ns | 1.66ns | 0.00789 | 0 | 0 | 576 B |
#6444 | StartFinishSpan |
net472 | 741ns | 0.208ns | 0.805ns | 0.0916 | 0 | 0 | 578 B |
#6444 | StartFinishScope |
net6.0 | 547ns | 0.22ns | 0.85ns | 0.00974 | 0 | 0 | 696 B |
#6444 | StartFinishScope |
netcoreapp3.1 | 688ns | 0.325ns | 1.26ns | 0.0093 | 0 | 0 | 696 B |
#6444 | StartFinishScope |
net472 | 859ns | 0.428ns | 1.66ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 591ns | 0.394ns | 1.47ns | 0.00976 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 885ns | 0.35ns | 1.31ns | 0.00973 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.16μs | 1.04ns | 4.04ns | 0.104 | 0 | 0 | 658 B |
#6444 | RunOnMethodBegin |
net6.0 | 601ns | 0.335ns | 1.3ns | 0.00968 | 0 | 0 | 696 B |
#6444 | RunOnMethodBegin |
netcoreapp3.1 | 865ns | 0.368ns | 1.38ns | 0.00962 | 0 | 0 | 696 B |
#6444 | RunOnMethodBegin |
net472 | 1.19μs | 0.512ns | 1.98ns | 0.105 | 0 | 0 | 658 B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
a659978
to
9db1d0d
Compare
Summary of changes
Fix bug introduced in #6415
Reason for change
Due to a change in #6415, the git repository url from not fetch using the correct tag.
Implementation details
Use the git repository url tag to fetch the value from the configuration.
Test coverage
Add a check in unit tests.
Other details