[IAST] Fix compilation of Samples.Security.AspNetCore2 #6441

kevingosse · 2024-12-16T12:01:24Z

Summary of changes

Compilation of Samples.Security.AspNetCore2 because of a bunch of using statement referencing nuget packages that are not added to this project.

It looks like the using are not actually used, so hopefully just removing them should be enough.

datadog-ddstaging · 2024-12-16T12:22:02Z

Datadog Report

Branch report: kevin/fix_security_aspnetcore2
Commit report: 444883d
Test service: dd-trace-dotnet

❌ 3 Failed (0 Known Flaky), 457794 Passed, 2848 Skipped, 19h 41m 25.12s Total Time

❌ Failed Tests (3)

StringConcatAspectBenchmark - Benchmarks.Trace.Iast.StringAspectsBenchmark - Details
StringConcatAspectBenchmark - Benchmarks.Trace.Iast.StringAspectsBenchmark - Details
StringConcatAspectBenchmark - Benchmarks.Trace.Iast.StringAspectsBenchmark - Details

andrewlock · 2024-12-16T12:33:42Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6441) - mean (68ms)  : 65, 71
     .   : milestone, 68,
    master - mean (68ms)  : 65, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6441) - mean (981ms)  : 950, 1012
     .   : milestone, 981,
    master - mean (977ms)  : 953, 1000
     .   : milestone, 977,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6441) - mean (107ms)  : 105, 109
     .   : milestone, 107,
    master - mean (107ms)  : 105, 109
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6441) - mean (678ms)  : 667, 690
     .   : milestone, 678,
    master - mean (677ms)  : 660, 694
     .   : milestone, 677,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6441) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6441) - mean (634ms)  : 621, 648
     .   : milestone, 634,
    master - mean (633ms)  : 615, 650
     .   : milestone, 633,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6441) - mean (193ms)  : 190, 197
     .   : milestone, 193,
    master - mean (194ms)  : 190, 198
     .   : milestone, 194,

    section CallTarget+Inlining+NGEN
    This PR (6441) - mean (1,106ms)  : 1075, 1138
     .   : milestone, 1106,
    master - mean (1,098ms)  : 1071, 1125
     .   : milestone, 1098,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6441) - mean (277ms)  : 274, 281
     .   : milestone, 277,
    master - mean (277ms)  : 271, 282
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6441) - mean (872ms)  : 844, 901
     .   : milestone, 872,
    master - mean (873ms)  : 838, 908
     .   : milestone, 873,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6441) - mean (266ms)  : 262, 270
     .   : milestone, 266,
    master - mean (266ms)  : 262, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6441) - mean (852ms)  : 814, 890
     .   : milestone, 852,
    master - mean (853ms)  : 820, 885
     .   : milestone, 853,

andrewlock · 2024-12-16T12:58:21Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6441) (11.094M)   : 0, 11094042
    master (11.207M)   : 0, 11207401
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6441) (7.269M)   : 0, 7268640
    master (7.306M)   : 0, 7305881
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.547M)   : 0, 7547108

    section Manual
    master (10.807M)   : 0, 10807085

    section Manual + Automatic
    This PR (6441) (6.842M)   : 0, 6842341
    master (6.654M)   : 0, 6654300

    section DD_TRACE_ENABLED=0
    master (10.240M)   : 0, 10239959

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6441) (9.683M)   : 0, 9683210
    master (9.559M)   : 0, 9558927
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6441) (6.165M)   : 0, 6164699
    master (6.276M)   : 0, 6276496

    section Trace stats
    master (6.702M)   : 0, 6702308

    section Manual
    master (9.582M)   : 0, 9582063

    section Manual + Automatic
    This PR (6441) (5.726M)   : 0, 5726298
    master (5.938M)   : 0, 5937696

    section DD_TRACE_ENABLED=0
    master (9.073M)   : 0, 9072831

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6441) (10.025M)   : 0, 10025227
    master (10.036M)   : 0, 10035894
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6441) (6.410M)   : 0, 6410343
    master (6.535M)   : 0, 6535216
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.175M)   : 0, 7175343

    section Manual
    master (9.942M)   : 0, 9942221

    section Manual + Automatic
    This PR (6441) (6.019M)   : 0, 6019433
    master (6.147M)   : 0, 6147492

    section DD_TRACE_ENABLED=0
    master (9.295M)   : 0, 9295444

andrewlock · 2024-12-16T12:59:12Z

Benchmarks Report for appsec 🐌

Benchmarks for #6441 compared to master:

All benchmarks have the same speed
1 benchmarks have fewer allocations
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`AllCycleSimpleBody`	net6.0	185μs	67.7ns	253ns	2.6	0	188.52 KB
master	`AllCycleSimpleBody`	netcoreapp3.1	287μs	134ns	503ns	2.71	0	195.8 KB
master	`AllCycleSimpleBody`	net472	257μs	169ns	653ns	35.7	2.04	225.32 KB
master	`AllCycleMoreComplexBody`	net6.0	199μs	132ns	493ns	2.71	0	192.02 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	295μs	174ns	650ns	2.65	0	199.22 KB
master	`AllCycleMoreComplexBody`	net472	259μs	258ns	1E+03ns	36.3	2.08	228.83 KB
master	`ObjectExtractorSimpleBody`	net6.0	138ns	0.137ns	0.531ns	0.00393	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	190ns	0.113ns	0.408ns	0.00367	0	272 B
master	`ObjectExtractorSimpleBody`	net472	163ns	0.117ns	0.454ns	0.0446	0	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	2.91μs	2.12ns	8.22ns	0.0528	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	3.77μs	2.53ns	9.8ns	0.05	0	3.69 KB
master	`ObjectExtractorMoreComplexBody`	net472	3.64μs	2.81ns	10.5ns	0.603	0.00543	3.8 KB
#6441	`AllCycleSimpleBody`	net6.0	202μs	56.4ns	195ns	2.63	0	188.38 KB
#6441	`AllCycleSimpleBody`	netcoreapp3.1	297μs	200ns	749ns	2.66	0	195.66 KB
#6441	`AllCycleSimpleBody`	net472	272μs	79.3ns	286ns	35.7	2.03	225.16 KB
#6441	`AllCycleMoreComplexBody`	net6.0	211μs	53.8ns	194ns	2.63	0	191.88 KB
#6441	`AllCycleMoreComplexBody`	netcoreapp3.1	316μs	119ns	414ns	2.68	0	199.07 KB
#6441	`AllCycleMoreComplexBody`	net472	273μs	427ns	1.66μs	36.3	2.05	228.67 KB
#6441	`ObjectExtractorSimpleBody`	net6.0	143ns	0.081ns	0.303ns	0.00394	0	280 B
#6441	`ObjectExtractorSimpleBody`	netcoreapp3.1	186ns	0.0501ns	0.174ns	0.00375	0	272 B
#6441	`ObjectExtractorSimpleBody`	net472	162ns	0.107ns	0.414ns	0.0446	0	281 B
#6441	`ObjectExtractorMoreComplexBody`	net6.0	2.82μs	1.05ns	3.78ns	0.0538	0	3.78 KB
#6441	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	3.72μs	1.87ns	6.75ns	0.0486	0	3.69 KB
#6441	`ObjectExtractorMoreComplexBody`	net472	3.61μs	4.9ns	19ns	0.603	0.00548	3.8 KB

Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EncodeArgs`	net6.0	36.9μs	28ns	108ns	0.444	0	32.4 KB
master	`EncodeArgs`	netcoreapp3.1	54.5μs	42.1ns	163ns	0.431	0	32.4 KB
master	`EncodeArgs`	net472	67.2μs	60.2ns	225ns	5.14	0.0671	32.5 KB
master	`EncodeLegacyArgs`	net6.0	71.2μs	155ns	580ns	0	0	2.14 KB
master	`EncodeLegacyArgs`	netcoreapp3.1	109μs	289ns	1.12μs	0	0	2.15 KB
master	`EncodeLegacyArgs`	net472	152μs	78.7ns	305ns	0.303	0	2.15 KB
#6441	`EncodeArgs`	net6.0	37.8μs	20.3ns	78.5ns	0.455	0	32.4 KB
#6441	`EncodeArgs`	netcoreapp3.1	53.8μs	30.5ns	114ns	0.428	0	32.4 KB
#6441	`EncodeArgs`	net472	67.6μs	22.6ns	78.4ns	5.14	0.0676	32.5 KB
#6441	`EncodeLegacyArgs`	net6.0	75.8μs	424ns	2.68μs	0	0	2.14 KB
#6441	`EncodeLegacyArgs`	netcoreapp3.1	104μs	82ns	318ns	0	0	2.15 KB
#6441	`EncodeLegacyArgs`	net472	152μs	128ns	494ns	0.305	0	2.15 KB

Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunWafRealisticBenchmark`	net6.0	182μs	172ns	668ns	0	2.44 KB
master	`RunWafRealisticBenchmark`	netcoreapp3.1	196μs	190ns	736ns	0	2.39 KB
master	`RunWafRealisticBenchmark`	net472	210μs	198ns	766ns	0.312	2.46 KB
master	`RunWafRealisticBenchmarkWithAttack`	net6.0	122μs	74.1ns	287ns	0	1.47 KB
master	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	128μs	88ns	341ns	0	1.46 KB
master	`RunWafRealisticBenchmarkWithAttack`	net472	140μs	40.3ns	151ns	0.209	1.49 KB
#6441	`RunWafRealisticBenchmark`	net6.0	182μs	196ns	758ns	0	2.44 KB
#6441	`RunWafRealisticBenchmark`	netcoreapp3.1	194μs	260ns	1.01μs	0	2.39 KB
#6441	`RunWafRealisticBenchmark`	net472	207μs	104ns	404ns	0.31	2.46 KB
#6441	`RunWafRealisticBenchmarkWithAttack`	net6.0	122μs	95.2ns	343ns	0	1.47 KB
#6441	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	130μs	141ns	546ns	0	1.46 KB
#6441	`RunWafRealisticBenchmarkWithAttack`	net472	139μs	67.3ns	261ns	0.208	1.49 KB

Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6441

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0	254.37 KB	263.09 KB	8.72 KB	3.43%

Fewer allocations 🎉 in #6441

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472	62.46 KB	62.09 KB	-376 B	-0.60%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`StringConcatBenchmark`	net6.0	58.4μs	717ns	7.1μs	43.44 KB
master	`StringConcatBenchmark`	netcoreapp3.1	52.9μs	235ns	912ns	42.64 KB
master	`StringConcatBenchmark`	net472	36.9μs	125ns	468ns	62.46 KB
master	`StringConcatAspectBenchmark`	net6.0	310μs	1.76μs	12.4μs	254.37 KB
master	`StringConcatAspectBenchmark`	netcoreapp3.1	338μs	1.6μs	6.59μs	252.92 KB
master	`StringConcatAspectBenchmark`	net472	281μs	5.99μs	58.1μs	278.53 KB
#6441	`StringConcatBenchmark`	net6.0	59.4μs	775ns	7.63μs	43.44 KB
#6441	`StringConcatBenchmark`	netcoreapp3.1	58μs	736ns	7.24μs	42.64 KB
#6441	`StringConcatBenchmark`	net472	37.1μs	92.3ns	333ns	62.09 KB
#6441	`StringConcatAspectBenchmark`	net6.0	326μs	1.82μs	11.8μs	263.09 KB
#6441	`StringConcatAspectBenchmark`	netcoreapp3.1	336μs	1.85μs	11.3μs	253.21 KB
#6441	`StringConcatAspectBenchmark`	net472	283μs	5.9μs	57.8μs	278.53 KB

andrewlock · 2024-12-16T13:03:46Z

Benchmarks Report for tracer 🐌

Benchmarks for #6441 compared to master:

2 benchmarks are faster, with geometric mean 1.139
2 benchmarks are slower, with geometric mean 1.142
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.02μs	43.7ns	287ns	0.0157	0.00784	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.1μs	46.8ns	181ns	0.0201	0.0101	0	5.8 KB
master	`StartStopWithChild`	net472	16.4μs	38.9ns	151ns	1.04	0.303	0.0983	6.2 KB
#6441	`StartStopWithChild`	net6.0	7.97μs	42.1ns	231ns	0.0154	0.00769	0	5.61 KB
#6441	`StartStopWithChild`	netcoreapp3.1	10.2μs	55.6ns	319ns	0.0242	0.00967	0	5.8 KB
#6441	`StartStopWithChild`	net472	16.4μs	61ns	236ns	1.04	0.31	0.0979	6.2 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	484μs	785ns	3.04μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	666μs	1.74μs	6.75μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	847μs	757ns	2.62μs	0.422	3.3 KB
#6441	`WriteAndFlushEnrichedTraces`	net6.0	476μs	413ns	1.6μs	0	2.7 KB
#6441	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	635μs	437ns	1.64μs	0	2.7 KB
#6441	`WriteAndFlushEnrichedTraces`	net472	849μs	429ns	1.61μs	0.422	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	149μs	869ns	8.24μs	0.153	14.47 KB
master	`SendRequest`	netcoreapp3.1	169μs	976ns	8.4μs	0.17	17.27 KB
master	`SendRequest`	net472	0.000589ns	0.000489ns	0.00183ns	0	0 b
#6441	`SendRequest`	net6.0	149μs	877ns	8.32μs	0.154	14.47 KB
#6441	`SendRequest`	netcoreapp3.1	167μs	923ns	6.39μs	0.168	17.27 KB
#6441	`SendRequest`	net472	3.05E‑05ns	3.05E‑05ns	0.000114ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6441

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.79 KB	41.44 KB	-350 B	-0.84%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	588μs	3.25μs	19.2μs	0.561	0	0	41.79 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	653μs	2.92μs	16μs	0.331	0	0	41.87 KB
master	`WriteAndFlushEnrichedTraces`	net472	838μs	4.22μs	17.9μs	8.52	2.44	0.406	53.26 KB
#6441	`WriteAndFlushEnrichedTraces`	net6.0	547μs	2.43μs	9.42μs	0.558	0	0	41.44 KB
#6441	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	680μs	3.73μs	23μs	0.322	0	0	41.92 KB
#6441	`WriteAndFlushEnrichedTraces`	net472	862μs	3.62μs	14μs	8.33	2.5	0.417	53.31 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.3μs	1.02ns	3.94ns	0.0146	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.81μs	2.54ns	9.85ns	0.0136	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.14μs	1.84ns	7.12ns	0.157	0.00107	987 B
#6441	`ExecuteNonQuery`	net6.0	1.25μs	1.08ns	4.19ns	0.0146	0	1.02 KB
#6441	`ExecuteNonQuery`	netcoreapp3.1	1.78μs	2.19ns	8.48ns	0.0129	0	1.02 KB
#6441	`ExecuteNonQuery`	net472	2.06μs	1.55ns	6ns	0.156	0.00102	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.33μs	0.64ns	2.48ns	0.0134	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.55μs	1.39ns	5.2ns	0.013	976 B
master	`CallElasticsearch`	net472	2.59μs	2.4ns	9.28ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.36μs	0.422ns	1.52ns	0.0128	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.64μs	1.02ns	3.93ns	0.014	1.02 KB
master	`CallElasticsearchAsync`	net472	2.58μs	2.13ns	8.26ns	0.166	1.05 KB
#6441	`CallElasticsearch`	net6.0	1.2μs	0.539ns	2.02ns	0.0133	976 B
#6441	`CallElasticsearch`	netcoreapp3.1	1.47μs	0.454ns	1.7ns	0.0134	976 B
#6441	`CallElasticsearch`	net472	2.56μs	2.48ns	9.61ns	0.157	995 B
#6441	`CallElasticsearchAsync`	net6.0	1.37μs	0.906ns	3.51ns	0.013	952 B
#6441	`CallElasticsearchAsync`	netcoreapp3.1	1.73μs	1.49ns	5.57ns	0.0138	1.02 KB
#6441	`CallElasticsearchAsync`	net472	2.65μs	2.55ns	9.89ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6441

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	1.134	1,381.92	1,218.45

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.38μs	0.494ns	1.91ns	0.0128	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.6μs	0.436ns	1.63ns	0.0128	952 B
master	`ExecuteAsync`	net472	1.82μs	0.371ns	1.39ns	0.145	915 B
#6441	`ExecuteAsync`	net6.0	1.22μs	0.554ns	2.07ns	0.0128	952 B
#6441	`ExecuteAsync`	netcoreapp3.1	1.61μs	0.717ns	2.78ns	0.0128	952 B
#6441	`ExecuteAsync`	net472	1.81μs	0.917ns	3.43ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.3μs	1.95ns	7.54ns	0.0323	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.33μs	1.59ns	5.97ns	0.0374	2.85 KB
master	`SendAsync`	net472	7.38μs	1.78ns	6.88ns	0.494	3.12 KB
#6441	`SendAsync`	net6.0	4.37μs	2.85ns	10.3ns	0.0328	2.31 KB
#6441	`SendAsync`	netcoreapp3.1	5.21μs	3.71ns	14.4ns	0.0387	2.85 KB
#6441	`SendAsync`	net472	7.42μs	1.24ns	4.63ns	0.493	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.48μs	0.72ns	2.69ns	0.0228	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.43μs	2.01ns	7.79ns	0.0219	1.64 KB
master	`EnrichedLog`	net472	2.8μs	1.47ns	5.68ns	0.249	1.57 KB
#6441	`EnrichedLog`	net6.0	1.53μs	4.74ns	18.4ns	0.0228	1.64 KB
#6441	`EnrichedLog`	netcoreapp3.1	2.38μs	1.2ns	4.31ns	0.0227	1.64 KB
#6441	`EnrichedLog`	net472	2.64μs	1.25ns	4.82ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	118μs	243ns	941ns	0.0591	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	121μs	171ns	662ns	0	0	4.28 KB
master	`EnrichedLog`	net472	154μs	81.5ns	294ns	0.684	0.228	4.46 KB
#6441	`EnrichedLog`	net6.0	120μs	131ns	506ns	0.0605	0	4.28 KB
#6441	`EnrichedLog`	netcoreapp3.1	123μs	114ns	441ns	0	0	4.28 KB
#6441	`EnrichedLog`	net472	152μs	141ns	547ns	0.675	0.225	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.02μs	1.06ns	4.1ns	0.0299	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.25μs	2.98ns	11.5ns	0.0296	2.2 KB
master	`EnrichedLog`	net472	4.89μs	1.4ns	5.42ns	0.32	2.02 KB
#6441	`EnrichedLog`	net6.0	3.22μs	0.832ns	3.22ns	0.03	2.2 KB
#6441	`EnrichedLog`	netcoreapp3.1	4.14μs	1.5ns	5.8ns	0.029	2.2 KB
#6441	`EnrichedLog`	net472	4.95μs	1.11ns	4.29ns	0.318	2.02 KB

Benchmarks.Trace.RedisBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6441

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1	1.143	1,928.67	1,687.05

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.31μs	0.911ns	3.53ns	0.0157	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.93μs	0.778ns	3.01ns	0.0154	1.14 KB
master	`SendReceive`	net472	2.21μs	0.887ns	3.44ns	0.183	1.16 KB
#6441	`SendReceive`	net6.0	1.31μs	0.469ns	1.69ns	0.0157	1.14 KB
#6441	`SendReceive`	netcoreapp3.1	1.69μs	0.973ns	3.77ns	0.0151	1.14 KB
#6441	`SendReceive`	net472	2.19μs	1.6ns	6.19ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.75μs	0.668ns	2.41ns	0.022	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.9μs	2.14ns	8.29ns	0.0216	1.65 KB
master	`EnrichedLog`	net472	4.42μs	3.49ns	13.5ns	0.322	2.04 KB
#6441	`EnrichedLog`	net6.0	2.74μs	1.06ns	3.97ns	0.022	1.6 KB
#6441	`EnrichedLog`	netcoreapp3.1	4.01μs	1.63ns	6.33ns	0.022	1.65 KB
#6441	`EnrichedLog`	net472	4.48μs	4.49ns	17.4ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6441

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472	1.132	631.01	714.13

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	402ns	0.238ns	0.921ns	0.00805	576 B
master	`StartFinishSpan`	netcoreapp3.1	616ns	0.76ns	2.95ns	0.00768	576 B
master	`StartFinishSpan`	net472	631ns	0.366ns	1.42ns	0.0916	578 B
master	`StartFinishScope`	net6.0	556ns	0.355ns	1.38ns	0.00982	696 B
master	`StartFinishScope`	netcoreapp3.1	733ns	0.697ns	2.7ns	0.00919	696 B
master	`StartFinishScope`	net472	849ns	0.866ns	3.35ns	0.104	658 B
#6441	`StartFinishSpan`	net6.0	397ns	0.236ns	0.912ns	0.00803	576 B
#6441	`StartFinishSpan`	netcoreapp3.1	626ns	0.849ns	3.06ns	0.00796	576 B
#6441	`StartFinishSpan`	net472	714ns	0.416ns	1.61ns	0.0915	578 B
#6441	`StartFinishScope`	net6.0	536ns	2.59ns	10.4ns	0.0098	696 B
#6441	`StartFinishScope`	netcoreapp3.1	669ns	0.9ns	3.48ns	0.00955	696 B
#6441	`StartFinishScope`	net472	852ns	1.03ns	3.98ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6441

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.152	591.12	680.81

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	591ns	0.394ns	1.47ns	0.00976	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	885ns	0.35ns	1.31ns	0.00973	696 B
master	`RunOnMethodBegin`	net472	1.16μs	1.04ns	4.04ns	0.104	658 B
#6441	`RunOnMethodBegin`	net6.0	681ns	0.637ns	2.47ns	0.00966	696 B
#6441	`RunOnMethodBegin`	netcoreapp3.1	958ns	1.19ns	4.61ns	0.00955	696 B
#6441	`RunOnMethodBegin`	net472	1.15μs	0.963ns	3.6ns	0.104	658 B

NachoEchevarria

Thank you!

kevingosse requested a review from a team as a code owner December 16, 2024 12:01

kevingosse added area:test-apps apps used to test integrations area:asm-iast labels Dec 16, 2024

github-actions bot added area:tests unit tests, integration tests and removed area:asm-iast labels Dec 16, 2024

NachoEchevarria approved these changes Dec 16, 2024

View reviewed changes

Removed unused usings

444883d

kevingosse force-pushed the kevin/fix_security_aspnetcore2 branch from 2fb7c20 to 444883d Compare December 17, 2024 10:27

andrewlock approved these changes Dec 17, 2024

View reviewed changes

kevingosse merged commit ece3b57 into master Dec 17, 2024
98 of 103 checks passed

kevingosse deleted the kevin/fix_security_aspnetcore2 branch December 17, 2024 13:04

github-actions bot added this to the vNext-v3 milestone Dec 17, 2024

robertpi added the area:asm-iast label Dec 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IAST] Fix compilation of Samples.Security.AspNetCore2 #6441

[IAST] Fix compilation of Samples.Security.AspNetCore2 #6441

kevingosse commented Dec 16, 2024

datadog-ddstaging bot commented Dec 16, 2024 •

edited

Loading

andrewlock commented Dec 16, 2024 •

edited

Loading

andrewlock commented Dec 16, 2024 •

edited

Loading

andrewlock commented Dec 16, 2024

Raw results

Raw results

Raw results

More allocations ⚠️ in #6441

Fewer allocations 🎉 in #6441

Raw results

andrewlock commented Dec 16, 2024

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6441

Raw results

Raw results

Raw results

Faster 🎉 in #6441

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6441

Raw results

Raw results

Slower ⚠️ in #6441

Raw results

Slower ⚠️ in #6441

Raw results

NachoEchevarria left a comment

[IAST] Fix compilation of Samples.Security.AspNetCore2 #6441

[IAST] Fix compilation of Samples.Security.AspNetCore2 #6441

Conversation

kevingosse commented Dec 16, 2024

Summary of changes

datadog-ddstaging bot commented Dec 16, 2024 • edited Loading

Datadog Report

❌ Failed Tests (3)

andrewlock commented Dec 16, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Dec 16, 2024 • edited Loading

Throughput/Crank Report ⚡

andrewlock commented Dec 16, 2024

Benchmarks Report for appsec 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #6441

Fewer allocations 🎉 in #6441

Raw results

andrewlock commented Dec 16, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6441

Raw results

Raw results

Raw results

Faster 🎉 in #6441

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6441

Raw results

Raw results

Slower ⚠️ in #6441

Raw results

Slower ⚠️ in #6441

Raw results

NachoEchevarria left a comment

Choose a reason for hiding this comment

datadog-ddstaging bot commented Dec 16, 2024 •

edited

Loading

andrewlock commented Dec 16, 2024 •

edited

Loading

andrewlock commented Dec 16, 2024 •

edited

Loading