[dd-dotnet] Catch error when failing to read env vars on IIS #6430

kevingosse · 2024-12-12T13:37:52Z

Summary of changes

Catch the error and log a warning when the diagnostic tool fails to read custom environment variables on an IIS application pool.

Reason for change

Versions of IIS prior to 10 didn't have an <environmentVariables> node.

Implementation details

Just catching the exceptions. And disabling rule SA1108 because stylecop doesn't like my comment.

Test coverage

I tried replacing environmentVariables with an attribute that doesn't exist and it works.

andrewlock · 2024-12-12T13:43:32Z

tracer/src/Datadog.Trace.Tools.dd_dotnet/Checks/Windows/IIS/ApplicationPool.cs

@@ -3,8 +3,11 @@
 // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
 // </copyright>

+#pragma warning disable SA1108 // BlockStatementsMustNotContainEmbeddedComments


I "love" that you disabled this instead of just moving the comment inside the catch 😂

My comment is at the right place and I'm willing to die on that hill

andrewlock · 2024-12-12T14:11:30Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6430) - mean (68ms)  : 66, 70
     .   : milestone, 68,
    master - mean (69ms)  : 65, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6430) - mean (973ms)  : 950, 997
     .   : milestone, 973,
    master - mean (979ms)  : 952, 1006
     .   : milestone, 979,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6430) - mean (107ms)  : 105, 109
     .   : milestone, 107,
    master - mean (108ms)  : 105, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6430) - mean (675ms)  : 659, 691
     .   : milestone, 675,
    master - mean (678ms)  : 664, 692
     .   : milestone, 678,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6430) - mean (90ms)  : 88, 92
     .   : milestone, 90,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6430) - mean (629ms)  : 613, 645
     .   : milestone, 629,
    master - mean (638ms)  : 625, 651
     .   : milestone, 638,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6430) - mean (193ms)  : 189, 197
     .   : milestone, 193,
    master - mean (194ms)  : 190, 198
     .   : milestone, 194,

    section CallTarget+Inlining+NGEN
    This PR (6430) - mean (1,104ms)  : 1068, 1139
     .   : milestone, 1104,
    master - mean (1,101ms)  : 1073, 1128
     .   : milestone, 1101,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6430) - mean (278ms)  : 274, 282
     .   : milestone, 278,
    master - mean (278ms)  : 274, 283
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (6430) - mean (872ms)  : 838, 905
     .   : milestone, 872,
    master - mean (877ms)  : 848, 906
     .   : milestone, 877,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6430) - mean (267ms)  : 263, 272
     .   : milestone, 267,
    master - mean (268ms)  : 262, 273
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (6430) - mean (853ms)  : 814, 893
     .   : milestone, 853,
    master - mean (854ms)  : 815, 893
     .   : milestone, 854,

datadog-ddstaging · 2024-12-12T14:38:02Z

Datadog Report

Branch report: kevin/dd-dotnet-environment
Commit report: ad558a6
Test service: dd-trace-dotnet

✅ 0 Failed, 459238 Passed, 2834 Skipped, 19h 41m 28.57s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

TestInstrumentedUnitTests - Datadog.Trace.Security.IntegrationTests.Iast.IastInstrumentationUnitTests

andrewlock · 2024-12-12T14:38:42Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6430) (11.319M)   : 0, 11318706
    master (11.185M)   : 0, 11185452
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6430) (7.272M)   : 0, 7272360
    master (7.339M)   : 0, 7338940
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.663M)   : 0, 7662708

    section Manual
    master (11.063M)   : 0, 11063462

    section Manual + Automatic
    This PR (6430) (6.711M)   : 0, 6711041
    master (6.756M)   : 0, 6755869

    section DD_TRACE_ENABLED=0
    master (10.292M)   : 0, 10291550

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6430) (9.400M)   : 0, 9399973
    master (9.298M)   : 0, 9298207
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6430) (6.255M)   : 0, 6255073
    master (6.384M)   : 0, 6384093

    section Trace stats
    master (6.648M)   : 0, 6647596

    section Manual
    master (9.348M)   : 0, 9347597

    section Manual + Automatic
    This PR (6430) (5.757M)   : 0, 5756677
    master (5.912M)   : 0, 5911591

    section DD_TRACE_ENABLED=0
    master (8.868M)   : 0, 8867634

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6430) (9.739M)   : 0, 9739274
    master (9.792M)   : 0, 9791934
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6430) (6.358M)   : 0, 6358074
    master (6.431M)   : 0, 6431072
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.934M)   : 0, 6934019

    section Manual
    master (9.676M)   : 0, 9675873

    section Manual + Automatic
    This PR (6430) (6.024M)   : 0, 6024115
    master (6.062M)   : 0, 6061828

    section DD_TRACE_ENABLED=0
    master (9.288M)   : 0, 9287665

andrewlock · 2024-12-12T14:58:08Z

Benchmarks Report for tracer 🐌

Benchmarks for #6430 compared to master:

1 benchmarks are faster, with geometric mean 1.135
1 benchmarks are slower, with geometric mean 1.197
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.16μs	45.8ns	290ns	0.0126	0.00422	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.2μs	53.6ns	268ns	0.0148	0.00493	0	5.8 KB
master	`StartStopWithChild`	net472	16.4μs	42.1ns	158ns	1.05	0.312	0.104	6.22 KB
#6430	`StartStopWithChild`	net6.0	8.05μs	37.3ns	144ns	0.0155	0.00777	0	5.61 KB
#6430	`StartStopWithChild`	netcoreapp3.1	10.2μs	50.1ns	230ns	0.0211	0.0106	0	5.81 KB
#6430	`StartStopWithChild`	net472	16.1μs	29.2ns	101ns	1.04	0.306	0.0968	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	511μs	219ns	820ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	668μs	737ns	2.85μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	857μs	1.25μs	4.84μs	0.428	3.3 KB
#6430	`WriteAndFlushEnrichedTraces`	net6.0	481μs	171ns	663ns	0	2.7 KB
#6430	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	649μs	252ns	942ns	0	2.7 KB
#6430	`WriteAndFlushEnrichedTraces`	net472	859μs	751ns	2.91μs	0.428	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	148μs	861ns	7.99μs	0.14	14.47 KB
master	`SendRequest`	netcoreapp3.1	171μs	1.19μs	11.8μs	0.165	17.27 KB
master	`SendRequest`	net472	0ns	0ns	0ns	0	0 b
#6430	`SendRequest`	net6.0	150μs	859ns	6.93μs	0.146	14.47 KB
#6430	`SendRequest`	netcoreapp3.1	173μs	1.1μs	10.9μs	0.16	17.27 KB
#6430	`SendRequest`	net472	0.00113ns	0.000609ns	0.00228ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	582μs	2.68μs	9.66μs	0.556	0	0	41.82 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	661μs	3.29μs	15.1μs	0.331	0	0	41.79 KB
master	`WriteAndFlushEnrichedTraces`	net472	860μs	4.24μs	18μs	8.19	2.59	0.431	53.27 KB
#6430	`WriteAndFlushEnrichedTraces`	net6.0	562μs	3.09μs	21.4μs	0.573	0	0	41.62 KB
#6430	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	667μs	3.1μs	11.6μs	0.319	0	0	41.74 KB
#6430	`WriteAndFlushEnrichedTraces`	net472	860μs	3.95μs	15.8μs	8.45	2.53	0.422	53.25 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.24μs	1.52ns	5.89ns	0.0142	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.68μs	0.676ns	2.53ns	0.0135	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.11μs	2.33ns	9.01ns	0.157	0.00106	987 B
#6430	`ExecuteNonQuery`	net6.0	1.2μs	0.979ns	3.79ns	0.0143	0	1.02 KB
#6430	`ExecuteNonQuery`	netcoreapp3.1	1.76μs	1.91ns	7.38ns	0.0141	0	1.02 KB
#6430	`ExecuteNonQuery`	net472	2.12μs	1.56ns	6.04ns	0.156	0.00106	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.13μs	0.771ns	2.89ns	0.0136	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.56μs	2.7ns	10.1ns	0.0132	976 B
master	`CallElasticsearch`	net472	2.56μs	1.88ns	7.05ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.27μs	0.535ns	2.07ns	0.0134	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.61μs	1.3ns	5.02ns	0.0137	1.02 KB
master	`CallElasticsearchAsync`	net472	2.65μs	1.85ns	6.91ns	0.166	1.05 KB
#6430	`CallElasticsearch`	net6.0	1.24μs	0.729ns	2.82ns	0.0137	976 B
#6430	`CallElasticsearch`	netcoreapp3.1	1.54μs	0.921ns	3.57ns	0.0131	976 B
#6430	`CallElasticsearch`	net472	2.56μs	1.88ns	7.03ns	0.157	995 B
#6430	`CallElasticsearchAsync`	net6.0	1.37μs	0.594ns	2.22ns	0.013	952 B
#6430	`CallElasticsearchAsync`	netcoreapp3.1	1.71μs	0.407ns	1.58ns	0.0137	1.02 KB
#6430	`CallElasticsearchAsync`	net472	2.66μs	1.99ns	7.43ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.36μs	0.562ns	2.18ns	0.0129	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.65μs	0.696ns	2.51ns	0.0124	952 B
master	`ExecuteAsync`	net472	1.82μs	0.398ns	1.43ns	0.145	915 B
#6430	`ExecuteAsync`	net6.0	1.27μs	0.55ns	2.06ns	0.0134	952 B
#6430	`ExecuteAsync`	netcoreapp3.1	1.6μs	1.62ns	6.29ns	0.0128	952 B
#6430	`ExecuteAsync`	net472	1.81μs	0.475ns	1.84ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.48μs	1.58ns	5.9ns	0.0315	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.33μs	2.31ns	8.63ns	0.0374	2.85 KB
master	`SendAsync`	net472	7.31μs	3.7ns	14.3ns	0.493	3.12 KB
#6430	`SendAsync`	net6.0	4.45μs	1.16ns	4.36ns	0.0333	2.31 KB
#6430	`SendAsync`	netcoreapp3.1	5.42μs	2.89ns	11.2ns	0.0382	2.85 KB
#6430	`SendAsync`	net472	7.38μs	1.66ns	6.21ns	0.494	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.52μs	2.22ns	8.6ns	0.0227	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.27μs	0.632ns	2.28ns	0.0216	1.64 KB
master	`EnrichedLog`	net472	2.73μs	1.34ns	5.19ns	0.249	1.57 KB
#6430	`EnrichedLog`	net6.0	1.54μs	0.705ns	2.64ns	0.0232	1.64 KB
#6430	`EnrichedLog`	netcoreapp3.1	2.23μs	1.96ns	7.58ns	0.0222	1.64 KB
#6430	`EnrichedLog`	net472	2.73μs	1.68ns	6.49ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	121μs	163ns	633ns	0	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	124μs	157ns	586ns	0.0621	0	4.28 KB
master	`EnrichedLog`	net472	152μs	107ns	387ns	0.675	0.225	4.46 KB
#6430	`EnrichedLog`	net6.0	117μs	114ns	441ns	0.0594	0	4.28 KB
#6430	`EnrichedLog`	netcoreapp3.1	122μs	194ns	752ns	0	0	4.28 KB
#6430	`EnrichedLog`	net472	153μs	93.1ns	360ns	0.69	0.23	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.07μs	1.18ns	4.56ns	0.0305	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.22μs	2.64ns	10.2ns	0.0296	2.2 KB
master	`EnrichedLog`	net472	5.01μs	1.2ns	4.64ns	0.319	2.02 KB
#6430	`EnrichedLog`	net6.0	3.16μs	1.18ns	4.58ns	0.0301	2.2 KB
#6430	`EnrichedLog`	netcoreapp3.1	4.2μs	1.74ns	6.51ns	0.0295	2.2 KB
#6430	`EnrichedLog`	net472	5μs	1.96ns	7.61ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.39μs	0.707ns	2.74ns	0.016	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.73μs	5.03ns	19.5ns	0.0154	1.14 KB
master	`SendReceive`	net472	2.16μs	2.04ns	7.88ns	0.183	1.16 KB
#6430	`SendReceive`	net6.0	1.29μs	0.428ns	1.66ns	0.0161	1.14 KB
#6430	`SendReceive`	netcoreapp3.1	1.79μs	0.508ns	1.9ns	0.0152	1.14 KB
#6430	`SendReceive`	net472	2.19μs	0.854ns	3.31ns	0.184	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.67μs	0.985ns	3.82ns	0.0227	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.93μs	2.47ns	9.55ns	0.0215	1.65 KB
master	`EnrichedLog`	net472	4.35μs	3.89ns	14ns	0.323	2.04 KB
#6430	`EnrichedLog`	net6.0	2.79μs	1.08ns	4.2ns	0.0223	1.6 KB
#6430	`EnrichedLog`	netcoreapp3.1	3.83μs	1.69ns	6.33ns	0.0212	1.65 KB
#6430	`EnrichedLog`	net472	4.4μs	4.7ns	18.2ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6430

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.197	560.05	670.59

Faster 🎉 in #6430

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1	1.135	775.76	683.68

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	448ns	0.279ns	1.08ns	0.00801	576 B
master	`StartFinishSpan`	netcoreapp3.1	560ns	0.304ns	1.1ns	0.00786	576 B
master	`StartFinishSpan`	net472	700ns	0.388ns	1.5ns	0.0915	578 B
master	`StartFinishScope`	net6.0	488ns	0.249ns	0.965ns	0.00979	696 B
master	`StartFinishScope`	netcoreapp3.1	776ns	0.426ns	1.65ns	0.00933	696 B
master	`StartFinishScope`	net472	940ns	0.499ns	1.93ns	0.104	658 B
#6430	`StartFinishSpan`	net6.0	426ns	0.355ns	1.37ns	0.0079	576 B
#6430	`StartFinishSpan`	netcoreapp3.1	671ns	0.398ns	1.49ns	0.00775	576 B
#6430	`StartFinishSpan`	net472	708ns	0.363ns	1.41ns	0.0918	578 B
#6430	`StartFinishScope`	net6.0	489ns	0.3ns	1.16ns	0.00984	696 B
#6430	`StartFinishScope`	netcoreapp3.1	685ns	1.06ns	4.1ns	0.0093	696 B
#6430	`StartFinishScope`	net472	916ns	0.44ns	1.7ns	0.105	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	690ns	1.36ns	5.29ns	0.00986	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	957ns	0.598ns	2.32ns	0.0092	696 B
master	`RunOnMethodBegin`	net472	1.14μs	0.616ns	2.39ns	0.104	658 B
#6430	`RunOnMethodBegin`	net6.0	671ns	0.436ns	1.69ns	0.00973	696 B
#6430	`RunOnMethodBegin`	netcoreapp3.1	973ns	0.69ns	2.67ns	0.00929	696 B
#6430	`RunOnMethodBegin`	net472	1.2μs	0.739ns	2.86ns	0.105	658 B

lucaspimentel

Thanks!

Catch error when failing to read env vars on IIS

ad558a6

kevingosse added the area:tools label Dec 12, 2024

kevingosse requested a review from a team as a code owner December 12, 2024 13:37

andrewlock approved these changes Dec 12, 2024

View reviewed changes

kevingosse added the type:bug label Dec 12, 2024

lucaspimentel approved these changes Dec 12, 2024

View reviewed changes

kevingosse merged commit 9a4790a into master Dec 17, 2024
104 checks passed

kevingosse deleted the kevin/dd-dotnet-environment branch December 17, 2024 10:08

github-actions bot added this to the vNext-v3 milestone Dec 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dd-dotnet] Catch error when failing to read env vars on IIS #6430

[dd-dotnet] Catch error when failing to read env vars on IIS #6430

kevingosse commented Dec 12, 2024

andrewlock Dec 12, 2024

kevingosse Dec 12, 2024

andrewlock commented Dec 12, 2024

datadog-ddstaging bot commented Dec 12, 2024 •

edited

Loading

andrewlock commented Dec 12, 2024

andrewlock commented Dec 12, 2024

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6430

Faster 🎉 in #6430

Raw results

Raw results

lucaspimentel left a comment

[dd-dotnet] Catch error when failing to read env vars on IIS #6430

[dd-dotnet] Catch error when failing to read env vars on IIS #6430

Conversation

kevingosse commented Dec 12, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

andrewlock Dec 12, 2024

Choose a reason for hiding this comment

kevingosse Dec 12, 2024

Choose a reason for hiding this comment

andrewlock commented Dec 12, 2024

Execution-Time Benchmarks Report ⏱️

datadog-ddstaging bot commented Dec 12, 2024 • edited Loading

Datadog Report

New Flaky Tests (1)

andrewlock commented Dec 12, 2024

Throughput/Crank Report ⚡

andrewlock commented Dec 12, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6430

Faster 🎉 in #6430

Raw results

Raw results

lucaspimentel left a comment

Choose a reason for hiding this comment

datadog-ddstaging bot commented Dec 12, 2024 •

edited

Loading