[Dynamic Instrumentation] DEBUG-3223 Add compression support for SymDB #6427

dudikeleti · 2024-12-12T08:30:47Z

Summary of changes

Add support of SymDB payload compresion using gzip. an option is still available to disable compression.

andrewlock · 2024-12-12T09:05:12Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6427) - mean (68ms)  : 66, 71
     .   : milestone, 68,
    master - mean (68ms)  : 66, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6427) - mean (977ms)  : 954, 1000
     .   : milestone, 977,
    master - mean (977ms)  : 956, 998
     .   : milestone, 977,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6427) - mean (108ms)  : 105, 110
     .   : milestone, 108,
    master - mean (107ms)  : 105, 109
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6427) - mean (674ms)  : 659, 689
     .   : milestone, 674,
    master - mean (678ms)  : 663, 692
     .   : milestone, 678,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6427) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6427) - mean (635ms)  : 618, 652
     .   : milestone, 635,
    master - mean (635ms)  : 621, 649
     .   : milestone, 635,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6427) - mean (194ms)  : 190, 197
     .   : milestone, 194,
    master - mean (194ms)  : 189, 199
     .   : milestone, 194,

    section CallTarget+Inlining+NGEN
    This PR (6427) - mean (1,101ms)  : 1074, 1128
     .   : milestone, 1101,
    master - mean (1,098ms)  : 1069, 1127
     .   : milestone, 1098,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6427) - mean (279ms)  : 272, 287
     .   : milestone, 279,
    master - mean (278ms)  : 273, 283
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (6427) - mean (870ms)  : 842, 899
     .   : milestone, 870,
    master - mean (878ms)  : 850, 906
     .   : milestone, 878,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6427) - mean (266ms)  : 262, 270
     .   : milestone, 266,
    master - mean (267ms)  : 263, 272
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (6427) - mean (852ms)  : 822, 882
     .   : milestone, 852,
    master - mean (851ms)  : 824, 877
     .   : milestone, 851,

andrewlock · 2024-12-12T09:27:27Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6427) (10.995M)   : 0, 10995467
    master (11.176M)   : 0, 11175779
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6427) (7.217M)   : 0, 7216672
    master (7.188M)   : 0, 7187812
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.592M)   : 0, 7592225

    section Manual
    master (11.202M)   : 0, 11201615

    section Manual + Automatic
    This PR (6427) (6.629M)   : 0, 6628791
    master (6.624M)   : 0, 6623622

    section DD_TRACE_ENABLED=0
    master (10.184M)   : 0, 10184081

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6427) (9.356M)   : 0, 9356257
    master (9.299M)   : 0, 9299402
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6427) (6.388M)   : 0, 6388204
    master (6.339M)   : 0, 6338804

    section Trace stats
    master (6.490M)   : 0, 6490416

    section Manual
    master (9.438M)   : 0, 9437615

    section Manual + Automatic
    This PR (6427) (5.952M)   : 0, 5952148
    master (5.979M)   : 0, 5979389

    section DD_TRACE_ENABLED=0
    master (8.785M)   : 0, 8784619

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6427) (10.395M)   : 0, 10395472
    master (9.992M)   : 0, 9991636
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6427) (6.481M)   : 0, 6481324
    master (6.531M)   : 0, 6530893
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.153M)   : 0, 7152931

    section Manual
    master (10.055M)   : 0, 10055115

    section Manual + Automatic
    This PR (6427) (6.218M)   : 0, 6217916
    master (5.851M)   : 0, 5850726

    section DD_TRACE_ENABLED=0
    master (9.524M)   : 0, 9524080

andrewlock · 2024-12-12T09:45:59Z

Benchmarks Report for tracer 🐌

Benchmarks for #6427 compared to master:

1 benchmarks are faster, with geometric mean 1.120
2 benchmarks are slower, with geometric mean 1.135
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.03μs	44.8ns	280ns	0.0168	0.00842	0	5.62 KB
master	`StartStopWithChild`	netcoreapp3.1	9.86μs	55.9ns	379ns	0.0251	0.01	0	5.8 KB
master	`StartStopWithChild`	net472	16.4μs	56.9ns	221ns	1.05	0.327	0.106	6.21 KB
#6427	`StartStopWithChild`	net6.0	7.93μs	41.9ns	237ns	0.0113	0.00376	0	5.61 KB
#6427	`StartStopWithChild`	netcoreapp3.1	10.2μs	58.1ns	438ns	0.0254	0.0152	0.00508	5.8 KB
#6427	`StartStopWithChild`	net472	16.5μs	46ns	178ns	1.03	0.309	0.0895	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	478μs	321ns	1.25μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	669μs	355ns	1.38μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	857μs	450ns	1.68μs	0.431	3.3 KB
#6427	`WriteAndFlushEnrichedTraces`	net6.0	481μs	432ns	1.67μs	0	2.7 KB
#6427	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	670μs	395ns	1.53μs	0	2.7 KB
#6427	`WriteAndFlushEnrichedTraces`	net472	851μs	413ns	1.54μs	0.422	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	155μs	934ns	9.11μs	0.145	14.47 KB
master	`SendRequest`	netcoreapp3.1	169μs	992ns	9.09μs	0.173	17.27 KB
master	`SendRequest`	net472	0ns	0ns	0ns	0	0 b
#6427	`SendRequest`	net6.0	152μs	887ns	8.46μs	0.141	14.47 KB
#6427	`SendRequest`	netcoreapp3.1	169μs	981ns	8.66μs	0.193	17.27 KB
#6427	`SendRequest`	net472	0.000414ns	0.000347ns	0.0013ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6427

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.73 KB	41.48 KB	-254 B	-0.61%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	572μs	2.72μs	11.5μs	0.581	0	0	41.73 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	663μs	3.38μs	20.3μs	0.379	0	0	41.65 KB
master	`WriteAndFlushEnrichedTraces`	net472	833μs	2.98μs	10.8μs	8.33	2.5	0.417	53.27 KB
#6427	`WriteAndFlushEnrichedTraces`	net6.0	553μs	3.03μs	17.7μs	0.536	0	0	41.48 KB
#6427	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	648μs	2.74μs	10.3μs	0.319	0	0	41.78 KB
#6427	`WriteAndFlushEnrichedTraces`	net472	837μs	3.9μs	15.6μs	8.22	2.47	0.411	53.3 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.34μs	1.63ns	6.08ns	0.014	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.79μs	1.58ns	6.12ns	0.0133	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.13μs	1.5ns	5.6ns	0.157	0.00105	987 B
#6427	`ExecuteNonQuery`	net6.0	1.25μs	1.51ns	5.84ns	0.0142	0	1.02 KB
#6427	`ExecuteNonQuery`	netcoreapp3.1	1.77μs	1.25ns	4.82ns	0.0136	0	1.02 KB
#6427	`ExecuteNonQuery`	net472	2.1μs	1.67ns	6.47ns	0.156	0.00105	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.33μs	0.421ns	1.52ns	0.0133	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.64μs	1.13ns	4.21ns	0.0132	976 B
master	`CallElasticsearch`	net472	2.54μs	2.48ns	9.62ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.3μs	3.34ns	13ns	0.0135	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.67μs	0.985ns	3.82ns	0.0132	1.02 KB
master	`CallElasticsearchAsync`	net472	2.66μs	2.27ns	8.5ns	0.166	1.05 KB
#6427	`CallElasticsearch`	net6.0	1.2μs	0.675ns	2.52ns	0.0137	976 B
#6427	`CallElasticsearch`	netcoreapp3.1	1.61μs	1.14ns	4.4ns	0.0131	976 B
#6427	`CallElasticsearch`	net472	2.6μs	1.99ns	7.7ns	0.158	995 B
#6427	`CallElasticsearchAsync`	net6.0	1.24μs	0.79ns	2.95ns	0.0131	952 B
#6427	`CallElasticsearchAsync`	netcoreapp3.1	1.71μs	2.96ns	11.5ns	0.0137	1.02 KB
#6427	`CallElasticsearchAsync`	net472	2.6μs	1.01ns	3.9ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.34μs	0.67ns	2.6ns	0.0133	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.68μs	0.626ns	2.43ns	0.0131	952 B
master	`ExecuteAsync`	net472	1.81μs	0.718ns	2.78ns	0.145	915 B
#6427	`ExecuteAsync`	net6.0	1.25μs	0.733ns	2.84ns	0.0132	952 B
#6427	`ExecuteAsync`	netcoreapp3.1	1.69μs	0.888ns	3.32ns	0.0126	952 B
#6427	`ExecuteAsync`	net472	1.76μs	0.612ns	2.37ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.46μs	1.41ns	5.46ns	0.0311	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.55μs	1.45ns	5.44ns	0.039	2.85 KB
master	`SendAsync`	net472	7.37μs	2.3ns	8.92ns	0.494	3.12 KB
#6427	`SendAsync`	net6.0	4.36μs	2.27ns	8.8ns	0.0323	2.31 KB
#6427	`SendAsync`	netcoreapp3.1	5.36μs	3.06ns	11.9ns	0.0377	2.85 KB
#6427	`SendAsync`	net472	7.42μs	1.69ns	6.54ns	0.494	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.54μs	0.991ns	3.71ns	0.023	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.18μs	5.29ns	20.5ns	0.0216	1.64 KB
master	`EnrichedLog`	net472	2.71μs	1.18ns	4.57ns	0.249	1.57 KB
#6427	`EnrichedLog`	net6.0	1.48μs	0.717ns	2.68ns	0.0228	1.64 KB
#6427	`EnrichedLog`	netcoreapp3.1	2.26μs	5.91ns	22.1ns	0.0222	1.64 KB
#6427	`EnrichedLog`	net472	2.68μs	1.64ns	6.14ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	119μs	153ns	592ns	0	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	121μs	140ns	540ns	0	0	4.28 KB
master	`EnrichedLog`	net472	150μs	228ns	884ns	0.675	0.225	4.46 KB
#6427	`EnrichedLog`	net6.0	116μs	95.1ns	368ns	0.058	0	4.28 KB
#6427	`EnrichedLog`	netcoreapp3.1	123μs	243ns	940ns	0	0	4.28 KB
#6427	`EnrichedLog`	net472	150μs	103ns	397ns	0.676	0.225	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.02μs	0.832ns	3.11ns	0.031	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.19μs	3.91ns	15.2ns	0.0294	2.2 KB
master	`EnrichedLog`	net472	4.87μs	1.82ns	7.03ns	0.319	2.02 KB
#6427	`EnrichedLog`	net6.0	3.04μs	0.678ns	2.54ns	0.0307	2.2 KB
#6427	`EnrichedLog`	netcoreapp3.1	4.21μs	2.69ns	10.1ns	0.0293	2.2 KB
#6427	`EnrichedLog`	net472	4.89μs	1.61ns	6.25ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.44μs	0.785ns	2.94ns	0.0159	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.88μs	1.56ns	5.82ns	0.0152	1.14 KB
master	`SendReceive`	net472	2.21μs	0.867ns	3.01ns	0.184	1.16 KB
#6427	`SendReceive`	net6.0	1.3μs	0.944ns	3.66ns	0.0163	1.14 KB
#6427	`SendReceive`	netcoreapp3.1	1.7μs	1.29ns	5.01ns	0.0154	1.14 KB
#6427	`SendReceive`	net472	2.1μs	1.27ns	4.94ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.79μs	0.86ns	3.33ns	0.0222	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	4.02μs	1.3ns	4.85ns	0.0225	1.65 KB
master	`EnrichedLog`	net472	4.55μs	3.92ns	15.2ns	0.323	2.04 KB
#6427	`EnrichedLog`	net6.0	2.67μs	0.901ns	3.49ns	0.0226	1.6 KB
#6427	`EnrichedLog`	netcoreapp3.1	3.78μs	1.72ns	6.45ns	0.0208	1.65 KB
#6427	`EnrichedLog`	net472	4.5μs	5.74ns	22.2ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6427

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.137	543.59	617.82
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.134	407.23	461.96

Faster 🎉 in #6427

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472	1.120	924.38	825.05

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	407ns	0.154ns	0.576ns	0.00802	576 B
master	`StartFinishSpan`	netcoreapp3.1	543ns	0.315ns	1.22ns	0.00782	576 B
master	`StartFinishSpan`	net472	702ns	0.585ns	2.27ns	0.0915	578 B
master	`StartFinishScope`	net6.0	556ns	0.232ns	0.869ns	0.00977	696 B
master	`StartFinishScope`	netcoreapp3.1	711ns	0.489ns	1.83ns	0.00939	696 B
master	`StartFinishScope`	net472	923ns	0.52ns	2.01ns	0.104	658 B
#6427	`StartFinishSpan`	net6.0	462ns	0.349ns	1.35ns	0.00813	576 B
#6427	`StartFinishSpan`	netcoreapp3.1	618ns	0.691ns	2.67ns	0.00773	576 B
#6427	`StartFinishSpan`	net472	682ns	0.657ns	2.54ns	0.0917	578 B
#6427	`StartFinishScope`	net6.0	502ns	0.17ns	0.638ns	0.00974	696 B
#6427	`StartFinishScope`	netcoreapp3.1	669ns	0.344ns	1.33ns	0.00936	696 B
#6427	`StartFinishScope`	net472	825ns	0.605ns	2.34ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	630ns	0.423ns	1.58ns	0.00979	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	897ns	0.46ns	1.78ns	0.00943	696 B
master	`RunOnMethodBegin`	net472	1.11μs	0.573ns	2.22ns	0.104	658 B
#6427	`RunOnMethodBegin`	net6.0	611ns	0.475ns	1.84ns	0.00972	696 B
#6427	`RunOnMethodBegin`	netcoreapp3.1	902ns	0.705ns	2.73ns	0.00947	696 B
#6427	`RunOnMethodBegin`	net472	1.17μs	0.865ns	3.35ns	0.104	658 B

datadog-ddstaging · 2024-12-12T09:58:38Z

Datadog Report

Branch report: dudik/symdb-compression
Commit report: 647262d
Test service: dd-trace-dotnet

✅ 0 Failed, 469689 Passed, 3728 Skipped, 33h 7m 41.38s Total Time

GreenMatan

LGTM

…apacity and approve the max capacity calculation

andrewlock

LGTM

tracer/src/Datadog.Trace/Debugger/Upload/SymbolUploadApi.cs

tracer/test/Datadog.Trace.Tests/Telemetry/config_norm_rules.json

dudikeleti requested a review from a team as a code owner December 12, 2024 08:30

github-actions bot added the area:debugger label Dec 12, 2024

dudikeleti force-pushed the dudik/symdb-compression branch from aa8dbd6 to bef9f0d Compare December 12, 2024 11:27

GreenMatan approved these changes Dec 12, 2024

View reviewed changes

This comment was marked as duplicate.

Sign in to view

dudikeleti force-pushed the dudik/symdb-compression branch 2 times, most recently from c3bdeb5 to 74b7198 Compare December 16, 2024 18:51

dudikeleti added 4 commits December 16, 2024 21:02

Prevent class serialization skipping when approaching StringBuilder c…

f2204bb

…apacity and approve the max capacity calculation

Add gzip compression to symbols

037c69c

Fix the upload compressed bytes

6ec77fe

fix build

a6fe958

dudikeleti force-pushed the dudik/symdb-compression branch from 74b7198 to a6fe958 Compare December 16, 2024 20:02

Add new config to config_norm_rules.json

647262d

dudikeleti requested a review from a team as a code owner December 16, 2024 23:18

andrewlock approved these changes Dec 17, 2024

View reviewed changes

tracer/src/Datadog.Trace/Debugger/Upload/SymbolUploadApi.cs Show resolved Hide resolved

tracer/test/Datadog.Trace.Tests/Telemetry/config_norm_rules.json Show resolved Hide resolved

dudikeleti merged commit 41d9038 into master Dec 17, 2024
105 of 109 checks passed

dudikeleti deleted the dudik/symdb-compression branch December 17, 2024 15:00

github-actions bot added this to the vNext-v3 milestone Dec 17, 2024

andrewlock added the type:performance Performance, speed, latency, resource usage (CPU, memory) label Dec 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dynamic Instrumentation] DEBUG-3223 Add compression support for SymDB #6427

[Dynamic Instrumentation] DEBUG-3223 Add compression support for SymDB #6427

dudikeleti commented Dec 12, 2024

andrewlock commented Dec 12, 2024 •

edited

Loading

andrewlock commented Dec 12, 2024 •

edited

Loading

andrewlock commented Dec 12, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6427

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6427

Faster 🎉 in #6427

Raw results

Raw results

datadog-ddstaging bot commented Dec 12, 2024 •

edited

Loading

GreenMatan left a comment

This comment was marked as duplicate.

andrewlock left a comment

[Dynamic Instrumentation] DEBUG-3223 Add compression support for SymDB #6427

[Dynamic Instrumentation] DEBUG-3223 Add compression support for SymDB #6427

Conversation

dudikeleti commented Dec 12, 2024

Summary of changes

andrewlock commented Dec 12, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Dec 12, 2024 • edited Loading

Throughput/Crank Report ⚡

andrewlock commented Dec 12, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6427

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6427

Faster 🎉 in #6427

Raw results

Raw results

datadog-ddstaging bot commented Dec 12, 2024 • edited Loading

Datadog Report

GreenMatan left a comment

Choose a reason for hiding this comment

This comment was marked as duplicate.

andrewlock left a comment

Choose a reason for hiding this comment

andrewlock commented Dec 12, 2024 •

edited

Loading

andrewlock commented Dec 12, 2024 •

edited

Loading

andrewlock commented Dec 12, 2024 •

edited

Loading

datadog-ddstaging bot commented Dec 12, 2024 •

edited

Loading