Add support for Aerospike.Client v8
#6424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlock
added
type:enhancement
Datadog ReportBranch report: ✅ 0 Failed, 467486 Passed, 3672 Skipped, 32h 31m 53.74s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6424) - mean (68ms) : 65, 71
. : milestone, 68,
master - mean (69ms) : 65, 72
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6424) - mean (974ms) : 951, 997
. : milestone, 974,
master - mean (978ms) : 952, 1004
. : milestone, 978,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6424) - mean (107ms) : 105, 109
. : milestone, 107,
master - mean (108ms) : 105, 110
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6424) - mean (674ms) : 660, 687
. : milestone, 674,
master - mean (680ms) : 663, 697
. : milestone, 680,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6424) - mean (91ms) : 89, 92
. : milestone, 91,
master - mean (91ms) : 89, 93
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6424) - mean (632ms) : 615, 648
. : milestone, 632,
master - mean (639ms) : 624, 653
. : milestone, 639,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6424) - mean (194ms) : 190, 198
. : milestone, 194,
master - mean (194ms) : 190, 199
. : milestone, 194,
section CallTarget+Inlining+NGEN
This PR (6424) - mean (1,094ms) : 1067, 1120
. : milestone, 1094,
master - mean (1,104ms) : 1076, 1132
. : milestone, 1104,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6424) - mean (278ms) : 274, 282
. : milestone, 278,
master - mean (277ms) : 272, 281
. : milestone, 277,
section CallTarget+Inlining+NGEN
This PR (6424) - mean (868ms) : 833, 902
. : milestone, 868,
master - mean (874ms) : 847, 901
. : milestone, 874,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6424) - mean (266ms) : 263, 269
. : milestone, 266,
master - mean (267ms) : 263, 271
. : milestone, 267,
section CallTarget+Inlining+NGEN
This PR (6424) - mean (849ms) : 816, 883
. : milestone, 849,
master - mean (856ms) : 823, 888
. : milestone, 856,
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6424) (10.972M) : 0, 10971755
master (11.199M) : 0, 11199251
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6424) (7.196M) : 0, 7195797
master (7.234M) : 0, 7234132
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.559M) : 0, 7558761
section Manual
master (11.028M) : 0, 11028498
section Manual + Automatic
This PR (6424) (6.662M) : 0, 6662057
master (6.711M) : 0, 6710751
section DD_TRACE_ENABLED=0
master (10.230M) : 0, 10230285
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6424) (9.655M) : 0, 9654764
master (9.417M) : 0, 9416704
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6424) (6.383M) : 0, 6382565
master (6.437M) : 0, 6437027
section Trace stats
master (6.619M) : 0, 6618620
section Manual
master (9.205M) : 0, 9205053
section Manual + Automatic
This PR (6424) (5.955M) : 0, 5954678
master (5.852M) : 0, 5852490
section DD_TRACE_ENABLED=0
master (8.872M) : 0, 8871934
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6424) (10.266M) : 0, 10266284
master (9.905M) : 0, 9904680
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6424) (6.288M) : 0, 6288035
master (6.337M) : 0, 6337163
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (6.938M) : 0, 6938182
section Manual
master (9.708M) : 0, 9708036
section Manual + Automatic
This PR (6424) (5.963M) : 0, 5962518
master (5.665M) : 0, 5664554
section DD_TRACE_ENABLED=0
master (9.111M) : 0, 9111450
|
kevingosse
approved these changes
Dec 12, 2024
Benchmarks Report for tracer 🐌Benchmarks for #6424 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️Raw results
|
veerbia
pushed a commit
that referenced
this pull request
Dec 16, 2024
## Summary of changes Adds support for latest `Aerospike.Client` package ## Reason for change We want to support the latest versions of libraries ## Implementation details Mostly just bump the numbers, needed to add a new duck type to handle some refactoring changes in the library ## Test coverage Extended the tests to cover the new version ## Other details Fixes https://datadoghq.atlassian.net/browse/AIDM-507
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Adds support for latest
Aerospike.ClientpackageReason for change
We want to support the latest versions of libraries
Implementation details
Mostly just bump the numbers, needed to add a new duck type to handle some refactoring changes in the library
Test coverage
Extended the tests to cover the new version
Other details
Fixes https://datadoghq.atlassian.net/browse/AIDM-507