-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Graph.NET v8 #6423
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 464129 Passed, 3690 Skipped, 32h 33m 5.83s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6423) - mean (68ms) : 65, 71
. : milestone, 68,
master - mean (68ms) : 65, 72
. : milestone, 68,
section CallTarget+Inlining+NGEN
This PR (6423) - mean (981ms) : 948, 1013
. : milestone, 981,
master - mean (978ms) : 960, 996
. : milestone, 978,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6423) - mean (108ms) : 105, 110
. : milestone, 108,
master - mean (107ms) : 104, 109
. : milestone, 107,
section CallTarget+Inlining+NGEN
This PR (6423) - mean (680ms) : 657, 703
. : milestone, 680,
master - mean (679ms) : 663, 696
. : milestone, 679,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6423) - mean (91ms) : 90, 93
. : milestone, 91,
master - mean (91ms) : 89, 92
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6423) - mean (634ms) : 620, 649
. : milestone, 634,
master - mean (635ms) : 621, 650
. : milestone, 635,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6423) - mean (193ms) : 188, 199
. : milestone, 193,
master - mean (192ms) : 189, 196
. : milestone, 192,
section CallTarget+Inlining+NGEN
This PR (6423) - mean (1,098ms) : 1062, 1134
. : milestone, 1098,
master - mean (1,101ms) : 1069, 1132
. : milestone, 1101,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6423) - mean (277ms) : 271, 284
. : milestone, 277,
master - mean (277ms) : 272, 282
. : milestone, 277,
section CallTarget+Inlining+NGEN
This PR (6423) - mean (871ms) : 835, 907
. : milestone, 871,
master - mean (872ms) : 832, 913
. : milestone, 872,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6423) - mean (267ms) : 260, 273
. : milestone, 267,
master - mean (266ms) : 261, 271
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (6423) - mean (850ms) : 824, 876
. : milestone, 850,
master - mean (852ms) : 816, 887
. : milestone, 852,
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6423) (11.128M) : 0, 11127652
master (11.216M) : 0, 11215640
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6423) (7.288M) : 0, 7288205
master (7.254M) : 0, 7253861
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.597M) : 0, 7596581
section Manual
master (11.173M) : 0, 11172529
section Manual + Automatic
This PR (6423) (6.693M) : 0, 6693486
master (6.632M) : 0, 6631665
section DD_TRACE_ENABLED=0
master (10.246M) : 0, 10246323
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6423) (9.375M) : 0, 9375379
master (9.607M) : 0, 9606780
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6423) (6.255M) : 0, 6254522
master (6.315M) : 0, 6314798
section Trace stats
master (6.839M) : 0, 6838732
section Manual
master (9.710M) : 0, 9709828
section Manual + Automatic
This PR (6423) (5.934M) : 0, 5933705
master (5.938M) : 0, 5937963
section DD_TRACE_ENABLED=0
master (8.890M) : 0, 8889686
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6423) (9.616M) : 0, 9615585
master (10.148M) : 0, 10148022
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6423) (6.294M) : 0, 6294186
master (6.340M) : 0, 6339706
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (7.100M) : 0, 7100020
section Manual
master (9.963M) : 0, 9962660
section Manual + Automatic
This PR (6423) (5.846M) : 0, 5846177
master (5.878M) : 0, 5877664
section DD_TRACE_ENABLED=0
master (9.254M) : 0, 9253958
|
Benchmarks Report for tracer 🐌Benchmarks for #6423 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Faster 🎉 Same allocations ✔️
|
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 | 1.118 | 1,249.12 | 1,117.03 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | CallElasticsearch |
net6.0 | 1.25μs | 0.603ns | 2.26ns | 0.0137 | 0 | 0 | 976 B |
master | CallElasticsearch |
netcoreapp3.1 | 1.55μs | 0.747ns | 2.89ns | 0.0133 | 0 | 0 | 976 B |
master | CallElasticsearch |
net472 | 2.62μs | 2.08ns | 8.05ns | 0.158 | 0 | 0 | 995 B |
master | CallElasticsearchAsync |
net6.0 | 1.34μs | 0.918ns | 3.56ns | 0.0134 | 0 | 0 | 952 B |
master | CallElasticsearchAsync |
netcoreapp3.1 | 1.66μs | 0.795ns | 2.97ns | 0.0133 | 0 | 0 | 1.02 KB |
master | CallElasticsearchAsync |
net472 | 2.67μs | 2.84ns | 11ns | 0.167 | 0 | 0 | 1.05 KB |
#6423 | CallElasticsearch |
net6.0 | 1.12μs | 1.32ns | 5.12ns | 0.0134 | 0 | 0 | 976 B |
#6423 | CallElasticsearch |
netcoreapp3.1 | 1.53μs | 1.59ns | 5.96ns | 0.013 | 0 | 0 | 976 B |
#6423 | CallElasticsearch |
net472 | 2.67μs | 2.13ns | 8.23ns | 0.157 | 0 | 0 | 995 B |
#6423 | CallElasticsearchAsync |
net6.0 | 1.32μs | 1.07ns | 4.02ns | 0.0133 | 0 | 0 | 952 B |
#6423 | CallElasticsearchAsync |
netcoreapp3.1 | 1.6μs | 1ns | 3.6ns | 0.0136 | 0 | 0 | 1.02 KB |
#6423 | CallElasticsearchAsync |
net472 | 2.68μs | 1.84ns | 7.12ns | 0.167 | 0 | 0 | 1.05 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | ExecuteAsync |
net6.0 | 1.33μs | 0.983ns | 3.68ns | 0.0131 | 0 | 0 | 952 B |
master | ExecuteAsync |
netcoreapp3.1 | 1.71μs | 1.27ns | 4.77ns | 0.0128 | 0 | 0 | 952 B |
master | ExecuteAsync |
net472 | 1.86μs | 0.442ns | 1.65ns | 0.145 | 0 | 0 | 915 B |
#6423 | ExecuteAsync |
net6.0 | 1.29μs | 1.34ns | 5.18ns | 0.0133 | 0 | 0 | 952 B |
#6423 | ExecuteAsync |
netcoreapp3.1 | 1.62μs | 1.47ns | 5.51ns | 0.013 | 0 | 0 | 952 B |
#6423 | ExecuteAsync |
net472 | 1.77μs | 0.455ns | 1.76ns | 0.145 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendAsync |
net6.0 | 4.5μs | 1.61ns | 6.24ns | 0.0311 | 0 | 0 | 2.31 KB |
master | SendAsync |
netcoreapp3.1 | 5.39μs | 1.81ns | 7.01ns | 0.0377 | 0 | 0 | 2.85 KB |
master | SendAsync |
net472 | 7.3μs | 1.93ns | 7.47ns | 0.494 | 0 | 0 | 3.12 KB |
#6423 | SendAsync |
net6.0 | 4.41μs | 1.36ns | 5.27ns | 0.0332 | 0 | 0 | 2.31 KB |
#6423 | SendAsync |
netcoreapp3.1 | 5.31μs | 2.72ns | 10.5ns | 0.0372 | 0 | 0 | 2.85 KB |
#6423 | SendAsync |
net472 | 7.37μs | 2.29ns | 8.87ns | 0.495 | 0 | 0 | 3.12 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 1.58μs | 0.628ns | 2.35ns | 0.023 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
netcoreapp3.1 | 2.29μs | 1.31ns | 4.9ns | 0.0214 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
net472 | 2.62μs | 1.86ns | 7.22ns | 0.25 | 0 | 0 | 1.57 KB |
#6423 | EnrichedLog |
net6.0 | 1.48μs | 2.41ns | 9.03ns | 0.0231 | 0 | 0 | 1.64 KB |
#6423 | EnrichedLog |
netcoreapp3.1 | 2.29μs | 1.64ns | 6.34ns | 0.0221 | 0 | 0 | 1.64 KB |
#6423 | EnrichedLog |
net472 | 2.64μs | 1.27ns | 4.76ns | 0.249 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 121μs | 133ns | 516ns | 0.0606 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
netcoreapp3.1 | 122μs | 180ns | 699ns | 0 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
net472 | 152μs | 148ns | 575ns | 0.678 | 0.226 | 0 | 4.46 KB |
#6423 | EnrichedLog |
net6.0 | 118μs | 178ns | 642ns | 0 | 0 | 0 | 4.28 KB |
#6423 | EnrichedLog |
netcoreapp3.1 | 125μs | 213ns | 824ns | 0 | 0 | 0 | 4.28 KB |
#6423 | EnrichedLog |
net472 | 151μs | 223ns | 862ns | 0.68 | 0.227 | 0 | 4.46 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 3.15μs | 1.21ns | 4.54ns | 0.0316 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
netcoreapp3.1 | 4.1μs | 1.02ns | 3.8ns | 0.0287 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
net472 | 4.89μs | 1.72ns | 6.19ns | 0.319 | 0 | 0 | 2.02 KB |
#6423 | EnrichedLog |
net6.0 | 3.15μs | 1.01ns | 3.91ns | 0.0316 | 0 | 0 | 2.2 KB |
#6423 | EnrichedLog |
netcoreapp3.1 | 4.19μs | 0.912ns | 3.41ns | 0.0294 | 0 | 0 | 2.2 KB |
#6423 | EnrichedLog |
net472 | 4.76μs | 1.86ns | 6.94ns | 0.32 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendReceive |
net6.0 | 1.41μs | 0.886ns | 3.43ns | 0.0162 | 0 | 0 | 1.14 KB |
master | SendReceive |
netcoreapp3.1 | 1.83μs | 1.03ns | 4ns | 0.0155 | 0 | 0 | 1.14 KB |
master | SendReceive |
net472 | 2.18μs | 1.23ns | 4.77ns | 0.183 | 0 | 0 | 1.16 KB |
#6423 | SendReceive |
net6.0 | 1.42μs | 0.632ns | 2.45ns | 0.0156 | 0 | 0 | 1.14 KB |
#6423 | SendReceive |
netcoreapp3.1 | 1.84μs | 1ns | 3.89ns | 0.0156 | 0 | 0 | 1.14 KB |
#6423 | SendReceive |
net472 | 2.1μs | 2.06ns | 7.97ns | 0.184 | 0 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.75μs | 0.832ns | 3.22ns | 0.0219 | 0 | 0 | 1.6 KB |
master | EnrichedLog |
netcoreapp3.1 | 3.93μs | 0.966ns | 3.74ns | 0.0217 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
net472 | 4.48μs | 3.96ns | 15.3ns | 0.322 | 0 | 0 | 2.04 KB |
#6423 | EnrichedLog |
net6.0 | 2.83μs | 1.14ns | 4.41ns | 0.0225 | 0 | 0 | 1.6 KB |
#6423 | EnrichedLog |
netcoreapp3.1 | 3.89μs | 1.66ns | 6.22ns | 0.0214 | 0 | 0 | 1.65 KB |
#6423 | EnrichedLog |
net472 | 4.51μs | 3.5ns | 13.6ns | 0.324 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 405ns | 0.194ns | 0.752ns | 0.00817 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 569ns | 0.745ns | 2.88ns | 0.00757 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 575ns | 0.421ns | 1.63ns | 0.0916 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 547ns | 0.43ns | 1.66ns | 0.00993 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 748ns | 1.44ns | 5.56ns | 0.00938 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 849ns | 0.654ns | 2.53ns | 0.104 | 0 | 0 | 658 B |
#6423 | StartFinishSpan |
net6.0 | 390ns | 0.185ns | 0.692ns | 0.00801 | 0 | 0 | 576 B |
#6423 | StartFinishSpan |
netcoreapp3.1 | 622ns | 0.418ns | 1.62ns | 0.00773 | 0 | 0 | 576 B |
#6423 | StartFinishSpan |
net472 | 608ns | 0.659ns | 2.55ns | 0.0917 | 0 | 0 | 578 B |
#6423 | StartFinishScope |
net6.0 | 533ns | 0.263ns | 1.02ns | 0.00987 | 0 | 0 | 696 B |
#6423 | StartFinishScope |
netcoreapp3.1 | 737ns | 0.35ns | 1.35ns | 0.00938 | 0 | 0 | 696 B |
#6423 | StartFinishScope |
net472 | 895ns | 0.694ns | 2.69ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 623ns | 0.591ns | 2.29ns | 0.00969 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 958ns | 0.671ns | 2.6ns | 0.00949 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.18μs | 0.682ns | 2.64ns | 0.104 | 0 | 0 | 658 B |
#6423 | RunOnMethodBegin |
net6.0 | 627ns | 0.46ns | 1.78ns | 0.00972 | 0 | 0 | 696 B |
#6423 | RunOnMethodBegin |
netcoreapp3.1 | 1.02μs | 0.745ns | 2.89ns | 0.00924 | 0 | 0 | 696 B |
#6423 | RunOnMethodBegin |
net472 | 1.12μs | 0.884ns | 3.31ns | 0.104 | 0 | 0 | 658 B |
## Summary of changes Adds support for latest major of GraphQL.NET ## Reason for change We want to support the latest versions (we're quite behind on this one) ## Implementation details Bumped the version numbers as required ## Test coverage Updated testing to test 8.x ## Other details Fixes: https://datadoghq.atlassian.net/browse/AIDM-506
Summary of changes
Adds support for latest major of GraphQL.NET
Reason for change
We want to support the latest versions (we're quite behind on this one)
Implementation details
Bumped the version numbers as required
Test coverage
Updated testing to test 8.x
Other details
Fixes: https://datadoghq.atlassian.net/browse/AIDM-506