Fix name of target creating trimming file + desc #6422

vandonr · 2024-12-10T17:37:20Z

Summary of changes

Rename the Nuke target to more closely match the file name

Reason for change

It's not clear that the trimming.xml file is created by the "RootDescriptors" task

Implementation details

Rename the target

andrewlock · 2024-12-10T18:10:50Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6422) - mean (69ms)  : 65, 72
     .   : milestone, 69,
    master - mean (68ms)  : 65, 72
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6422) - mean (979ms)  : 956, 1002
     .   : milestone, 979,
    master - mean (978ms)  : 960, 996
     .   : milestone, 978,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6422) - mean (108ms)  : 105, 110
     .   : milestone, 108,
    master - mean (107ms)  : 104, 109
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6422) - mean (677ms)  : 662, 692
     .   : milestone, 677,
    master - mean (679ms)  : 663, 696
     .   : milestone, 679,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6422) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 92
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6422) - mean (632ms)  : 617, 648
     .   : milestone, 632,
    master - mean (635ms)  : 621, 650
     .   : milestone, 635,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6422) - mean (193ms)  : 190, 197
     .   : milestone, 193,
    master - mean (192ms)  : 189, 196
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (6422) - mean (1,101ms)  : 1069, 1134
     .   : milestone, 1101,
    master - mean (1,101ms)  : 1069, 1132
     .   : milestone, 1101,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6422) - mean (277ms)  : 271, 283
     .   : milestone, 277,
    master - mean (277ms)  : 272, 282
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6422) - mean (870ms)  : 841, 899
     .   : milestone, 870,
    master - mean (872ms)  : 832, 913
     .   : milestone, 872,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6422) - mean (266ms)  : 260, 271
     .   : milestone, 266,
    master - mean (266ms)  : 261, 271
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6422) - mean (845ms)  : 813, 876
     .   : milestone, 845,
    master - mean (852ms)  : 816, 887
     .   : milestone, 852,

datadog-ddstaging · 2024-12-10T18:34:16Z

Datadog Report

Branch report: vandonr/nit
Commit report: 0702344
Test service: dd-trace-dotnet

✅ 0 Failed, 462870 Passed, 2866 Skipped, 19h 0m 21.14s Total Time

andrewlock · 2024-12-10T21:38:54Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6422) (11.199M)   : 0, 11199039
    master (11.276M)   : 0, 11275734
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6422) (7.294M)   : 0, 7293627
    master (7.220M)   : 0, 7219810
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.670M)   : 0, 7670008

    section Manual
    master (11.225M)   : 0, 11225338

    section Manual + Automatic
    This PR (6422) (6.714M)   : 0, 6714247
    master (6.626M)   : 0, 6626303

    section DD_TRACE_ENABLED=0
    master (10.262M)   : 0, 10261513

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6422) (9.635M)   : 0, 9634564
    master (9.566M)   : 0, 9565552
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6422) (6.315M)   : 0, 6314857
    master (6.392M)   : 0, 6391526

    section Trace stats
    master (6.743M)   : 0, 6742893

    section Manual
    master (9.619M)   : 0, 9619042

    section Manual + Automatic
    This PR (6422) (5.937M)   : 0, 5936705
    master (5.993M)   : 0, 5993242

    section DD_TRACE_ENABLED=0
    master (8.957M)   : 0, 8956849

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6422) (9.666M)   : 0, 9666415
    master (10.098M)   : 0, 10098032
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6422) (6.220M)   : 0, 6220400
    master (6.354M)   : 0, 6353995
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.176M)   : 0, 7176170

    section Manual
    master (9.806M)   : 0, 9805667

    section Manual + Automatic
    This PR (6422) (5.783M)   : 0, 5783048
    master (6.074M)   : 0, 6074333

    section DD_TRACE_ENABLED=0
    master (9.222M)   : 0, 9222262

andrewlock · 2024-12-11T05:45:40Z

Benchmarks Report for tracer 🐌

Benchmarks for #6422 compared to master:

2 benchmarks are slower, with geometric mean 1.162
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.89μs	44.6ns	292ns	0.0186	0.00743	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	9.91μs	51.3ns	336ns	0.0198	0.0099	0	5.8 KB
master	`StartStopWithChild`	net472	16.2μs	62.8ns	243ns	1.04	0.313	0.0964	6.21 KB
#6422	`StartStopWithChild`	net6.0	8.04μs	45ns	291ns	0.016	0.00801	0	5.61 KB
#6422	`StartStopWithChild`	netcoreapp3.1	10.3μs	57.6ns	360ns	0.0151	0.00503	0	5.8 KB
#6422	`StartStopWithChild`	net472	16.4μs	47.1ns	176ns	1.05	0.312	0.0985	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	500μs	183ns	710ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	687μs	436ns	1.69μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	848μs	636ns	2.46μs	0.422	3.3 KB
#6422	`WriteAndFlushEnrichedTraces`	net6.0	489μs	535ns	2.07μs	0	2.7 KB
#6422	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	652μs	219ns	818ns	0	2.7 KB
#6422	`WriteAndFlushEnrichedTraces`	net472	850μs	688ns	2.57μs	0.434	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	148μs	827ns	7.11μs	0.139	14.47 KB
master	`SendRequest`	netcoreapp3.1	167μs	900ns	6.1μs	0.231	17.27 KB
master	`SendRequest`	net472	0.000284ns	0.000195ns	0.000756ns	0	0 b
#6422	`SendRequest`	net6.0	138μs	726ns	3.48μs	0.142	14.47 KB
#6422	`SendRequest`	netcoreapp3.1	163μs	874ns	6.31μs	0.166	17.27 KB
#6422	`SendRequest`	net472	0.00111ns	0.000599ns	0.00224ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	545μs	1.95μs	7.31μs	0.543	0	0	41.69 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	634μs	2.6μs	9.37μs	0.312	0	0	41.81 KB
master	`WriteAndFlushEnrichedTraces`	net472	842μs	2.94μs	11μs	8.28	2.48	0.414	53.33 KB
#6422	`WriteAndFlushEnrichedTraces`	net6.0	552μs	2.69μs	11.4μs	0.53	0	0	41.58 KB
#6422	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	648μs	3.31μs	15.2μs	0.322	0	0	41.89 KB
#6422	`WriteAndFlushEnrichedTraces`	net472	823μs	3.85μs	14.9μs	8.12	2.44	0.406	53.32 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.3μs	2.14ns	8.29ns	0.0143	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.77μs	1.19ns	4.6ns	0.0133	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.06μs	1.4ns	5.23ns	0.156	0.00103	987 B
#6422	`ExecuteNonQuery`	net6.0	1.3μs	1.49ns	5.57ns	0.0142	0	1.02 KB
#6422	`ExecuteNonQuery`	netcoreapp3.1	1.75μs	2.59ns	10ns	0.0139	0	1.02 KB
#6422	`ExecuteNonQuery`	net472	2.1μs	1.85ns	7.18ns	0.156	0.00106	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6422

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0	1.181	1,103.03	1,302.39
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0	1.143	1,276.02	1,459.07

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.1μs	0.63ns	2.36ns	0.0133	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.54μs	1.04ns	4.02ns	0.0131	976 B
master	`CallElasticsearch`	net472	2.61μs	2.34ns	9.05ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.28μs	0.815ns	3.05ns	0.0134	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.68μs	0.94ns	3.52ns	0.0135	1.02 KB
master	`CallElasticsearchAsync`	net472	2.66μs	1.56ns	5.82ns	0.166	1.05 KB
#6422	`CallElasticsearch`	net6.0	1.3μs	0.548ns	2.05ns	0.0137	976 B
#6422	`CallElasticsearch`	netcoreapp3.1	1.59μs	0.507ns	1.9ns	0.0128	976 B
#6422	`CallElasticsearch`	net472	2.57μs	2.23ns	7.73ns	0.158	995 B
#6422	`CallElasticsearchAsync`	net6.0	1.46μs	0.942ns	3.52ns	0.0132	952 B
#6422	`CallElasticsearchAsync`	netcoreapp3.1	1.62μs	2.01ns	7.77ns	0.0138	1.02 KB
#6422	`CallElasticsearchAsync`	net472	2.62μs	1.84ns	6.88ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.26μs	1.08ns	4.05ns	0.0131	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.72μs	1.07ns	3.99ns	0.0128	952 B
master	`ExecuteAsync`	net472	1.85μs	0.877ns	3.4ns	0.145	915 B
#6422	`ExecuteAsync`	net6.0	1.26μs	0.42ns	1.57ns	0.0133	952 B
#6422	`ExecuteAsync`	netcoreapp3.1	1.63μs	1.89ns	7.09ns	0.0122	952 B
#6422	`ExecuteAsync`	net472	1.82μs	0.363ns	1.36ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.35μs	3.26ns	12.2ns	0.0327	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.21μs	3.56ns	13.8ns	0.0392	2.85 KB
master	`SendAsync`	net472	7.38μs	3.43ns	13.3ns	0.495	3.12 KB
#6422	`SendAsync`	net6.0	4.38μs	2.23ns	8.65ns	0.0331	2.31 KB
#6422	`SendAsync`	netcoreapp3.1	5.51μs	2.61ns	9.05ns	0.0385	2.85 KB
#6422	`SendAsync`	net472	7.4μs	1.09ns	3.92ns	0.493	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.44μs	0.98ns	3.67ns	0.0232	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.24μs	1.96ns	7.06ns	0.0222	1.64 KB
master	`EnrichedLog`	net472	2.71μs	0.824ns	3.08ns	0.249	1.57 KB
#6422	`EnrichedLog`	net6.0	1.47μs	0.598ns	2.16ns	0.0228	1.64 KB
#6422	`EnrichedLog`	netcoreapp3.1	2.1μs	0.789ns	3.05ns	0.0221	1.64 KB
#6422	`EnrichedLog`	net472	2.52μs	1.04ns	3.89ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	118μs	140ns	542ns	0.0596	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	125μs	91.5ns	354ns	0	0	4.28 KB
master	`EnrichedLog`	net472	152μs	115ns	431ns	0.682	0.227	4.46 KB
#6422	`EnrichedLog`	net6.0	120μs	157ns	606ns	0.06	0	4.28 KB
#6422	`EnrichedLog`	netcoreapp3.1	123μs	114ns	410ns	0	0	4.28 KB
#6422	`EnrichedLog`	net472	154μs	108ns	404ns	0.687	0.229	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.06μs	1.07ns	4.13ns	0.0307	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.38μs	1.64ns	6.33ns	0.0282	2.2 KB
master	`EnrichedLog`	net472	5μs	1.45ns	5.6ns	0.319	2.02 KB
#6422	`EnrichedLog`	net6.0	3.05μs	1.33ns	4.99ns	0.0307	2.2 KB
#6422	`EnrichedLog`	netcoreapp3.1	4.23μs	1.61ns	6.24ns	0.0297	2.2 KB
#6422	`EnrichedLog`	net472	4.96μs	1.79ns	6.92ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.42μs	6.19ns	22.3ns	0.0162	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.7μs	1.69ns	6.54ns	0.0152	1.14 KB
master	`SendReceive`	net472	2.18μs	1.13ns	3.92ns	0.183	1.16 KB
#6422	`SendReceive`	net6.0	1.37μs	0.46ns	1.78ns	0.0161	1.14 KB
#6422	`SendReceive`	netcoreapp3.1	1.73μs	0.861ns	3.34ns	0.0156	1.14 KB
#6422	`SendReceive`	net472	2μs	1.64ns	6.35ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.7μs	0.994ns	3.85ns	0.0217	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.86μs	1.6ns	5.98ns	0.0212	1.65 KB
master	`EnrichedLog`	net472	4.64μs	3.6ns	13.5ns	0.322	2.04 KB
#6422	`EnrichedLog`	net6.0	2.68μs	1.78ns	6.89ns	0.0214	1.6 KB
#6422	`EnrichedLog`	netcoreapp3.1	3.83μs	1.7ns	6.59ns	0.0212	1.65 KB
#6422	`EnrichedLog`	net472	4.43μs	4.07ns	15.8ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	409ns	0.221ns	0.856ns	0.00814	576 B
master	`StartFinishSpan`	netcoreapp3.1	624ns	0.266ns	0.996ns	0.00764	576 B
master	`StartFinishSpan`	net472	701ns	0.332ns	1.29ns	0.0917	578 B
master	`StartFinishScope`	net6.0	502ns	0.232ns	0.87ns	0.00974	696 B
master	`StartFinishScope`	netcoreapp3.1	698ns	0.722ns	2.8ns	0.00946	696 B
master	`StartFinishScope`	net472	883ns	0.604ns	2.34ns	0.104	658 B
#6422	`StartFinishSpan`	net6.0	403ns	0.382ns	1.48ns	0.00816	576 B
#6422	`StartFinishSpan`	netcoreapp3.1	592ns	0.339ns	1.22ns	0.00766	576 B
#6422	`StartFinishSpan`	net472	724ns	0.419ns	1.62ns	0.0915	578 B
#6422	`StartFinishScope`	net6.0	501ns	0.436ns	1.69ns	0.0097	696 B
#6422	`StartFinishScope`	netcoreapp3.1	720ns	0.857ns	3.32ns	0.00953	696 B
#6422	`StartFinishScope`	net472	895ns	0.456ns	1.76ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	610ns	0.431ns	1.67ns	0.00983	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	945ns	0.797ns	3.09ns	0.00904	696 B
master	`RunOnMethodBegin`	net472	1.15μs	0.422ns	1.58ns	0.105	658 B
#6422	`RunOnMethodBegin`	net6.0	637ns	0.561ns	2.17ns	0.00959	696 B
#6422	`RunOnMethodBegin`	netcoreapp3.1	1.01μs	0.644ns	2.49ns	0.00923	696 B
#6422	`RunOnMethodBegin`	net472	1.15μs	0.644ns	2.49ns	0.104	658 B

andrewlock

This target is referenced in other places too, e.g. ultimate-pipeline and github actions, so you'll need to rename it there too

andrewlock

Thanks!

## Summary of changes Rename the Nuke target to more closely match the file name ## Reason for change It's not clear that the trimming.xml file is created by the "RootDescriptors" task ## Implementation details Rename the target

Fix name of target creating trimming file + desc

f09272a

vandonr requested a review from a team as a code owner December 10, 2024 17:37

vandonr requested a review from tonyredondo December 10, 2024 17:37

github-actions bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Dec 10, 2024

andrewlock reviewed Dec 11, 2024

View reviewed changes

update azure and github things

0702344

andrewlock approved these changes Dec 11, 2024

View reviewed changes

pierotibou approved these changes Dec 11, 2024

View reviewed changes

vandonr merged commit 31d6d2a into master Dec 11, 2024
102 of 104 checks passed

vandonr deleted the vandonr/nit branch December 11, 2024 13:02

github-actions bot added this to the vNext-v3 milestone Dec 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix name of target creating trimming file + desc #6422

Fix name of target creating trimming file + desc #6422

vandonr commented Dec 10, 2024 •

edited by andrewlock

Loading

andrewlock commented Dec 10, 2024 •

edited

Loading

datadog-ddstaging bot commented Dec 10, 2024 •

edited

Loading

andrewlock commented Dec 10, 2024 •

edited

Loading

andrewlock commented Dec 11, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6422

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

andrewlock left a comment

andrewlock left a comment

Fix name of target creating trimming file + desc #6422

Fix name of target creating trimming file + desc #6422

Conversation

vandonr commented Dec 10, 2024 • edited by andrewlock Loading

Summary of changes

Reason for change

Implementation details

andrewlock commented Dec 10, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

datadog-ddstaging bot commented Dec 10, 2024 • edited Loading

Datadog Report

andrewlock commented Dec 10, 2024 • edited Loading

Throughput/Crank Report ⚡

andrewlock commented Dec 11, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6422

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

andrewlock left a comment

Choose a reason for hiding this comment

andrewlock left a comment

Choose a reason for hiding this comment

vandonr commented Dec 10, 2024 •

edited by andrewlock

Loading

andrewlock commented Dec 10, 2024 •

edited

Loading

datadog-ddstaging bot commented Dec 10, 2024 •

edited

Loading

andrewlock commented Dec 10, 2024 •

edited

Loading

andrewlock commented Dec 11, 2024 •

edited

Loading