Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Package Versions Bump] Updating package versions #6420

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Updates the package versions for integration tests.

@github-actions github-actions bot requested review from a team as code owners December 10, 2024 17:04
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Dec 10, 2024

Datadog Report

Branch report: bot/test-package-versions-bump
Commit report: effb27f
Test service: dd-trace-dotnet

✅ 0 Failed, 452546 Passed, 2820 Skipped, 19h 24m 53.06s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • HttpClient_SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.HttpMessageHandlerTests - Last Failure

    Expand for error
     
      to contain key "CurlHandler".dler"adog.Trace.Telemetry.IntegrationTelemetryDatae.Telemetry.IntegrationTelemetryData
    

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6420) - mean (69ms)  : 66, 72
     .   : milestone, 69,
    master - mean (69ms)  : 66, 73
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6420) - mean (985ms)  : 957, 1012
     .   : milestone, 985,
    master - mean (978ms)  : 956, 1000
     .   : milestone, 978,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6420) - mean (108ms)  : 106, 111
     .   : milestone, 108,
    master - mean (108ms)  : 106, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6420) - mean (679ms)  : 663, 695
     .   : milestone, 679,
    master - mean (681ms)  : 666, 696
     .   : milestone, 681,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6420) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6420) - mean (638ms)  : 622, 654
     .   : milestone, 638,
    master - mean (635ms)  : 619, 651
     .   : milestone, 635,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6420) - mean (192ms)  : 184, 200
     .   : milestone, 192,
    master - mean (192ms)  : 187, 197
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (6420) - mean (1,102ms)  : 1071, 1133
     .   : milestone, 1102,
    master - mean (1,100ms)  : 1070, 1131
     .   : milestone, 1100,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6420) - mean (278ms)  : 274, 282
     .   : milestone, 278,
    master - mean (279ms)  : 275, 284
     .   : milestone, 279,

    section CallTarget+Inlining+NGEN
    This PR (6420) - mean (875ms)  : 845, 906
     .   : milestone, 875,
    master - mean (879ms)  : 857, 901
     .   : milestone, 879,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6420) - mean (267ms)  : 263, 271
     .   : milestone, 267,
    master - mean (269ms)  : 264, 274
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (6420) - mean (858ms)  : 832, 884
     .   : milestone, 858,
    master - mean (858ms)  : 828, 889
     .   : milestone, 858,

Loading

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6420 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.125
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.21μs 44.8ns 269ns 0.0156 0.00779 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10μs 53.8ns 304ns 0.015 0.00499 0 5.8 KB
master StartStopWithChild net472 16.3μs 35.8ns 139ns 1.03 0.3 0.0974 6.22 KB
#6420 StartStopWithChild net6.0 7.94μs 42.8ns 242ns 0.0167 0.00834 0 5.6 KB
#6420 StartStopWithChild netcoreapp3.1 10.2μs 56.2ns 328ns 0.0202 0.0101 0 5.8 KB
#6420 StartStopWithChild net472 16.1μs 39.1ns 151ns 1.03 0.298 0.0993 6.22 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 494μs 370ns 1.38μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 654μs 285ns 1.1μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 843μs 355ns 1.28μs 0.422 0 0 3.3 KB
#6420 WriteAndFlushEnrichedTraces net6.0 499μs 262ns 944ns 0 0 0 2.7 KB
#6420 WriteAndFlushEnrichedTraces netcoreapp3.1 668μs 395ns 1.48μs 0 0 0 2.7 KB
#6420 WriteAndFlushEnrichedTraces net472 852μs 575ns 2.23μs 0.428 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 147μs 794ns 4.49μs 0.152 0 0 14.47 KB
master SendRequest netcoreapp3.1 159μs 848ns 5.3μs 0.157 0 0 17.27 KB
master SendRequest net472 0.000771ns 0.000473ns 0.00171ns 0 0 0 0 b
#6420 SendRequest net6.0 147μs 814ns 5.69μs 0.147 0 0 14.47 KB
#6420 SendRequest netcoreapp3.1 164μs 928ns 6.08μs 0.168 0 0 17.27 KB
#6420 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 566μs 2.67μs 9.99μs 0.556 0 0 41.72 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 666μs 3.33μs 15.6μs 0.322 0 0 41.91 KB
master WriteAndFlushEnrichedTraces net472 864μs 2.96μs 11.1μs 8.45 2.53 0.422 53.29 KB
#6420 WriteAndFlushEnrichedTraces net6.0 539μs 2.18μs 8.15μs 0.548 0 0 41.63 KB
#6420 WriteAndFlushEnrichedTraces netcoreapp3.1 651μs 2.07μs 7.74μs 0.331 0 0 41.81 KB
#6420 WriteAndFlushEnrichedTraces net472 833μs 2.77μs 10.7μs 8.33 2.5 0.417 53.26 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.41μs 1.48ns 5.75ns 0.0141 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.83μs 1.44ns 5.58ns 0.0136 0 0 1.02 KB
master ExecuteNonQuery net472 2.11μs 1.23ns 4.74ns 0.157 0.00106 0 987 B
#6420 ExecuteNonQuery net6.0 1.29μs 1.52ns 5.9ns 0.0143 0 0 1.02 KB
#6420 ExecuteNonQuery netcoreapp3.1 1.81μs 3.23ns 12.5ns 0.0134 0 0 1.02 KB
#6420 ExecuteNonQuery net472 2.08μs 1.18ns 4.57ns 0.157 0.00104 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.3μs 1.29ns 5.01ns 0.0138 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.63μs 1.16ns 4.51ns 0.0132 0 0 976 B
master CallElasticsearch net472 2.46μs 2.19ns 8.2ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.37μs 0.742ns 2.78ns 0.0129 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.64μs 0.853ns 3.3ns 0.0141 0 0 1.02 KB
master CallElasticsearchAsync net472 2.74μs 1.86ns 7.2ns 0.166 0 0 1.05 KB
#6420 CallElasticsearch net6.0 1.23μs 0.577ns 2.16ns 0.0135 0 0 976 B
#6420 CallElasticsearch netcoreapp3.1 1.61μs 3.01ns 11.3ns 0.0129 0 0 976 B
#6420 CallElasticsearch net472 2.57μs 1.14ns 4.25ns 0.157 0 0 995 B
#6420 CallElasticsearchAsync net6.0 1.31μs 1.02ns 3.97ns 0.013 0 0 952 B
#6420 CallElasticsearchAsync netcoreapp3.1 1.64μs 0.936ns 3.63ns 0.0132 0 0 1.02 KB
#6420 CallElasticsearchAsync net472 2.56μs 0.651ns 2.44ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.37μs 1.07ns 4.02ns 0.0138 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.66μs 1.1ns 4.1ns 0.0132 0 0 952 B
master ExecuteAsync net472 1.78μs 0.578ns 2.16ns 0.145 0 0 915 B
#6420 ExecuteAsync net6.0 1.35μs 0.545ns 2.04ns 0.0136 0 0 952 B
#6420 ExecuteAsync netcoreapp3.1 1.62μs 1.39ns 5.38ns 0.013 0 0 952 B
#6420 ExecuteAsync net472 1.81μs 1.21ns 4.54ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.39μs 1.85ns 7.18ns 0.0329 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.42μs 2.55ns 9.53ns 0.0378 0 0 2.85 KB
master SendAsync net472 7.39μs 1.71ns 6.4ns 0.493 0 0 3.12 KB
#6420 SendAsync net6.0 4.49μs 1.38ns 5.36ns 0.0315 0 0 2.31 KB
#6420 SendAsync netcoreapp3.1 5.33μs 1.94ns 7.53ns 0.0374 0 0 2.85 KB
#6420 SendAsync net472 7.38μs 1.58ns 5.92ns 0.494 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.47μs 0.71ns 2.66ns 0.0235 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.36μs 1.4ns 5.24ns 0.0213 0 0 1.64 KB
master EnrichedLog net472 2.57μs 1.07ns 4.15ns 0.249 0 0 1.57 KB
#6420 EnrichedLog net6.0 1.52μs 0.968ns 3.75ns 0.023 0 0 1.64 KB
#6420 EnrichedLog netcoreapp3.1 2.24μs 1.18ns 4.42ns 0.0223 0 0 1.64 KB
#6420 EnrichedLog net472 2.72μs 1.4ns 5.05ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 120μs 119ns 461ns 0 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 126μs 105ns 394ns 0 0 0 4.28 KB
master EnrichedLog net472 151μs 179ns 694ns 0.676 0.225 0 4.46 KB
#6420 EnrichedLog net6.0 120μs 188ns 729ns 0.0607 0 0 4.28 KB
#6420 EnrichedLog netcoreapp3.1 125μs 110ns 410ns 0 0 0 4.28 KB
#6420 EnrichedLog net472 152μs 102ns 396ns 0.677 0.226 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.02μs 1.21ns 4.18ns 0.0318 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.15μs 1.82ns 7.04ns 0.0296 0 0 2.2 KB
master EnrichedLog net472 5.04μs 1.36ns 5.29ns 0.319 0 0 2.02 KB
#6420 EnrichedLog net6.0 3.05μs 1ns 3.89ns 0.0301 0 0 2.2 KB
#6420 EnrichedLog netcoreapp3.1 4.31μs 1.77ns 6.87ns 0.0304 0 0 2.2 KB
#6420 EnrichedLog net472 5.06μs 1.52ns 5.87ns 0.321 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.34μs 0.789ns 2.85ns 0.0154 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.77μs 0.496ns 1.92ns 0.0151 0 0 1.14 KB
master SendReceive net472 2.08μs 0.886ns 3.32ns 0.184 0 0 1.16 KB
#6420 SendReceive net6.0 1.34μs 0.643ns 2.49ns 0.0161 0 0 1.14 KB
#6420 SendReceive netcoreapp3.1 1.8μs 1.07ns 4.15ns 0.0153 0 0 1.14 KB
#6420 SendReceive net472 2.03μs 2.18ns 8.46ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.81μs 1.23ns 4.77ns 0.0224 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.78μs 1.56ns 6.05ns 0.0209 0 0 1.65 KB
master EnrichedLog net472 4.43μs 1.93ns 7.21ns 0.322 0 0 2.04 KB
#6420 EnrichedLog net6.0 2.75μs 1.34ns 4.63ns 0.022 0 0 1.6 KB
#6420 EnrichedLog netcoreapp3.1 3.84μs 1.57ns 6.1ns 0.0212 0 0 1.65 KB
#6420 EnrichedLog net472 4.41μs 1.11ns 4.14ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6420

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.125 784.40 697.29

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 394ns 0.255ns 0.987ns 0.00812 0 0 576 B
master StartFinishSpan netcoreapp3.1 564ns 0.426ns 1.65ns 0.00761 0 0 576 B
master StartFinishSpan net472 643ns 0.407ns 1.58ns 0.0917 0 0 578 B
master StartFinishScope net6.0 496ns 0.208ns 0.805ns 0.00968 0 0 696 B
master StartFinishScope netcoreapp3.1 784ns 0.347ns 1.25ns 0.00942 0 0 696 B
master StartFinishScope net472 868ns 0.668ns 2.59ns 0.104 0 0 658 B
#6420 StartFinishSpan net6.0 410ns 0.28ns 1.01ns 0.00803 0 0 576 B
#6420 StartFinishSpan netcoreapp3.1 587ns 0.314ns 1.22ns 0.00795 0 0 576 B
#6420 StartFinishSpan net472 655ns 0.403ns 1.56ns 0.0916 0 0 578 B
#6420 StartFinishScope net6.0 477ns 0.268ns 1ns 0.00983 0 0 696 B
#6420 StartFinishScope netcoreapp3.1 698ns 0.514ns 1.85ns 0.00941 0 0 696 B
#6420 StartFinishScope net472 904ns 0.708ns 2.65ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 653ns 0.518ns 2ns 0.00989 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 894ns 0.626ns 2.42ns 0.0094 0 0 696 B
master RunOnMethodBegin net472 1.17μs 0.922ns 3.57ns 0.104 0 0 658 B
#6420 RunOnMethodBegin net6.0 682ns 0.418ns 1.56ns 0.00957 0 0 696 B
#6420 RunOnMethodBegin netcoreapp3.1 980ns 0.781ns 3.03ns 0.00935 0 0 696 B
#6420 RunOnMethodBegin net472 1.13μs 0.801ns 3.1ns 0.104 0 0 658 B

@andrewlock
Copy link
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6420) (11.071M)   : 0, 11070608
    master (11.088M)   : 0, 11088184
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6420) (7.268M)   : 0, 7268165
    master (7.254M)   : 0, 7254128
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.516M)   : 0, 7515745

    section Manual
    master (11.014M)   : 0, 11013989

    section Manual + Automatic
    This PR (6420) (6.811M)   : 0, 6811343
    master (6.700M)   : 0, 6700166

    section DD_TRACE_ENABLED=0
    master (10.228M)   : 0, 10228208

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6420) (9.569M)   : 0, 9568943
    master (9.438M)   : 0, 9438272
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6420) (6.466M)   : 0, 6465861
    master (6.384M)   : 0, 6384110

    section Trace stats
    master (6.758M)   : 0, 6758045

    section Manual
    master (9.394M)   : 0, 9393606

    section Manual + Automatic
    This PR (6420) (5.905M)   : 0, 5905476
    master (6.041M)   : 0, 6040522

    section DD_TRACE_ENABLED=0
    master (8.691M)   : 0, 8690632

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6420) (10.359M)   : 0, 10358840
    master (9.438M)   : 0, 9438032
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6420) (6.556M)   : 0, 6555767
    master (6.073M)   : 0, 6073208
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.747M)   : 0, 6747095

    section Manual
    master (9.357M)   : 0, 9356938

    section Manual + Automatic
    This PR (6420) (6.190M)   : 0, 6190290
    master (5.605M)   : 0, 5604930

    section DD_TRACE_ENABLED=0
    master (8.787M)   : 0, 8787187

Loading

@andrewlock andrewlock merged commit 699da71 into master Dec 11, 2024
94 checks passed
@andrewlock andrewlock deleted the bot/test-package-versions-bump branch December 11, 2024 10:20
@github-actions github-actions bot added this to the vNext-v3 milestone Dec 11, 2024
veerbia pushed a commit that referenced this pull request Dec 16, 2024
Updates the package versions for integration tests.

Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
@andrewlock andrewlock added dependencies Pull requests that update a dependency file area:dependabot dependabot updates area:integrations labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dependabot dependabot updates area:integrations dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant