[CI Visibility] Adding nullability checks #6374

tonyredondo · 2024-11-28T23:24:12Z

Summary of changes

This PR adds the nullability check to all CI Visibility classes.

datadog-ddstaging · 2024-11-28T23:53:53Z

Datadog Report

Branch report: tony/fix-civisibility-nullables
Commit report: e3c42df
Test service: dd-trace-dotnet

✅ 0 Failed, 445742 Passed, 2716 Skipped, 20h 24m 20.18s Total Time
❄️ 2 New Flaky

New Flaky Tests (2)

HttpClient_SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.HttpMessageHandlerTests - Last Failure

Expand for error

 
  to contain key "CurlHandler".dler"adog.Trace.Telemetry.IntegrationTelemetryDatae.Telemetry.IntegrationTelemetryData

TestSessionTimeoutVulnerability - Datadog.Trace.Security.IntegrationTests.Iast.AspNetCore5IastTestsRestartedSampleIastEnabled - Last Failure

Expand for error

 Results do not match.
 Differences:
 Received: Iast.SessionIdleTimeout.AspNetCore5.IastEnabled.received.txt
 Verified: Iast.SessionIdleTimeout.AspNetCore5.IastEnabled.verified.txt
 Received Content:
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: session_timeout,
 ...

andrewlock · 2024-11-29T00:21:40Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6374) - mean (69ms)  : 66, 71
     .   : milestone, 69,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6374) - mean (985ms)  : 962, 1009
     .   : milestone, 985,
    master - mean (977ms)  : 957, 996
     .   : milestone, 977,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6374) - mean (109ms)  : 107, 111
     .   : milestone, 109,
    master - mean (108ms)  : 106, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6374) - mean (684ms)  : 669, 699
     .   : milestone, 684,
    master - mean (677ms)  : 661, 692
     .   : milestone, 677,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6374) - mean (92ms)  : 90, 93
     .   : milestone, 92,
    master - mean (91ms)  : 89, 94
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6374) - mean (634ms)  : 618, 651
     .   : milestone, 634,
    master - mean (634ms)  : 616, 652
     .   : milestone, 634,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6374) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (190ms)  : 186, 195
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6374) - mean (1,100ms)  : 1066, 1133
     .   : milestone, 1100,
    master - mean (1,090ms)  : 1059, 1121
     .   : milestone, 1090,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6374) - mean (276ms)  : 272, 280
     .   : milestone, 276,
    master - mean (277ms)  : 273, 281
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6374) - mean (872ms)  : 843, 901
     .   : milestone, 872,
    master - mean (870ms)  : 839, 901
     .   : milestone, 870,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6374) - mean (266ms)  : 261, 271
     .   : milestone, 266,
    master - mean (266ms)  : 260, 271
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6374) - mean (855ms)  : 826, 885
     .   : milestone, 855,
    master - mean (849ms)  : 812, 887
     .   : milestone, 849,

andrewlock · 2024-11-29T01:45:32Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6374) (11.168M)   : 0, 11167859
    master (11.163M)   : 0, 11163279
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6374) (7.243M)   : 0, 7243432
    master (7.379M)   : 0, 7378518
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.698M)   : 0, 7697685

    section Manual
    master (11.208M)   : 0, 11207970

    section Manual + Automatic
    This PR (6374) (6.726M)   : 0, 6726276
    master (6.848M)   : 0, 6847878

    section DD_TRACE_ENABLED=0
    master (10.300M)   : 0, 10300258

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6374) (9.560M)   : 0, 9559821
    master (9.614M)   : 0, 9613662
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6374) (6.252M)   : 0, 6251602
    master (6.420M)   : 0, 6420484

    section Trace stats
    master (6.620M)   : 0, 6620303

    section Manual
    master (9.598M)   : 0, 9598372

    section Manual + Automatic
    This PR (6374) (5.842M)   : 0, 5841724
    master (5.968M)   : 0, 5968390

    section DD_TRACE_ENABLED=0
    master (8.911M)   : 0, 8911128

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6374) (9.820M)   : 0, 9819671
    master (9.949M)   : 0, 9949075
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6374) (6.419M)   : 0, 6418501
    master (6.538M)   : 0, 6537814
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.075M)   : 0, 7075474

    section Manual
    master (9.758M)   : 0, 9757921

    section Manual + Automatic
    This PR (6374) (6.095M)   : 0, 6094811
    master (6.151M)   : 0, 6151047

    section DD_TRACE_ENABLED=0
    master (9.404M)   : 0, 9403695

andrewlock · 2024-11-29T04:42:55Z

Benchmarks Report for tracer 🐌

Benchmarks for #6374 compared to master:

1 benchmarks are faster, with geometric mean 1.162
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.76μs	43.4ns	294ns	0.0165	0.00826	0	5.62 KB
master	`StartStopWithChild`	netcoreapp3.1	10μs	55.2ns	336ns	0.0188	0.0094	0	5.8 KB
master	`StartStopWithChild`	net472	16.1μs	39.6ns	153ns	1.05	0.32	0.0959	6.21 KB
#6374	`StartStopWithChild`	net6.0	7.9μs	44.9ns	330ns	0.0187	0.00747	0	5.61 KB
#6374	`StartStopWithChild`	netcoreapp3.1	10.1μs	56.8ns	364ns	0.0304	0.0152	0	5.8 KB
#6374	`StartStopWithChild`	net472	16.1μs	46.1ns	179ns	1.05	0.308	0.103	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	500μs	1.58μs	6.11μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	637μs	199ns	771ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	841μs	636ns	2.46μs	0.419	3.3 KB
#6374	`WriteAndFlushEnrichedTraces`	net6.0	508μs	506ns	1.96μs	0	2.7 KB
#6374	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	662μs	321ns	1.2μs	0	2.7 KB
#6374	`WriteAndFlushEnrichedTraces`	net472	840μs	373ns	1.39μs	0.417	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	147μs	861ns	7.7μs	0.156	14.47 KB
master	`SendRequest`	netcoreapp3.1	163μs	923ns	6.26μs	0.163	17.27 KB
master	`SendRequest`	net472	0.000374ns	0.00021ns	0.000759ns	0	0 b
#6374	`SendRequest`	net6.0	151μs	962ns	9.53μs	0.135	14.47 KB
#6374	`SendRequest`	netcoreapp3.1	167μs	963ns	7.82μs	0.163	17.27 KB
#6374	`SendRequest`	net472	0.002ns	0.000763ns	0.00296ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6374

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.7 KB	41.96 KB	256 B	0.61%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	560μs	2.91μs	15.1μs	0.579	0	0	41.67 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	679μs	2.14μs	8.29μs	0.338	0	0	41.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	882μs	4.02μs	15.6μs	8.25	2.6	0.434	53.32 KB
#6374	`WriteAndFlushEnrichedTraces`	net6.0	560μs	2.69μs	11.7μs	0.534	0	0	41.74 KB
#6374	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	677μs	3.49μs	16μs	0.324	0	0	41.96 KB
#6374	`WriteAndFlushEnrichedTraces`	net472	857μs	4.36μs	20μs	8.08	2.55	0.425	53.28 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.29μs	0.622ns	2.41ns	0.0141	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.78μs	1.85ns	7.16ns	0.0142	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.11μs	1.75ns	6.54ns	0.156	0.00105	987 B
#6374	`ExecuteNonQuery`	net6.0	1.26μs	1.26ns	4.89ns	0.0142	0	1.02 KB
#6374	`ExecuteNonQuery`	netcoreapp3.1	1.75μs	0.897ns	3.47ns	0.0141	0	1.02 KB
#6374	`ExecuteNonQuery`	net472	2.02μs	1.2ns	4.47ns	0.156	0.00102	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.1μs	0.635ns	2.38ns	0.0137	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.62μs	0.584ns	2.02ns	0.013	976 B
master	`CallElasticsearch`	net472	2.62μs	1.98ns	7.66ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.21μs	0.559ns	2.16ns	0.0133	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.64μs	1.27ns	4.56ns	0.0139	1.02 KB
master	`CallElasticsearchAsync`	net472	2.59μs	0.914ns	3.3ns	0.167	1.05 KB
#6374	`CallElasticsearch`	net6.0	1.16μs	0.755ns	2.62ns	0.013	976 B
#6374	`CallElasticsearch`	netcoreapp3.1	1.52μs	0.969ns	3.63ns	0.013	976 B
#6374	`CallElasticsearch`	net472	2.59μs	1.72ns	6.43ns	0.158	995 B
#6374	`CallElasticsearchAsync`	net6.0	1.27μs	0.487ns	1.82ns	0.0134	952 B
#6374	`CallElasticsearchAsync`	netcoreapp3.1	1.62μs	0.97ns	3.63ns	0.0137	1.02 KB
#6374	`CallElasticsearchAsync`	net472	2.67μs	1.12ns	4.35ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.31μs	1.13ns	4.36ns	0.0137	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.65μs	0.829ns	2.99ns	0.0123	952 B
master	`ExecuteAsync`	net472	1.8μs	0.627ns	2.43ns	0.145	915 B
#6374	`ExecuteAsync`	net6.0	1.23μs	0.504ns	1.88ns	0.0135	952 B
#6374	`ExecuteAsync`	netcoreapp3.1	1.71μs	0.675ns	2.53ns	0.0129	952 B
#6374	`ExecuteAsync`	net472	1.89μs	1.53ns	5.74ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.52μs	10.4ns	40.1ns	0.0314	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.34μs	1.79ns	6.46ns	0.0373	2.85 KB
master	`SendAsync`	net472	7.35μs	2.71ns	10.5ns	0.494	3.12 KB
#6374	`SendAsync`	net6.0	4.32μs	2.77ns	10.7ns	0.0325	2.31 KB
#6374	`SendAsync`	netcoreapp3.1	5.48μs	1.86ns	6.97ns	0.0384	2.85 KB
#6374	`SendAsync`	net472	7.29μs	1.08ns	4.17ns	0.496	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.51μs	3.83ns	14.8ns	0.0227	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.25μs	0.994ns	3.72ns	0.0226	1.64 KB
master	`EnrichedLog`	net472	2.61μs	0.894ns	3.35ns	0.249	1.57 KB
#6374	`EnrichedLog`	net6.0	1.56μs	0.273ns	0.944ns	0.0226	1.64 KB
#6374	`EnrichedLog`	netcoreapp3.1	2.12μs	0.931ns	3.36ns	0.0222	1.64 KB
#6374	`EnrichedLog`	net472	2.66μs	3.15ns	11.8ns	0.25	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	118μs	209ns	811ns	0.0595	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	125μs	154ns	598ns	0	0	4.28 KB
master	`EnrichedLog`	net472	153μs	164ns	637ns	0.689	0.23	4.46 KB
#6374	`EnrichedLog`	net6.0	121μs	185ns	715ns	0	0	4.28 KB
#6374	`EnrichedLog`	netcoreapp3.1	123μs	133ns	498ns	0	0	4.28 KB
#6374	`EnrichedLog`	net472	152μs	136ns	528ns	0.683	0.228	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.14μs	1.54ns	5.98ns	0.0309	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.26μs	1.48ns	5.75ns	0.0296	2.2 KB
master	`EnrichedLog`	net472	4.78μs	2.13ns	8.23ns	0.319	2.02 KB
#6374	`EnrichedLog`	net6.0	3.16μs	4.53ns	17.5ns	0.0316	2.2 KB
#6374	`EnrichedLog`	netcoreapp3.1	4.21μs	3.77ns	14.6ns	0.0296	2.2 KB
#6374	`EnrichedLog`	net472	4.98μs	1.68ns	6.5ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.32μs	1.64ns	6.12ns	0.0162	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.81μs	0.814ns	3.15ns	0.0154	1.14 KB
master	`SendReceive`	net472	2.06μs	1.1ns	3.96ns	0.183	1.16 KB
#6374	`SendReceive`	net6.0	1.38μs	0.583ns	2.26ns	0.0159	1.14 KB
#6374	`SendReceive`	netcoreapp3.1	1.7μs	0.48ns	1.73ns	0.0153	1.14 KB
#6374	`SendReceive`	net472	2.14μs	2.14ns	8.28ns	0.184	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.75μs	1.63ns	6.1ns	0.0221	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.98μs	1.86ns	7.22ns	0.0217	1.65 KB
master	`EnrichedLog`	net472	4.45μs	2.51ns	9.74ns	0.323	2.04 KB
#6374	`EnrichedLog`	net6.0	2.7μs	0.967ns	3.74ns	0.0216	1.6 KB
#6374	`EnrichedLog`	netcoreapp3.1	3.88μs	1.3ns	4.7ns	0.0213	1.65 KB
#6374	`EnrichedLog`	net472	4.33μs	4.19ns	16.2ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6374

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.162	643.70	554.01

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	421ns	0.693ns	2.68ns	0.00816	576 B
master	`StartFinishSpan`	netcoreapp3.1	643ns	1.54ns	5.95ns	0.00777	576 B
master	`StartFinishSpan`	net472	669ns	1.34ns	5.21ns	0.0915	578 B
master	`StartFinishScope`	net6.0	488ns	0.756ns	2.93ns	0.00976	696 B
master	`StartFinishScope`	netcoreapp3.1	737ns	0.902ns	3.37ns	0.00955	696 B
master	`StartFinishScope`	net472	819ns	1.43ns	5.55ns	0.105	658 B
#6374	`StartFinishSpan`	net6.0	391ns	0.721ns	2.79ns	0.008	576 B
#6374	`StartFinishSpan`	netcoreapp3.1	554ns	0.972ns	3.76ns	0.00793	576 B
#6374	`StartFinishSpan`	net472	709ns	1.48ns	5.75ns	0.0916	578 B
#6374	`StartFinishScope`	net6.0	480ns	0.555ns	2.08ns	0.00965	696 B
#6374	`StartFinishScope`	netcoreapp3.1	680ns	1.54ns	5.95ns	0.00926	696 B
#6374	`StartFinishScope`	net472	823ns	0.94ns	3.64ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	661ns	0.835ns	3.24ns	0.00965	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	897ns	1.03ns	3.86ns	0.00938	696 B
master	`RunOnMethodBegin`	net472	1.2μs	2.45ns	9.5ns	0.104	658 B
#6374	`RunOnMethodBegin`	net6.0	680ns	1.29ns	5ns	0.00976	696 B
#6374	`RunOnMethodBegin`	netcoreapp3.1	851ns	1.43ns	5.53ns	0.00939	696 B
#6374	`RunOnMethodBegin`	net472	1.12μs	1.55ns	6.01ns	0.104	658 B

andrewlock

Awesome, thank you! 🙂

...og.Trace/ClrProfiler/AutoInstrumentation/ManualInstrumentation/Ci/Proxies/ITestParameters.cs

tracer/src/Datadog.Trace/Ci/Agent/MessagePack/EventMessagePackFormatter.cs

tracer/src/Datadog.Trace/Ci/Agent/Payloads/EventPlatformPayload.cs

tracer/src/Datadog.Trace/Ci/CITracerManagerFactory.cs

tracer/src/Datadog.Trace/Ci/Coverage/Exceptions/PdbNotFoundException.cs

tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Testing/NUnit/IMethodInfo.cs

andrewlock · 2024-11-29T14:55:13Z

tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Testing/NUnit/ITest.cs

+    /// Gets the parent test, if any.
+    /// </summary>
+    /// <value>The parent test or null if none exists.</value>
+    ITest? Parent { get; }


Should ITestResult below be nullable?

No, MakeTestResult() always returns an instance or throws an exception.

tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Testing/NUnit/ITestCommand.cs

tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Testing/NUnit/IWorkItem.cs

tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/Testing/NUnit/NUnitIntegration.cs

## Summary of changes This PR adds the nullability check to all CI Visibility classes.

[CI Visibility] Adding nullability checks

c8c1090

github-actions bot added the area:ci-visibility label Nov 28, 2024

add more files

ac7ae72

tonyredondo added 4 commits November 29, 2024 10:32

more files

ed90ea7

Add MsTest integration

5f7eae3

Adding NUnit integration

26dc97e

fix

3bc2d51

tonyredondo marked this pull request as ready for review November 29, 2024 13:01

tonyredondo requested review from a team as code owners November 29, 2024 13:01

fix

b280769

andrewlock approved these changes Nov 29, 2024

View reviewed changes

changes from the review

3d98a45

lucaspimentel approved these changes Dec 2, 2024

View reviewed changes

tonyredondo added 3 commits December 3, 2024 00:52

Merge branch 'master' into tony/fix-civisibility-nullables

0386f0e

changes

8cd87ba

Merge branch 'master' into tony/fix-civisibility-nullables

e3c42df

tonyredondo merged commit 881ce60 into master Dec 5, 2024
80 checks passed

tonyredondo deleted the tony/fix-civisibility-nullables branch December 5, 2024 11:08

github-actions bot added this to the vNext-v3 milestone Dec 5, 2024

veerbia pushed a commit that referenced this pull request Dec 16, 2024

[CI Visibility] Adding nullability checks (#6374)

4ff9326

## Summary of changes This PR adds the nullability check to all CI Visibility classes.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CI Visibility] Adding nullability checks #6374

[CI Visibility] Adding nullability checks #6374

tonyredondo commented Nov 28, 2024 •

edited

Loading

datadog-ddstaging bot commented Nov 28, 2024 •

edited

Loading

andrewlock commented Nov 29, 2024 •

edited

Loading

andrewlock commented Nov 29, 2024 •

edited

Loading

andrewlock commented Nov 29, 2024 •

edited

Loading

Raw results

Raw results

Raw results

More allocations ⚠️ in #6374

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6374

Raw results

Raw results

andrewlock left a comment

andrewlock Nov 29, 2024

tonyredondo Nov 29, 2024

[CI Visibility] Adding nullability checks #6374

[CI Visibility] Adding nullability checks #6374

Conversation

tonyredondo commented Nov 28, 2024 • edited Loading

Summary of changes

datadog-ddstaging bot commented Nov 28, 2024 • edited Loading

Datadog Report

New Flaky Tests (2)

andrewlock commented Nov 29, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Nov 29, 2024 • edited Loading

Throughput/Crank Report ⚡

andrewlock commented Nov 29, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #6374

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6374

Raw results

Raw results

andrewlock left a comment

Choose a reason for hiding this comment

andrewlock Nov 29, 2024

Choose a reason for hiding this comment

tonyredondo Nov 29, 2024

Choose a reason for hiding this comment

tonyredondo commented Nov 28, 2024 •

edited

Loading

datadog-ddstaging bot commented Nov 28, 2024 •

edited

Loading

andrewlock commented Nov 29, 2024 •

edited

Loading

andrewlock commented Nov 29, 2024 •

edited

Loading

andrewlock commented Nov 29, 2024 •

edited

Loading