Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Profiler] Avoid ETW tests flackiness #6368

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Conversation

chrisnas
Copy link
Contributor

Summary of changes

Pick a less CPU intensive scenario and increase test timeout

Reason for change

The previous version of the tests showed that the agent proxy was not able to asynchronously send the recorded events before the test ends.

Implementation details

Increase the timeout so the profiled application lives long enough to receive the recorded events

Test coverage

yes

Other details

@chrisnas chrisnas requested a review from a team as a code owner November 28, 2024 12:20
@github-actions github-actions bot added the area:profiler Issues related to the continous-profiler label Nov 28, 2024
Copy link
Collaborator

@gleocadie gleocadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Nov 28, 2024

Datadog Report

Branch report: chrisnas/flacky_etw_tests
Commit report: 55f4cfd
Test service: dd-trace-dotnet

✅ 0 Failed, 451383 Passed, 3185 Skipped, 20h 57m 15.07s Total Time

@andrewlock
Copy link
Member

andrewlock commented Nov 28, 2024

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6368) - mean (69ms)  : 66, 72
     .   : milestone, 69,
    master - mean (69ms)  : 66, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6368) - mean (979ms)  : 961, 998
     .   : milestone, 979,
    master - mean (976ms)  : 944, 1008
     .   : milestone, 976,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6368) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (108ms)  : 105, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6368) - mean (679ms)  : 664, 695
     .   : milestone, 679,
    master - mean (672ms)  : 657, 687
     .   : milestone, 672,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6368) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 90, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6368) - mean (634ms)  : 621, 646
     .   : milestone, 634,
    master - mean (626ms)  : 610, 641
     .   : milestone, 626,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6368) - mean (191ms)  : 186, 196
     .   : milestone, 191,
    master - mean (191ms)  : 187, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6368) - mean (1,096ms)  : 1067, 1125
     .   : milestone, 1096,
    master - mean (1,094ms)  : 1063, 1125
     .   : milestone, 1094,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6368) - mean (277ms)  : 272, 282
     .   : milestone, 277,
    master - mean (277ms)  : 272, 281
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6368) - mean (872ms)  : 847, 896
     .   : milestone, 872,
    master - mean (868ms)  : 842, 895
     .   : milestone, 868,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6368) - mean (266ms)  : 262, 271
     .   : milestone, 266,
    master - mean (266ms)  : 262, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6368) - mean (855ms)  : 826, 884
     .   : milestone, 855,
    master - mean (847ms)  : 812, 882
     .   : milestone, 847,

Loading

@andrewlock
Copy link
Member

andrewlock commented Nov 28, 2024

Benchmarks Report for tracer 🐌

Benchmarks for #6368 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.121
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.12μs 45.6ns 323ns 0.0157 0.00784 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.1μs 54.3ns 307ns 0.0199 0.00997 0 5.8 KB
master StartStopWithChild net472 16.2μs 56.8ns 220ns 1.05 0.316 0.0972 6.2 KB
#6368 StartStopWithChild net6.0 8.11μs 46.3ns 344ns 0.0204 0.00817 0 5.61 KB
#6368 StartStopWithChild netcoreapp3.1 10.2μs 48.4ns 200ns 0.0152 0.00506 0 5.8 KB
#6368 StartStopWithChild net472 16.1μs 44.1ns 171ns 1.04 0.313 0.0964 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 488μs 510ns 1.97μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 681μs 416ns 1.61μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 855μs 386ns 1.44μs 0.419 0 0 3.3 KB
#6368 WriteAndFlushEnrichedTraces net6.0 496μs 315ns 1.22μs 0 0 0 2.7 KB
#6368 WriteAndFlushEnrichedTraces netcoreapp3.1 672μs 546ns 1.97μs 0 0 0 2.7 KB
#6368 WriteAndFlushEnrichedTraces net472 848μs 442ns 1.71μs 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 151μs 885ns 8.35μs 0.154 0 0 14.47 KB
master SendRequest netcoreapp3.1 170μs 1.01μs 10μs 0.179 0 0 17.27 KB
master SendRequest net472 0.000387ns 0.000188ns 0.000704ns 0 0 0 0 b
#6368 SendRequest net6.0 152μs 916ns 9.16μs 0.147 0 0 14.47 KB
#6368 SendRequest netcoreapp3.1 168μs 979ns 8.92μs 0.166 0 0 17.27 KB
#6368 SendRequest net472 0.00108ns 0.000531ns 0.00206ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 555μs 3.13μs 23μs 0.587 0 0 41.51 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 677μs 3.61μs 19.8μs 0.347 0 0 41.73 KB
master WriteAndFlushEnrichedTraces net472 881μs 4.25μs 17.5μs 8.19 2.59 0.431 53.32 KB
#6368 WriteAndFlushEnrichedTraces net6.0 563μs 2.63μs 9.83μs 0.561 0 0 41.62 KB
#6368 WriteAndFlushEnrichedTraces netcoreapp3.1 686μs 3.07μs 11.9μs 0.34 0 0 41.76 KB
#6368 WriteAndFlushEnrichedTraces net472 838μs 3.63μs 14.1μs 8.81 2.52 0.419 53.27 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.23μs 1.52ns 5.88ns 0.014 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.71μs 0.849ns 3.29ns 0.0137 0 0 1.02 KB
master ExecuteNonQuery net472 2.07μs 1.83ns 6.86ns 0.156 0.00103 0 987 B
#6368 ExecuteNonQuery net6.0 1.29μs 1.37ns 5.32ns 0.0144 0 0 1.02 KB
#6368 ExecuteNonQuery netcoreapp3.1 1.7μs 0.919ns 3.56ns 0.0135 0 0 1.02 KB
#6368 ExecuteNonQuery net472 2.02μs 2.96ns 11.5ns 0.156 0.00101 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.33μs 0.511ns 1.98ns 0.0133 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.56μs 1.97ns 7.63ns 0.0132 0 0 976 B
master CallElasticsearch net472 2.53μs 2.29ns 8.57ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.32μs 0.764ns 2.96ns 0.0132 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.66μs 0.914ns 3.42ns 0.0141 0 0 1.02 KB
master CallElasticsearchAsync net472 2.66μs 2.05ns 7.94ns 0.167 0 0 1.05 KB
#6368 CallElasticsearch net6.0 1.29μs 0.553ns 2.07ns 0.0135 0 0 976 B
#6368 CallElasticsearch netcoreapp3.1 1.69μs 1.9ns 7.34ns 0.0127 0 0 976 B
#6368 CallElasticsearch net472 2.54μs 1.39ns 5.01ns 0.157 0 0 995 B
#6368 CallElasticsearchAsync net6.0 1.24μs 0.443ns 1.66ns 0.0131 0 0 952 B
#6368 CallElasticsearchAsync netcoreapp3.1 1.72μs 0.966ns 3.74ns 0.0137 0 0 1.02 KB
#6368 CallElasticsearchAsync net472 2.67μs 1.48ns 5.35ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6368

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 1.127 1,330.69 1,180.52

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.33μs 0.469ns 1.82ns 0.0133 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.62μs 0.654ns 2.53ns 0.0124 0 0 952 B
master ExecuteAsync net472 1.75μs 0.873ns 3.15ns 0.145 0 0 915 B
#6368 ExecuteAsync net6.0 1.18μs 0.346ns 1.25ns 0.0131 0 0 952 B
#6368 ExecuteAsync netcoreapp3.1 1.7μs 0.923ns 3.57ns 0.0128 0 0 952 B
#6368 ExecuteAsync net472 1.79μs 0.836ns 3.24ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.52μs 3.22ns 11.6ns 0.0317 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.23μs 1.29ns 5ns 0.0366 0 0 2.85 KB
master SendAsync net472 7.33μs 2.03ns 7.88ns 0.495 0 0 3.12 KB
#6368 SendAsync net6.0 4.44μs 5.42ns 21ns 0.0314 0 0 2.31 KB
#6368 SendAsync netcoreapp3.1 5.34μs 5.98ns 23.2ns 0.0371 0 0 2.85 KB
#6368 SendAsync net472 7.43μs 0.966ns 3.48ns 0.494 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6368

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.114 1,617.34 1,451.95

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.62μs 0.908ns 3.4ns 0.0227 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.13μs 0.629ns 2.44ns 0.0224 0 0 1.64 KB
master EnrichedLog net472 2.71μs 1.13ns 4.38ns 0.25 0 0 1.57 KB
#6368 EnrichedLog net6.0 1.45μs 0.633ns 2.45ns 0.0226 0 0 1.64 KB
#6368 EnrichedLog netcoreapp3.1 2.1μs 0.417ns 1.56ns 0.022 0 0 1.64 KB
#6368 EnrichedLog net472 2.73μs 1.41ns 5.28ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 119μs 119ns 461ns 0.0603 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 124μs 136ns 526ns 0 0 0 4.28 KB
master EnrichedLog net472 152μs 152ns 589ns 0.69 0.23 0 4.46 KB
#6368 EnrichedLog net6.0 121μs 140ns 525ns 0 0 0 4.28 KB
#6368 EnrichedLog netcoreapp3.1 124μs 87ns 337ns 0 0 0 4.28 KB
#6368 EnrichedLog net472 153μs 137ns 529ns 0.692 0.231 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.07μs 0.84ns 3.25ns 0.0307 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.08μs 1.32ns 5.09ns 0.0285 0 0 2.2 KB
master EnrichedLog net472 4.96μs 2.43ns 9.41ns 0.319 0 0 2.02 KB
#6368 EnrichedLog net6.0 2.99μs 1.34ns 5.2ns 0.031 0 0 2.2 KB
#6368 EnrichedLog netcoreapp3.1 4.44μs 6.41ns 24.8ns 0.0293 0 0 2.2 KB
#6368 EnrichedLog net472 4.85μs 1ns 3.87ns 0.318 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.42μs 0.336ns 1.3ns 0.0156 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.72μs 0.937ns 3.51ns 0.0155 0 0 1.14 KB
master SendReceive net472 2.12μs 3.57ns 13.8ns 0.183 0 0 1.16 KB
#6368 SendReceive net6.0 1.34μs 0.588ns 2.28ns 0.0161 0 0 1.14 KB
#6368 SendReceive netcoreapp3.1 1.76μs 0.911ns 3.41ns 0.0149 0 0 1.14 KB
#6368 SendReceive net472 2.11μs 1.53ns 5.71ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.62μs 0.971ns 3.76ns 0.0224 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.98μs 2.35ns 9.09ns 0.0219 0 0 1.65 KB
master EnrichedLog net472 4.44μs 3.15ns 12.2ns 0.323 0 0 2.04 KB
#6368 EnrichedLog net6.0 2.8μs 1.56ns 5.83ns 0.0224 0 0 1.6 KB
#6368 EnrichedLog netcoreapp3.1 3.93μs 1.66ns 6.45ns 0.0215 0 0 1.65 KB
#6368 EnrichedLog net472 4.35μs 1.42ns 5.3ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 396ns 0.55ns 2.13ns 0.00802 0 0 576 B
master StartFinishSpan netcoreapp3.1 548ns 0.95ns 3.68ns 0.00773 0 0 576 B
master StartFinishSpan net472 635ns 1.04ns 4.02ns 0.0918 0 0 578 B
master StartFinishScope net6.0 518ns 0.905ns 3.51ns 0.00966 0 0 696 B
master StartFinishScope netcoreapp3.1 700ns 1.27ns 4.91ns 0.00944 0 0 696 B
master StartFinishScope net472 888ns 1.31ns 5.09ns 0.104 0 0 658 B
#6368 StartFinishSpan net6.0 410ns 0.528ns 1.97ns 0.00808 0 0 576 B
#6368 StartFinishSpan netcoreapp3.1 549ns 0.707ns 2.74ns 0.00778 0 0 576 B
#6368 StartFinishSpan net472 679ns 2.36ns 9.14ns 0.0917 0 0 578 B
#6368 StartFinishScope net6.0 497ns 0.452ns 1.63ns 0.00974 0 0 696 B
#6368 StartFinishScope netcoreapp3.1 770ns 1.11ns 4.29ns 0.0093 0 0 696 B
#6368 StartFinishScope net472 854ns 2.22ns 8.6ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 656ns 1.2ns 4.65ns 0.00954 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 897ns 3.82ns 14.8ns 0.00954 0 0 696 B
master RunOnMethodBegin net472 1.11μs 2.31ns 8.97ns 0.104 0 0 658 B
#6368 RunOnMethodBegin net6.0 611ns 1.07ns 4.15ns 0.00981 0 0 696 B
#6368 RunOnMethodBegin netcoreapp3.1 940ns 1.76ns 6.82ns 0.0096 0 0 696 B
#6368 RunOnMethodBegin net472 1.06μs 3.15ns 12.2ns 0.105 0 0 658 B

@andrewlock
Copy link
Member

andrewlock commented Nov 28, 2024

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6368) (11.222M)   : 0, 11222487
    master (11.137M)   : 0, 11136693
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6368) (7.355M)   : 0, 7355497
    master (7.208M)   : 0, 7207773
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.606M)   : 0, 7605597

    section Manual
    master (11.229M)   : 0, 11228588

    section Manual + Automatic
    This PR (6368) (6.686M)   : 0, 6686421
    master (6.591M)   : 0, 6590949

    section DD_TRACE_ENABLED=0
    master (10.370M)   : 0, 10369998

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6368) (9.495M)   : 0, 9495423
    master (9.315M)   : 0, 9314649
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6368) (6.362M)   : 0, 6362194
    master (6.373M)   : 0, 6372940

    section Trace stats
    master (6.614M)   : 0, 6613938

    section Manual
    master (9.430M)   : 0, 9429935

    section Manual + Automatic
    This PR (6368) (6.020M)   : 0, 6019961
    master (5.873M)   : 0, 5872760

    section DD_TRACE_ENABLED=0
    master (8.828M)   : 0, 8827967

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6368) (9.606M)   : 0, 9606356
    master (9.813M)   : 0, 9813025
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6368) (6.165M)   : crit ,0, 6164803
    master (6.493M)   : 0, 6493296
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.088M)   : 0, 7087833

    section Manual
    master (10.002M)   : 0, 10001889

    section Manual + Automatic
    This PR (6368) (5.906M)   : 0, 5906376
    master (6.146M)   : 0, 6145502

    section DD_TRACE_ENABLED=0
    master (9.378M)   : 0, 9377652

Loading

@gleocadie gleocadie force-pushed the chrisnas/flacky_etw_tests branch from c17ea1c to 55f4cfd Compare November 30, 2024 15:02
@link04 link04 merged commit 97a2e2e into master Dec 1, 2024
83 of 85 checks passed
@link04 link04 deleted the chrisnas/flacky_etw_tests branch December 1, 2024 17:34
@github-actions github-actions bot added this to the vNext-v3 milestone Dec 1, 2024
veerbia pushed a commit that referenced this pull request Dec 16, 2024
## Summary of changes
Pick a less CPU intensive scenario and increase test timeout

## Reason for change
The previous version of the tests showed that the agent proxy was not
able to asynchronously send the recorded events before the test ends.

## Implementation details
Increase the timeout so the profiled application lives long enough to
receive the recorded events

## Test coverage
yes

## Other details
<!-- Fixes #{issue} -->

<!-- ⚠️ Note: where possible, please obtain 2 approvals prior to
merging. Unless CODEOWNERS specifies otherwise, for external teams it is
typically best to have one review from a team member, and one review
from apm-dotnet. Trivial changes do not require 2 reviews. -->
@andrewlock andrewlock added area:tests unit tests, integration tests and removed area:profiler Issues related to the continous-profiler labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tests unit tests, integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants