-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Profiler] Disable flaky check #6367
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 452081 Passed, 3215 Skipped, 21h 12m 23.24s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6367) - mean (69ms) : 66, 71
. : milestone, 69,
master - mean (69ms) : 66, 72
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (6367) - mean (980ms) : 953, 1008
. : milestone, 980,
master - mean (980ms) : 954, 1006
. : milestone, 980,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6367) - mean (108ms) : 105, 110
. : milestone, 108,
master - mean (108ms) : 106, 110
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6367) - mean (679ms) : 663, 695
. : milestone, 679,
master - mean (680ms) : 667, 694
. : milestone, 680,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6367) - mean (91ms) : 89, 93
. : milestone, 91,
master - mean (92ms) : 90, 94
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6367) - mean (629ms) : 609, 649
. : milestone, 629,
master - mean (634ms) : 618, 650
. : milestone, 634,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6367) - mean (191ms) : 187, 195
. : milestone, 191,
master - mean (190ms) : 186, 195
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (6367) - mean (1,091ms) : 1060, 1123
. : milestone, 1091,
master - mean (1,096ms) : 1054, 1137
. : milestone, 1096,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6367) - mean (276ms) : 272, 280
. : milestone, 276,
master - mean (276ms) : 272, 280
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6367) - mean (872ms) : 840, 904
. : milestone, 872,
master - mean (869ms) : 842, 895
. : milestone, 869,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6367) - mean (268ms) : 261, 274
. : milestone, 268,
master - mean (266ms) : 262, 270
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (6367) - mean (845ms) : 813, 877
. : milestone, 845,
master - mean (855ms) : 817, 892
. : milestone, 855,
|
Benchmarks Report for tracer 🐌Benchmarks for #6367 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Slower
|
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.220 | 393.88 | 480.58 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 394ns | 0.459ns | 1.78ns | 0.00807 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 611ns | 1.25ns | 4.68ns | 0.00761 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 649ns | 1.5ns | 5.8ns | 0.0917 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 502ns | 0.695ns | 2.69ns | 0.00966 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 758ns | 1.67ns | 6.24ns | 0.00922 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 866ns | 2.06ns | 7.97ns | 0.104 | 0 | 0 | 658 B |
#6367 | StartFinishSpan |
net6.0 | 482ns | 0.866ns | 3.35ns | 0.00804 | 0 | 0 | 576 B |
#6367 | StartFinishSpan |
netcoreapp3.1 | 566ns | 0.902ns | 3.49ns | 0.00761 | 0 | 0 | 576 B |
#6367 | StartFinishSpan |
net472 | 648ns | 0.834ns | 3.23ns | 0.0918 | 0 | 0 | 578 B |
#6367 | StartFinishScope |
net6.0 | 532ns | 1.2ns | 4.66ns | 0.00961 | 0 | 0 | 696 B |
#6367 | StartFinishScope |
netcoreapp3.1 | 685ns | 0.93ns | 3.6ns | 0.00953 | 0 | 0 | 696 B |
#6367 | StartFinishScope |
net472 | 891ns | 1.79ns | 6.92ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6367
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.153
594.18
684.92
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.153 | 594.18 | 684.92 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 594ns | 0.761ns | 2.95ns | 0.00961 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 952ns | 1.56ns | 6.06ns | 0.00949 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.16μs | 2.5ns | 9.66ns | 0.104 | 0 | 0 | 658 B |
#6367 | RunOnMethodBegin |
net6.0 | 687ns | 2.59ns | 10ns | 0.00994 | 0 | 0 | 696 B |
#6367 | RunOnMethodBegin |
netcoreapp3.1 | 958ns | 1.03ns | 3.85ns | 0.00909 | 0 | 0 | 696 B |
#6367 | RunOnMethodBegin |
net472 | 1.1μs | 1.72ns | 6.67ns | 0.104 | 0 | 0 | 658 B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
46e9ec3
to
dbb73b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6367) (11.306M) : 0, 11305577
master (11.361M) : 0, 11361081
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6367) (7.304M) : 0, 7304407
master (7.386M) : 0, 7386114
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.662M) : 0, 7662233
section Manual
master (11.190M) : 0, 11189983
section Manual + Automatic
This PR (6367) (6.838M) : 0, 6838149
master (6.815M) : 0, 6814740
section DD_TRACE_ENABLED=0
master (10.320M) : 0, 10319505
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6367) (9.255M) : 0, 9254552
master (9.527M) : 0, 9527423
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6367) (6.235M) : 0, 6234699
master (6.264M) : 0, 6263949
section Trace stats
master (6.510M) : 0, 6509886
section Manual
master (9.336M) : 0, 9335765
section Manual + Automatic
This PR (6367) (5.825M) : 0, 5824561
master (5.881M) : 0, 5880843
section DD_TRACE_ENABLED=0
master (8.790M) : 0, 8790191
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6367) (10.232M) : 0, 10232317
master (10.062M) : 0, 10061771
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6367) (6.513M) : 0, 6512696
master (6.546M) : 0, 6545951
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (7.305M) : 0, 7305404
section Manual
master (10.146M) : 0, 10146170
section Manual + Automatic
This PR (6367) (6.289M) : 0, 6289280
master (6.140M) : 0, 6140263
section DD_TRACE_ENABLED=0
master (9.363M) : 0, 9362965
|
Summary of changes
Disable check that causes flakiness.
Reason for change
Flakiness induced by this check might be due to a bug in libunwind. Since we do not use the
OldWay
anymore, we can skip that check.Implementation details
Test coverage
Other details