Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude InetMgr.exe from instrumentation #6355

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Exclude InetMgr.exe from instrumentation #6355

merged 1 commit into from
Nov 26, 2024

Conversation

andrewlock
Copy link
Member

@andrewlock andrewlock commented Nov 26, 2024 •
edited
Loading

Summary of changes

Excludes InetMgr.exe from traced processes

Reason for change

There's no reason to trace this process

Implementation details

Add to the exclude list

Other details

Didn't bother adding it to the SSI list seeing as it's Windows only

@andrewlock andrewlock added the area:native-library Automatic instrumentation native C++ code (Datadog.Trace.ClrProfiler.Native) label Nov 26, 2024
@andrewlock andrewlock requested review from a team as code owners November 26, 2024 14:09
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Nov 26, 2024 •
edited
Loading

Datadog Report

Branch report: andrew/exclude-inetmgr
Commit report: 0343be5
Test service: dd-trace-dotnet

✅ 0 Failed, 463343 Passed, 4067 Skipped, 34h 13m 40.38s Total Time

@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6355) - mean (77ms)  : 73, 81
     .   : milestone, 77,
    master - mean (69ms)  : 67, 70
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6355) - mean (1,042ms)  : crit, 1012, 1072
     .   : crit, milestone, 1042,
    master - mean (975ms)  : 954, 996
     .   : milestone, 975,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6355) - mean (120ms)  : 114, 125
     .   : milestone, 120,
    master - mean (108ms)  : 105, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6355) - mean (729ms)  : crit, 709, 749
     .   : crit, milestone, 729,
    master - mean (679ms)  : 666, 691
     .   : milestone, 679,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6355) - mean (102ms)  : 98, 106
     .   : milestone, 102,
    master - mean (91ms)  : 88, 94
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6355) - mean (676ms)  : crit, 654, 698
     .   : crit, milestone, 676,
    master - mean (630ms)  : 615, 646
     .   : milestone, 630,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6355) - mean (190ms)  : 187, 194
     .   : milestone, 190,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6355) - mean (1,091ms)  : 1064, 1119
     .   : milestone, 1091,
    master - mean (1,094ms)  : 1064, 1124
     .   : milestone, 1094,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6355) - mean (277ms)  : 271, 283
     .   : milestone, 277,
    master - mean (277ms)  : 272, 282
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6355) - mean (872ms)  : 841, 902
     .   : milestone, 872,
    master - mean (871ms)  : 837, 906
     .   : milestone, 871,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6355) - mean (266ms)  : 261, 270
     .   : milestone, 266,
    master - mean (266ms)  : 261, 271
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6355) - mean (857ms)  : 824, 889
     .   : milestone, 857,
    master - mean (851ms)  : 810, 893
     .   : milestone, 851,
Loading

@andrewlock
Copy link
Member Author

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6355) (11.189M)   : 0, 11188867
    master (10.987M)   : 0, 10986728
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6355) (7.394M)   : 0, 7393630
    master (7.175M)   : 0, 7174684
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.577M)   : 0, 7577344

    section Manual
    master (11.201M)   : 0, 11201309

    section Manual + Automatic
    This PR (6355) (6.761M)   : 0, 6760506
    master (6.769M)   : 0, 6769214

    section DD_TRACE_ENABLED=0
    master (10.257M)   : 0, 10257268
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6355) (9.721M)   : 0, 9720532
    master (9.557M)   : 0, 9557319
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6355) (6.520M)   : 0, 6520493
    master (6.368M)   : 0, 6367805

    section Trace stats
    master (6.673M)   : 0, 6672869

    section Manual
    master (9.631M)   : 0, 9630961

    section Manual + Automatic
    This PR (6355) (6.012M)   : 0, 6012296
    master (5.951M)   : 0, 5951439

    section DD_TRACE_ENABLED=0
    master (8.900M)   : 0, 8899929
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6355) (10.111M)   : 0, 10111060
    master (9.199M)   : 0, 9198633
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6355) (6.514M)   : 0, 6514036
    master (6.083M)   : 0, 6082614
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.603M)   : 0, 6602631

    section Manual
    master (9.506M)   : 0, 9505886

    section Manual + Automatic
    This PR (6355) (5.991M)   : 0, 5991089
    master (5.789M)   : 0, 5788592

    section DD_TRACE_ENABLED=0
    master (8.972M)   : 0, 8971897
Loading

@andrewlock andrewlock merged commit 2ac2b32 into master Nov 26, 2024
85 of 88 checks passed
@andrewlock andrewlock deleted the andrew/exclude-inetmgr branch November 26, 2024 17:25
@github-actions github-actions bot added this to the vNext-v3 milestone Nov 26, 2024
veerbia pushed a commit that referenced this pull request Dec 16, 2024
@andrewlock @veerbia
Exclude InetMgr.exe from instrumentation (#6355)
2be2839 
## Summary of changes

Excludes `InetMgr.exe` from traced processes

## Reason for change

There's no reason to trace this process

## Implementation details

Add to the exclude list

## Other details

Didn't bother adding it to the SSI list seeing as it's Windows only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevingosse kevingosse kevingosse approved these changes

@lucaspimentel lucaspimentel lucaspimentel approved these changes

Assignees
No one assigned
Labels
area:native-library Automatic instrumentation native C++ code (Datadog.Trace.ClrProfiler.Native)
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewlock @lucaspimentel @kevingosse