-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump timeit to 0.3.2 #6349
Bump timeit to 0.3.2 #6349
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 450988 Passed, 2742 Skipped, 19h 22m 41.67s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6349) - mean (73ms) : 70, 76
. : milestone, 73,
master - mean (76ms) : 71, 81
. : milestone, 76,
section CallTarget+Inlining+NGEN
This PR (6349) - mean (1,018ms) : 981, 1054
. : milestone, 1018,
master - mean (1,064ms) : 973, 1154
. : milestone, 1064,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6349) - mean (114ms) : 110, 119
. : milestone, 114,
master - mean (119ms) : 114, 124
. : milestone, 119,
section CallTarget+Inlining+NGEN
This PR (6349) - mean (703ms) : 688, 718
. : milestone, 703,
master - mean (745ms) : 678, 811
. : milestone, 745,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6349) - mean (97ms) : 92, 102
. : milestone, 97,
master - mean (101ms) : 96, 107
. : milestone, 101,
section CallTarget+Inlining+NGEN
This PR (6349) - mean (650ms) : 634, 667
. : milestone, 650,
master - mean (678ms) : 658, 698
. : milestone, 678,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6349) - mean (190ms) : 187, 193
. : milestone, 190,
master - mean (192ms) : 189, 195
. : milestone, 192,
section CallTarget+Inlining+NGEN
This PR (6349) - mean (1,095ms) : 1066, 1124
. : milestone, 1095,
master - mean (1,095ms) : 1072, 1119
. : milestone, 1095,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6349) - mean (276ms) : 272, 280
. : milestone, 276,
master - mean (276ms) : 272, 280
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6349) - mean (873ms) : 836, 910
. : milestone, 873,
master - mean (868ms) : 846, 891
. : milestone, 868,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6349) - mean (266ms) : 262, 270
. : milestone, 266,
master - mean (266ms) : 262, 269
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (6349) - mean (850ms) : 815, 886
. : milestone, 850,
master - mean (856ms) : 826, 887
. : milestone, 856,
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6349) (11.156M) : 0, 11155730
master (11.198M) : 0, 11198348
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6349) (7.351M) : 0, 7351480
master (7.205M) : 0, 7205466
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.443M) : 0, 7442635
section Manual
master (11.218M) : 0, 11217680
section Manual + Automatic
This PR (6349) (6.742M) : 0, 6741955
master (6.727M) : 0, 6726536
section DD_TRACE_ENABLED=0
master (10.410M) : 0, 10409702
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6349) (9.537M) : 0, 9536549
master (9.510M) : 0, 9510466
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6349) (6.342M) : 0, 6342249
master (6.331M) : 0, 6331398
section Trace stats
master (6.659M) : 0, 6658730
section Manual
master (9.280M) : 0, 9280107
section Manual + Automatic
This PR (6349) (5.976M) : 0, 5976106
master (5.691M) : 0, 5690770
section DD_TRACE_ENABLED=0
master (8.840M) : 0, 8840434
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6349) (9.804M) : 0, 9803773
master (10.163M) : 0, 10163050
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6349) (6.025M) : crit ,0, 6025042
master (6.829M) : 0, 6828973
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (7.555M) : 0, 7554541
section Manual
master (10.735M) : 0, 10735441
section Manual + Automatic
This PR (6349) (6.213M) : crit ,0, 6212745
master (6.575M) : 0, 6575410
section DD_TRACE_ENABLED=0
master (10.155M) : 0, 10155272
|
Benchmarks Report for tracer 🐌Benchmarks for #6349 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Faster 🎉 Same allocations ✔️
|
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 | 1.118 | 1,344.46 | 1,202.74 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | CallElasticsearch |
net6.0 | 1.35μs | 1.64ns | 6.37ns | 0.0135 | 0 | 0 | 976 B |
master | CallElasticsearch |
netcoreapp3.1 | 1.49μs | 0.569ns | 2.13ns | 0.0133 | 0 | 0 | 976 B |
master | CallElasticsearch |
net472 | 2.56μs | 2.42ns | 9.38ns | 0.158 | 0 | 0 | 995 B |
master | CallElasticsearchAsync |
net6.0 | 1.29μs | 0.568ns | 2.13ns | 0.0129 | 0 | 0 | 952 B |
master | CallElasticsearchAsync |
netcoreapp3.1 | 1.68μs | 1.97ns | 7.65ns | 0.0136 | 0 | 0 | 1.02 KB |
master | CallElasticsearchAsync |
net472 | 2.63μs | 1.95ns | 7.3ns | 0.166 | 0 | 0 | 1.05 KB |
#6349 | CallElasticsearch |
net6.0 | 1.2μs | 1.91ns | 7.39ns | 0.0137 | 0 | 0 | 976 B |
#6349 | CallElasticsearch |
netcoreapp3.1 | 1.61μs | 1.64ns | 5.91ns | 0.0127 | 0 | 0 | 976 B |
#6349 | CallElasticsearch |
net472 | 2.59μs | 1.43ns | 5.53ns | 0.158 | 0 | 0 | 995 B |
#6349 | CallElasticsearchAsync |
net6.0 | 1.32μs | 0.705ns | 2.73ns | 0.0131 | 0 | 0 | 952 B |
#6349 | CallElasticsearchAsync |
netcoreapp3.1 | 1.66μs | 1.18ns | 4.41ns | 0.0133 | 0 | 0 | 1.02 KB |
#6349 | CallElasticsearchAsync |
net472 | 2.83μs | 0.521ns | 1.88ns | 0.166 | 0 | 0 | 1.05 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | ExecuteAsync |
net6.0 | 1.27μs | 0.915ns | 3.42ns | 0.0132 | 0 | 0 | 952 B |
master | ExecuteAsync |
netcoreapp3.1 | 1.72μs | 0.807ns | 3.02ns | 0.0123 | 0 | 0 | 952 B |
master | ExecuteAsync |
net472 | 1.8μs | 0.423ns | 1.64ns | 0.145 | 0 | 0 | 915 B |
#6349 | ExecuteAsync |
net6.0 | 1.29μs | 0.768ns | 2.88ns | 0.0136 | 0 | 0 | 952 B |
#6349 | ExecuteAsync |
netcoreapp3.1 | 1.55μs | 1.08ns | 4.18ns | 0.0125 | 0 | 0 | 952 B |
#6349 | ExecuteAsync |
net472 | 1.83μs | 1.52ns | 5.87ns | 0.145 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendAsync |
net6.0 | 4.44μs | 1.38ns | 5.16ns | 0.0311 | 0 | 0 | 2.31 KB |
master | SendAsync |
netcoreapp3.1 | 5.35μs | 1.65ns | 6.4ns | 0.0374 | 0 | 0 | 2.85 KB |
master | SendAsync |
net472 | 7.28μs | 8.94ns | 34.6ns | 0.494 | 0 | 0 | 3.12 KB |
#6349 | SendAsync |
net6.0 | 4.48μs | 1.01ns | 3.8ns | 0.0324 | 0 | 0 | 2.31 KB |
#6349 | SendAsync |
netcoreapp3.1 | 5.45μs | 3.07ns | 11.9ns | 0.0385 | 0 | 0 | 2.85 KB |
#6349 | SendAsync |
net472 | 7.12μs | 2.01ns | 7.79ns | 0.495 | 0 | 0 | 3.12 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 1.61μs | 0.652ns | 2.44ns | 0.0227 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
netcoreapp3.1 | 2.21μs | 0.8ns | 2.99ns | 0.0222 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
net472 | 2.58μs | 2.47ns | 9.22ns | 0.249 | 0 | 0 | 1.57 KB |
#6349 | EnrichedLog |
net6.0 | 1.53μs | 1.31ns | 4.91ns | 0.0232 | 0 | 0 | 1.64 KB |
#6349 | EnrichedLog |
netcoreapp3.1 | 2.23μs | 1.31ns | 4.91ns | 0.0225 | 0 | 0 | 1.64 KB |
#6349 | EnrichedLog |
net472 | 2.74μs | 1.75ns | 6.77ns | 0.249 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 121μs | 114ns | 428ns | 0.0608 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
netcoreapp3.1 | 124μs | 160ns | 618ns | 0 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
net472 | 151μs | 99.8ns | 373ns | 0.681 | 0.227 | 0 | 4.46 KB |
#6349 | EnrichedLog |
net6.0 | 120μs | 174ns | 675ns | 0 | 0 | 0 | 4.28 KB |
#6349 | EnrichedLog |
netcoreapp3.1 | 124μs | 114ns | 427ns | 0 | 0 | 0 | 4.28 KB |
#6349 | EnrichedLog |
net472 | 152μs | 147ns | 570ns | 0.684 | 0.228 | 0 | 4.46 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 3.08μs | 1.29ns | 5.01ns | 0.0306 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
netcoreapp3.1 | 4.25μs | 1.32ns | 5.13ns | 0.0302 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
net472 | 4.79μs | 2.13ns | 8.25ns | 0.321 | 0 | 0 | 2.02 KB |
#6349 | EnrichedLog |
net6.0 | 2.96μs | 2.32ns | 8.99ns | 0.031 | 0 | 0 | 2.2 KB |
#6349 | EnrichedLog |
netcoreapp3.1 | 4.15μs | 1.47ns | 5.5ns | 0.0292 | 0 | 0 | 2.2 KB |
#6349 | EnrichedLog |
net472 | 4.79μs | 1.05ns | 3.93ns | 0.321 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendReceive |
net6.0 | 1.34μs | 0.474ns | 1.77ns | 0.0158 | 0 | 0 | 1.14 KB |
master | SendReceive |
netcoreapp3.1 | 1.74μs | 0.59ns | 2.21ns | 0.0157 | 0 | 0 | 1.14 KB |
master | SendReceive |
net472 | 2.12μs | 0.668ns | 2.5ns | 0.183 | 0 | 0 | 1.16 KB |
#6349 | SendReceive |
net6.0 | 1.29μs | 0.486ns | 1.88ns | 0.0161 | 0 | 0 | 1.14 KB |
#6349 | SendReceive |
netcoreapp3.1 | 1.79μs | 0.967ns | 3.62ns | 0.0152 | 0 | 0 | 1.14 KB |
#6349 | SendReceive |
net472 | 2.06μs | 1.04ns | 4.01ns | 0.183 | 0 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.67μs | 1.32ns | 5.12ns | 0.0228 | 0 | 0 | 1.6 KB |
master | EnrichedLog |
netcoreapp3.1 | 3.85μs | 1.17ns | 4.37ns | 0.0211 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
net472 | 4.48μs | 2.37ns | 8.88ns | 0.322 | 0 | 0 | 2.04 KB |
#6349 | EnrichedLog |
net6.0 | 2.81μs | 1.27ns | 4.92ns | 0.0224 | 0 | 0 | 1.6 KB |
#6349 | EnrichedLog |
netcoreapp3.1 | 3.83μs | 4.31ns | 16.7ns | 0.021 | 0 | 0 | 1.65 KB |
#6349 | EnrichedLog |
net472 | 4.45μs | 1.76ns | 6.58ns | 0.322 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6349
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0
1.249
477.75
596.84
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0
1.127
404.06
455.32
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 | 1.249 | 477.75 | 596.84 | |
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.127 | 404.06 | 455.32 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 403ns | 0.694ns | 2.69ns | 0.00817 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 578ns | 1.3ns | 5.05ns | 0.00778 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 721ns | 1.91ns | 7.41ns | 0.0917 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 478ns | 0.652ns | 2.52ns | 0.00978 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 676ns | 3.63ns | 18.5ns | 0.00961 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 850ns | 1.58ns | 6.1ns | 0.104 | 0 | 0 | 658 B |
#6349 | StartFinishSpan |
net6.0 | 455ns | 0.606ns | 2.35ns | 0.00807 | 0 | 0 | 576 B |
#6349 | StartFinishSpan |
netcoreapp3.1 | 563ns | 0.494ns | 1.91ns | 0.00784 | 0 | 0 | 576 B |
#6349 | StartFinishSpan |
net472 | 653ns | 1.5ns | 5.8ns | 0.0916 | 0 | 0 | 578 B |
#6349 | StartFinishScope |
net6.0 | 596ns | 0.909ns | 3.52ns | 0.00976 | 0 | 0 | 696 B |
#6349 | StartFinishScope |
netcoreapp3.1 | 708ns | 2.15ns | 8.05ns | 0.00936 | 0 | 0 | 696 B |
#6349 | StartFinishScope |
net472 | 859ns | 1.79ns | 6.92ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 651ns | 1.15ns | 4.47ns | 0.00982 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 986ns | 2.14ns | 8.27ns | 0.00893 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.06μs | 2.33ns | 9.03ns | 0.104 | 0 | 0 | 658 B |
#6349 | RunOnMethodBegin |
net6.0 | 678ns | 0.98ns | 3.8ns | 0.00975 | 0 | 0 | 696 B |
#6349 | RunOnMethodBegin |
netcoreapp3.1 | 952ns | 1.96ns | 7.6ns | 0.00939 | 0 | 0 | 696 B |
#6349 | RunOnMethodBegin |
net472 | 1.07μs | 2.21ns | 8.58ns | 0.104 | 0 | 0 | 658 B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
## Summary of changes This PR bumps timeit to the latest version.
Summary of changes
This PR bumps timeit to the latest version.