[Crashtracker] Use blazesym API to retrieve buildid #6347

gleocadie · 2024-11-25T14:17:42Z

Summary of changes

Use blazesym API to retrieve the ELF buildid.

Reason for change

Crashtracker on linux does not provide the buildid in the crash report. This is essential to allow symbolization in the backend.

Implementation details

Bump to libdatadog 14.3.1 only for linux
Use the blaze_read_elf_build_id to get the ELF buildid.
The nuget package for windows is too big (> 250MB), so we cannot bump for windows. so keep libdatadog to 13.1.0

Test coverage

I ran the test locally and observe that the event is correctly sent to the telemetry backend and the resolution was correctly done.

Other details

Windows and Linux will use different version of libdatadog. This is fine since it's a temporary situation, and the crash report format has not changed.

andrewlock · 2024-11-25T14:59:13Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6347) - mean (69ms)  : 66, 72
     .   : milestone, 69,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6347) - mean (979ms)  : 952, 1006
     .   : milestone, 979,
    master - mean (977ms)  : 953, 1000
     .   : milestone, 977,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6347) - mean (108ms)  : 105, 110
     .   : milestone, 108,
    master - mean (107ms)  : 105, 110
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6347) - mean (678ms)  : 656, 700
     .   : milestone, 678,
    master - mean (680ms)  : 664, 695
     .   : milestone, 680,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6347) - mean (91ms)  : 90, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6347) - mean (633ms)  : 612, 654
     .   : milestone, 633,
    master - mean (631ms)  : 618, 645
     .   : milestone, 631,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6347) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (191ms)  : 186, 196
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6347) - mean (1,096ms)  : 1065, 1127
     .   : milestone, 1096,
    master - mean (1,090ms)  : 1061, 1118
     .   : milestone, 1090,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6347) - mean (277ms)  : 273, 280
     .   : milestone, 277,
    master - mean (277ms)  : 273, 281
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6347) - mean (872ms)  : 845, 899
     .   : milestone, 872,
    master - mean (874ms)  : 851, 897
     .   : milestone, 874,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6347) - mean (266ms)  : 262, 270
     .   : milestone, 266,
    master - mean (266ms)  : 263, 269
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6347) - mean (852ms)  : 820, 884
     .   : milestone, 852,
    master - mean (850ms)  : 817, 883
     .   : milestone, 850,

datadog-ddstaging · 2024-11-25T15:23:30Z

Datadog Report

Branch report: gleocadie/use-blazesym-elf-build-id-reader
Commit report: dfc30a6
Test service: dd-trace-dotnet

✅ 0 Failed, 453475 Passed, 3194 Skipped, 21h 55m 6.16s Total Time
❄️ 50 New Flaky

New Flaky Tests (50)

IntegrationDisabled - Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.SystemDataSqlClientTests - Last Failure
Expand for error
```
 Expected exit code: 0, actual exit code: 134.
```
SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.SystemDataSqlClientTests - Last Failure
Expand for error
```
 Expected exit code: 0, actual exit code: 134.
```
SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.SystemDataSqlClientTests - Last Failure
Expand for error
```
 Expected exit code: 0, actual exit code: 134.
```
SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.SystemDataSqlClientTests - Last Failure
Expand for error
```
 Expected exit code: 0, actual exit code: 134.
```
SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.SystemDataSqlClientTests - Last Failure
Expand for error
```
 Expected exit code: 0, actual exit code: 134.
```

andrewlock · 2024-11-25T17:01:54Z

Benchmarks Report for tracer 🐌

Benchmarks for #6347 compared to master:

1 benchmarks are faster, with geometric mean 1.137
1 benchmarks are slower, with geometric mean 1.120
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.11μs	46.4ns	344ns	0.0159	0.00794	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	9.98μs	53.3ns	292ns	0.0154	0.00512	0	5.81 KB
master	`StartStopWithChild`	net472	16.1μs	38ns	142ns	1.03	0.305	0.0963	6.2 KB
#6347	`StartStopWithChild`	net6.0	7.88μs	44ns	305ns	0.0155	0.00386	0	5.6 KB
#6347	`StartStopWithChild`	netcoreapp3.1	9.79μs	46.8ns	198ns	0.0147	0.0049	0	5.81 KB
#6347	`StartStopWithChild`	net472	16.2μs	59.4ns	230ns	1.06	0.336	0.0983	6.2 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	507μs	227ns	881ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	654μs	349ns	1.26μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	844μs	615ns	2.38μs	0.419	3.3 KB
#6347	`WriteAndFlushEnrichedTraces`	net6.0	491μs	196ns	761ns	0	2.7 KB
#6347	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	662μs	286ns	1.11μs	0	2.7 KB
#6347	`WriteAndFlushEnrichedTraces`	net472	851μs	429ns	1.66μs	0.422	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	151μs	843ns	7.49μs	0.149	14.47 KB
master	`SendRequest`	netcoreapp3.1	172μs	1.16μs	11.5μs	0.163	17.27 KB
master	`SendRequest`	net472	0.00199ns	0.000919ns	0.00356ns	0	0 b
#6347	`SendRequest`	net6.0	154μs	1.02μs	10.1μs	0.146	14.47 KB
#6347	`SendRequest`	netcoreapp3.1	171μs	983ns	7.62μs	0.171	17.27 KB
#6347	`SendRequest`	net472	0.0021ns	0.000797ns	0.00309ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	574μs	2.34μs	8.74μs	0.573	0	0	41.8 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	663μs	3.34μs	18.3μs	0.331	0	0	41.68 KB
master	`WriteAndFlushEnrichedTraces`	net472	877μs	3.83μs	15.8μs	8.33	2.5	0.417	53.29 KB
#6347	`WriteAndFlushEnrichedTraces`	net6.0	580μs	3.16μs	17.3μs	0.561	0	0	41.65 KB
#6347	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	670μs	3.53μs	18.7μs	0.353	0	0	41.74 KB
#6347	`WriteAndFlushEnrichedTraces`	net472	857μs	4.38μs	19.6μs	8.45	2.53	0.422	53.29 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.28μs	1ns	3.75ns	0.014	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.79μs	1.69ns	6.53ns	0.0135	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.07μs	2.04ns	7.9ns	0.157	0.00103	987 B
#6347	`ExecuteNonQuery`	net6.0	1.2μs	0.91ns	3.41ns	0.0145	0	1.02 KB
#6347	`ExecuteNonQuery`	netcoreapp3.1	1.73μs	1.63ns	6.11ns	0.0138	0	1.02 KB
#6347	`ExecuteNonQuery`	net472	2.04μs	2.16ns	7.78ns	0.156	0.00101	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.15μs	0.343ns	1.28ns	0.0133	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.48μs	0.526ns	1.97ns	0.0133	976 B
master	`CallElasticsearch`	net472	2.67μs	1.31ns	4.9ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.32μs	0.298ns	1.11ns	0.0134	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.65μs	2.51ns	9.72ns	0.0142	1.02 KB
master	`CallElasticsearchAsync`	net472	2.71μs	1.34ns	5.17ns	0.166	1.05 KB
#6347	`CallElasticsearch`	net6.0	1.25μs	1.6ns	6.2ns	0.0138	976 B
#6347	`CallElasticsearch`	netcoreapp3.1	1.54μs	0.766ns	2.97ns	0.0125	976 B
#6347	`CallElasticsearch`	net472	2.59μs	1.3ns	5.02ns	0.157	995 B
#6347	`CallElasticsearchAsync`	net6.0	1.25μs	0.985ns	3.82ns	0.0132	952 B
#6347	`CallElasticsearchAsync`	netcoreapp3.1	1.7μs	1.28ns	4.61ns	0.0136	1.02 KB
#6347	`CallElasticsearchAsync`	net472	2.63μs	0.735ns	2.75ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.34μs	0.935ns	3.5ns	0.0135	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.68μs	0.477ns	1.79ns	0.0126	952 B
master	`ExecuteAsync`	net472	1.85μs	0.924ns	3.46ns	0.145	915 B
#6347	`ExecuteAsync`	net6.0	1.33μs	0.908ns	3.4ns	0.0134	952 B
#6347	`ExecuteAsync`	netcoreapp3.1	1.57μs	0.512ns	1.85ns	0.0126	952 B
#6347	`ExecuteAsync`	net472	1.79μs	0.838ns	3.24ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.34μs	1.98ns	7.41ns	0.0327	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.23μs	2.51ns	9.71ns	0.0391	2.85 KB
master	`SendAsync`	net472	7.36μs	2.47ns	9.56ns	0.495	3.12 KB
#6347	`SendAsync`	net6.0	4.49μs	1.88ns	7.03ns	0.0317	2.31 KB
#6347	`SendAsync`	netcoreapp3.1	5.38μs	2.78ns	10.8ns	0.0376	2.85 KB
#6347	`SendAsync`	net472	7.39μs	1.4ns	5.41ns	0.495	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.42μs	1.2ns	4.65ns	0.023	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.2μs	0.773ns	2.89ns	0.022	1.64 KB
master	`EnrichedLog`	net472	2.71μs	1ns	3.75ns	0.249	1.57 KB
#6347	`EnrichedLog`	net6.0	1.46μs	0.609ns	2.2ns	0.0228	1.64 KB
#6347	`EnrichedLog`	netcoreapp3.1	2.1μs	0.685ns	2.56ns	0.0223	1.64 KB
#6347	`EnrichedLog`	net472	2.54μs	1.27ns	4.75ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	119μs	145ns	563ns	0.06	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	124μs	145ns	561ns	0.0626	0	4.28 KB
master	`EnrichedLog`	net472	152μs	77ns	298ns	0.677	0.226	4.46 KB
#6347	`EnrichedLog`	net6.0	120μs	87.3ns	327ns	0.0604	0	4.28 KB
#6347	`EnrichedLog`	netcoreapp3.1	125μs	134ns	517ns	0	0	4.28 KB
#6347	`EnrichedLog`	net472	153μs	164ns	634ns	0.685	0.228	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.07μs	1.47ns	5.69ns	0.0306	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.19μs	1.52ns	5.7ns	0.0294	2.2 KB
master	`EnrichedLog`	net472	4.75μs	2.07ns	8.01ns	0.32	2.02 KB
#6347	`EnrichedLog`	net6.0	3.01μs	1.4ns	5.4ns	0.03	2.2 KB
#6347	`EnrichedLog`	netcoreapp3.1	4.14μs	1.75ns	6.76ns	0.029	2.2 KB
#6347	`EnrichedLog`	net472	4.77μs	1.15ns	4.44ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.36μs	0.602ns	2.25ns	0.0157	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.71μs	0.56ns	2.17ns	0.0157	1.14 KB
master	`SendReceive`	net472	2.08μs	0.678ns	2.62ns	0.184	1.16 KB
#6347	`SendReceive`	net6.0	1.28μs	0.726ns	2.81ns	0.0159	1.14 KB
#6347	`SendReceive`	netcoreapp3.1	1.78μs	0.511ns	1.91ns	0.0159	1.14 KB
#6347	`SendReceive`	net472	2.14μs	1.14ns	4.42ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.7μs	0.768ns	2.87ns	0.0217	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.82μs	3.3ns	12.4ns	0.021	1.65 KB
master	`EnrichedLog`	net472	4.27μs	1.35ns	5.05ns	0.322	2.04 KB
#6347	`EnrichedLog`	net6.0	2.85μs	0.791ns	3.07ns	0.0228	1.6 KB
#6347	`EnrichedLog`	netcoreapp3.1	3.94μs	2.2ns	8.51ns	0.0217	1.65 KB
#6347	`EnrichedLog`	net472	4.45μs	2.05ns	7.67ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6347

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472	1.120	641.13	718.32

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	460ns	0.638ns	2.47ns	0.00804	576 B
master	`StartFinishSpan`	netcoreapp3.1	621ns	0.75ns	2.81ns	0.00784	576 B
master	`StartFinishSpan`	net472	641ns	0.765ns	2.96ns	0.0918	578 B
master	`StartFinishScope`	net6.0	528ns	0.624ns	2.42ns	0.00962	696 B
master	`StartFinishScope`	netcoreapp3.1	716ns	0.525ns	2.03ns	0.00924	696 B
master	`StartFinishScope`	net472	840ns	2.78ns	10.8ns	0.105	658 B
#6347	`StartFinishSpan`	net6.0	486ns	0.473ns	1.83ns	0.00799	576 B
#6347	`StartFinishSpan`	netcoreapp3.1	569ns	1.05ns	4.08ns	0.0077	576 B
#6347	`StartFinishSpan`	net472	717ns	1.06ns	4.09ns	0.0917	578 B
#6347	`StartFinishScope`	net6.0	484ns	0.688ns	2.67ns	0.0098	696 B
#6347	`StartFinishScope`	netcoreapp3.1	695ns	1.28ns	4.98ns	0.0093	696 B
#6347	`StartFinishScope`	net472	850ns	1.02ns	3.8ns	0.105	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6347

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1	1.137	1,007.91	886.34

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	644ns	0.827ns	3.2ns	0.0096	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	1.01μs	1.57ns	6.06ns	0.00946	696 B
master	`RunOnMethodBegin`	net472	1.12μs	2.33ns	9.04ns	0.104	658 B
#6347	`RunOnMethodBegin`	net6.0	609ns	1.02ns	3.96ns	0.00993	696 B
#6347	`RunOnMethodBegin`	netcoreapp3.1	884ns	1.63ns	6.33ns	0.0093	696 B
#6347	`RunOnMethodBegin`	net472	1.11μs	2.64ns	10.2ns	0.104	658 B

andrewlock · 2024-11-25T17:39:15Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6347) (11.103M)   : 0, 11103107
    master (10.984M)   : 0, 10984077
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6347) (7.356M)   : 0, 7356017
    master (7.340M)   : 0, 7339941
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.574M)   : 0, 7574089

    section Manual
    master (11.230M)   : 0, 11229595

    section Manual + Automatic
    This PR (6347) (6.726M)   : 0, 6725597
    master (6.646M)   : 0, 6645602

    section DD_TRACE_ENABLED=0
    master (10.229M)   : 0, 10228605

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6347) (9.390M)   : 0, 9390293
    master (9.657M)   : 0, 9656803
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6347) (6.271M)   : 0, 6271385
    master (6.427M)   : 0, 6427247

    section Trace stats
    master (6.789M)   : 0, 6789090

    section Manual
    master (9.592M)   : 0, 9591563

    section Manual + Automatic
    This PR (6347) (5.907M)   : 0, 5906797
    master (5.908M)   : 0, 5907813

    section DD_TRACE_ENABLED=0
    master (8.975M)   : 0, 8975433

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6347) (9.869M)   : 0, 9868995
    master (10.448M)   : 0, 10448233
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6347) (6.224M)   : crit ,0, 6223816
    master (6.753M)   : 0, 6752851
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.483M)   : 0, 7482807

    section Manual
    master (10.487M)   : 0, 10487393

    section Manual + Automatic
    This PR (6347) (5.704M)   : crit ,0, 5703681
    master (6.271M)   : 0, 6270817

    section DD_TRACE_ENABLED=0
    master (9.551M)   : 0, 9551351

kevingosse

Thanks! Can you please add an assertion in CreatedumpTests.ReportedStacktrace (in the Datadog.Trace.Tools.dd_dotnet.ArtifactTests project) to verify that you're getting the right build-id?

profiler/src/ProfilerEngine/Datadog.Profiler.Native/CrashReporting.h

gleocadie · 2024-11-27T16:52:52Z

Thanks! Can you please add an assertion in CreatedumpTests.ReportedStacktrace (in the Datadog.Trace.Tools.dd_dotnet.ArtifactTests project) to verify that you're getting the right build-id?

👍

gleocadie · 2024-11-29T11:12:40Z

Thanks! Can you please add an assertion in CreatedumpTests.ReportedStacktrace (in the Datadog.Trace.Tools.dd_dotnet.ArtifactTests project) to verify that you're getting the right build-id?

👍

done in 0968207

andrewlock

LGTM, just one question

andrewlock · 2024-11-29T13:16:05Z

tracer/test/Datadog.Trace.Tools.dd_dotnet.ArtifactTests/CreatedumpTests.cs

 #endif

-                validatedModules.Should().ContainMatch($@"*\{clrModuleName}");
+            if (!Utils.IsAlpine())


Why !IsAlpine? 🤔

On Alpine, I think the unwinding failed on that test and we did not get to frames from libcoreclr and other.
I added this to my note to check why it's failing and if it's already fixed upstream.
(I pushed fixes months ago)

gleocadie force-pushed the gleocadie/use-blazesym-elf-build-id-reader branch from f1247d8 to 39a5fcd Compare November 25, 2024 14:31

gleocadie force-pushed the gleocadie/use-blazesym-elf-build-id-reader branch 2 times, most recently from d733f4f to 6bf4411 Compare November 26, 2024 19:12

gleocadie changed the title ~~[Crashtracker] WIP~~ [Crashtracker] Use blazesym API to retrieve buildid Nov 27, 2024

gleocadie added the area:crashtracking label Nov 27, 2024

gleocadie marked this pull request as ready for review November 27, 2024 09:35

gleocadie requested review from a team as code owners November 27, 2024 09:35

gleocadie force-pushed the gleocadie/use-blazesym-elf-build-id-reader branch 2 times, most recently from 9b185dd to cf4c31c Compare November 27, 2024 11:01

kevingosse requested changes Nov 27, 2024

View reviewed changes

profiler/src/ProfilerEngine/Datadog.Profiler.Native/CrashReporting.h Show resolved Hide resolved

gleocadie force-pushed the gleocadie/use-blazesym-elf-build-id-reader branch from cf4c31c to 157cbca Compare November 27, 2024 22:47

gleocadie requested a review from a team as a code owner November 27, 2024 22:47

gleocadie force-pushed the gleocadie/use-blazesym-elf-build-id-reader branch 9 times, most recently from 6b6e909 to 0968207 Compare November 29, 2024 11:12

kevingosse approved these changes Nov 29, 2024

View reviewed changes

Bump to libdatadog 14.3.0 and use blazesym API to retrieve ELF buildid

2f965d7

gleocadie added 4 commits November 29, 2024 14:16

Bump to libdatadog 14.3.1

0822832

Improve a bit

38bbb88

Fix bug

bbe4162

Add build-id checks in test

dfc30a6

gleocadie force-pushed the gleocadie/use-blazesym-elf-build-id-reader branch from 0968207 to dfc30a6 Compare November 29, 2024 13:16

andrewlock approved these changes Nov 29, 2024

View reviewed changes

gleocadie merged commit 4bfa589 into master Nov 29, 2024
83 of 85 checks passed

gleocadie deleted the gleocadie/use-blazesym-elf-build-id-reader branch November 29, 2024 16:34

github-actions bot added this to the vNext-v3 milestone Nov 29, 2024

veerbia pushed a commit that referenced this pull request Dec 16, 2024

[Crashtracker] Use blazesym API to retrieve buildid (#6347)

40e8072

andrewlock added the type:enhancement Improvement to an existing feature label Dec 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Crashtracker] Use blazesym API to retrieve buildid #6347

[Crashtracker] Use blazesym API to retrieve buildid #6347

gleocadie commented Nov 25, 2024 •

edited

Loading

andrewlock commented Nov 25, 2024 •

edited

Loading

datadog-ddstaging bot commented Nov 25, 2024 •

edited

Loading

andrewlock commented Nov 25, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6347

Raw results

Faster 🎉 in #6347

Raw results

andrewlock commented Nov 25, 2024 •

edited

Loading

kevingosse left a comment

gleocadie commented Nov 27, 2024

gleocadie commented Nov 29, 2024

andrewlock left a comment

andrewlock Nov 29, 2024

gleocadie Nov 29, 2024 •

edited

Loading

[Crashtracker] Use blazesym API to retrieve buildid #6347

[Crashtracker] Use blazesym API to retrieve buildid #6347

Conversation

gleocadie commented Nov 25, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

andrewlock commented Nov 25, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

datadog-ddstaging bot commented Nov 25, 2024 • edited Loading

Datadog Report

New Flaky Tests (50)

andrewlock commented Nov 25, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6347

Raw results

Faster 🎉 in #6347

Raw results

andrewlock commented Nov 25, 2024 • edited Loading

Throughput/Crank Report ⚡

kevingosse left a comment

Choose a reason for hiding this comment

gleocadie commented Nov 27, 2024

gleocadie commented Nov 29, 2024

andrewlock left a comment

Choose a reason for hiding this comment

andrewlock Nov 29, 2024

Choose a reason for hiding this comment

gleocadie Nov 29, 2024 • edited Loading

Choose a reason for hiding this comment

gleocadie commented Nov 25, 2024 •

edited

Loading

andrewlock commented Nov 25, 2024 •

edited

Loading

datadog-ddstaging bot commented Nov 25, 2024 •

edited

Loading

andrewlock commented Nov 25, 2024 •

edited

Loading

andrewlock commented Nov 25, 2024 •

edited

Loading

gleocadie Nov 29, 2024 •

edited

Loading