-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove RuntimeMetricsShutdownSmokeTest #6317
Conversation
closing in favor of #6316 |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6317) - mean (72ms) : 63, 80
. : milestone, 72,
master - mean (72ms) : 64, 79
. : milestone, 72,
section CallTarget+Inlining+NGEN
This PR (6317) - mean (1,109ms) : 1090, 1127
. : milestone, 1109,
master - mean (1,107ms) : 1090, 1125
. : milestone, 1107,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6317) - mean (109ms) : 106, 111
. : milestone, 109,
master - mean (109ms) : 106, 111
. : milestone, 109,
section CallTarget+Inlining+NGEN
This PR (6317) - mean (771ms) : 755, 787
. : milestone, 771,
master - mean (768ms) : 753, 782
. : milestone, 768,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6317) - mean (92ms) : 90, 94
. : milestone, 92,
master - mean (92ms) : 89, 94
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6317) - mean (727ms) : 711, 743
. : milestone, 727,
master - mean (724ms) : 710, 738
. : milestone, 724,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6317) - mean (191ms) : 185, 196
. : milestone, 191,
master - mean (191ms) : 183, 200
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6317) - mean (1,212ms) : 1191, 1232
. : milestone, 1212,
master - mean (1,210ms) : 1186, 1234
. : milestone, 1210,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6317) - mean (276ms) : 271, 281
. : milestone, 276,
master - mean (276ms) : 272, 281
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6317) - mean (943ms) : 921, 966
. : milestone, 943,
master - mean (947ms) : 927, 967
. : milestone, 947,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6317) - mean (266ms) : 263, 270
. : milestone, 266,
master - mean (266ms) : 261, 270
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (6317) - mean (933ms) : 914, 952
. : milestone, 933,
master - mean (930ms) : 912, 949
. : milestone, 930,
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6317) (11.137M) : 0, 11136606
master (10.953M) : 0, 10953423
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6317) (7.273M) : 0, 7272608
master (7.258M) : 0, 7258128
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.591M) : 0, 7590970
section Manual
master (11.208M) : 0, 11207771
section Manual + Automatic
This PR (6317) (6.615M) : 0, 6615135
master (6.722M) : 0, 6721955
section DD_TRACE_ENABLED=0
master (10.178M) : 0, 10178373
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6317) (9.658M) : 0, 9657946
master (9.269M) : 0, 9268938
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6317) (6.421M) : 0, 6421136
master (6.299M) : 0, 6299432
section Trace stats
master (6.605M) : 0, 6605300
section Manual
master (9.212M) : 0, 9211628
section Manual + Automatic
This PR (6317) (5.997M) : 0, 5997039
master (5.797M) : 0, 5796944
section DD_TRACE_ENABLED=0
master (8.676M) : 0, 8675777
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6317) (8.760M) : 0, 8760449
master (9.183M) : 0, 9182720
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6317) (5.777M) : crit ,0, 5776766
master (6.143M) : 0, 6143036
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (6.605M) : 0, 6604886
section Manual
master (9.047M) : 0, 9046916
section Manual + Automatic
This PR (6317) (5.472M) : 0, 5471878
master (5.730M) : 0, 5730049
section DD_TRACE_ENABLED=0
master (8.828M) : 0, 8828238
|
Benchmarks Report for tracer 🐌Benchmarks for #6317 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️
|
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.137 | 453.29 | 398.78 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 452ns | 0.784ns | 3.03ns | 0.00815 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 595ns | 1.21ns | 4.7ns | 0.00785 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 659ns | 1.25ns | 4.83ns | 0.0916 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 484ns | 0.751ns | 2.91ns | 0.00985 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 768ns | 1.32ns | 5.11ns | 0.00953 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 845ns | 2.72ns | 10.5ns | 0.105 | 0 | 0 | 658 B |
#6317 | StartFinishSpan |
net6.0 | 398ns | 0.544ns | 2.11ns | 0.00809 | 0 | 0 | 576 B |
#6317 | StartFinishSpan |
netcoreapp3.1 | 631ns | 0.687ns | 2.66ns | 0.00791 | 0 | 0 | 576 B |
#6317 | StartFinishSpan |
net472 | 684ns | 1.29ns | 5.01ns | 0.0917 | 0 | 0 | 578 B |
#6317 | StartFinishScope |
net6.0 | 495ns | 0.329ns | 1.23ns | 0.00967 | 0 | 0 | 696 B |
#6317 | StartFinishScope |
netcoreapp3.1 | 742ns | 2.02ns | 7.82ns | 0.0093 | 0 | 0 | 696 B |
#6317 | StartFinishScope |
net472 | 922ns | 2.01ns | 7.79ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6317
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1
1.129
898.50
1,014.35
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 | 1.129 | 898.50 | 1,014.35 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 599ns | 1.38ns | 5.35ns | 0.00976 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 898ns | 1.15ns | 4.46ns | 0.00942 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.04μs | 2.57ns | 9.96ns | 0.104 | 0 | 0 | 658 B |
#6317 | RunOnMethodBegin |
net6.0 | 661ns | 1.39ns | 5.37ns | 0.00961 | 0 | 0 | 696 B |
#6317 | RunOnMethodBegin |
netcoreapp3.1 | 1.01μs | 2.3ns | 8.91ns | 0.0091 | 0 | 0 | 696 B |
#6317 | RunOnMethodBegin |
net472 | 1.08μs | 2.6ns | 10.1ns | 0.104 | 0 | 0 | 658 B |
Summary of changes
PR to remove the runtime metrics shutdown smoke test
Reason for change
The test regularly fails due to a runtime bug when doing dispose.
Implementation details
Remove the test