-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CMake warnings #6309
Fix CMake warnings #6309
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6309) - mean (72ms) : 64, 79
. : milestone, 72,
master - mean (72ms) : 64, 79
. : milestone, 72,
section CallTarget+Inlining+NGEN
This PR (6309) - mean (1,110ms) : 1091, 1129
. : milestone, 1110,
master - mean (1,107ms) : 1090, 1125
. : milestone, 1107,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6309) - mean (108ms) : 106, 111
. : milestone, 108,
master - mean (109ms) : 106, 111
. : milestone, 109,
section CallTarget+Inlining+NGEN
This PR (6309) - mean (771ms) : 752, 791
. : milestone, 771,
master - mean (768ms) : 753, 782
. : milestone, 768,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6309) - mean (92ms) : 89, 95
. : milestone, 92,
master - mean (92ms) : 89, 94
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6309) - mean (727ms) : 712, 743
. : milestone, 727,
master - mean (724ms) : 710, 738
. : milestone, 724,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6309) - mean (191ms) : 186, 196
. : milestone, 191,
master - mean (191ms) : 183, 200
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6309) - mean (1,213ms) : 1194, 1231
. : milestone, 1213,
master - mean (1,210ms) : 1186, 1234
. : milestone, 1210,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6309) - mean (276ms) : 271, 281
. : milestone, 276,
master - mean (276ms) : 272, 281
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6309) - mean (944ms) : 928, 961
. : milestone, 944,
master - mean (947ms) : 927, 967
. : milestone, 947,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6309) - mean (266ms) : 260, 271
. : milestone, 266,
master - mean (266ms) : 261, 270
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (6309) - mean (930ms) : 913, 948
. : milestone, 930,
master - mean (930ms) : 912, 949
. : milestone, 930,
|
Benchmarks Report for tracer 🐌Benchmarks for #6309 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Slower
|
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 | 1.125 | 484.24 | 544.75 |
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.151 | 453.29 | 393.98 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 452ns | 0.784ns | 3.03ns | 0.00815 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 595ns | 1.21ns | 4.7ns | 0.00785 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 659ns | 1.25ns | 4.83ns | 0.0916 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 484ns | 0.751ns | 2.91ns | 0.00985 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 768ns | 1.32ns | 5.11ns | 0.00953 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 845ns | 2.72ns | 10.5ns | 0.105 | 0 | 0 | 658 B |
#6309 | StartFinishSpan |
net6.0 | 393ns | 0.764ns | 2.96ns | 0.00819 | 0 | 0 | 576 B |
#6309 | StartFinishSpan |
netcoreapp3.1 | 645ns | 1.52ns | 5.89ns | 0.00777 | 0 | 0 | 576 B |
#6309 | StartFinishSpan |
net472 | 658ns | 1.86ns | 7.22ns | 0.0916 | 0 | 0 | 578 B |
#6309 | StartFinishScope |
net6.0 | 544ns | 1.57ns | 6.06ns | 0.00989 | 0 | 0 | 696 B |
#6309 | StartFinishScope |
netcoreapp3.1 | 698ns | 1.25ns | 4.84ns | 0.00914 | 0 | 0 | 696 B |
#6309 | StartFinishScope |
net472 | 864ns | 1.88ns | 7.29ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6309
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472
1.117
1,044.09
1,166.44
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 | 1.117 | 1,044.09 | 1,166.44 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 599ns | 1.38ns | 5.35ns | 0.00976 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 898ns | 1.15ns | 4.46ns | 0.00942 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.04μs | 2.57ns | 9.96ns | 0.104 | 0 | 0 | 658 B |
#6309 | RunOnMethodBegin |
net6.0 | 586ns | 0.698ns | 2.7ns | 0.00968 | 0 | 0 | 696 B |
#6309 | RunOnMethodBegin |
netcoreapp3.1 | 918ns | 1.68ns | 6.51ns | 0.00943 | 0 | 0 | 696 B |
#6309 | RunOnMethodBegin |
net472 | 1.17μs | 2.26ns | 8.75ns | 0.104 | 0 | 0 | 658 B |
Datadog ReportBranch report: ✅ 0 Failed, 460977 Passed, 3899 Skipped, 33h 56m 8.19s Total Time |
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6309) (10.933M) : 0, 10932527
master (10.953M) : 0, 10953423
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6309) (7.209M) : 0, 7209142
master (7.258M) : 0, 7258128
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.591M) : 0, 7590970
section Manual
master (11.208M) : 0, 11207771
section Manual + Automatic
This PR (6309) (6.656M) : 0, 6656168
master (6.722M) : 0, 6721955
section DD_TRACE_ENABLED=0
master (10.178M) : 0, 10178373
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6309) (9.423M) : 0, 9422623
master (9.269M) : 0, 9268938
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6309) (6.412M) : 0, 6412463
master (6.299M) : 0, 6299432
section Trace stats
master (6.605M) : 0, 6605300
section Manual
master (9.212M) : 0, 9211628
section Manual + Automatic
This PR (6309) (5.901M) : 0, 5901223
master (5.797M) : 0, 5796944
section DD_TRACE_ENABLED=0
master (8.676M) : 0, 8675777
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6309) (9.405M) : 0, 9404550
master (9.183M) : 0, 9182720
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6309) (6.073M) : 0, 6073331
master (6.143M) : 0, 6143036
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (6.605M) : 0, 6604886
section Manual
master (9.047M) : 0, 9046916
section Manual + Automatic
This PR (6309) (5.564M) : 0, 5564207
master (5.730M) : 0, 5730049
section DD_TRACE_ENABLED=0
master (8.828M) : 0, 8828238
|
b2c6d2c
to
c25e5bd
Compare
Summary of changes
Fixes CMake warnings
Reason for change
Because ....