Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Package Versions Bump] Updating package versions #6279

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Updates the package versions for integration tests.

@github-actions github-actions bot requested review from a team as code owners November 13, 2024 17:18
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Nov 13, 2024

Datadog Report

Branch report: bot/test-package-versions-bump
Commit report: 18df3e6
Test service: dd-trace-dotnet

✅ 0 Failed, 453020 Passed, 2735 Skipped, 19h 42m 10.88s Total Time

@andrewlock
Copy link
Member

andrewlock commented Nov 13, 2024

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6279) - mean (71ms)  : 64, 78
     .   : milestone, 71,
    master - mean (71ms)  : 65, 78
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (6279) - mean (980ms)  : 953, 1008
     .   : milestone, 980,
    master - mean (981ms)  : 960, 1003
     .   : milestone, 981,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6279) - mean (108ms)  : 106, 111
     .   : milestone, 108,
    master - mean (108ms)  : 106, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6279) - mean (680ms)  : 667, 694
     .   : milestone, 680,
    master - mean (683ms)  : 665, 702
     .   : milestone, 683,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6279) - mean (92ms)  : 89, 95
     .   : milestone, 92,
    master - mean (92ms)  : 89, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6279) - mean (636ms)  : 618, 653
     .   : milestone, 636,
    master - mean (638ms)  : 623, 653
     .   : milestone, 638,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6279) - mean (190ms)  : 185, 196
     .   : milestone, 190,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6279) - mean (1,103ms)  : 1069, 1138
     .   : milestone, 1103,
    master - mean (1,094ms)  : 1072, 1115
     .   : milestone, 1094,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6279) - mean (276ms)  : 272, 280
     .   : milestone, 276,
    master - mean (276ms)  : 272, 279
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6279) - mean (875ms)  : 842, 907
     .   : milestone, 875,
    master - mean (875ms)  : 850, 900
     .   : milestone, 875,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6279) - mean (265ms)  : 260, 270
     .   : milestone, 265,
    master - mean (264ms)  : 260, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6279) - mean (854ms)  : 816, 893
     .   : milestone, 854,
    master - mean (854ms)  : 825, 884
     .   : milestone, 854,

Loading


<!-- Integration: Microsoft.Extensions.Telemetry -->
<!-- Assembly: Microsoft.Extensions.Telemetry -->
<!-- Latest package https://www.nuget.org/packages/Microsoft.Extensions.Telemetry/8.10.0 -->
<!-- Latest package https://www.nuget.org/packages/Microsoft.Extensions.Telemetry/9.0.0 -->
<PackageReference Include="Microsoft.Extensions.Telemetry" Version="8.10.0" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one probably needs updating

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 It looks like we have already updated to support 9.x on that one, just not updated the json matrix I think

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the matrix in this PR so 🤞

<!-- Latest package https://www.nuget.org/packages/System.Data.SqlClient/4.8.6 -->
<PackageReference Include="System.Data.SqlClient" Version="4.8.6" />
<!-- Latest package https://www.nuget.org/packages/System.Data.SqlClient/4.9.0 -->
<PackageReference Include="System.Data.SqlClient" Version="4.9.0" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing some strange failures here, haven't looked into them

System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
18:16:34 [DBG]   ---> System.PlatformNotSupportedException: System.Data.SqlClient is not supported on this platform.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like they just killed it for EOL runtimes to me - we'll need to tweak the json to remove it:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done on a commit to this branch

@andrewlock
Copy link
Member

andrewlock commented Nov 13, 2024

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6279) (11.266M)   : 0, 11265933
    master (11.216M)   : 0, 11215877
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6279) (7.277M)   : 0, 7277060
    master (7.356M)   : 0, 7355647
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.653M)   : 0, 7652612

    section Manual
    master (11.177M)   : 0, 11177132

    section Manual + Automatic
    This PR (6279) (6.810M)   : 0, 6809930
    master (6.722M)   : 0, 6722247

    section DD_TRACE_ENABLED=0
    master (10.246M)   : 0, 10246375

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6279) (9.481M)   : 0, 9480646
    master (9.495M)   : 0, 9495372
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6279) (6.416M)   : 0, 6415946
    master (6.445M)   : 0, 6445315

    section Trace stats
    master (6.617M)   : 0, 6617151

    section Manual
    master (9.564M)   : 0, 9564169

    section Manual + Automatic
    This PR (6279) (5.928M)   : 0, 5927534
    master (5.943M)   : 0, 5943103

    section DD_TRACE_ENABLED=0
    master (8.993M)   : 0, 8992941

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6279) (9.118M)   : 0, 9117515
    master (8.980M)   : 0, 8980408
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6279) (5.984M)   : 0, 5984075
    master (5.865M)   : 0, 5865070
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.446M)   : 0, 6446474

    section Manual
    master (9.151M)   : 0, 9151083

    section Manual + Automatic
    This PR (6279) (5.659M)   : 0, 5658760
    master (5.595M)   : 0, 5594798

    section DD_TRACE_ENABLED=0
    master (8.375M)   : 0, 8375216

Loading

@github-actions github-actions bot force-pushed the bot/test-package-versions-bump branch from 316c2ad to 9e10789 Compare November 17, 2024 00:26
@andrewlock
Copy link
Member

andrewlock commented Nov 17, 2024

Benchmarks Report for tracer 🐌

Benchmarks for #6279 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.120
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.84μs 42.3ns 247ns 0.0112 0.00372 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.1μs 52.1ns 244ns 0.0145 0.00482 0 5.8 KB
master StartStopWithChild net472 16.1μs 65.2ns 252ns 1.04 0.3 0.0972 6.21 KB
#6279 StartStopWithChild net6.0 7.76μs 42.8ns 296ns 0.0155 0.00773 0 5.61 KB
#6279 StartStopWithChild netcoreapp3.1 10.1μs 55.7ns 369ns 0.0152 0.00505 0 5.8 KB
#6279 StartStopWithChild net472 16.3μs 48.3ns 187ns 1.04 0.3 0.0948 6.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 490μs 463ns 1.79μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 652μs 267ns 1μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 838μs 365ns 1.37μs 0.417 0 0 3.3 KB
#6279 WriteAndFlushEnrichedTraces net6.0 485μs 130ns 470ns 0 0 0 2.7 KB
#6279 WriteAndFlushEnrichedTraces netcoreapp3.1 652μs 377ns 1.46μs 0 0 0 2.7 KB
#6279 WriteAndFlushEnrichedTraces net472 834μs 479ns 1.86μs 0.417 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 150μs 860ns 6.93μs 0.148 0 0 14.47 KB
master SendRequest netcoreapp3.1 169μs 953ns 7.69μs 0.154 0 0 17.27 KB
master SendRequest net472 0.000269ns 0.000209ns 0.000783ns 0 0 0 0 b
#6279 SendRequest net6.0 148μs 867ns 8.09μs 0.142 0 0 14.47 KB
#6279 SendRequest netcoreapp3.1 165μs 903ns 5.27μs 0.158 0 0 17.27 KB
#6279 SendRequest net472 0.00142ns 0.000541ns 0.00203ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 586μs 2.86μs 11.8μs 0.553 0 0 41.77 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 673μs 3.4μs 15.2μs 0.331 0 0 41.74 KB
master WriteAndFlushEnrichedTraces net472 873μs 4.48μs 20μs 8.68 2.6 0.434 53.31 KB
#6279 WriteAndFlushEnrichedTraces net6.0 572μs 3.02μs 15.1μs 0.563 0 0 41.65 KB
#6279 WriteAndFlushEnrichedTraces netcoreapp3.1 675μs 2.31μs 8.33μs 0.326 0 0 41.74 KB
#6279 WriteAndFlushEnrichedTraces net472 887μs 3.51μs 14.1μs 8.39 2.52 0.419 53.33 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.34μs 0.985ns 3.69ns 0.0143 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.76μs 1.76ns 6.83ns 0.0131 0 0 1.02 KB
master ExecuteNonQuery net472 2.05μs 1.84ns 7.12ns 0.157 0.00103 0 987 B
#6279 ExecuteNonQuery net6.0 1.29μs 1.26ns 4.89ns 0.0144 0 0 1.02 KB
#6279 ExecuteNonQuery netcoreapp3.1 1.67μs 0.985ns 3.55ns 0.0135 0 0 1.02 KB
#6279 ExecuteNonQuery net472 2.17μs 0.799ns 2.99ns 0.157 0.00108 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.27μs 0.534ns 2ns 0.0133 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.55μs 0.877ns 3.28ns 0.0132 0 0 976 B
master CallElasticsearch net472 2.62μs 1.67ns 6.47ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.29μs 0.46ns 1.78ns 0.0136 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.66μs 0.788ns 2.95ns 0.014 0 0 1.02 KB
master CallElasticsearchAsync net472 2.57μs 1.6ns 5.97ns 0.167 0 0 1.05 KB
#6279 CallElasticsearch net6.0 1.17μs 0.341ns 1.28ns 0.0135 0 0 976 B
#6279 CallElasticsearch netcoreapp3.1 1.46μs 3.82ns 14.3ns 0.0131 0 0 976 B
#6279 CallElasticsearch net472 2.73μs 1.63ns 6.31ns 0.158 0 0 995 B
#6279 CallElasticsearchAsync net6.0 1.3μs 0.735ns 2.85ns 0.0136 0 0 952 B
#6279 CallElasticsearchAsync netcoreapp3.1 1.68μs 1.56ns 6.04ns 0.0141 0 0 1.02 KB
#6279 CallElasticsearchAsync net472 2.69μs 1.39ns 5.39ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.24μs 0.418ns 1.56ns 0.0131 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.69μs 0.393ns 1.42ns 0.0127 0 0 952 B
master ExecuteAsync net472 1.85μs 0.57ns 2.21ns 0.145 0 0 915 B
#6279 ExecuteAsync net6.0 1.27μs 0.527ns 2.04ns 0.0134 0 0 952 B
#6279 ExecuteAsync netcoreapp3.1 1.63μs 0.791ns 3.06ns 0.013 0 0 952 B
#6279 ExecuteAsync net472 1.8μs 1.06ns 4.1ns 0.144 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.44μs 2.22ns 8.6ns 0.0311 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.11μs 2.24ns 8.37ns 0.0383 0 0 2.85 KB
master SendAsync net472 7.19μs 2.21ns 8.57ns 0.493 0 0 3.12 KB
#6279 SendAsync net6.0 4.42μs 1.56ns 5.62ns 0.0328 0 0 2.31 KB
#6279 SendAsync netcoreapp3.1 5.21μs 5.1ns 19.8ns 0.0387 0 0 2.85 KB
#6279 SendAsync net472 7.33μs 2.15ns 8.33ns 0.495 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.55μs 0.814ns 3.04ns 0.0232 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.14μs 6.14ns 23.8ns 0.0214 0 0 1.64 KB
master EnrichedLog net472 2.65μs 1.55ns 6.02ns 0.249 0 0 1.57 KB
#6279 EnrichedLog net6.0 1.66μs 2.11ns 7.88ns 0.0228 0 0 1.64 KB
#6279 EnrichedLog netcoreapp3.1 2.21μs 1.67ns 6.24ns 0.022 0 0 1.64 KB
#6279 EnrichedLog net472 2.6μs 1.55ns 5.98ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 120μs 115ns 446ns 0.0599 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 124μs 92.3ns 357ns 0 0 0 4.28 KB
master EnrichedLog net472 152μs 137ns 529ns 0.684 0.228 0 4.46 KB
#6279 EnrichedLog net6.0 120μs 150ns 579ns 0.0597 0 0 4.28 KB
#6279 EnrichedLog netcoreapp3.1 123μs 183ns 708ns 0 0 0 4.28 KB
#6279 EnrichedLog net472 153μs 170ns 659ns 0.681 0.227 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.99μs 0.917ns 3.55ns 0.0314 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.1μs 1.36ns 4.91ns 0.0286 0 0 2.2 KB
master EnrichedLog net472 4.82μs 1.16ns 4.47ns 0.32 0 0 2.02 KB
#6279 EnrichedLog net6.0 3.13μs 1.09ns 4.23ns 0.0298 0 0 2.2 KB
#6279 EnrichedLog netcoreapp3.1 4.04μs 2.61ns 10.1ns 0.0284 0 0 2.2 KB
#6279 EnrichedLog net472 4.78μs 1.89ns 7.32ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6279

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 1.115 1,346.32 1,500.60

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.35μs 0.38ns 1.42ns 0.0162 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.73μs 0.869ns 3.25ns 0.0156 0 0 1.14 KB
master SendReceive net472 2.06μs 1.19ns 4.44ns 0.183 0 0 1.16 KB
#6279 SendReceive net6.0 1.5μs 0.77ns 2.98ns 0.0157 0 0 1.14 KB
#6279 SendReceive netcoreapp3.1 1.69μs 0.909ns 3.52ns 0.0153 0 0 1.14 KB
#6279 SendReceive net472 2.08μs 1.23ns 4.45ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.65μs 1.63ns 6.3ns 0.0226 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.96μs 2.55ns 9.89ns 0.022 0 0 1.65 KB
master EnrichedLog net472 4.35μs 3.38ns 13.1ns 0.322 0 0 2.04 KB
#6279 EnrichedLog net6.0 2.68μs 2.43ns 9.4ns 0.0215 0 0 1.6 KB
#6279 EnrichedLog netcoreapp3.1 3.88μs 11.4ns 44ns 0.0214 0 0 1.65 KB
#6279 EnrichedLog net472 4.5μs 2.62ns 10.1ns 0.324 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 399ns 0.725ns 2.81ns 0.00807 0 0 576 B
master StartFinishSpan netcoreapp3.1 590ns 1.42ns 5.51ns 0.00775 0 0 576 B
master StartFinishSpan net472 659ns 0.643ns 2.32ns 0.0916 0 0 578 B
master StartFinishScope net6.0 478ns 0.619ns 2.4ns 0.00968 0 0 696 B
master StartFinishScope netcoreapp3.1 705ns 1.06ns 4.1ns 0.0095 0 0 696 B
master StartFinishScope net472 844ns 1.45ns 5.62ns 0.105 0 0 658 B
#6279 StartFinishSpan net6.0 392ns 0.573ns 2.22ns 0.00815 0 0 576 B
#6279 StartFinishSpan netcoreapp3.1 583ns 0.811ns 3.03ns 0.00777 0 0 576 B
#6279 StartFinishSpan net472 720ns 1.28ns 4.95ns 0.0917 0 0 578 B
#6279 StartFinishScope net6.0 496ns 0.855ns 3.31ns 0.00975 0 0 696 B
#6279 StartFinishScope netcoreapp3.1 735ns 1.18ns 4.58ns 0.00909 0 0 696 B
#6279 StartFinishScope net472 883ns 1.56ns 6.05ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6279

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 1.126 1,056.41 1,189.55

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 656ns 0.758ns 2.94ns 0.00974 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 903ns 1.41ns 5.45ns 0.00941 0 0 696 B
master RunOnMethodBegin net472 1.06μs 1.46ns 5.66ns 0.105 0 0 658 B
#6279 RunOnMethodBegin net6.0 640ns 1.17ns 4.55ns 0.0097 0 0 696 B
#6279 RunOnMethodBegin netcoreapp3.1 890ns 1.67ns 6.47ns 0.00925 0 0 696 B
#6279 RunOnMethodBegin net472 1.19μs 2.17ns 8.4ns 0.104 0 0 658 B

@andrewlock andrewlock force-pushed the bot/test-package-versions-bump branch from 9e10789 to b53fbb0 Compare November 22, 2024 13:34
@github-actions github-actions bot force-pushed the bot/test-package-versions-bump branch from b53fbb0 to 7cbf98c Compare November 24, 2024 00:25
@andrewlock andrewlock force-pushed the bot/test-package-versions-bump branch from 7cbf98c to 5895064 Compare November 25, 2024 12:49
@andrewlock andrewlock requested a review from a team as a code owner November 25, 2024 14:16
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@andrewlock andrewlock merged commit 79b28b3 into master Nov 25, 2024
77 checks passed
@andrewlock andrewlock deleted the bot/test-package-versions-bump branch November 25, 2024 17:32
@github-actions github-actions bot added this to the vNext-v3 milestone Nov 25, 2024
veerbia pushed a commit that referenced this pull request Dec 16, 2024
Updates the package versions for integration tests.

---------

Co-authored-by: andrewlock <andrewlock@users.noreply.github.com>
Co-authored-by: Andrew Lock <andrew.lock@datadoghq.com>
@andrewlock andrewlock added dependencies Pull requests that update a dependency file area:dependabot dependabot updates area:integrations labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dependabot dependabot updates area:integrations dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants