add the filepath we check for datadog.json to the output of diagnostic tool #6273

chojomok · 2024-11-12T20:39:40Z

outputs configurationFileName in TryLoadJsonConfigurationFile and we print it

Summary of changes

add the directory where we look for datadog.json in the tracer logs and in the diagnostic tool

Reason for change

https://datadoghq.atlassian.net/browse/APMLP-297
Customer confusion over why their configuration isn't picked up.

Implementation details

Log where the directory we check the json for is.

Test coverage

Need to create a test to check this programmatically, but here's the results running it manually on IIS/Process (IIS check calls the process check)
datadog.json read:

datadog.json not read:

Other details

outputs `configurationFileName` in TryLoadJsonConfigurationFile and we print it

tracer/src/Datadog.Trace.Tools.dd_dotnet/Checks/ProcessConfiguration.cs

andrewlock · 2024-11-12T21:13:26Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6273) - mean (69ms)  : 67, 71
     .   : milestone, 69,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6273) - mean (979ms)  : 954, 1004
     .   : milestone, 979,
    master - mean (980ms)  : 957, 1004
     .   : milestone, 980,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6273) - mean (109ms)  : 106, 111
     .   : milestone, 109,
    master - mean (108ms)  : 105, 112
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6273) - mean (680ms)  : 664, 696
     .   : milestone, 680,
    master - mean (685ms)  : 667, 704
     .   : milestone, 685,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6273) - mean (92ms)  : 89, 94
     .   : milestone, 92,
    master - mean (92ms)  : 89, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6273) - mean (633ms)  : 614, 652
     .   : milestone, 633,
    master - mean (632ms)  : 616, 648
     .   : milestone, 632,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6273) - mean (190ms)  : 185, 195
     .   : milestone, 190,
    master - mean (190ms)  : 186, 195
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6273) - mean (1,085ms)  : 1059, 1110
     .   : milestone, 1085,
    master - mean (1,093ms)  : 1058, 1128
     .   : milestone, 1093,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6273) - mean (277ms)  : 273, 281
     .   : milestone, 277,
    master - mean (276ms)  : 272, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6273) - mean (868ms)  : 836, 901
     .   : milestone, 868,
    master - mean (866ms)  : 832, 900
     .   : milestone, 866,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6273) - mean (266ms)  : 262, 270
     .   : milestone, 266,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6273) - mean (849ms)  : 818, 880
     .   : milestone, 849,
    master - mean (896ms)  : 803, 990
     .   : milestone, 896,

datadog-ddstaging · 2024-11-12T21:41:33Z

Datadog Report

Branch report: mohammad/datadog_json_debug_log
Commit report: 4f23a42
Test service: dd-trace-dotnet

✅ 0 Failed, 450999 Passed, 2739 Skipped, 19h 6m 46.97s Total Time

andrewlock · 2024-11-12T23:04:47Z

Benchmarks Report for tracer 🐌

Benchmarks for #6273 compared to master:

1 benchmarks are faster, with geometric mean 1.151
2 benchmarks are slower, with geometric mean 1.172
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.97μs	42.9ns	235ns	0.00799	0	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.3μs	55.8ns	382ns	0.0203	0.0101	0	5.81 KB
master	`StartStopWithChild`	net472	16.3μs	47.8ns	179ns	1.04	0.298	0.0886	6.21 KB
#6273	`StartStopWithChild`	net6.0	7.89μs	42.4ns	236ns	0.024	0.012	0	5.61 KB
#6273	`StartStopWithChild`	netcoreapp3.1	10.3μs	58.8ns	428ns	0.0208	0.0104	0	5.8 KB
#6273	`StartStopWithChild`	net472	16.4μs	25.9ns	96.9ns	1.05	0.313	0.107	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	476μs	498ns	1.93μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	652μs	387ns	1.5μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	844μs	346ns	1.34μs	0.419	3.3 KB
#6273	`WriteAndFlushEnrichedTraces`	net6.0	481μs	227ns	850ns	0	2.7 KB
#6273	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	658μs	483ns	1.87μs	0	2.7 KB
#6273	`WriteAndFlushEnrichedTraces`	net472	851μs	422ns	1.63μs	0.425	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	151μs	882ns	8.18μs	0.163	14.47 KB
master	`SendRequest`	netcoreapp3.1	170μs	1.06μs	10.4μs	0.176	17.27 KB
master	`SendRequest`	net472	0.00274ns	0.000976ns	0.00378ns	0	0 b
#6273	`SendRequest`	net6.0	155μs	886ns	7.36μs	0.148	14.47 KB
#6273	`SendRequest`	netcoreapp3.1	170μs	996ns	9.29μs	0.161	17.27 KB
#6273	`SendRequest`	net472	0.000494ns	0.000438ns	0.00164ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	582μs	2.98μs	14.3μs	0.558	0	0	41.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	681μs	3.98μs	35.6μs	0.327	0	0	41.81 KB
master	`WriteAndFlushEnrichedTraces`	net472	829μs	3.84μs	14.9μs	8.12	2.44	0.406	53.3 KB
#6273	`WriteAndFlushEnrichedTraces`	net6.0	552μs	2.55μs	10.2μs	0.534	0	0	41.66 KB
#6273	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	681μs	3.78μs	23μs	0.329	0	0	41.8 KB
#6273	`WriteAndFlushEnrichedTraces`	net472	853μs	3.22μs	12.1μs	8.45	2.53	0.422	53.3 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.25μs	1ns	3.89ns	0.0143	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.73μs	1.41ns	5.29ns	0.013	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.09μs	2.33ns	9.03ns	0.156	0.00104	987 B
#6273	`ExecuteNonQuery`	net6.0	1.25μs	0.89ns	3.45ns	0.0144	0	1.02 KB
#6273	`ExecuteNonQuery`	netcoreapp3.1	1.76μs	1.09ns	4.22ns	0.0132	0	1.02 KB
#6273	`ExecuteNonQuery`	net472	2.11μs	1.56ns	6.06ns	0.157	0.00106	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.23μs	0.529ns	1.98ns	0.0135	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.65μs	0.639ns	2.39ns	0.0132	976 B
master	`CallElasticsearch`	net472	2.58μs	2.46ns	9.52ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.21μs	0.969ns	3.75ns	0.0133	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.57μs	0.575ns	2.15ns	0.0133	1.02 KB
master	`CallElasticsearchAsync`	net472	2.66μs	1.72ns	6.67ns	0.166	1.05 KB
#6273	`CallElasticsearch`	net6.0	1.18μs	0.478ns	1.79ns	0.0136	976 B
#6273	`CallElasticsearch`	netcoreapp3.1	1.56μs	1.17ns	4.38ns	0.0132	976 B
#6273	`CallElasticsearch`	net472	2.5μs	1.94ns	7.5ns	0.157	995 B
#6273	`CallElasticsearchAsync`	net6.0	1.24μs	0.596ns	2.23ns	0.0136	952 B
#6273	`CallElasticsearchAsync`	netcoreapp3.1	1.6μs	1.26ns	4.86ns	0.0136	1.02 KB
#6273	`CallElasticsearchAsync`	net472	2.64μs	1.05ns	3.8ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.37μs	1.37ns	5.13ns	0.0131	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.72μs	1.13ns	4.21ns	0.0129	952 B
master	`ExecuteAsync`	net472	1.81μs	0.823ns	3.19ns	0.145	915 B
#6273	`ExecuteAsync`	net6.0	1.29μs	0.369ns	1.43ns	0.0136	952 B
#6273	`ExecuteAsync`	netcoreapp3.1	1.65μs	1.5ns	5.79ns	0.0133	952 B
#6273	`ExecuteAsync`	net472	1.85μs	1.02ns	3.8ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.39μs	2.34ns	8.75ns	0.0328	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.31μs	1.6ns	6.18ns	0.037	2.85 KB
master	`SendAsync`	net472	7.48μs	1.86ns	7.21ns	0.493	3.12 KB
#6273	`SendAsync`	net6.0	4.39μs	1.65ns	6.37ns	0.0306	2.31 KB
#6273	`SendAsync`	netcoreapp3.1	5.26μs	3.24ns	12.5ns	0.037	2.85 KB
#6273	`SendAsync`	net472	7.35μs	2.76ns	10.7ns	0.493	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6273

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0	1.143	1,430.64	1,635.42

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.43μs	0.522ns	1.88ns	0.0229	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.26μs	0.877ns	3.28ns	0.0216	1.64 KB
master	`EnrichedLog`	net472	2.73μs	2.1ns	8.12ns	0.249	1.57 KB
#6273	`EnrichedLog`	net6.0	1.63μs	1.75ns	6.79ns	0.0229	1.64 KB
#6273	`EnrichedLog`	netcoreapp3.1	2.42μs	1.02ns	3.93ns	0.0227	1.64 KB
#6273	`EnrichedLog`	net472	2.66μs	1.36ns	5.09ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	119μs	123ns	477ns	0.0599	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	123μs	262ns	1.01μs	0.0615	0	4.28 KB
master	`EnrichedLog`	net472	151μs	180ns	699ns	0.683	0.228	4.46 KB
#6273	`EnrichedLog`	net6.0	118μs	286ns	1.11μs	0.0604	0	4.28 KB
#6273	`EnrichedLog`	netcoreapp3.1	124μs	169ns	654ns	0	0	4.28 KB
#6273	`EnrichedLog`	net472	152μs	99.2ns	384ns	0.682	0.227	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.02μs	1.13ns	4.23ns	0.0302	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.19μs	1.25ns	4.68ns	0.0294	2.2 KB
master	`EnrichedLog`	net472	4.86μs	1.26ns	4.87ns	0.319	2.02 KB
#6273	`EnrichedLog`	net6.0	3.12μs	2.13ns	7.69ns	0.0313	2.2 KB
#6273	`EnrichedLog`	netcoreapp3.1	4.32μs	2.13ns	8.25ns	0.0301	2.2 KB
#6273	`EnrichedLog`	net472	5.01μs	1.25ns	4.67ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.32μs	0.675ns	2.53ns	0.016	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.72μs	0.739ns	2.86ns	0.0154	1.14 KB
master	`SendReceive`	net472	2.06μs	2.04ns	7.89ns	0.183	1.16 KB
#6273	`SendReceive`	net6.0	1.47μs	0.614ns	2.38ns	0.0161	1.14 KB
#6273	`SendReceive`	netcoreapp3.1	1.72μs	0.839ns	3.25ns	0.0154	1.14 KB
#6273	`SendReceive`	net472	2.03μs	2.61ns	10.1ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.85μs	1.37ns	5.14ns	0.0228	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.97μs	1.99ns	7.72ns	0.0219	1.65 KB
master	`EnrichedLog`	net472	4.37μs	2.06ns	7.13ns	0.323	2.04 KB
#6273	`EnrichedLog`	net6.0	2.85μs	1.44ns	5.58ns	0.0215	1.6 KB
#6273	`EnrichedLog`	netcoreapp3.1	3.91μs	2.01ns	7.8ns	0.0211	1.65 KB
#6273	`EnrichedLog`	net472	4.48μs	3.92ns	15.2ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6273

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.201	483.30	580.51

Faster 🎉 in #6273

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.151	455.80	395.94

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	456ns	0.117ns	0.439ns	0.00819	576 B
master	`StartFinishSpan`	netcoreapp3.1	612ns	0.431ns	1.67ns	0.00783	576 B
master	`StartFinishSpan`	net472	701ns	0.35ns	1.35ns	0.0916	578 B
master	`StartFinishScope`	net6.0	483ns	0.207ns	0.803ns	0.00974	696 B
master	`StartFinishScope`	netcoreapp3.1	795ns	0.468ns	1.75ns	0.00919	696 B
master	`StartFinishScope`	net472	869ns	0.484ns	1.88ns	0.104	658 B
#6273	`StartFinishSpan`	net6.0	396ns	0.115ns	0.413ns	0.00798	576 B
#6273	`StartFinishSpan`	netcoreapp3.1	568ns	3.25ns	23.6ns	0.0079	576 B
#6273	`StartFinishSpan`	net472	743ns	0.484ns	1.87ns	0.0916	578 B
#6273	`StartFinishScope`	net6.0	580ns	0.352ns	1.36ns	0.00964	696 B
#6273	`StartFinishScope`	netcoreapp3.1	744ns	0.558ns	2.16ns	0.00973	696 B
#6273	`StartFinishScope`	net472	883ns	0.287ns	1.11ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	685ns	0.359ns	1.39ns	0.00954	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	955ns	0.461ns	1.79ns	0.00954	696 B
master	`RunOnMethodBegin`	net472	1.11μs	0.797ns	2.87ns	0.105	658 B
#6273	`RunOnMethodBegin`	net6.0	660ns	0.24ns	0.899ns	0.00961	696 B
#6273	`RunOnMethodBegin`	netcoreapp3.1	1μs	0.558ns	2.09ns	0.00909	696 B
#6273	`RunOnMethodBegin`	net472	1.12μs	0.688ns	2.57ns	0.104	658 B

andrewlock · 2024-11-12T23:27:07Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6273) (11.281M)   : 0, 11281282
    master (11.227M)   : 0, 11226681
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6273) (7.334M)   : 0, 7334272
    master (7.304M)   : 0, 7304407
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.538M)   : 0, 7538390

    section Manual
    master (11.369M)   : 0, 11369387

    section Manual + Automatic
    This PR (6273) (6.824M)   : 0, 6824232
    master (6.752M)   : 0, 6752251

    section DD_TRACE_ENABLED=0
    master (10.342M)   : 0, 10342303

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6273) (9.762M)   : 0, 9761795
    master (9.354M)   : 0, 9354138
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6273) (6.414M)   : 0, 6414118
    master (6.353M)   : 0, 6353370

    section Trace stats
    master (6.599M)   : 0, 6598729

    section Manual
    master (9.476M)   : 0, 9475552

    section Manual + Automatic
    This PR (6273) (5.969M)   : 0, 5969411
    master (5.943M)   : 0, 5942843

    section DD_TRACE_ENABLED=0
    master (8.875M)   : 0, 8875031

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6273) (10.385M)   : 0, 10385248
    master (10.132M)   : 0, 10131852
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6273) (6.725M)   : 0, 6725095
    master (6.697M)   : 0, 6696840
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.321M)   : 0, 7320806

    section Manual
    master (10.073M)   : 0, 10072874

    section Manual + Automatic
    This PR (6273) (6.239M)   : 0, 6238618
    master (6.233M)   : 0, 6232865

    section DD_TRACE_ENABLED=0
    master (9.544M)   : 0, 9544007

bouwkast

I think it's good

Left a comment for a potential improvement, but I'm unsure if it'd help or be worthwhile.
IMO (and I may be wrong) but making a test for this isn't too important

tracer/src/Datadog.Trace.Tools.dd_dotnet/Checks/ProcessConfiguration.cs

…c tool (#6273) outputs `configurationFileName` in TryLoadJsonConfigurationFile and we print it ## Summary of changes add the directory where we look for `datadog.json` in the tracer logs and in the diagnostic tool ## Reason for change https://datadoghq.atlassian.net/browse/APMLP-297 Customer confusion over why their configuration isn't picked up. ## Implementation details Log where the directory we check the json for is. ## Test coverage Need to create a test to check this programmatically in the future, but here's the results running it manually on IIS/Process (IIS check calls the process check) datadog.json read: ![image](https://github.com/user-attachments/assets/8614c834-e08d-47af-8135-f5a10000ca4d) datadog.json not read: ![image](https://github.com/user-attachments/assets/c49fe373-47da-47e6-b604-29d673d93533) ## Other details

add json directory output to diag tool

5c2dca9

outputs `configurationFileName` in TryLoadJsonConfigurationFile and we print it

chojomok requested a review from a team as a code owner November 12, 2024 20:39

Merge branch 'master' into mohammad/datadog_json_debug_log

b541379

bouwkast reviewed Nov 12, 2024

View reviewed changes

tracer/src/Datadog.Trace.Tools.dd_dotnet/Checks/ProcessConfiguration.cs Outdated Show resolved Hide resolved

dynamic info log based on if json exists

42fde7b

fixed spacing whoops

7f2dc85

bouwkast approved these changes Nov 13, 2024

View reviewed changes

tracer/src/Datadog.Trace.Tools.dd_dotnet/Checks/ProcessConfiguration.cs Show resolved Hide resolved

Merge branch 'master' into mohammad/datadog_json_debug_log

de40196

chojomok changed the title ~~WIP add json directory output to diag tool~~ add the filepath we check for datadog.json to the output of diagnostic tool Nov 18, 2024

chojomok added 3 commits November 21, 2024 16:55

Merge branch 'master' into mohammad/datadog_json_debug_log

77811cb

Merge branch 'master' into mohammad/datadog_json_debug_log

1332da8

Merge branch 'master' into mohammad/datadog_json_debug_log

4f23a42

link04 approved these changes Dec 9, 2024

View reviewed changes

chojomok merged commit ca37528 into master Dec 9, 2024
104 checks passed

chojomok deleted the mohammad/datadog_json_debug_log branch December 9, 2024 21:46

github-actions bot added this to the vNext-v3 milestone Dec 9, 2024

robertpi added area:shared-components area:builds project files, build scripts, pipelines, versioning, releases, packages labels Dec 18, 2024

andrewlock added area:tools and removed area:builds project files, build scripts, pipelines, versioning, releases, packages area:shared-components labels Dec 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add the filepath we check for datadog.json to the output of diagnostic tool #6273

add the filepath we check for datadog.json to the output of diagnostic tool #6273

chojomok commented Nov 12, 2024 •

edited

Loading

andrewlock commented Nov 12, 2024 •

edited

Loading

datadog-ddstaging bot commented Nov 12, 2024 •

edited

Loading

andrewlock commented Nov 12, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6273

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6273

Faster 🎉 in #6273

Raw results

Raw results

andrewlock commented Nov 12, 2024 •

edited

Loading

bouwkast left a comment

add the filepath we check for datadog.json to the output of diagnostic tool #6273

add the filepath we check for datadog.json to the output of diagnostic tool #6273

Conversation

chojomok commented Nov 12, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

andrewlock commented Nov 12, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

datadog-ddstaging bot commented Nov 12, 2024 • edited Loading

Datadog Report

andrewlock commented Nov 12, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6273

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6273

Faster 🎉 in #6273

Raw results

Raw results

andrewlock commented Nov 12, 2024 • edited Loading

Throughput/Crank Report ⚡

bouwkast left a comment

Choose a reason for hiding this comment

chojomok commented Nov 12, 2024 •

edited

Loading

andrewlock commented Nov 12, 2024 •

edited

Loading

datadog-ddstaging bot commented Nov 12, 2024 •

edited

Loading

andrewlock commented Nov 12, 2024 •

edited

Loading

andrewlock commented Nov 12, 2024 •

edited

Loading