Fix subtle WCF bug #6131

andrewlock · 2024-10-08T18:40:27Z

Summary of changes

Fix the precedence bug

Reason for change

The order of precedence is wrong with the use of ?? false, so the second condition is never checked

Implementation details

Make the null check explicit

Test coverage

Meh, this seems like a tricky case to check so YOLO?

datadog-ddstaging · 2024-10-08T19:20:35Z

Datadog Report

Branch report: andrew/fix-wcf-bug
Commit report: 5bb2da3
Test service: dd-trace-dotnet

✅ 0 Failed, 364916 Passed, 2084 Skipped, 15h 5m 24.83s Total Time

andrewlock · 2024-10-08T19:29:06Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6131) - mean (71ms)  : 67, 74
     .   : milestone, 71,
    master - mean (70ms)  : 68, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6131) - mean (1,108ms)  : 1083, 1133
     .   : milestone, 1108,
    master - mean (1,109ms)  : 1088, 1130
     .   : milestone, 1109,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6131) - mean (110ms)  : 106, 113
     .   : milestone, 110,
    master - mean (110ms)  : 108, 113
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (6131) - mean (776ms)  : 759, 792
     .   : milestone, 776,
    master - mean (781ms)  : 765, 796
     .   : milestone, 781,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6131) - mean (93ms)  : 91, 95
     .   : milestone, 93,
    master - mean (93ms)  : 91, 95
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6131) - mean (731ms)  : 711, 752
     .   : milestone, 731,
    master - mean (739ms)  : 718, 761
     .   : milestone, 739,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6131) - mean (194ms)  : 186, 201
     .   : milestone, 194,
    master - mean (191ms)  : 187, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6131) - mean (1,203ms)  : 1161, 1244
     .   : milestone, 1203,
    master - mean (1,197ms)  : 1171, 1222
     .   : milestone, 1197,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6131) - mean (276ms)  : 272, 280
     .   : milestone, 276,
    master - mean (277ms)  : 271, 282
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6131) - mean (939ms)  : 923, 955
     .   : milestone, 939,
    master - mean (942ms)  : 924, 960
     .   : milestone, 942,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6131) - mean (265ms)  : 260, 271
     .   : milestone, 265,
    master - mean (268ms)  : 262, 273
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (6131) - mean (930ms)  : 909, 951
     .   : milestone, 930,
    master - mean (937ms)  : 916, 958
     .   : milestone, 937,

bouwkast

Thanks!

andrewlock · 2024-10-08T20:42:53Z

Benchmarks Report for tracer 🐌

Benchmarks for #6131 compared to master:

2 benchmarks are faster, with geometric mean 1.145
2 benchmarks are slower, with geometric mean 1.153
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.83μs	43.8ns	270ns	0.0149	0.00744	0	5.43 KB
master	`StartStopWithChild`	netcoreapp3.1	9.81μs	54.2ns	347ns	0.0189	0.00945	0	5.61 KB
master	`StartStopWithChild`	net472	16.8μs	75ns	291ns	1.02	0.311	0.0864	6.06 KB
#6131	`StartStopWithChild`	net6.0	7.96μs	45ns	298ns	0.0152	0.00759	0	5.43 KB
#6131	`StartStopWithChild`	netcoreapp3.1	9.83μs	53.7ns	318ns	0.0195	0.00975	0	5.62 KB
#6131	`StartStopWithChild`	net472	16.3μs	47.7ns	185ns	1.03	0.293	0.0978	6.07 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	499μs	216ns	778ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	648μs	730ns	2.83μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	826μs	214ns	828ns	0.414	3.3 KB
#6131	`WriteAndFlushEnrichedTraces`	net6.0	498μs	438ns	1.7μs	0	2.7 KB
#6131	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	644μs	2.76μs	13.5μs	0	2.7 KB
#6131	`WriteAndFlushEnrichedTraces`	net472	842μs	509ns	1.9μs	0.422	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	192μs	1.07μs	6.66μs	0.147	18.45 KB
master	`SendRequest`	netcoreapp3.1	218μs	1.18μs	8.24μs	0.217	20.61 KB
master	`SendRequest`	net472	0.00176ns	0.000702ns	0.00272ns	0	0 b
#6131	`SendRequest`	net6.0	210μs	1.33μs	13.2μs	0.182	18.45 KB
#6131	`SendRequest`	netcoreapp3.1	228μs	1.4μs	13.5μs	0.206	20.61 KB
#6131	`SendRequest`	net472	0.0022ns	0.000955ns	0.0037ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6131

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.75 KB	41.43 KB	-323 B	-0.77%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	576μs	1.64μs	6.12μs	0.553	0	0	41.75 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	699μs	3.53μs	16.6μs	0.336	0	0	41.73 KB
master	`WriteAndFlushEnrichedTraces`	net472	852μs	3.34μs	12.9μs	8.45	2.53	0.422	53.28 KB
#6131	`WriteAndFlushEnrichedTraces`	net6.0	559μs	2.58μs	9.65μs	0.563	0	0	41.43 KB
#6131	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	752μs	4.06μs	27.8μs	0.393	0	0	41.57 KB
#6131	`WriteAndFlushEnrichedTraces`	net472	852μs	3.26μs	12.6μs	8.39	2.52	0.419	53.29 KB

Benchmarks.Trace.DbCommandBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6131

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0	1.134	1,361.15	1,200.62

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.36μs	1.25ns	4.84ns	0.014	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.75μs	1.7ns	6.58ns	0.0139	1.02 KB
master	`ExecuteNonQuery`	net472	2.15μs	1.75ns	6.57ns	0.157	987 B
#6131	`ExecuteNonQuery`	net6.0	1.2μs	1.25ns	4.85ns	0.0144	1.02 KB
#6131	`ExecuteNonQuery`	netcoreapp3.1	1.72μs	1.53ns	5.71ns	0.0139	1.02 KB
#6131	`ExecuteNonQuery`	net472	2.19μs	3.64ns	14.1ns	0.156	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.17μs	0.644ns	2.41ns	0.0135	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.49μs	1.09ns	4.22ns	0.0129	976 B
master	`CallElasticsearch`	net472	2.5μs	1.29ns	5ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.28μs	0.913ns	3.42ns	0.0134	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.6μs	0.532ns	1.99ns	0.0136	1.02 KB
master	`CallElasticsearchAsync`	net472	2.57μs	1.07ns	4.01ns	0.167	1.05 KB
#6131	`CallElasticsearch`	net6.0	1.23μs	1.14ns	4.43ns	0.0133	976 B
#6131	`CallElasticsearch`	netcoreapp3.1	1.58μs	1.06ns	4.11ns	0.0135	976 B
#6131	`CallElasticsearch`	net472	2.58μs	0.851ns	3.3ns	0.157	995 B
#6131	`CallElasticsearchAsync`	net6.0	1.18μs	0.75ns	2.9ns	0.0135	952 B
#6131	`CallElasticsearchAsync`	netcoreapp3.1	1.57μs	0.598ns	2.24ns	0.0134	1.02 KB
#6131	`CallElasticsearchAsync`	net472	2.55μs	2.08ns	8.06ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.25μs	2.17ns	8.41ns	0.0131	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.61μs	1.36ns	5.07ns	0.0129	952 B
master	`ExecuteAsync`	net472	1.9μs	0.723ns	2.8ns	0.144	915 B
#6131	`ExecuteAsync`	net6.0	1.2μs	0.281ns	1.01ns	0.0132	952 B
#6131	`ExecuteAsync`	netcoreapp3.1	1.55μs	0.642ns	2.4ns	0.0132	952 B
#6131	`ExecuteAsync`	net472	1.85μs	2.23ns	8.62ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.11μs	2.8ns	10.5ns	0.0308	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.16μs	3.69ns	14.3ns	0.0361	2.76 KB
master	`SendAsync`	net472	7.75μs	5.08ns	19ns	0.498	3.15 KB
#6131	`SendAsync`	net6.0	4.28μs	1.73ns	6.71ns	0.03	2.22 KB
#6131	`SendAsync`	netcoreapp3.1	5.1μs	2.29ns	8.87ns	0.0356	2.76 KB
#6131	`SendAsync`	net472	7.8μs	1.65ns	6.41ns	0.497	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.44μs	0.626ns	2.34ns	0.023	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.22μs	1.67ns	6.24ns	0.0223	1.64 KB
master	`EnrichedLog`	net472	2.54μs	1.09ns	4.07ns	0.249	1.57 KB
#6131	`EnrichedLog`	net6.0	1.46μs	0.647ns	2.51ns	0.0233	1.64 KB
#6131	`EnrichedLog`	netcoreapp3.1	2.2μs	1.77ns	6.63ns	0.0218	1.64 KB
#6131	`EnrichedLog`	net472	2.51μs	0.8ns	3.1ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	114μs	128ns	495ns	0.0567	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	117μs	166ns	644ns	0.0588	0	4.28 KB
master	`EnrichedLog`	net472	146μs	134ns	519ns	0.654	0.218	4.46 KB
#6131	`EnrichedLog`	net6.0	115μs	121ns	467ns	0.0572	0	4.28 KB
#6131	`EnrichedLog`	netcoreapp3.1	119μs	266ns	1.03μs	0	0	4.28 KB
#6131	`EnrichedLog`	net472	147μs	128ns	494ns	0.661	0.22	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.06μs	1.91ns	7.39ns	0.0305	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.3μs	1.99ns	7.69ns	0.0302	2.2 KB
master	`EnrichedLog`	net472	4.85μs	2ns	7.49ns	0.32	2.02 KB
#6131	`EnrichedLog`	net6.0	3.03μs	2.68ns	10ns	0.0303	2.2 KB
#6131	`EnrichedLog`	netcoreapp3.1	4.08μs	9.8ns	37.9ns	0.0284	2.2 KB
#6131	`EnrichedLog`	net472	4.98μs	0.899ns	3.48ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.35μs	0.772ns	2.89ns	0.0161	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.83μs	0.869ns	3.37ns	0.0155	0	1.14 KB
master	`SendReceive`	net472	2.14μs	1.73ns	6.7ns	0.183	0.00108	1.16 KB
#6131	`SendReceive`	net6.0	1.39μs	1.54ns	5.96ns	0.0157	0	1.14 KB
#6131	`SendReceive`	netcoreapp3.1	1.79μs	2.08ns	8.06ns	0.0154	0	1.14 KB
#6131	`SendReceive`	net472	2.1μs	1.68ns	6.52ns	0.183	0	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.67μs	1.16ns	4.48ns	0.0214	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.81μs	1.71ns	6.61ns	0.0211	1.65 KB
master	`EnrichedLog`	net472	4.46μs	2.37ns	8.87ns	0.322	2.04 KB
#6131	`EnrichedLog`	net6.0	2.69μs	0.709ns	2.74ns	0.0215	1.6 KB
#6131	`EnrichedLog`	netcoreapp3.1	4.07μs	1.69ns	6.54ns	0.0203	1.65 KB
#6131	`EnrichedLog`	net472	4.46μs	3.68ns	14.3ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6131

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.195	485.03	579.76

Faster 🎉 in #6131

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.157	647.65	559.77

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	413ns	0.329ns	1.27ns	0.00812	576 B
master	`StartFinishSpan`	netcoreapp3.1	649ns	1.79ns	6.92ns	0.0077	576 B
master	`StartFinishSpan`	net472	722ns	0.204ns	0.764ns	0.0915	578 B
master	`StartFinishScope`	net6.0	485ns	0.356ns	1.38ns	0.00974	696 B
master	`StartFinishScope`	netcoreapp3.1	733ns	1.47ns	5.67ns	0.00939	696 B
master	`StartFinishScope`	net472	844ns	0.555ns	2ns	0.104	658 B
#6131	`StartFinishSpan`	net6.0	401ns	0.248ns	0.961ns	0.00803	576 B
#6131	`StartFinishSpan`	netcoreapp3.1	560ns	0.247ns	0.89ns	0.00791	576 B
#6131	`StartFinishSpan`	net472	707ns	0.256ns	0.959ns	0.0915	578 B
#6131	`StartFinishScope`	net6.0	579ns	0.477ns	1.85ns	0.00988	696 B
#6131	`StartFinishScope`	netcoreapp3.1	769ns	0.731ns	2.83ns	0.00941	696 B
#6131	`StartFinishScope`	net472	851ns	0.696ns	2.6ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6131

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.113	591.09	657.75

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	591ns	0.29ns	1.12ns	0.00966	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	903ns	0.496ns	1.92ns	0.00919	696 B
master	`RunOnMethodBegin`	net472	1.07μs	0.313ns	1.13ns	0.105	658 B
#6131	`RunOnMethodBegin`	net6.0	658ns	0.428ns	1.66ns	0.00958	696 B
#6131	`RunOnMethodBegin`	netcoreapp3.1	1μs	0.381ns	1.47ns	0.00902	696 B
#6131	`RunOnMethodBegin`	net472	1.13μs	0.495ns	1.92ns	0.104	658 B

andrewlock · 2024-10-08T22:55:16Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6131) (11.147M)   : 0, 11147482
    master (10.947M)   : 0, 10947067
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6131) (7.336M)   : 0, 7336378
    master (7.357M)   : 0, 7357178
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.658M)   : 0, 7658023

    section Manual
    master (11.170M)   : 0, 11169713

    section Manual + Automatic
    This PR (6131) (6.818M)   : 0, 6818467
    master (6.794M)   : 0, 6793735

    section DD_TRACE_ENABLED=0
    master (10.165M)   : 0, 10164915

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6131) (9.489M)   : 0, 9488617
    master (9.407M)   : 0, 9406571
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6131) (6.555M)   : 0, 6554553
    master (6.543M)   : 0, 6542618

    section Trace stats
    master (6.888M)   : 0, 6887750

    section Manual
    master (9.380M)   : 0, 9379533

    section Manual + Automatic
    This PR (6131) (6.111M)   : 0, 6110814
    master (6.148M)   : 0, 6147954

    section DD_TRACE_ENABLED=0
    master (8.559M)   : 0, 8559117

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6131) (10.417M)   : 0, 10416739
    master (9.869M)   : 0, 9868639
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6131) (6.858M)   : 0, 6858137
    master (6.673M)   : 0, 6672534
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.379M)   : 0, 7378820

    section Manual
    master (10.188M)   : 0, 10188482

    section Manual + Automatic
    This PR (6131) (6.439M)   : 0, 6439046
    master (6.068M)   : 0, 6067649

    section DD_TRACE_ENABLED=0
    master (9.316M)   : 0, 9315564

andrewlock added type:bug area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed) area:integrations labels Oct 8, 2024

andrewlock requested review from a team as code owners October 8, 2024 18:40

Fix subtle WCF bug

5bb2da3

andrewlock force-pushed the andrew/fix-wcf-bug branch from f7944bf to 5bb2da3 Compare October 8, 2024 18:57

zacharycmontoya approved these changes Oct 8, 2024

View reviewed changes

bouwkast approved these changes Oct 8, 2024

View reviewed changes

lucaspimentel approved these changes Oct 8, 2024

View reviewed changes

andrewlock merged commit 1900fea into master Oct 9, 2024
74 of 75 checks passed

andrewlock deleted the andrew/fix-wcf-bug branch October 9, 2024 16:34

github-actions bot added this to the vNext-v3 milestone Oct 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix subtle WCF bug #6131

Fix subtle WCF bug #6131

andrewlock commented Oct 8, 2024

datadog-ddstaging bot commented Oct 8, 2024 •

edited

Loading

andrewlock commented Oct 8, 2024

bouwkast left a comment

andrewlock commented Oct 8, 2024

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6131

Raw results

Faster 🎉 in #6131

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6131

Faster 🎉 in #6131

Raw results

Slower ⚠️ in #6131

Raw results

andrewlock commented Oct 8, 2024

Fix subtle WCF bug #6131

Fix subtle WCF bug #6131

Conversation

andrewlock commented Oct 8, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

datadog-ddstaging bot commented Oct 8, 2024 • edited Loading

Datadog Report

andrewlock commented Oct 8, 2024

Execution-Time Benchmarks Report ⏱️

bouwkast left a comment

Choose a reason for hiding this comment

andrewlock commented Oct 8, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6131

Raw results

Faster 🎉 in #6131

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6131

Faster 🎉 in #6131

Raw results

Slower ⚠️ in #6131

Raw results

andrewlock commented Oct 8, 2024

Throughput/Crank Report ⚡

datadog-ddstaging bot commented Oct 8, 2024 •

edited

Loading