[CrashTracking] Add more exception types #5697

kevingosse · 2024-06-14T18:03:53Z

Summary of changes

Add System.MissingFieldException, System.MissingMemberException, and System.TypeLoadException to the list of suspicious exceptions.

Reason for change

Those are other exception types that can be thrown by faulty instrumentation.

datadog-ddstaging · 2024-06-14T18:20:51Z

Datadog Report

Branch report: kevin/crash_report_more_exceptions
Commit report: 18cb007
Test service: dd-trace-dotnet

✅ 0 Failed, 341344 Passed, 1670 Skipped, 14h 15m 18.84s Total Time

andrewlock · 2024-06-14T18:47:12Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5697) - mean (74ms)  : 64, 85
     .   : milestone, 74,
    master - mean (73ms)  : 64, 81
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5697) - mean (1,013ms)  : 984, 1042
     .   : milestone, 1013,
    master - mean (1,008ms)  : 990, 1025
     .   : milestone, 1008,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5697) - mean (110ms)  : 108, 113
     .   : milestone, 110,
    master - mean (109ms)  : 105, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5697) - mean (727ms)  : 705, 749
     .   : milestone, 727,
    master - mean (722ms)  : 698, 746
     .   : milestone, 722,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5697) - mean (94ms)  : 91, 97
     .   : milestone, 94,
    master - mean (93ms)  : 89, 98
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5697) - mean (680ms)  : 657, 703
     .   : milestone, 680,
    master - mean (681ms)  : 658, 703
     .   : milestone, 681,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5697) - mean (193ms)  : 189, 198
     .   : milestone, 193,
    master - mean (195ms)  : 191, 200
     .   : milestone, 195,

    section CallTarget+Inlining+NGEN
    This PR (5697) - mean (1,118ms)  : 1100, 1136
     .   : milestone, 1118,
    master - mean (1,120ms)  : 1095, 1144
     .   : milestone, 1120,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5697) - mean (278ms)  : 273, 283
     .   : milestone, 278,
    master - mean (279ms)  : 273, 285
     .   : milestone, 279,

    section CallTarget+Inlining+NGEN
    This PR (5697) - mean (908ms)  : 885, 930
     .   : milestone, 908,
    master - mean (911ms)  : 885, 938
     .   : milestone, 911,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5697) - mean (269ms)  : 264, 274
     .   : milestone, 269,
    master - mean (269ms)  : 264, 275
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (5697) - mean (891ms)  : 873, 910
     .   : milestone, 891,
    master - mean (898ms)  : 876, 921
     .   : milestone, 898,

andrewlock · 2024-06-14T22:11:43Z

Benchmarks Report for tracer 🐌

Benchmarks for #5697 compared to master:

3 benchmarks are faster, with geometric mean 1.166
1 benchmarks are slower, with geometric mean 1.153
1 benchmarks have fewer allocations
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.7μs	43.2ns	277ns	0.0159	0.00797	0	5.43 KB
master	`StartStopWithChild`	netcoreapp3.1	10.1μs	57.3ns	405ns	0.0144	0.00479	0	5.62 KB
master	`StartStopWithChild`	net472	16.1μs	40ns	149ns	1.03	0.318	0.0954	6.06 KB
#5697	`StartStopWithChild`	net6.0	7.66μs	43ns	295ns	0.0157	0.00783	0	5.42 KB
#5697	`StartStopWithChild`	netcoreapp3.1	9.82μs	51.5ns	262ns	0.0239	0.00957	0	5.61 KB
#5697	`StartStopWithChild`	net472	15.9μs	50.2ns	195ns	1.04	0.326	0.103	6.06 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	480μs	139ns	502ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	637μs	343ns	1.33μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	834μs	461ns	1.73μs	0.417	3.3 KB
#5697	`WriteAndFlushEnrichedTraces`	net6.0	467μs	165ns	594ns	0	2.7 KB
#5697	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	639μs	197ns	737ns	0	2.7 KB
#5697	`WriteAndFlushEnrichedTraces`	net472	817μs	544ns	2.04μs	0.408	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	171μs	182ns	703ns	0.256	18.44 KB
master	`SendRequest`	netcoreapp3.1	192μs	378ns	1.46μs	0.192	20.6 KB
master	`SendRequest`	net472	0.000225ns	0.000225ns	0.000843ns	0	0 b
#5697	`SendRequest`	net6.0	172μs	236ns	913ns	0.257	18.44 KB
#5697	`SendRequest`	netcoreapp3.1	192μs	422ns	1.64μs	0.193	20.6 KB
#5697	`SendRequest`	net472	5.68E‑05ns	5.68E‑05ns	0.000205ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5697

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.68 KB	41.97 KB	298 B	0.72%

Fewer allocations 🎉 in #5697

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.79 KB	41.57 KB	-227 B	-0.54%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	567μs	695ns	2.69μs	0.566	0	0	41.79 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	666μs	1.21μs	4.19μs	0.336	0	0	41.68 KB
master	`WriteAndFlushEnrichedTraces`	net472	865μs	3.84μs	15.8μs	8.13	2.57	0.428	53.25 KB
#5697	`WriteAndFlushEnrichedTraces`	net6.0	553μs	498ns	1.93μs	0.556	0	0	41.57 KB
#5697	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	661μs	1.13μs	4.37μs	0.327	0	0	41.97 KB
#5697	`WriteAndFlushEnrichedTraces`	net472	852μs	3.83μs	14.9μs	8.45	2.53	0.422	53.27 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.09μs	0.61ns	2.36ns	0.0115	808 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.5μs	1.22ns	4.71ns	0.0106	808 B
master	`ExecuteNonQuery`	net472	1.77μs	0.785ns	2.83ns	0.122	770 B
#5697	`ExecuteNonQuery`	net6.0	1.19μs	0.44ns	1.7ns	0.0113	808 B
#5697	`ExecuteNonQuery`	netcoreapp3.1	1.5μs	0.942ns	3.65ns	0.0106	808 B
#5697	`ExecuteNonQuery`	net472	1.75μs	1ns	3.87ns	0.122	770 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`CallElasticsearch`	net6.0	1.18μs	0.917ns	3.43ns	0.0137	0	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.51μs	0.368ns	1.27ns	0.0136	0	976 B
master	`CallElasticsearch`	net472	2.43μs	2.15ns	8.06ns	0.157	0	995 B
master	`CallElasticsearchAsync`	net6.0	1.27μs	0.396ns	1.53ns	0.0134	0	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.67μs	0.721ns	2.6ns	0.0143	0	1.02 KB
master	`CallElasticsearchAsync`	net472	2.5μs	2.08ns	8.06ns	0.167	0	1.05 KB
#5697	`CallElasticsearch`	net6.0	1.19μs	0.432ns	1.62ns	0.0138	0	976 B
#5697	`CallElasticsearch`	netcoreapp3.1	1.55μs	0.442ns	1.53ns	0.0132	0	976 B
#5697	`CallElasticsearch`	net472	2.47μs	4.29ns	16.6ns	0.157	0	995 B
#5697	`CallElasticsearchAsync`	net6.0	1.32μs	0.743ns	2.78ns	0.0131	0	952 B
#5697	`CallElasticsearchAsync`	netcoreapp3.1	1.57μs	0.887ns	3.2ns	0.0135	0	1.02 KB
#5697	`CallElasticsearchAsync`	net472	2.67μs	3.81ns	14.3ns	0.166	0.00133	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.27μs	0.793ns	2.97ns	0.0134	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.66μs	2.08ns	7.77ns	0.0125	952 B
master	`ExecuteAsync`	net472	1.77μs	1.5ns	5.61ns	0.145	915 B
#5697	`ExecuteAsync`	net6.0	1.19μs	0.537ns	2.01ns	0.0132	952 B
#5697	`ExecuteAsync`	netcoreapp3.1	1.65μs	0.702ns	2.72ns	0.0123	952 B
#5697	`ExecuteAsync`	net472	1.83μs	1.18ns	4.41ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.27μs	1.06ns	3.66ns	0.0299	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.1μs	3.13ns	11.7ns	0.0375	2.76 KB
master	`SendAsync`	net472	7.66μs	1.66ns	6.44ns	0.497	3.15 KB
#5697	`SendAsync`	net6.0	4.23μs	1.74ns	6.49ns	0.0296	2.22 KB
#5697	`SendAsync`	netcoreapp3.1	5.15μs	2.92ns	11.3ns	0.0359	2.76 KB
#5697	`SendAsync`	net472	7.63μs	1.4ns	5.24ns	0.499	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5697

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0	1.144	1,611.91	1,409.12

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.61μs	0.781ns	2.92ns	0.0226	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.22μs	1.82ns	7.04ns	0.0212	1.64 KB
master	`EnrichedLog`	net472	2.63μs	2.81ns	10.9ns	0.248	1.57 KB
#5697	`EnrichedLog`	net6.0	1.41μs	0.636ns	2.46ns	0.0226	1.64 KB
#5697	`EnrichedLog`	netcoreapp3.1	2.15μs	0.559ns	2.02ns	0.0226	1.64 KB
#5697	`EnrichedLog`	net472	2.47μs	1.05ns	3.79ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	114μs	227ns	879ns	0.0571	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	117μs	108ns	418ns	0.0587	0	4.28 KB
master	`EnrichedLog`	net472	146μs	55.4ns	215ns	0.66	0.22	4.46 KB
#5697	`EnrichedLog`	net6.0	113μs	224ns	867ns	0.0562	0	4.28 KB
#5697	`EnrichedLog`	netcoreapp3.1	117μs	120ns	463ns	0	0	4.28 KB
#5697	`EnrichedLog`	net472	146μs	94.5ns	366ns	0.658	0.219	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.15μs	1.59ns	5.72ns	0.0299	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.28μs	3.84ns	14.9ns	0.03	2.2 KB
master	`EnrichedLog`	net472	4.91μs	1.38ns	5.18ns	0.32	2.02 KB
#5697	`EnrichedLog`	net6.0	3.07μs	1.84ns	6.88ns	0.0303	2.2 KB
#5697	`EnrichedLog`	netcoreapp3.1	4.14μs	2.15ns	8.34ns	0.029	2.2 KB
#5697	`EnrichedLog`	net472	4.82μs	1.29ns	5.01ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.31μs	1.32ns	5.1ns	0.0158	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.83μs	0.901ns	3.37ns	0.0156	1.14 KB
master	`SendReceive`	net472	2.1μs	1.12ns	4.19ns	0.183	1.16 KB
#5697	`SendReceive`	net6.0	1.24μs	0.443ns	1.72ns	0.0161	1.14 KB
#5697	`SendReceive`	netcoreapp3.1	1.74μs	0.448ns	1.74ns	0.0157	1.14 KB
#5697	`SendReceive`	net472	2.01μs	0.717ns	2.68ns	0.184	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.76μs	1.02ns	3.96ns	0.022	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.88μs	2.27ns	8.81ns	0.0213	1.65 KB
master	`EnrichedLog`	net472	4.56μs	3.05ns	11.8ns	0.323	2.04 KB
#5697	`EnrichedLog`	net6.0	2.82μs	0.721ns	2.7ns	0.0225	1.6 KB
#5697	`EnrichedLog`	netcoreapp3.1	3.96μs	1.08ns	3.91ns	0.0218	1.65 KB
#5697	`EnrichedLog`	net472	4.46μs	4.24ns	16.4ns	0.324	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5697

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.153	470.37	542.41

Faster 🎉 in #5697

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.216	674.20	554.49
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472	1.139	878.01	770.73

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	401ns	0.18ns	0.699ns	0.00803	576 B
master	`StartFinishSpan`	netcoreapp3.1	674ns	0.228ns	0.852ns	0.00782	576 B
master	`StartFinishSpan`	net472	576ns	0.431ns	1.67ns	0.0916	578 B
master	`StartFinishScope`	net6.0	470ns	0.202ns	0.754ns	0.00986	696 B
master	`StartFinishScope`	netcoreapp3.1	758ns	0.426ns	1.59ns	0.00957	696 B
master	`StartFinishScope`	net472	878ns	0.173ns	0.671ns	0.104	658 B
#5697	`StartFinishSpan`	net6.0	397ns	0.113ns	0.422ns	0.00813	576 B
#5697	`StartFinishSpan`	netcoreapp3.1	554ns	0.251ns	0.941ns	0.00783	576 B
#5697	`StartFinishSpan`	net472	634ns	0.467ns	1.81ns	0.0916	578 B
#5697	`StartFinishScope`	net6.0	543ns	0.374ns	1.45ns	0.00986	696 B
#5697	`StartFinishScope`	netcoreapp3.1	745ns	0.312ns	1.17ns	0.00952	696 B
#5697	`StartFinishScope`	net472	769ns	1.62ns	6.28ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	751ns	0.993ns	3.58ns	0.00978	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	917ns	0.25ns	0.934ns	0.00965	696 B
master	`RunOnMethodBegin`	net472	1.11μs	0.649ns	2.43ns	0.104	658 B
#5697	`RunOnMethodBegin`	net6.0	677ns	0.376ns	1.46ns	0.00987	696 B
#5697	`RunOnMethodBegin`	netcoreapp3.1	886ns	0.683ns	2.56ns	0.00922	696 B
#5697	`RunOnMethodBegin`	net472	1.08μs	0.652ns	2.52ns	0.104	658 B

andrewlock · 2024-06-14T22:46:07Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5697) (11.340M)   : 0, 11339514
    master (11.600M)   : 0, 11600057
    benchmarks/2.9.0 (11.574M)   : 0, 11573681

    section Automatic
    This PR (5697) (7.733M)   : 0, 7732864
    master (7.856M)   : 0, 7856121
    benchmarks/2.9.0 (8.261M)   : 0, 8260805

    section Trace stats
    master (8.127M)   : 0, 8126693

    section Manual
    This PR (5697) (9.871M)   : 0, 9870624
    master (9.913M)   : 0, 9912547

    section Manual + Automatic
    This PR (5697) (7.212M)   : 0, 7211930
    master (7.333M)   : 0, 7333164

    section Version Conflict
    master (6.559M)   : 0, 6558973

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5697) (9.526M)   : 0, 9526171
    benchmarks/2.9.0 (9.623M)   : 0, 9623209

    section Automatic
    This PR (5697) (6.591M)   : 0, 6591364

    section Manual
    This PR (5697) (8.334M)   : 0, 8334330

    section Manual + Automatic
    This PR (5697) (6.233M)   : 0, 6232620

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5697) (10.231M)   : 0, 10231406
    master (10.024M)   : 0, 10023979
    benchmarks/2.9.0 (9.948M)   : 0, 9948007

    section Automatic
    This PR (5697) (7.211M)   : 0, 7210801
    master (7.036M)   : 0, 7035910
    benchmarks/2.9.0 (7.263M)   : 0, 7263417

    section Trace stats
    master (7.421M)   : 0, 7421266

    section Manual
    This PR (5697) (9.038M)   : 0, 9037947
    master (8.963M)   : 0, 8963310

    section Manual + Automatic
    This PR (5697) (6.954M)   : 0, 6953527
    master (6.886M)   : 0, 6886303

    section Version Conflict
    master (6.265M)   : 0, 6265268

Add more exception types to crash tracking

18cb007

kevingosse requested a review from a team as a code owner June 14, 2024 18:03

andrewlock approved these changes Jun 14, 2024

View reviewed changes

kevingosse merged commit 0a8bb3d into master Jun 17, 2024
55 of 57 checks passed

kevingosse deleted the kevin/crash_report_more_exceptions branch June 17, 2024 11:20

github-actions bot added this to the vNext-v2 milestone Jun 17, 2024

andrewlock pushed a commit that referenced this pull request Jun 17, 2024

Add more exception types to crash tracking (#5697)

16bb889

andrewlock modified the milestones: vNext-v2, 2.53.1 Jun 17, 2024

andrewlock added the area:crashtracking label Oct 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CrashTracking] Add more exception types #5697

[CrashTracking] Add more exception types #5697

kevingosse commented Jun 14, 2024

datadog-ddstaging bot commented Jun 14, 2024 •

edited

Loading

andrewlock commented Jun 14, 2024

andrewlock commented Jun 14, 2024

Raw results

Raw results

Raw results

More allocations ⚠️ in #5697

Fewer allocations 🎉 in #5697

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5697

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5697

Faster 🎉 in #5697

Raw results

Raw results

andrewlock commented Jun 14, 2024

[CrashTracking] Add more exception types #5697

[CrashTracking] Add more exception types #5697

Conversation

kevingosse commented Jun 14, 2024

Summary of changes

Reason for change

datadog-ddstaging bot commented Jun 14, 2024 • edited Loading

Datadog Report

andrewlock commented Jun 14, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Jun 14, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #5697

Fewer allocations 🎉 in #5697

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5697

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5697

Faster 🎉 in #5697

Raw results

Raw results

andrewlock commented Jun 14, 2024

Throughput/Crank Report:zap:

datadog-ddstaging bot commented Jun 14, 2024 •

edited

Loading