-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test Package Versions Bump] Updating package versions #5605
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5605) - mean (74ms) : 62, 86
. : milestone, 74,
master - mean (72ms) : 63, 81
. : milestone, 72,
section CallTarget+Inlining+NGEN
This PR (5605) - mean (992ms) : 974, 1010
. : milestone, 992,
master - mean (992ms) : 973, 1011
. : milestone, 992,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5605) - mean (108ms) : 104, 111
. : milestone, 108,
master - mean (108ms) : 105, 112
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (5605) - mean (709ms) : 687, 732
. : milestone, 709,
master - mean (711ms) : 689, 732
. : milestone, 711,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5605) - mean (91ms) : 89, 94
. : milestone, 91,
master - mean (93ms) : 90, 95
. : milestone, 93,
section CallTarget+Inlining+NGEN
This PR (5605) - mean (659ms) : 640, 678
. : milestone, 659,
master - mean (662ms) : 642, 682
. : milestone, 662,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5605) - mean (194ms) : 188, 200
. : milestone, 194,
master - mean (192ms) : 190, 195
. : milestone, 192,
section CallTarget+Inlining+NGEN
This PR (5605) - mean (1,099ms) : 1076, 1123
. : milestone, 1099,
master - mean (1,093ms) : 1070, 1115
. : milestone, 1093,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5605) - mean (277ms) : 273, 281
. : milestone, 277,
master - mean (277ms) : 273, 282
. : milestone, 277,
section CallTarget+Inlining+NGEN
This PR (5605) - mean (892ms) : 870, 914
. : milestone, 892,
master - mean (896ms) : 875, 917
. : milestone, 896,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5605) - mean (265ms) : 262, 269
. : milestone, 265,
master - mean (266ms) : 262, 269
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (5605) - mean (878ms) : 854, 901
. : milestone, 878,
master - mean (875ms) : 854, 897
. : milestone, 875,
|
Throughput/Crank Report:zap:Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5605) (11.185M) : 0, 11184641
master (11.262M) : 0, 11262343
benchmarks/2.9.0 (11.124M) : 0, 11124333
section Automatic
This PR (5605) (7.621M) : 0, 7620788
master (7.586M) : 0, 7586126
benchmarks/2.9.0 (7.978M) : 0, 7978037
section Trace stats
master (8.046M) : 0, 8046133
section Manual
This PR (5605) (9.803M) : 0, 9803332
master (9.744M) : 0, 9743956
section Manual + Automatic
This PR (5605) (7.252M) : 0, 7252017
master (7.098M) : 0, 7098145
section Version Conflict
master (6.470M) : 0, 6469848
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5605) (9.500M) : 0, 9499886
master (9.600M) : 0, 9599985
benchmarks/2.9.0 (9.596M) : 0, 9596252
section Automatic
This PR (5605) (6.631M) : 0, 6630672
master (6.527M) : 0, 6526883
section Trace stats
master (6.915M) : 0, 6915159
section Manual
This PR (5605) (8.258M) : 0, 8258453
master (8.199M) : 0, 8198545
section Manual + Automatic
This PR (5605) (6.126M) : 0, 6126128
master (6.002M) : 0, 6001900
section Version Conflict
master (5.639M) : 0, 5638978
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5605) (9.574M) : 0, 9574443
master (9.763M) : 0, 9763334
benchmarks/2.9.0 (9.869M) : 0, 9868550
section Automatic
This PR (5605) (6.927M) : 0, 6927092
master (7.038M) : 0, 7038436
benchmarks/2.9.0 (7.444M) : 0, 7444484
section Trace stats
master (7.362M) : 0, 7362164
section Manual
This PR (5605) (8.726M) : 0, 8726420
master (8.858M) : 0, 8858293
section Manual + Automatic
This PR (5605) (6.697M) : 0, 6697322
master (6.796M) : 0, 6796126
section Version Conflict
master (6.172M) : 0, 6171707
|
Datadog ReportBranch report: ✅ 0 Failed, 336582 Passed, 1566 Skipped, 13h 51m 8.51s Total Time |
Benchmarks Report for tracer 🐌Benchmarks for #5605 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️
|
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 | 1.171 | 858.03 | 732.56 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 404ns | 0.175ns | 0.679ns | 0.00798 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 587ns | 0.397ns | 1.49ns | 0.00779 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 712ns | 0.601ns | 2.33ns | 0.0916 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 489ns | 0.229ns | 0.886ns | 0.00974 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 858ns | 0.318ns | 1.23ns | 0.00911 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 819ns | 0.742ns | 2.68ns | 0.104 | 0 | 0 | 658 B |
#5605 | StartFinishSpan |
net6.0 | 414ns | 1.14ns | 4.41ns | 0.00803 | 0 | 0 | 576 B |
#5605 | StartFinishSpan |
netcoreapp3.1 | 609ns | 0.397ns | 1.54ns | 0.00762 | 0 | 0 | 576 B |
#5605 | StartFinishSpan |
net472 | 647ns | 0.398ns | 1.44ns | 0.0917 | 0 | 0 | 578 B |
#5605 | StartFinishScope |
net6.0 | 485ns | 0.178ns | 0.691ns | 0.00966 | 0 | 0 | 696 B |
#5605 | StartFinishScope |
netcoreapp3.1 | 733ns | 0.198ns | 0.767ns | 0.00925 | 0 | 0 | 696 B |
#5605 | StartFinishScope |
net472 | 859ns | 0.324ns | 1.25ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 591ns | 0.197ns | 0.71ns | 0.00975 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 923ns | 0.317ns | 1.23ns | 0.00922 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.11μs | 0.136ns | 0.527ns | 0.104 | 0 | 0 | 658 B |
#5605 | RunOnMethodBegin |
net6.0 | 584ns | 0.341ns | 1.32ns | 0.00995 | 0 | 0 | 696 B |
#5605 | RunOnMethodBegin |
netcoreapp3.1 | 869ns | 0.356ns | 1.38ns | 0.00919 | 0 | 0 | 696 B |
#5605 | RunOnMethodBegin |
net472 | 1.08μs | 0.364ns | 1.36ns | 0.104 | 0 | 0 | 658 B |
53ebc5f
to
0bedf91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if the tests all pass
(I reverted the NLog ones again)
0bedf91
to
60666a4
Compare
60666a4
to
fa8f77d
Compare
fa8f77d
to
4afbdbf
Compare
e367eb8
to
92a9000
Compare
92a9000
to
b7d1e81
Compare
Updates the package versions for integration tests.