Try working around missing Docker Compose v1 in hosted runners #5386

andrewlock · 2024-04-03T08:40:04Z

Summary of changes

Run installer tests on a separate "smoke test" pool

Reason for change

Microsoft, have decided to break 30k pipelines by removing docker compose v1 from their hosted pipelines, installing v2 only instead: actions/runner-images#9557

What's more, their own Azure Devops DockerCompose@0 task doesn't even support v2: microsoft/azure-pipelines-tasks#19711

Implementation details

As a workaround, set up a separate Azure VMSS and use that for the smoke tests instead of the hosted runners.

Alternatives include:

Switching everything to use v2. This would also require dropping usage of the built-in task DockerCompose@0. Also, Microsoft don't provide arm64 hosted runners, so we have to self host, and those images are using v2, so we'd have to duplicate a bunch of tasks and/or update the runners etc.
Install Docker compose v1 on the hosted runners, as described here. I tried that, and it didn't work, primarily because we don't just use the DockerCompose@v0 task.
Switch to managing this with test containers, so there's only one abstraction to handle. I think we should look into this in the future, if nothing else it would reduce the amount of YAML we have, aiding transitions to other CI systems if necessary

Test coverage

This is the test. I'll also do a "run all installer tests" run to be sure.

Other details

:azure-chaos:

datadog-ddstaging · 2024-04-03T08:55:17Z

Datadog Report

Branch report: andrew/ci/fix-docker-compose
Commit report: 7f0cafb
Test service: dd-trace-dotnet

✅ 0 Failed, 319935 Passed, 1541 Skipped, 42m 29.41s Wall Time
❄️ 1 New Flaky

New Flaky Tests (1)

ObfuscateWithDefaultPattern - Datadog.Trace.Tests.Util.Http.EvidenceRedactorTests - Last Failure

Expand for error

 Expected string to be "key1=val1&<redacted>&key2=val2" with a length of 30, but "" has a length of 0, differs near "" (index 0).

andrewlock · 2024-04-03T09:03:56Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5386) - mean (74ms)  : 65, 84
     .   : milestone, 74,
    master - mean (73ms)  : 65, 80
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5386) - mean (1,010ms)  : 989, 1031
     .   : milestone, 1010,
    master - mean (1,003ms)  : 983, 1022
     .   : milestone, 1003,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5386) - mean (112ms)  : 109, 115
     .   : milestone, 112,
    master - mean (111ms)  : 106, 115
     .   : milestone, 111,

    section CallTarget+Inlining+NGEN
    This PR (5386) - mean (723ms)  : 701, 745
     .   : milestone, 723,
    master - mean (717ms)  : 692, 742
     .   : milestone, 717,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5386) - mean (94ms)  : 90, 98
     .   : milestone, 94,
    master - mean (94ms)  : 90, 98
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (5386) - mean (679ms)  : 657, 700
     .   : milestone, 679,
    master - mean (676ms)  : 651, 700
     .   : milestone, 676,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5386) - mean (188ms)  : 185, 191
     .   : milestone, 188,
    master - mean (187ms)  : 182, 193
     .   : milestone, 187,

    section CallTarget+Inlining+NGEN
    This PR (5386) - mean (1,077ms)  : 1052, 1101
     .   : milestone, 1077,
    master - mean (1,077ms)  : 1056, 1097
     .   : milestone, 1077,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5386) - mean (272ms)  : 268, 276
     .   : milestone, 272,
    master - mean (270ms)  : 264, 277
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (5386) - mean (878ms)  : 848, 908
     .   : milestone, 878,
    master - mean (868ms)  : 847, 889
     .   : milestone, 868,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5386) - mean (260ms)  : 254, 266
     .   : milestone, 260,
    master - mean (260ms)  : 253, 266
     .   : milestone, 260,

    section CallTarget+Inlining+NGEN
    This PR (5386) - mean (857ms)  : 831, 884
     .   : milestone, 857,
    master - mean (855ms)  : 824, 887
     .   : milestone, 855,

andrewlock · 2024-04-03T09:16:58Z

Benchmarks Report for tracer 🐌

Benchmarks for #5386 compared to master:

1 benchmarks are faster, with geometric mean 1.132
3 benchmarks are slower, with geometric mean 1.149
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.82μs	48.5ns	295ns	0.0176	0.00879	0	7.51 KB
master	`StartStopWithChild`	netcoreapp3.1	10.6μs	53ns	249ns	0.0268	0.0107	0	7.6 KB
master	`StartStopWithChild`	net472	16.9μs	50.1ns	194ns	1.35	0.337	0.11	8.05 KB
#5386	`StartStopWithChild`	net6.0	8.59μs	48.7ns	334ns	0.0272	0.00906	0	7.51 KB
#5386	`StartStopWithChild`	netcoreapp3.1	10.6μs	55.2ns	253ns	0.0261	0.0104	0	7.6 KB
#5386	`StartStopWithChild`	net472	16.9μs	75.9ns	284ns	1.35	0.356	0.0932	8.05 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	461μs	362ns	1.4μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	604μs	303ns	1.17μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	817μs	3.87μs	18.2μs	0.403	3.3 KB
#5386	`WriteAndFlushEnrichedTraces`	net6.0	462μs	1.07μs	3.99μs	0	2.7 KB
#5386	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	608μs	1.41μs	5.44μs	0	2.7 KB
#5386	`WriteAndFlushEnrichedTraces`	net472	813μs	243ns	840ns	0.408	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	174μs	217ns	839ns	0.174	18.33 KB
master	`SendRequest`	netcoreapp3.1	191μs	293ns	1.1μs	0.19	20.49 KB
master	`SendRequest`	net472	0.000539ns	0.000291ns	0.00105ns	0	0 b
#5386	`SendRequest`	net6.0	175μs	208ns	805ns	0.174	18.33 KB
#5386	`SendRequest`	netcoreapp3.1	193μs	305ns	1.18μs	0.193	20.49 KB
#5386	`SendRequest`	net472	0.000605ns	0.000224ns	0.000869ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #5386

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.75 KB	41.53 KB	-217 B	-0.52%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	549μs	259ns	1μs	0.551	0	0	41.75 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	654μs	938ns	3.63μs	0.324	0	0	41.74 KB
master	`WriteAndFlushEnrichedTraces`	net472	899μs	4.22μs	16.3μs	8.04	2.23	0.446	53.24 KB
#5386	`WriteAndFlushEnrichedTraces`	net6.0	543μs	1.01μs	3.9μs	0.546	0	0	41.53 KB
#5386	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	670μs	842ns	3.15μs	0.34	0	0	41.79 KB
#5386	`WriteAndFlushEnrichedTraces`	net472	838μs	3.2μs	12.4μs	8.08	2.55	0.425	53.23 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.18μs	0.318ns	1.23ns	0.0107	784 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.53μs	0.851ns	3.3ns	0.0105	784 B
master	`ExecuteNonQuery`	net472	1.73μs	1.19ns	4.6ns	0.118	746 B
#5386	`ExecuteNonQuery`	net6.0	1.13μs	0.595ns	2.31ns	0.0108	784 B
#5386	`ExecuteNonQuery`	netcoreapp3.1	1.47μs	1.47ns	5.71ns	0.0109	784 B
#5386	`ExecuteNonQuery`	net472	1.81μs	1.21ns	4.68ns	0.118	746 B

Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5386

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0	1.123	1,299.70	1,459.98

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.32μs	1.32ns	5.13ns	0.0144	1.01 KB
master	`CallElasticsearch`	netcoreapp3.1	1.57μs	0.883ns	3.3ns	0.0139	1.01 KB
master	`CallElasticsearch`	net472	2.47μs	1.15ns	4.13ns	0.161	1.02 KB
master	`CallElasticsearchAsync`	net6.0	1.3μs	0.506ns	1.89ns	0.0137	984 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.63μs	0.751ns	2.81ns	0.0144	1.06 KB
master	`CallElasticsearchAsync`	net472	2.67μs	1.07ns	4.15ns	0.17	1.08 KB
#5386	`CallElasticsearch`	net6.0	1.25μs	0.482ns	1.87ns	0.0145	1.01 KB
#5386	`CallElasticsearch`	netcoreapp3.1	1.59μs	0.626ns	2.34ns	0.0139	1.01 KB
#5386	`CallElasticsearch`	net472	2.48μs	1.05ns	4.05ns	0.161	1.02 KB
#5386	`CallElasticsearchAsync`	net6.0	1.46μs	1.15ns	4.46ns	0.0139	984 B
#5386	`CallElasticsearchAsync`	netcoreapp3.1	1.76μs	2.48ns	9.6ns	0.0139	1.06 KB
#5386	`CallElasticsearchAsync`	net472	2.7μs	1.95ns	7.29ns	0.17	1.08 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteAsync`	net6.0	1.24μs	0.545ns	2.11ns	0.013	0	928 B
master	`ExecuteAsync`	netcoreapp3.1	1.69μs	1.05ns	3.92ns	0.0125	0	928 B
master	`ExecuteAsync`	net472	1.91μs	0.712ns	2.67ns	0.141	0	891 B
#5386	`ExecuteAsync`	net6.0	1.31μs	1.01ns	3.76ns	0.0131	0	928 B
#5386	`ExecuteAsync`	netcoreapp3.1	1.75μs	2.08ns	8.05ns	0.0123	0	928 B
#5386	`ExecuteAsync`	net472	1.89μs	2.05ns	7.94ns	0.141	0.000952	891 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.04μs	2.09ns	7.8ns	0.0302	2.16 KB
master	`SendAsync`	netcoreapp3.1	5.16μs	1.43ns	5.37ns	0.0362	2.7 KB
master	`SendAsync`	net472	7.56μs	3.82ns	14.8ns	0.484	3.05 KB
#5386	`SendAsync`	net6.0	4.19μs	3.27ns	12.2ns	0.0296	2.16 KB
#5386	`SendAsync`	netcoreapp3.1	4.96μs	7.78ns	30.1ns	0.0343	2.7 KB
#5386	`SendAsync`	net472	7.65μs	8.46ns	32.8ns	0.481	3.05 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.5μs	1.13ns	4.37ns	0.0233	1.65 KB
master	`EnrichedLog`	netcoreapp3.1	2.15μs	0.918ns	3.43ns	0.0219	1.65 KB
master	`EnrichedLog`	net472	2.73μs	2.51ns	9.74ns	0.25	1.57 KB
#5386	`EnrichedLog`	net6.0	1.53μs	0.403ns	1.51ns	0.023	1.65 KB
#5386	`EnrichedLog`	netcoreapp3.1	2.29μs	0.95ns	3.68ns	0.0225	1.65 KB
#5386	`EnrichedLog`	net472	2.62μs	1.57ns	6.07ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	111μs	105ns	407ns	0	0	4.23 KB
master	`EnrichedLog`	netcoreapp3.1	117μs	132ns	513ns	0.0587	0	4.23 KB
master	`EnrichedLog`	net472	145μs	64.1ns	248ns	0.654	0.218	4.41 KB
#5386	`EnrichedLog`	net6.0	112μs	90.2ns	349ns	0.0559	0	4.23 KB
#5386	`EnrichedLog`	netcoreapp3.1	119μs	138ns	518ns	0	0	4.23 KB
#5386	`EnrichedLog`	net472	146μs	119ns	460ns	0.658	0.219	4.41 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.26μs	1.31ns	5.07ns	0.0311	2.21 KB
master	`EnrichedLog`	netcoreapp3.1	4.08μs	2.63ns	10.2ns	0.0305	2.21 KB
master	`EnrichedLog`	net472	5μs	2.36ns	8.82ns	0.321	2.02 KB
#5386	`EnrichedLog`	net6.0	3.1μs	1.84ns	6.9ns	0.0311	2.21 KB
#5386	`EnrichedLog`	netcoreapp3.1	4.3μs	2.89ns	11.2ns	0.03	2.21 KB
#5386	`EnrichedLog`	net472	4.93μs	4.25ns	16.5ns	0.321	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.52μs	1.01ns	3.9ns	0.016	1.18 KB
master	`SendReceive`	netcoreapp3.1	1.79μs	1.17ns	4.38ns	0.016	1.18 KB
master	`SendReceive`	net472	2.37μs	1.59ns	6.16ns	0.187	1.18 KB
#5386	`SendReceive`	net6.0	1.4μs	0.625ns	2.25ns	0.0161	1.18 KB
#5386	`SendReceive`	netcoreapp3.1	1.75μs	0.495ns	1.78ns	0.0157	1.18 KB
#5386	`SendReceive`	net472	2.18μs	1.43ns	5.36ns	0.187	1.18 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.76μs	1.05ns	4.06ns	0.0219	1.55 KB
master	`EnrichedLog`	netcoreapp3.1	4μs	0.974ns	3.51ns	0.022	1.6 KB
master	`EnrichedLog`	net472	4.45μs	2.02ns	7.81ns	0.314	1.99 KB
#5386	`EnrichedLog`	net6.0	2.76μs	0.991ns	3.84ns	0.0222	1.55 KB
#5386	`EnrichedLog`	netcoreapp3.1	4.07μs	1.22ns	4.71ns	0.0204	1.6 KB
#5386	`EnrichedLog`	net472	4.41μs	2.37ns	9.17ns	0.316	1.99 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5386

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.205	456.10	549.61

Faster 🎉 in #5386

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.132	777.01	686.61

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	457ns	1.04ns	4.04ns	0.00774	552 B
master	`StartFinishSpan`	netcoreapp3.1	778ns	2.42ns	9.36ns	0.00729	552 B
master	`StartFinishSpan`	net472	779ns	1.64ns	6.15ns	0.0876	554 B
master	`StartFinishScope`	net6.0	609ns	1.34ns	5.21ns	0.00935	672 B
master	`StartFinishScope`	netcoreapp3.1	856ns	1.34ns	5.02ns	0.00896	672 B
master	`StartFinishScope`	net472	935ns	1.28ns	4.94ns	0.1	634 B
#5386	`StartFinishSpan`	net6.0	550ns	0.792ns	3.07ns	0.00782	552 B
#5386	`StartFinishSpan`	netcoreapp3.1	686ns	1.3ns	4.85ns	0.00736	552 B
#5386	`StartFinishSpan`	net472	800ns	0.978ns	3.79ns	0.0879	554 B
#5386	`StartFinishScope`	net6.0	550ns	1.47ns	5.68ns	0.00947	672 B
#5386	`StartFinishScope`	netcoreapp3.1	890ns	1.07ns	4.15ns	0.00882	672 B
#5386	`StartFinishScope`	net472	891ns	1.59ns	6.17ns	0.101	634 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5386

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472	1.120	1,021.87	1,144.02

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	638ns	0.91ns	3.52ns	0.0093	672 B
master	`RunOnMethodBegin`	netcoreapp3.1	944ns	1.74ns	6.76ns	0.00916	672 B
master	`RunOnMethodBegin`	net472	1.02μs	1.18ns	4.42ns	0.101	634 B
#5386	`RunOnMethodBegin`	net6.0	665ns	0.999ns	3.87ns	0.00939	672 B
#5386	`RunOnMethodBegin`	netcoreapp3.1	923ns	1.59ns	5.95ns	0.00903	672 B
#5386	`RunOnMethodBegin`	net472	1.14μs	2.67ns	10.3ns	0.101	634 B

This reverts commit e4b0775.

andrewlock · 2024-04-03T11:22:58Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5386) (11.239M)   : 0, 11238645
    master (11.713M)   : 0, 11712713
    benchmarks/2.9.0 (11.269M)   : 0, 11269029

    section Automatic
    This PR (5386) (7.884M)   : 0, 7884189
    master (7.970M)   : 0, 7970298
    benchmarks/2.9.0 (8.101M)   : 0, 8100962

    section Trace stats
    This PR (5386) (8.223M)   : 0, 8222894
    master (8.309M)   : 0, 8309370

    section Manual
    This PR (5386) (9.941M)   : 0, 9941351
    master (10.107M)   : 0, 10107374

    section Manual + Automatic
    This PR (5386) (7.467M)   : 0, 7467302
    master (7.592M)   : 0, 7591882

    section Version Conflict
    This PR (5386) (6.682M)   : 0, 6682297
    master (6.799M)   : 0, 6799241

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5386) (9.486M)   : 0, 9486105
    master (9.521M)   : 0, 9520620
    benchmarks/2.9.0 (9.648M)   : 0, 9648037

    section Automatic
    This PR (5386) (6.536M)   : 0, 6536406
    master (6.557M)   : 0, 6557237

    section Trace stats
    This PR (5386) (6.938M)   : 0, 6937958
    master (6.958M)   : 0, 6958067

    section Manual
    This PR (5386) (8.146M)   : 0, 8145535
    master (8.209M)   : 0, 8209424

    section Manual + Automatic
    This PR (5386) (6.195M)   : 0, 6194611
    master (6.187M)   : 0, 6187080

    section Version Conflict
    This PR (5386) (5.609M)   : 0, 5608709
    master (5.613M)   : 0, 5612669

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5386) (8.864M)   : 0, 8864217
    master (8.806M)   : 0, 8806035
    benchmarks/2.9.0 (8.991M)   : 0, 8990879

    section Automatic
    This PR (5386) (6.188M)   : 0, 6187835
    master (6.106M)   : 0, 6106236
    benchmarks/2.9.0 (6.362M)   : 0, 6361714

    section Trace stats
    This PR (5386) (6.382M)   : 0, 6382402
    master (6.459M)   : 0, 6458941

    section Manual
    This PR (5386) (7.674M)   : 0, 7673833
    master (7.422M)   : 0, 7422112

    section Manual + Automatic
    This PR (5386) (5.859M)   : 0, 5859235
    master (5.963M)   : 0, 5962899

    section Version Conflict
    This PR (5386) (5.291M)   : 0, 5291334
    master (5.237M)   : 0, 5237367

shurivich

LGTM

daniel-romano-DD

Thanks a lot

Try workaround missing Docker Compose v1 in hosted runners

e4b0775

andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Apr 3, 2024

andrewlock added 2 commits April 3, 2024 10:41

Revert "Try workaround missing Docker Compose v1 in hosted runners"

056b68b

This reverts commit e4b0775.

Try switching to the new "smoke test" pool

7f0cafb

andrewlock marked this pull request as ready for review April 3, 2024 10:21

andrewlock requested a review from a team as a code owner April 3, 2024 10:21

shurivich reviewed Apr 3, 2024

View reviewed changes

daniel-romano-DD approved these changes Apr 3, 2024

View reviewed changes

shurivich approved these changes Apr 3, 2024

View reviewed changes

andrewlock merged commit dae0a2f into master Apr 3, 2024
61 of 66 checks passed

andrewlock deleted the andrew/ci/fix-docker-compose branch April 3, 2024 11:38

github-actions bot added this to the vNext milestone Apr 3, 2024

andrewlock modified the milestones: vNext, vNext-v2 Apr 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Try working around missing Docker Compose v1 in hosted runners #5386

Try working around missing Docker Compose v1 in hosted runners #5386

andrewlock commented Apr 3, 2024 •

edited

Loading

datadog-ddstaging bot commented Apr 3, 2024 •

edited

Loading

andrewlock commented Apr 3, 2024 •

edited

Loading

andrewlock commented Apr 3, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #5386

Raw results

Raw results

Slower ⚠️ in #5386

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5386

Faster 🎉 in #5386

Raw results

Slower ⚠️ in #5386

Raw results

andrewlock commented Apr 3, 2024

shurivich left a comment

daniel-romano-DD left a comment

Try working around missing Docker Compose v1 in hosted runners #5386

Try working around missing Docker Compose v1 in hosted runners #5386

Conversation

andrewlock commented Apr 3, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Apr 3, 2024 • edited Loading

Datadog Report

New Flaky Tests (1)

andrewlock commented Apr 3, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Apr 3, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #5386

Raw results

Raw results

Slower ⚠️ in #5386

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5386

Faster 🎉 in #5386

Raw results

Slower ⚠️ in #5386

Raw results

andrewlock commented Apr 3, 2024

Throughput/Crank Report:zap:

shurivich left a comment

Choose a reason for hiding this comment

daniel-romano-DD left a comment

Choose a reason for hiding this comment

andrewlock commented Apr 3, 2024 •

edited

Loading

datadog-ddstaging bot commented Apr 3, 2024 •

edited

Loading

andrewlock commented Apr 3, 2024 •

edited

Loading

andrewlock commented Apr 3, 2024 •

edited

Loading