Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skipping 3.0 Snapshot Check #5316

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Skipping 3.0 Snapshot Check #5316

merged 1 commit into from
Mar 15, 2024

Conversation

link04
Copy link
Contributor

@link04 link04 commented Mar 15, 2024

Summary of changes

Same as #5314 skipping the tainting test for now in 3.0 to prevent the snapshots comparison test from failing.

@link04 link04 requested a review from a team as a code owner March 15, 2024 18:59
@link04 link04 changed the title Didn't notice the if was missing on the failing test Skipping 3.0 Snapshot Check Mar 15, 2024
@github-actions github-actions bot added the area:tests unit tests, integration tests label Mar 15, 2024
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Mar 15, 2024 •
edited
Loading

Datadog Report

Branch report: maximo/stop-snapshot-check-for-3.0
Commit report: 878155e
Test service: dd-trace-dotnet

✅ 0 Failed, 330045 Passed, 1583 Skipped, 37m 35.43s Wall Time

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5316) - mean (75ms)  : 65, 84
     .   : milestone, 75,
    master - mean (71ms)  : 66, 76
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (5316) - mean (1,003ms)  : 985, 1021
     .   : milestone, 1003,
    master - mean (1,013ms)  : 987, 1039
     .   : milestone, 1013,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5316) - mean (110ms)  : 107, 113
     .   : milestone, 110,
    master - mean (110ms)  : 107, 113
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5316) - mean (721ms)  : 701, 741
     .   : milestone, 721,
    master - mean (736ms)  : 713, 758
     .   : milestone, 736,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5316) - mean (94ms)  : 89, 98
     .   : milestone, 94,
    master - mean (93ms)  : 91, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5316) - mean (681ms)  : 655, 708
     .   : milestone, 681,
    master - mean (686ms)  : 663, 709
     .   : milestone, 686,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5316) - mean (187ms)  : 184, 190
     .   : milestone, 187,
    master - mean (188ms)  : 184, 191
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (5316) - mean (1,080ms)  : 1059, 1101
     .   : milestone, 1080,
    master - mean (1,084ms)  : 1061, 1106
     .   : milestone, 1084,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5316) - mean (270ms)  : 265, 275
     .   : milestone, 270,
    master - mean (272ms)  : 267, 276
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (5316) - mean (877ms)  : 854, 901
     .   : milestone, 877,
    master - mean (881ms)  : 858, 905
     .   : milestone, 881,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5316) - mean (260ms)  : 257, 264
     .   : milestone, 260,
    master - mean (261ms)  : 256, 265
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (5316) - mean (865ms)  : 842, 888
     .   : milestone, 865,
    master - mean (863ms)  : 833, 893
     .   : milestone, 863,
Loading

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #5316 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.147
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.71μs 48.3ns 313ns 0.0175 0.00874 0 7.51 KB
master StartStopWithChild netcoreapp3.1 10.5μs 55.9ns 291ns 0.0307 0.0153 0 7.6 KB
master StartStopWithChild net472 17.1μs 58.1ns 225ns 1.38 0.388 0.135 8.15 KB
#5316 StartStopWithChild net6.0 8.51μs 47.8ns 306ns 0.0285 0.0163 0.00408 7.5 KB
#5316 StartStopWithChild netcoreapp3.1 10.5μs 52.6ns 288ns 0.0302 0.0151 0 7.59 KB
#5316 StartStopWithChild net472 17.3μs 42.4ns 164ns 1.37 0.354 0.101 8.14 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 469μs 154ns 578ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 612μs 265ns 956ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 810μs 344ns 1.33μs 0.403 0 0 3.3 KB
#5316 WriteAndFlushEnrichedTraces net6.0 459μs 243ns 911ns 0 0 0 2.7 KB
#5316 WriteAndFlushEnrichedTraces netcoreapp3.1 619μs 440ns 1.7μs 0 0 0 2.7 KB
#5316 WriteAndFlushEnrichedTraces net472 806μs 152ns 547ns 0.401 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 170μs 86ns 322ns 0.255 0 0 18.33 KB
master SendRequest netcoreapp3.1 192μs 278ns 1.08μs 0.19 0 0 20.49 KB
master SendRequest net472 0.00154ns 0.000415ns 0.00155ns 0 0 0 0 b
#5316 SendRequest net6.0 169μs 133ns 514ns 0.252 0 0 18.33 KB
#5316 SendRequest netcoreapp3.1 194μs 339ns 1.31μs 0.193 0 0 20.49 KB
#5316 SendRequest net472 0.00262ns 0.000572ns 0.00221ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 536μs 725ns 2.51μs 0.543 0 0 41.56 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 664μs 979ns 3.79μs 0.332 0 0 41.8 KB
master WriteAndFlushEnrichedTraces net472 876μs 4.04μs 16.2μs 8.42 2.66 0.443 53.25 KB
#5316 WriteAndFlushEnrichedTraces net6.0 544μs 251ns 938ns 0.539 0 0 41.63 KB
#5316 WriteAndFlushEnrichedTraces netcoreapp3.1 659μs 1.44μs 5.56μs 0.326 0 0 41.84 KB
#5316 WriteAndFlushEnrichedTraces net472 867μs 4.2μs 17.8μs 8.13 2.57 0.428 53.25 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.24μs 0.554ns 2.15ns 0.0108 0 0 784 B
master ExecuteNonQuery netcoreapp3.1 1.45μs 0.793ns 2.86ns 0.0102 0 0 784 B
master ExecuteNonQuery net472 1.86μs 2.47ns 9.23ns 0.118 0 0 746 B
#5316 ExecuteNonQuery net6.0 1.24μs 0.336ns 1.3ns 0.0111 0 0 784 B
#5316 ExecuteNonQuery netcoreapp3.1 1.5μs 1.21ns 4.68ns 0.0106 0 0 784 B
#5316 ExecuteNonQuery net472 1.92μs 0.969ns 3.63ns 0.118 0 0 746 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.26μs 3.44ns 13.3ns 0.0138 0 0 1.01 KB
master CallElasticsearch netcoreapp3.1 1.67μs 1.23ns 4.76ns 0.0136 0 0 1.01 KB
master CallElasticsearch net472 2.56μs 0.991ns 3.84ns 0.162 0 0 1.02 KB
master CallElasticsearchAsync net6.0 1.35μs 0.78ns 3.02ns 0.0136 0 0 984 B
master CallElasticsearchAsync netcoreapp3.1 1.68μs 0.999ns 3.87ns 0.0144 0 0 1.06 KB
master CallElasticsearchAsync net472 2.66μs 2.09ns 8.11ns 0.17 0.00133 0 1.08 KB
#5316 CallElasticsearch net6.0 1.35μs 1.59ns 6.16ns 0.0143 0 0 1.01 KB
#5316 CallElasticsearch netcoreapp3.1 1.58μs 0.635ns 2.46ns 0.0135 0 0 1.01 KB
#5316 CallElasticsearch net472 2.52μs 1.33ns 5.15ns 0.162 0 0 1.02 KB
#5316 CallElasticsearchAsync net6.0 1.33μs 1.6ns 6.19ns 0.0139 0 0 984 B
#5316 CallElasticsearchAsync netcoreapp3.1 1.63μs 1.09ns 4.23ns 0.0139 0 0 1.06 KB
#5316 CallElasticsearchAsync net472 2.48μs 1.89ns 7.33ns 0.17 0 0 1.08 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.3μs 1.38ns 5.34ns 0.013 0 0 928 B
master ExecuteAsync netcoreapp3.1 1.65μs 1.72ns 6.65ns 0.0122 0 0 928 B
master ExecuteAsync net472 1.9μs 2.24ns 8.66ns 0.141 0 0 891 B
#5316 ExecuteAsync net6.0 1.42μs 1.8ns 6.98ns 0.0129 0 0 928 B
#5316 ExecuteAsync netcoreapp3.1 1.64μs 1.15ns 4.47ns 0.0123 0 0 928 B
#5316 ExecuteAsync net472 1.97μs 2.28ns 8.21ns 0.141 0 0 891 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.16μs 1.15ns 4.31ns 0.0292 0 0 2.16 KB
master SendAsync netcoreapp3.1 5.15μs 1.55ns 5.78ns 0.0363 0 0 2.7 KB
master SendAsync net472 7.78μs 1.9ns 6.86ns 0.533 0 0 3.38 KB
#5316 SendAsync net6.0 4.21μs 1.63ns 6.31ns 0.0293 0 0 2.16 KB
#5316 SendAsync netcoreapp3.1 5.12μs 4.3ns 16.1ns 0.0358 0 0 2.7 KB
#5316 SendAsync net472 7.69μs 3.37ns 13ns 0.537 0 0 3.38 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.44μs 0.888ns 3.32ns 0.0231 0 0 1.65 KB
master EnrichedLog netcoreapp3.1 2.45μs 1.28ns 4.94ns 0.0219 0 0 1.65 KB
master EnrichedLog net472 2.57μs 3.79ns 14.7ns 0.25 0 0 1.57 KB
#5316 EnrichedLog net6.0 1.54μs 5.29ns 35.5ns 0.0236 0 0 1.65 KB
#5316 EnrichedLog netcoreapp3.1 2.32μs 1.22ns 4.56ns 0.0227 0 0 1.65 KB
#5316 EnrichedLog net472 2.61μs 2.29ns 8.88ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 113μs 143ns 553ns 0.0571 0 0 4.23 KB
master EnrichedLog netcoreapp3.1 118μs 135ns 504ns 0 0 0 4.23 KB
master EnrichedLog net472 147μs 130ns 503ns 0.663 0.221 0 4.41 KB
#5316 EnrichedLog net6.0 114μs 299ns 1.16μs 0.0575 0 0 4.23 KB
#5316 EnrichedLog netcoreapp3.1 121μs 265ns 1.03μs 0.06 0 0 4.23 KB
#5316 EnrichedLog net472 148μs 256ns 993ns 0.66 0.22 0 4.41 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3μs 0.88ns 3.29ns 0.0312 0 0 2.21 KB
master EnrichedLog netcoreapp3.1 4.09μs 2.02ns 7.83ns 0.0287 0 0 2.21 KB
master EnrichedLog net472 4.95μs 2.01ns 7.79ns 0.319 0 0 2.02 KB
#5316 EnrichedLog net6.0 2.99μs 1.53ns 5.73ns 0.0314 0 0 2.21 KB
#5316 EnrichedLog netcoreapp3.1 4.07μs 2.28ns 8.84ns 0.0287 0 0 2.21 KB
#5316 EnrichedLog net472 4.91μs 1.81ns 7ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.48μs 2.98ns 11.5ns 0.0163 0 0 1.18 KB
master SendReceive netcoreapp3.1 1.79μs 0.8ns 2.99ns 0.0161 0 0 1.18 KB
master SendReceive net472 2.28μs 2.77ns 10.7ns 0.187 0 0 1.18 KB
#5316 SendReceive net6.0 1.44μs 1.79ns 6.94ns 0.0165 0 0 1.18 KB
#5316 SendReceive netcoreapp3.1 1.8μs 1.45ns 5.61ns 0.0161 0 0 1.18 KB
#5316 SendReceive net472 2.18μs 1.36ns 5.1ns 0.187 0 0 1.18 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.74μs 0.767ns 2.87ns 0.0218 0 0 1.55 KB
master EnrichedLog netcoreapp3.1 3.84μs 1.02ns 3.96ns 0.0211 0 0 1.6 KB
master EnrichedLog net472 4.4μs 6.23ns 24.1ns 0.315 0 0 1.99 KB
#5316 EnrichedLog net6.0 2.75μs 0.931ns 3.61ns 0.0219 0 0 1.55 KB
#5316 EnrichedLog netcoreapp3.1 3.97μs 2.55ns 9.88ns 0.0218 0 0 1.6 KB
#5316 EnrichedLog net472 4.37μs 2.73ns 10.6ns 0.316 0 0 1.99 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5316

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.147 553.80 635.26

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 523ns 0.338ns 1.31ns 0.00781 0 0 552 B
master StartFinishSpan netcoreapp3.1 674ns 1.16ns 4.5ns 0.00733 0 0 552 B
master StartFinishSpan net472 713ns 0.947ns 3.67ns 0.088 0 0 554 B
master StartFinishScope net6.0 554ns 0.289ns 1.08ns 0.00944 0 0 672 B
master StartFinishScope netcoreapp3.1 844ns 0.488ns 1.89ns 0.00881 0 0 672 B
master StartFinishScope net472 976ns 1.95ns 7.56ns 0.101 0 0 634 B
#5316 StartFinishSpan net6.0 508ns 1.13ns 4.36ns 0.00762 0 0 552 B
#5316 StartFinishSpan netcoreapp3.1 684ns 1.72ns 6.66ns 0.0075 0 0 552 B
#5316 StartFinishSpan net472 731ns 1.27ns 4.76ns 0.0879 0 0 554 B
#5316 StartFinishScope net6.0 636ns 1.05ns 3.93ns 0.00926 0 0 672 B
#5316 StartFinishScope netcoreapp3.1 805ns 2.3ns 8.93ns 0.00912 0 0 672 B
#5316 StartFinishScope net472 901ns 1.37ns 5.32ns 0.1 0 0 634 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 676ns 0.69ns 2.67ns 0.00954 0 0 672 B
master RunOnMethodBegin netcoreapp3.1 880ns 0.57ns 2.13ns 0.00907 0 0 672 B
master RunOnMethodBegin net472 1.02μs 0.913ns 3.54ns 0.101 0 0 634 B
#5316 RunOnMethodBegin net6.0 744ns 1.47ns 5.7ns 0.00931 0 0 672 B
#5316 RunOnMethodBegin netcoreapp3.1 884ns 3.57ns 13.8ns 0.0092 0 0 672 B
#5316 RunOnMethodBegin net472 1.02μs 1.72ns 6.65ns 0.101 0 0 634 B

@andrewlock
Copy link
Member

Benchmarks Report for appsec 🐌

Benchmarks for #5316 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.206
  • 1 benchmarks have fewer allocations
  • 2 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5316

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑netcoreapp3.1 1.206 202.36 244.06

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 577ns 0.42ns 1.57ns 0.0152 0 0 1.08 KB
master AllCycleSimpleBody netcoreapp3.1 817ns 0.539ns 2.09ns 0.0142 0 0 1.06 KB
master AllCycleSimpleBody net472 638ns 0.481ns 1.86ns 0.174 0.000317 0 1.1 KB
master AllCycleMoreComplexBody net6.0 3.55μs 2.22ns 8.59ns 0.0642 0 0 4.58 KB
master AllCycleMoreComplexBody netcoreapp3.1 4.56μs 3.5ns 13.1ns 0.0615 0 0 4.48 KB
master AllCycleMoreComplexBody net472 4.35μs 3.55ns 13.7ns 0.732 0.00866 0 4.61 KB
master ObjectExtractorSimpleBody net6.0 141ns 0.0977ns 0.366ns 0.00398 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 202ns 0.127ns 0.491ns 0.00368 0 0 272 B
master ObjectExtractorSimpleBody net472 169ns 0.261ns 0.903ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3.04μs 2.88ns 11.2ns 0.0531 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.04μs 1.45ns 5.62ns 0.0505 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.82μs 1.41ns 4.88ns 0.601 0.00575 0 3.8 KB
#5316 AllCycleSimpleBody net6.0 600ns 0.787ns 3.05ns 0.0152 0 0 1.08 KB
#5316 AllCycleSimpleBody netcoreapp3.1 768ns 0.419ns 1.62ns 0.0146 0 0 1.06 KB
#5316 AllCycleSimpleBody net472 658ns 0.564ns 2.19ns 0.174 0.000315 0 1.1 KB
#5316 AllCycleMoreComplexBody net6.0 3.55μs 2.51ns 9.38ns 0.0643 0 0 4.58 KB
#5316 AllCycleMoreComplexBody netcoreapp3.1 4.74μs 2.23ns 8.62ns 0.0596 0 0 4.48 KB
#5316 AllCycleMoreComplexBody net472 4.33μs 1.61ns 6.01ns 0.732 0.00867 0 4.61 KB
#5316 ObjectExtractorSimpleBody net6.0 139ns 0.133ns 0.499ns 0.00397 0 0 280 B
#5316 ObjectExtractorSimpleBody netcoreapp3.1 244ns 0.212ns 0.823ns 0.00368 0 0 272 B
#5316 ObjectExtractorSimpleBody net472 161ns 0.13ns 0.505ns 0.0446 0 0 281 B
#5316 ObjectExtractorMoreComplexBody net6.0 3.13μs 1.62ns 6.28ns 0.0535 0 0 3.78 KB
#5316 ObjectExtractorMoreComplexBody netcoreapp3.1 3.79μs 1.89ns 7.3ns 0.0493 0 0 3.69 KB
#5316 ObjectExtractorMoreComplexBody net472 3.77μs 3.82ns 14.8ns 0.603 0.00569 0 3.8 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 187μs 410ns 1.59μs 0.0931 0 0 6.51 KB
master RunWafRealisticBenchmark netcoreapp3.1 202μs 389ns 1.51μs 0 0 0 6.49 KB
master RunWafRealisticBenchmark net472 224μs 96ns 372ns 1.01 0 0 6.59 KB
master RunWafRealisticBenchmarkWithAttack net6.0 126μs 59.2ns 229ns 0 0 0 4.15 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 134μs 83.8ns 325ns 0 0 0 4.14 KB
master RunWafRealisticBenchmarkWithAttack net472 146μs 108ns 416ns 0.653 0 0 4.19 KB
#5316 RunWafRealisticBenchmark net6.0 188μs 52.6ns 204ns 0.0957 0 0 6.51 KB
#5316 RunWafRealisticBenchmark netcoreapp3.1 204μs 117ns 455ns 0 0 0 6.49 KB
#5316 RunWafRealisticBenchmark net472 221μs 63.7ns 238ns 0.992 0 0 6.59 KB
#5316 RunWafRealisticBenchmarkWithAttack net6.0 125μs 219ns 790ns 0.0623 0 0 4.15 KB
#5316 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 135μs 83.9ns 325ns 0 0 0 4.14 KB
#5316 RunWafRealisticBenchmarkWithAttack net472 147μs 182ns 704ns 0.659 0 0 4.19 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5316

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 205.63 KB 212.22 KB 6.59 KB 3.21%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 200.93 KB 202.39 KB 1.46 KB 0.73%

Fewer allocations 🎉 in #5316

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 61.77 KB 59.54 KB -2.23 KB -3.61%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 51.5μs 125ns 468ns 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 53.2μs 236ns 851ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 36.7μs 53.6ns 193ns 0 0 0 61.77 KB
master StringConcatAspectBenchmark net6.0 296μs 1.51μs 6.58μs 0 0 0 205.63 KB
master StringConcatAspectBenchmark netcoreapp3.1 296μs 1.39μs 5.56μs 0 0 0 200.93 KB
master StringConcatAspectBenchmark net472 261μs 4.01μs 37.8μs 0 0 0 221.18 KB
#5316 StringConcatBenchmark net6.0 58.7μs 759ns 7.16μs 0 0 0 43.44 KB
#5316 StringConcatBenchmark netcoreapp3.1 53.3μs 256ns 993ns 0 0 0 42.64 KB
#5316 StringConcatBenchmark net472 37.9μs 83.1ns 300ns 0 0 0 59.54 KB
#5316 StringConcatAspectBenchmark net6.0 286μs 1.36μs 7.82μs 0 0 0 212.22 KB
#5316 StringConcatAspectBenchmark netcoreapp3.1 311μs 1.79μs 14μs 0 0 0 202.39 KB
#5316 StringConcatAspectBenchmark net472 267μs 6.08μs 57.7μs 0 0 0 221.18 KB

@link04 link04 merged commit 1f14db9 into master Mar 15, 2024
54 of 57 checks passed
@link04 link04 deleted the maximo/stop-snapshot-check-for-3.0 branch March 15, 2024 21:08
@github-actions github-actions bot added this to the vNext milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-romano-DD daniel-romano-DD daniel-romano-DD approved these changes

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:tests unit tests, integration tests
Projects
None yet
Milestone
2.49.0
Development

Successfully merging this pull request may close these issues.
3 participants
@link04 @andrewlock @daniel-romano-DD