Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running All Datadog.Trace.ClrProfiler.IntegrationTests Tests Serially #5310

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Running All Datadog.Trace.ClrProfiler.IntegrationTests Tests Serially #5310

merged 1 commit into from
Mar 15, 2024

Conversation

link04
Copy link
Contributor

@link04 link04 commented Mar 15, 2024

Summary of changes

Added an if statement to disable running tests in parallel if they live within the Datadog.Trace.ClrProfiler.IntegrationTests assembly.

Reason for change

To test and monitor the error rate of tests within this assembly in master(if any 😼).

@link04 link04 requested a review from a team as a code owner March 15, 2024 00:11
@github-actions github-actions bot added the area:tests unit tests, integration tests label Mar 15, 2024
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Mar 15, 2024 •
edited
Loading

Datadog Report

Branch report: maximo/updating-tests-to-serial-run
Commit report: bef54fb
Test service: dd-trace-dotnet

✅ 0 Failed, 331466 Passed, 1594 Skipped, 35m 26.58s Wall Time

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5310) - mean (74ms)  : 66, 82
     .   : milestone, 74,
    master - mean (74ms)  : 67, 82
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5310) - mean (1,005ms)  : 987, 1024
     .   : milestone, 1005,
    master - mean (1,027ms)  : 1010, 1044
     .   : milestone, 1027,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5310) - mean (110ms)  : 107, 113
     .   : milestone, 110,
    master - mean (113ms)  : 109, 117
     .   : milestone, 113,

    section CallTarget+Inlining+NGEN
    This PR (5310) - mean (734ms)  : 710, 758
     .   : milestone, 734,
    master - mean (750ms)  : 733, 767
     .   : milestone, 750,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5310) - mean (95ms)  : 92, 97
     .   : milestone, 95,
    master - mean (96ms)  : 93, 100
     .   : milestone, 96,

    section CallTarget+Inlining+NGEN
    This PR (5310) - mean (694ms)  : 668, 720
     .   : milestone, 694,
    master - mean (706ms)  : 688, 723
     .   : milestone, 706,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5310) - mean (188ms)  : 186, 191
     .   : milestone, 188,
    master - mean (187ms)  : 185, 190
     .   : milestone, 187,

    section CallTarget+Inlining+NGEN
    This PR (5310) - mean (1,082ms)  : 1055, 1108
     .   : milestone, 1082,
    master - mean (1,082ms)  : 1061, 1103
     .   : milestone, 1082,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5310) - mean (271ms)  : 268, 274
     .   : milestone, 271,
    master - mean (270ms)  : 265, 275
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (5310) - mean (881ms)  : 863, 898
     .   : milestone, 881,
    master - mean (881ms)  : 858, 904
     .   : milestone, 881,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5310) - mean (259ms)  : 256, 263
     .   : milestone, 259,
    master - mean (260ms)  : 257, 262
     .   : milestone, 260,

    section CallTarget+Inlining+NGEN
    This PR (5310) - mean (867ms)  : 847, 886
     .   : milestone, 867,
    master - mean (871ms)  : 845, 897
     .   : milestone, 871,
Loading

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #5310 compared to master:

  • 4 benchmarks are slower, with geometric mean 1.160
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.75μs 45.7ns 270ns 0.0171 0.00857 0 7.51 KB
master StartStopWithChild netcoreapp3.1 10.7μs 56.4ns 298ns 0.0211 0.0106 0 7.61 KB
master StartStopWithChild net472 17.1μs 71ns 275ns 1.36 0.331 0.102 8.14 KB
#5310 StartStopWithChild net6.0 8.9μs 50.1ns 344ns 0.0223 0.00894 0 7.51 KB
#5310 StartStopWithChild netcoreapp3.1 10.7μs 57.5ns 325ns 0.0257 0.0103 0 7.6 KB
#5310 StartStopWithChild net472 17.2μs 41.8ns 162ns 1.37 0.349 0.116 8.13 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 467μs 261ns 940ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 636μs 225ns 871ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 818μs 564ns 2.19μs 0.406 0 0 3.3 KB
#5310 WriteAndFlushEnrichedTraces net6.0 444μs 193ns 722ns 0 0 0 2.7 KB
#5310 WriteAndFlushEnrichedTraces netcoreapp3.1 630μs 529ns 2.05μs 0 0 0 2.7 KB
#5310 WriteAndFlushEnrichedTraces net472 783μs 421ns 1.58μs 0.388 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 171μs 108ns 419ns 0.255 0 0 18.33 KB
master SendRequest netcoreapp3.1 191μs 281ns 1.09μs 0.188 0 0 20.49 KB
master SendRequest net472 0.000401ns 0.000151ns 0.000563ns 0 0 0 0 b
#5310 SendRequest net6.0 171μs 168ns 651ns 0.171 0 0 18.33 KB
#5310 SendRequest netcoreapp3.1 195μs 248ns 960ns 0.193 0 0 20.49 KB
#5310 SendRequest net472 0.000493ns 0.000274ns 0.00102ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 569μs 680ns 2.45μs 0.558 0 0 41.59 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 655μs 407ns 1.58μs 0.329 0 0 41.78 KB
master WriteAndFlushEnrichedTraces net472 879μs 4.16μs 17.1μs 8.3 2.62 0.437 53.26 KB
#5310 WriteAndFlushEnrichedTraces net6.0 539μs 206ns 798ns 0.534 0 0 41.74 KB
#5310 WriteAndFlushEnrichedTraces netcoreapp3.1 654μs 2.16μs 8.38μs 0.322 0 0 41.98 KB
#5310 WriteAndFlushEnrichedTraces net472 875μs 4.27μs 17.6μs 8.36 2.64 0.44 53.26 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.09μs 0.58ns 2.17ns 0.011 0 0 784 B
master ExecuteNonQuery netcoreapp3.1 1.47μs 0.409ns 1.47ns 0.0102 0 0 784 B
master ExecuteNonQuery net472 1.81μs 0.95ns 3.55ns 0.118 0 0 746 B
#5310 ExecuteNonQuery net6.0 1.12μs 0.565ns 2.19ns 0.0107 0 0 784 B
#5310 ExecuteNonQuery netcoreapp3.1 1.44μs 0.631ns 2.44ns 0.0105 0 0 784 B
#5310 ExecuteNonQuery net472 1.8μs 0.47ns 1.82ns 0.118 0 0 746 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.33μs 0.64ns 2.4ns 0.0141 0 0 1.01 KB
master CallElasticsearch netcoreapp3.1 1.6μs 1.33ns 4.96ns 0.0139 0 0 1.01 KB
master CallElasticsearch net472 2.42μs 1.59ns 6.14ns 0.162 0 0 1.02 KB
master CallElasticsearchAsync net6.0 1.37μs 0.876ns 3.28ns 0.0137 0 0 984 B
master CallElasticsearchAsync netcoreapp3.1 1.59μs 0.871ns 3.26ns 0.0145 0 0 1.06 KB
master CallElasticsearchAsync net472 2.67μs 1.59ns 6.15ns 0.17 0 0 1.08 KB
#5310 CallElasticsearch net6.0 1.36μs 1.14ns 4.41ns 0.0143 0 0 1.01 KB
#5310 CallElasticsearch netcoreapp3.1 1.7μs 1.96ns 7.35ns 0.0136 0 0 1.01 KB
#5310 CallElasticsearch net472 2.41μs 1.04ns 4.04ns 0.161 0 0 1.02 KB
#5310 CallElasticsearchAsync net6.0 1.31μs 0.744ns 2.78ns 0.0137 0 0 984 B
#5310 CallElasticsearchAsync netcoreapp3.1 1.65μs 2.78ns 10.4ns 0.0143 0 0 1.06 KB
#5310 CallElasticsearchAsync net472 2.56μs 2.85ns 11ns 0.171 0 0 1.08 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.37μs 1.14ns 4.43ns 0.0131 0 0 928 B
master ExecuteAsync netcoreapp3.1 1.67μs 1.14ns 4.12ns 0.0126 0 0 928 B
master ExecuteAsync net472 1.89μs 3.16ns 12.2ns 0.141 0 0 891 B
#5310 ExecuteAsync net6.0 1.26μs 0.992ns 3.71ns 0.013 0 0 928 B
#5310 ExecuteAsync netcoreapp3.1 1.69μs 0.881ns 3.3ns 0.0118 0 0 928 B
#5310 ExecuteAsync net472 1.86μs 2.29ns 8.89ns 0.141 0 0 891 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.46μs 14.6ns 56.7ns 0.029 0 0 2.16 KB
master SendAsync netcoreapp3.1 4.97μs 6.56ns 24.5ns 0.0377 0 0 2.7 KB
master SendAsync net472 7.73μs 1.82ns 7.04ns 0.533 0 0 3.38 KB
#5310 SendAsync net6.0 4.19μs 4.46ns 16.7ns 0.0293 0 0 2.16 KB
#5310 SendAsync netcoreapp3.1 4.98μs 2.95ns 10.2ns 0.0347 0 0 2.7 KB
#5310 SendAsync net472 7.84μs 3.24ns 12.1ns 0.535 0 0 3.38 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.49μs 0.471ns 1.7ns 0.0232 0 0 1.65 KB
master EnrichedLog netcoreapp3.1 2.32μs 1.46ns 5.48ns 0.0219 0 0 1.65 KB
master EnrichedLog net472 2.59μs 1.29ns 4.84ns 0.249 0 0 1.57 KB
#5310 EnrichedLog net6.0 1.53μs 0.452ns 1.63ns 0.0229 0 0 1.65 KB
#5310 EnrichedLog netcoreapp3.1 2.21μs 3.59ns 13.4ns 0.0218 0 0 1.65 KB
#5310 EnrichedLog net472 2.69μs 1.74ns 6.51ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 116μs 199ns 744ns 0.0572 0 0 4.23 KB
master EnrichedLog netcoreapp3.1 118μs 214ns 828ns 0 0 0 4.23 KB
master EnrichedLog net472 146μs 62.9ns 244ns 0.657 0.219 0 4.41 KB
#5310 EnrichedLog net6.0 113μs 165ns 638ns 0 0 0 4.23 KB
#5310 EnrichedLog netcoreapp3.1 117μs 85ns 295ns 0.059 0 0 4.23 KB
#5310 EnrichedLog net472 147μs 81ns 292ns 0.66 0.22 0 4.41 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.92μs 1.04ns 3.74ns 0.0306 0 0 2.21 KB
master EnrichedLog netcoreapp3.1 4.18μs 2.71ns 10.5ns 0.0294 0 0 2.21 KB
master EnrichedLog net472 4.95μs 2.57ns 9.27ns 0.32 0 0 2.02 KB
#5310 EnrichedLog net6.0 2.87μs 2.08ns 7.51ns 0.0304 0 0 2.21 KB
#5310 EnrichedLog netcoreapp3.1 4.12μs 1.38ns 4.97ns 0.0291 0 0 2.21 KB
#5310 EnrichedLog net472 4.89μs 2.24ns 8.39ns 0.321 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.4μs 0.7ns 2.62ns 0.0161 0 0 1.18 KB
master SendReceive netcoreapp3.1 1.73μs 0.597ns 2.15ns 0.0156 0 0 1.18 KB
master SendReceive net472 2.31μs 1.16ns 4.36ns 0.187 0.00115 0 1.18 KB
#5310 SendReceive net6.0 1.53μs 1.39ns 5.21ns 0.0168 0 0 1.18 KB
#5310 SendReceive netcoreapp3.1 1.83μs 1.97ns 7.36ns 0.0154 0 0 1.18 KB
#5310 SendReceive net472 2.17μs 0.947ns 3.55ns 0.187 0 0 1.18 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.83μs 7.67ns 27.7ns 0.0212 0 0 1.55 KB
master EnrichedLog netcoreapp3.1 3.79μs 1.59ns 5.75ns 0.0209 0 0 1.6 KB
master EnrichedLog net472 4.29μs 1.53ns 5.74ns 0.315 0 0 1.99 KB
#5310 EnrichedLog net6.0 2.73μs 0.844ns 3.16ns 0.0218 0 0 1.55 KB
#5310 EnrichedLog netcoreapp3.1 3.84μs 3.29ns 12.8ns 0.0212 0 0 1.6 KB
#5310 EnrichedLog net472 4.43μs 1.96ns 7.34ns 0.316 0 0 1.99 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5310

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.262 449.67 567.61 bimodal
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.134 759.28 861.37
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 1.119 897.60 1,004.42

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 460ns 2.63ns 18.4ns 0.00776 0 0 552 B
master StartFinishSpan netcoreapp3.1 709ns 0.756ns 2.83ns 0.00739 0 0 552 B
master StartFinishSpan net472 776ns 1.8ns 6.98ns 0.088 0 0 554 B
master StartFinishScope net6.0 578ns 0.549ns 2.13ns 0.00945 0 0 672 B
master StartFinishScope netcoreapp3.1 759ns 0.584ns 2.26ns 0.00895 0 0 672 B
master StartFinishScope net472 895ns 1.5ns 5.8ns 0.1 0 0 634 B
#5310 StartFinishSpan net6.0 567ns 1.14ns 4.4ns 0.00779 0 0 552 B
#5310 StartFinishSpan netcoreapp3.1 669ns 1.08ns 4.2ns 0.00752 0 0 552 B
#5310 StartFinishSpan net472 775ns 1.15ns 4.46ns 0.0877 0 0 554 B
#5310 StartFinishScope net6.0 621ns 0.758ns 2.93ns 0.00933 0 0 672 B
#5310 StartFinishScope netcoreapp3.1 862ns 0.87ns 3.14ns 0.00891 0 0 672 B
#5310 StartFinishScope net472 1μs 1.43ns 5.15ns 0.1 0 0 634 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5310

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.128 615.27 694.31

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 615ns 0.338ns 1.31ns 0.00951 0 0 672 B
master RunOnMethodBegin netcoreapp3.1 932ns 1.63ns 6.32ns 0.00894 0 0 672 B
master RunOnMethodBegin net472 1.05μs 1.35ns 5.23ns 0.1 0 0 634 B
#5310 RunOnMethodBegin net6.0 693ns 0.911ns 3.53ns 0.00936 0 0 672 B
#5310 RunOnMethodBegin netcoreapp3.1 929ns 0.745ns 2.88ns 0.00947 0 0 672 B
#5310 RunOnMethodBegin net472 1.07μs 1.57ns 6.09ns 0.101 0 0 634 B

@andrewlock
Copy link
Member

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5310) (10.984M)   : 0, 10984048
    master (11.017M)   : 0, 11017015
    benchmarks/2.9.0 (11.247M)   : 0, 11247223

    section Automatic
    This PR (5310) (7.592M)   : 0, 7592250
    master (7.508M)   : 0, 7508030
    benchmarks/2.9.0 (8.075M)   : 0, 8075266

    section Trace stats
    This PR (5310) (7.979M)   : 0, 7978827
    master (7.722M)   : 0, 7721813

    section Manual
    This PR (5310) (9.667M)   : 0, 9666773
    master (9.535M)   : 0, 9535238

    section Manual + Automatic
    This PR (5310) (7.347M)   : 0, 7347272
    master (7.064M)   : 0, 7063872

    section Version Conflict
    This PR (5310) (6.549M)   : 0, 6548810
    master (6.347M)   : 0, 6347078
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5310) (9.751M)   : 0, 9750880
    master (9.504M)   : 0, 9503748
    benchmarks/2.9.0 (9.694M)   : 0, 9694479

    section Automatic
    This PR (5310) (6.401M)   : 0, 6401359
    master (6.599M)   : 0, 6599196

    section Trace stats
    This PR (5310) (6.898M)   : 0, 6897986
    master (6.588M)   : 0, 6587752

    section Manual
    This PR (5310) (8.260M)   : 0, 8259760
    master (8.179M)   : 0, 8179137

    section Manual + Automatic
    This PR (5310) (6.187M)   : 0, 6187070
    master (6.190M)   : 0, 6190340

    section Version Conflict
    This PR (5310) (5.537M)   : 0, 5537190
    master (5.558M)   : 0, 5558386
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5310) (9.396M)   : 0, 9395869
    master (9.282M)   : 0, 9281749
    benchmarks/2.9.0 (9.301M)   : 0, 9300867

    section Automatic
    This PR (5310) (6.679M)   : 0, 6678560
    master (6.684M)   : 0, 6684085
    benchmarks/2.9.0 (7.022M)   : 0, 7021879

    section Trace stats
    This PR (5310) (6.921M)   : 0, 6921073
    master (6.915M)   : 0, 6915432

    section Manual
    This PR (5310) (8.270M)   : 0, 8270229
    master (8.285M)   : 0, 8284898

    section Manual + Automatic
    This PR (5310) (6.447M)   : 0, 6446710
    master (6.542M)   : 0, 6541818

    section Version Conflict
    This PR (5310) (5.744M)   : 0, 5744285
    master (5.892M)   : 0, 5891780
Loading

andrewlock
andrewlock approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@link04 link04 merged commit f32a53d into master Mar 15, 2024
56 checks passed
@link04 link04 deleted the maximo/updating-tests-to-serial-run branch March 15, 2024 13:46
@github-actions github-actions bot added this to the vNext milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:tests unit tests, integration tests
Projects
None yet
Milestone
2.49.0
Development

Successfully merging this pull request may close these issues.
2 participants
@link04 @andrewlock