Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip .NET Core 2.1 tests on ARM64 #5283

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Skip .NET Core 2.1 tests on ARM64 #5283

merged 1 commit into from
Mar 7, 2024

Conversation

kevingosse
Copy link
Collaborator

Summary of changes

Skip .NET Core 2.1 tests on ARM64

Reason for change

The obfuscator regex crashes with .NET Core 2.1 on ARM64, and we don't support this runtime on that platform anyway.

Implementation details

Filtering the runtime/platform in Nuke.

Other details

Required to unblock #5266.

@kevingosse kevingosse requested a review from a team as a code owner March 7, 2024 10:22
@github-actions github-actions bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Mar 7, 2024
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Mar 7, 2024

Datadog Report

Branch report: kevin/arm64_2.1
Commit report: c657752
Test service: dd-trace-dotnet

✅ 0 Failed, 335038 Passed, 1564 Skipped, 34m 53.98s Wall Time
⌛ 1 Performance Regression

⌛ Performance Regressions vs Default Branch (1)

  • Profiler_contention_cpu_walltime - scenarios 2.58s (+195.28ms, +8%) - Details

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5283) - mean (72ms)  : 65, 80
     .   : milestone, 72,
    master - mean (74ms)  : 66, 83
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5283) - mean (989ms)  : 968, 1009
     .   : milestone, 989,
    master - mean (996ms)  : 972, 1020
     .   : milestone, 996,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5283) - mean (111ms)  : 107, 114
     .   : milestone, 111,
    master - mean (111ms)  : 108, 115
     .   : milestone, 111,

    section CallTarget+Inlining+NGEN
    This PR (5283) - mean (718ms)  : 695, 742
     .   : milestone, 718,
    master - mean (717ms)  : 686, 749
     .   : milestone, 717,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5283) - mean (95ms)  : 90, 99
     .   : milestone, 95,
    master - mean (94ms)  : 91, 97
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (5283) - mean (672ms)  : 648, 696
     .   : milestone, 672,
    master - mean (676ms)  : 641, 712
     .   : milestone, 676,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5283) - mean (188ms)  : 184, 191
     .   : milestone, 188,
    master - mean (188ms)  : 186, 190
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (5283) - mean (1,063ms)  : 1034, 1092
     .   : milestone, 1063,
    master - mean (1,064ms)  : 1037, 1091
     .   : milestone, 1064,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5283) - mean (270ms)  : 266, 275
     .   : milestone, 270,
    master - mean (271ms)  : 268, 275
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (5283) - mean (865ms)  : 842, 888
     .   : milestone, 865,
    master - mean (871ms)  : 843, 899
     .   : milestone, 871,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5283) - mean (259ms)  : 255, 264
     .   : milestone, 259,
    master - mean (261ms)  : 257, 265
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (5283) - mean (850ms)  : 829, 872
     .   : milestone, 850,
    master - mean (857ms)  : 833, 881
     .   : milestone, 857,

Loading

@kevingosse kevingosse merged commit c465743 into master Mar 7, 2024
53 of 56 checks passed
@kevingosse kevingosse deleted the kevin/arm64_2.1 branch March 7, 2024 14:08
@github-actions github-actions bot added this to the vNext milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants