[Dynamic Instrumentation] Fix not equal (ne\!=) operator in EL #5212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 312269 Passed, 2029 Skipped, 41m 23.19s Wall Time ⌛ Performance Regressions vs Default Branch (1)
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5212) - mean (73ms) : 65, 82
. : milestone, 73,
master - mean (72ms) : 63, 82
. : milestone, 72,
section CallTarget+Inlining+NGEN
This PR (5212) - mean (985ms) : 963, 1008
. : milestone, 985,
master - mean (988ms) : 968, 1008
. : milestone, 988,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5212) - mean (110ms) : 107, 112
. : milestone, 110,
master - mean (110ms) : 107, 114
. : milestone, 110,
section CallTarget+Inlining+NGEN
This PR (5212) - mean (713ms) : 688, 738
. : milestone, 713,
master - mean (718ms) : 696, 740
. : milestone, 718,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5212) - mean (97ms) : 93, 101
. : milestone, 97,
master - mean (94ms) : 91, 98
. : milestone, 94,
section CallTarget+Inlining+NGEN
This PR (5212) - mean (661ms) : 638, 685
. : milestone, 661,
master - mean (674ms) : 651, 698
. : milestone, 674,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5212) - mean (188ms) : 184, 192
. : milestone, 188,
master - mean (188ms) : 185, 191
. : milestone, 188,
section CallTarget+Inlining+NGEN
This PR (5212) - mean (1,058ms) : 1036, 1080
. : milestone, 1058,
master - mean (1,067ms) : 1043, 1090
. : milestone, 1067,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5212) - mean (271ms) : 266, 276
. : milestone, 271,
master - mean (271ms) : 267, 274
. : milestone, 271,
section CallTarget+Inlining+NGEN
This PR (5212) - mean (865ms) : 834, 896
. : milestone, 865,
master - mean (870ms) : 838, 902
. : milestone, 870,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5212) - mean (260ms) : 257, 263
. : milestone, 260,
master - mean (260ms) : 257, 263
. : milestone, 260,
section CallTarget+Inlining+NGEN
This PR (5212) - mean (848ms) : 827, 869
. : milestone, 848,
master - mean (851ms) : 830, 873
. : milestone, 851,
|
Throughput/Crank Report:zap:Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5212) (11.123M) : 0, 11123366
master (11.441M) : 0, 11441140
benchmarks/2.9.0 (10.834M) : 0, 10833884
section Automatic
This PR (5212) (7.725M) : 0, 7725401
master (7.668M) : 0, 7667570
benchmarks/2.9.0 (7.842M) : 0, 7841734
section Trace stats
This PR (5212) (8.009M) : 0, 8009446
master (8.166M) : 0, 8166448
section Manual
This PR (5212) (9.781M) : 0, 9781306
master (9.973M) : 0, 9972807
section Manual + Automatic
This PR (5212) (7.388M) : 0, 7387622
master (7.456M) : 0, 7456170
section Version Conflict
This PR (5212) (6.636M) : 0, 6635574
master (6.593M) : 0, 6592685
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5212) (9.630M) : 0, 9629625
master (9.813M) : 0, 9813336
benchmarks/2.9.0 (9.534M) : 0, 9534497
section Automatic
This PR (5212) (6.627M) : 0, 6626741
master (6.742M) : 0, 6741806
section Trace stats
This PR (5212) (6.900M) : 0, 6899888
master (6.893M) : 0, 6893482
section Manual
This PR (5212) (8.137M) : 0, 8137318
master (8.334M) : 0, 8333838
section Manual + Automatic
This PR (5212) (6.171M) : 0, 6171122
master (6.182M) : 0, 6182245
section Version Conflict
This PR (5212) (5.558M) : 0, 5558380
master (5.596M) : 0, 5595993
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5212) (10.205M) : 0, 10205252
master (10.323M) : 0, 10322809
benchmarks/2.9.0 (10.178M) : 0, 10178311
section Automatic
This PR (5212) (7.218M) : 0, 7217536
master (7.283M) : 0, 7282890
benchmarks/2.9.0 (7.446M) : 0, 7445613
section Trace stats
This PR (5212) (7.586M) : 0, 7586123
master (7.607M) : 0, 7607163
section Manual
This PR (5212) (9.220M) : 0, 9219797
master (9.021M) : 0, 9021167
section Manual + Automatic
This PR (5212) (7.036M) : 0, 7036243
master (6.996M) : 0, 6995693
section Version Conflict
This PR (5212) (6.318M) : 0, 6318370
master (6.440M) : 0, 6439981
gantt
title Throughput Linux x64 (ASM) (Total requests)
dateFormat X
axisFormat %s
section Baseline
master (7.406M) : 0, 7405870
benchmarks/2.9.0 (7.752M) : 0, 7751668
section No attack
master (1.828M) : 0, 1827667
benchmarks/2.9.0 (3.208M) : 0, 3207733
section Attack
master (1.448M) : 0, 1447929
benchmarks/2.9.0 (2.458M) : 0, 2457864
section Blocking
master (3.108M) : 0, 3108020
section IAST default
master (6.401M) : 0, 6400808
section IAST full
master (5.548M) : 0, 5547501
section Base vuln
master (0.959M) : 0, 959432
section IAST vuln
master (0.829M) : 0, 829471
|
dudikeleti
force-pushed
the
dudik/fix-ne-operator
branch
from
84c5ebb to
3606c0a
Compare
Datadog ReportBranch report: ✅ 0 Failed, 333770 Passed, 2057 Skipped, 35m 37.7s Wall Time ⌛ Performance Regressions vs Default Branch (1)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR fixes a bug in our expression language where != was handled incorrect.
Test coverage
NotEqial.json