[Dynamic Instrumentation] Made the captured members size flexible due to `IndexOutOfRangeException` #5099

GreenMatan · 2024-01-23T09:37:10Z

Summary of changes

We had a support case of a customer that encountered IndexOutOfRangeException when a new local/arg was inserted in async methods.

Reason for change

When there's no PDB we can not know how many locals a method has. It led to an issue when the bytecode instrumentation tried to push new local, and the underlying array didn't have the capacity to handle it.

Implementation details

The size of the members is made flexible.

datadog-ddstaging · 2024-01-23T09:52:23Z

Datadog Report

Branch report: matang/temp-fix-members-grow
Commit report: 7260bde
Test service: dd-trace-dotnet

✅ 0 Failed, 307701 Passed, 2022 Skipped, 58m 46.73s Wall Time

andrewlock · 2024-01-23T10:01:22Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5099) - mean (72ms)  : 58, 86
     .   : milestone, 72,
    master - mean (72ms)  : 60, 83
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (5099) - mean (954ms)  : 932, 975
     .   : milestone, 954,
    master - mean (959ms)  : 938, 979
     .   : milestone, 959,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5099) - mean (106ms)  : 103, 110
     .   : milestone, 106,
    master - mean (108ms)  : 104, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (5099) - mean (696ms)  : 674, 718
     .   : milestone, 696,
    master - mean (701ms)  : 683, 718
     .   : milestone, 701,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5099) - mean (90ms)  : 87, 92
     .   : milestone, 90,
    master - mean (91ms)  : 88, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (5099) - mean (648ms)  : 628, 668
     .   : milestone, 648,
    master - mean (648ms)  : 628, 669
     .   : milestone, 648,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5099) - mean (188ms)  : 185, 191
     .   : milestone, 188,
    master - mean (188ms)  : 184, 193
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (5099) - mean (1,069ms)  : 1043, 1095
     .   : milestone, 1069,
    master - mean (1,069ms)  : 1045, 1092
     .   : milestone, 1069,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5099) - mean (272ms)  : 268, 277
     .   : milestone, 272,
    master - mean (272ms)  : 267, 278
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (5099) - mean (1,053ms)  : 1028, 1079
     .   : milestone, 1053,
    master - mean (1,051ms)  : 1021, 1080
     .   : milestone, 1051,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5099) - mean (261ms)  : 258, 265
     .   : milestone, 261,
    master - mean (261ms)  : 256, 265
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (5099) - mean (1,021ms)  : 991, 1050
     .   : milestone, 1021,
    master - mean (1,015ms)  : 996, 1034
     .   : milestone, 1015,

…ios when there was no PDB

andrewlock · 2024-01-23T12:23:59Z

Benchmarks Report 🐌

Benchmarks for #5099 compared to master:

3 benchmarks are faster, with geometric mean 1.177
2 benchmarks have fewer allocations
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.83μs	46.5ns	237ns	0.0217	0.00434	0	7.48 KB
master	`StartStopWithChild`	netcoreapp3.1	10.9μs	58.5ns	321ns	0.0223	0.0111	0	7.58 KB
master	`StartStopWithChild`	net472	17.3μs	34.2ns	132ns	1.32	0.344	0.112	7.94 KB
#5099	`StartStopWithChild`	net6.0	8.68μs	46.1ns	239ns	0.0361	0.018	0	7.48 KB
#5099	`StartStopWithChild`	netcoreapp3.1	10.9μs	50.6ns	196ns	0.0209	0.0105	0	7.58 KB
#5099	`StartStopWithChild`	net472	17.3μs	53.5ns	207ns	1.34	0.346	0.121	7.95 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	471μs	190ns	736ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	623μs	159ns	593ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	781μs	454ns	1.76μs	0.391	3.3 KB
#5099	`WriteAndFlushEnrichedTraces`	net6.0	479μs	221ns	858ns	0	2.7 KB
#5099	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	633μs	175ns	655ns	0	2.7 KB
#5099	`WriteAndFlushEnrichedTraces`	net472	785μs	221ns	798ns	0.398	3.3 KB

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5099

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑netcoreapp3.1	1.270	250.17	196.95

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`AllCycleSimpleBody`	net6.0	38.4μs	15.5ns	58ns	0.0193	0	1.77 KB
master	`AllCycleSimpleBody`	netcoreapp3.1	41.9μs	65.1ns	252ns	0.0209	0	1.74 KB
master	`AllCycleSimpleBody`	net472	45.4μs	40.7ns	158ns	0.271	0	1.81 KB
master	`AllCycleMoreComplexBody`	net6.0	199μs	37.9ns	137ns	0.0998	0	9.25 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	212μs	371ns	1.44μs	0.105	0	9.14 KB
master	`AllCycleMoreComplexBody`	net472	226μs	135ns	525ns	1.46	0	9.32 KB
master	`ObjectExtractorSimpleBody`	net6.0	139ns	0.189ns	0.731ns	0.00394	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	250ns	0.192ns	0.742ns	0.00362	0	272 B
master	`ObjectExtractorSimpleBody`	net472	169ns	0.244ns	0.944ns	0.0446	0	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	3.02μs	1.62ns	6.26ns	0.0538	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	4.02μs	2.09ns	7.81ns	0.0482	0	3.69 KB
master	`ObjectExtractorMoreComplexBody`	net472	3.7μs	1.23ns	4.42ns	0.603	0.00553	3.8 KB
#5099	`AllCycleSimpleBody`	net6.0	38.2μs	14.8ns	55.2ns	0.0192	0	1.77 KB
#5099	`AllCycleSimpleBody`	netcoreapp3.1	41.6μs	76.9ns	298ns	0.0206	0	1.74 KB
#5099	`AllCycleSimpleBody`	net472	45.2μs	17.9ns	66.8ns	0.269	0	1.81 KB
#5099	`AllCycleMoreComplexBody`	net6.0	200μs	33.1ns	124ns	0.0986	0	9.25 KB
#5099	`AllCycleMoreComplexBody`	netcoreapp3.1	213μs	149ns	576ns	0.105	0	9.14 KB
#5099	`AllCycleMoreComplexBody`	net472	227μs	631ns	2.45μs	1.46	0	9.32 KB
#5099	`ObjectExtractorSimpleBody`	net6.0	142ns	0.108ns	0.404ns	0.00395	0	280 B
#5099	`ObjectExtractorSimpleBody`	netcoreapp3.1	197ns	0.143ns	0.555ns	0.00368	0	272 B
#5099	`ObjectExtractorSimpleBody`	net472	169ns	0.119ns	0.427ns	0.0446	0	281 B
#5099	`ObjectExtractorMoreComplexBody`	net6.0	2.98μs	2.9ns	10.9ns	0.0536	0	3.78 KB
#5099	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	3.94μs	2.61ns	10.1ns	0.0492	0	3.69 KB
#5099	`ObjectExtractorMoreComplexBody`	net472	3.72μs	2.42ns	9.39ns	0.602	0.00557	3.8 KB

Benchmarks.Trace.Asm.AppSecWafBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5099

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWaf(args: NestedMap (20))‑net6.0	1.120	109,500.79	97,769.92

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`RunWaf(args=NestedMap (10))`	net6.0	57.1μs	327ns	2.45μs	0.204	0	16.06 KB
master	`RunWaf(args=NestedMap (10))`	netcoreapp3.1	70.4μs	401ns	2.8μs	0.211	0	16.06 KB
master	`RunWaf(args=NestedMap (10))`	net472	101μs	49.8ns	186ns	2.56	0.0966	16.14 KB
master	`RunWafTwice(args=NestedMap (10))`	net6.0	57.3μs	145ns	666ns	0.231	0	16.6 KB
master	`RunWafTwice(args=NestedMap (10))`	netcoreapp3.1	73.9μs	349ns	1.44μs	0.192	0	16.58 KB
master	`RunWafTwice(args=NestedMap (10))`	net472	108μs	69.4ns	250ns	2.63	0.103	16.69 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	115μs	59.9ns	232ns	0.325	0	22.41 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	129μs	153ns	551ns	0.258	0	22.36 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	161μs	824ns	3.69μs	3.54	0.157	22.7 KB
master	`RunWaf(args=NestedMap (100))`	net6.0	101μs	28.3ns	110ns	0.453	0	32.76 KB
master	`RunWaf(args=NestedMap (100))`	netcoreapp3.1	135μs	451ns	1.75μs	0.408	0	33.33 KB
master	`RunWaf(args=NestedMap (100))`	net472	185μs	81.6ns	294ns	5.29	0.371	33.67 KB
master	`RunWafTwice(args=NestedMap (100))`	net6.0	105μs	29.2ns	113ns	0.473	0	33.3 KB
master	`RunWafTwice(args=NestedMap (100))`	netcoreapp3.1	140μs	769ns	4.68μs	0.457	0	33.86 KB
master	`RunWafTwice(args=NestedMap (100))`	net472	196μs	173ns	670ns	5.41	0.386	34.23 KB
master	`RunWafWithAttack(args=Neste(...)tack) [23])`	net6.0	166μs	62ns	223ns	0.495	0	39.1 KB
master	`RunWafWithAttack(args=Neste(...)tack) [23])`	netcoreapp3.1	201μs	438ns	1.7μs	0.484	0	39.63 KB
master	`RunWafWithAttack(args=Neste(...)tack) [23])`	net472	256μs	1.21μs	4.68μs	6.29	0.503	40.23 KB
master	`RunWaf(args=NestedMap (20))`	net6.0	109μs	319ns	1.24μs	0.46	0	32.18 KB
master	`RunWaf(args=NestedMap (20))`	netcoreapp3.1	138μs	198ns	768ns	0.41	0	32.3 KB
master	`RunWaf(args=NestedMap (20))`	net472	185μs	53.4ns	200ns	5.15	0.368	32.63 KB
master	`RunWafTwice(args=NestedMap (20))`	net6.0	101μs	332ns	1.29μs	0.464	0	32.72 KB
master	`RunWafTwice(args=NestedMap (20))`	netcoreapp3.1	137μs	746ns	4.02μs	0.39	0	32.82 KB
master	`RunWafTwice(args=NestedMap (20))`	net472	194μs	234ns	906ns	5.22	0.387	33.19 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	161μs	35.4ns	132ns	0.482	0	38.53 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	195μs	67.8ns	244ns	0.516	0	38.6 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	254μs	197ns	762ns	6.21	0.507	39.2 KB
#5099	`RunWaf(args=NestedMap (10))`	net6.0	55.4μs	318ns	2.33μs	0.206	0	16.06 KB
#5099	`RunWaf(args=NestedMap (10))`	netcoreapp3.1	68.4μs	394ns	3.15μs	0.206	0	16.06 KB
#5099	`RunWaf(args=NestedMap (10))`	net472	97μs	428ns	1.66μs	2.56	0.0948	16.14 KB
#5099	`RunWafTwice(args=NestedMap (10))`	net6.0	53.9μs	174ns	650ns	0.218	0	16.6 KB
#5099	`RunWafTwice(args=NestedMap (10))`	netcoreapp3.1	76.6μs	279ns	1.08μs	0.192	0	16.58 KB
#5099	`RunWafTwice(args=NestedMap (10))`	net472	108μs	82.7ns	309ns	2.62	0.103	16.69 KB
#5099	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	116μs	61.2ns	237ns	0.284	0	22.41 KB
#5099	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	131μs	623ns	2.41μs	0.262	0	22.36 KB
#5099	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	159μs	102ns	394ns	3.55	0.158	22.7 KB
#5099	`RunWaf(args=NestedMap (100))`	net6.0	105μs	88.8ns	344ns	0.437	0	32.76 KB
#5099	`RunWaf(args=NestedMap (100))`	netcoreapp3.1	139μs	171ns	662ns	0.448	0	33.33 KB
#5099	`RunWaf(args=NestedMap (100))`	net472	189μs	489ns	1.89μs	5.32	0.373	33.67 KB
#5099	`RunWafTwice(args=NestedMap (100))`	net6.0	110μs	55.8ns	201ns	0.472	0	33.3 KB
#5099	`RunWafTwice(args=NestedMap (100))`	netcoreapp3.1	143μs	165ns	639ns	0.429	0	33.86 KB
#5099	`RunWafTwice(args=NestedMap (100))`	net472	195μs	114ns	413ns	5.35	0.389	34.23 KB
#5099	`RunWafWithAttack(args=Neste(...)tack) [23])`	net6.0	172μs	123ns	475ns	0.504	0	39.1 KB
#5099	`RunWafWithAttack(args=Neste(...)tack) [23])`	netcoreapp3.1	200μs	132ns	474ns	0.493	0	39.63 KB
#5099	`RunWafWithAttack(args=Neste(...)tack) [23])`	net472	254μs	204ns	792ns	6.34	0.507	40.23 KB
#5099	`RunWaf(args=NestedMap (20))`	net6.0	97.8μs	22.8ns	82.3ns	0.471	0	32.18 KB
#5099	`RunWaf(args=NestedMap (20))`	netcoreapp3.1	135μs	738ns	4.18μs	0.442	0	32.3 KB
#5099	`RunWaf(args=NestedMap (20))`	net472	191μs	122ns	471ns	5.12	0.365	32.63 KB
#5099	`RunWafTwice(args=NestedMap (20))`	net6.0	100μs	20ns	77.6ns	0.425	0	32.72 KB
#5099	`RunWafTwice(args=NestedMap (20))`	netcoreapp3.1	136μs	718ns	3.44μs	0.454	0	32.82 KB
#5099	`RunWafTwice(args=NestedMap (20))`	net472	192μs	126ns	487ns	5.22	0.386	33.19 KB
#5099	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	161μs	98.3ns	381ns	0.478	0	38.53 KB
#5099	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	199μs	1.06μs	5.43μs	0.48	0	38.6 KB
#5099	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	256μs	1.19μs	4.61μs	6.17	0.504	39.2 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	172μs	258ns	966ns	0.259	18.25 KB
master	`SendRequest`	netcoreapp3.1	194μs	246ns	951ns	0.195	20.41 KB
master	`SendRequest`	net472	0.000163ns	0.000126ns	0.000473ns	0	0 b
#5099	`SendRequest`	net6.0	171μs	142ns	512ns	0.17	18.25 KB
#5099	`SendRequest`	netcoreapp3.1	194μs	323ns	1.25μs	0.192	20.41 KB
#5099	`SendRequest`	net472	0.000409ns	0.000171ns	0.000663ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #5099

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.79 KB	41.42 KB	-363 B	-0.87%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	555μs	630ns	2.44μs	0.543	0	0	41.79 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	652μs	866ns	3.35μs	0.332	0	0	41.63 KB
master	`WriteAndFlushEnrichedTraces`	net472	829μs	3.3μs	12.8μs	8.28	2.48	0.414	53.22 KB
#5099	`WriteAndFlushEnrichedTraces`	net6.0	532μs	270ns	1.01μs	0.523	0	0	41.42 KB
#5099	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	664μs	1.44μs	5.56μs	0.334	0	0	41.64 KB
#5099	`WriteAndFlushEnrichedTraces`	net472	851μs	2.85μs	11μs	8.19	2.59	0.431	53.28 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.09μs	0.801ns	3.1ns	0.0104	768 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.46μs	0.901ns	3.49ns	0.0103	768 B
master	`ExecuteNonQuery`	net472	1.76μs	1.85ns	7.17ns	0.116	730 B
#5099	`ExecuteNonQuery`	net6.0	1.12μs	0.731ns	2.83ns	0.0107	768 B
#5099	`ExecuteNonQuery`	netcoreapp3.1	1.59μs	0.843ns	3.15ns	0.0104	768 B
#5099	`ExecuteNonQuery`	net472	1.79μs	1.28ns	4.94ns	0.115	730 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.27μs	1.65ns	5.71ns	0.0129	936 B
master	`CallElasticsearch`	netcoreapp3.1	1.46μs	0.882ns	3.06ns	0.0126	936 B
master	`CallElasticsearch`	net472	2.54μs	1.38ns	5.36ns	0.152	955 B
master	`CallElasticsearchAsync`	net6.0	1.25μs	0.344ns	1.29ns	0.0125	912 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.62μs	0.739ns	2.77ns	0.013	984 B
master	`CallElasticsearchAsync`	net472	2.68μs	1.35ns	5.22ns	0.16	1.01 KB
#5099	`CallElasticsearch`	net6.0	1.36μs	0.303ns	1.13ns	0.0129	936 B
#5099	`CallElasticsearch`	netcoreapp3.1	1.53μs	0.707ns	2.64ns	0.0123	936 B
#5099	`CallElasticsearch`	net472	2.53μs	0.745ns	2.79ns	0.152	955 B
#5099	`CallElasticsearchAsync`	net6.0	1.37μs	0.682ns	2.64ns	0.0124	912 B
#5099	`CallElasticsearchAsync`	netcoreapp3.1	1.66μs	0.723ns	2.7ns	0.0133	984 B
#5099	`CallElasticsearchAsync`	net472	2.69μs	1.54ns	5.98ns	0.16	1.01 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.37μs	0.456ns	1.71ns	0.0125	912 B
master	`ExecuteAsync`	netcoreapp3.1	1.61μs	1.05ns	3.94ns	0.012	912 B
master	`ExecuteAsync`	net472	1.81μs	1.12ns	4.32ns	0.138	875 B
#5099	`ExecuteAsync`	net6.0	1.32μs	3.23ns	12.5ns	0.0125	912 B
#5099	`ExecuteAsync`	netcoreapp3.1	1.6μs	2.13ns	8.25ns	0.012	912 B
#5099	`ExecuteAsync`	net472	1.85μs	1.47ns	5.51ns	0.139	875 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.21μs	1.2ns	4.51ns	0.0294	2.1 KB
master	`SendAsync`	netcoreapp3.1	5.07μs	25.6ns	114ns	0.0347	2.63 KB
master	`SendAsync`	net472	7.76μs	2.81ns	10.1ns	0.523	3.31 KB
#5099	`SendAsync`	net6.0	4.15μs	1.22ns	4.57ns	0.0293	2.1 KB
#5099	`SendAsync`	netcoreapp3.1	4.84μs	1.7ns	6.37ns	0.0365	2.63 KB
#5099	`SendAsync`	net472	7.73μs	4.59ns	17.8ns	0.525	3.31 KB

Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5099

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1	212.7 KB	214.05 KB	1.35 KB	0.64%

Fewer allocations 🎉 in #5099

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0	213.75 KB	204.34 KB	-9.41 KB	-4.40%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`StringConcatBenchmark`	net6.0	62.9μs	942ns	9.13μs	43.44 KB
master	`StringConcatBenchmark`	netcoreapp3.1	53.3μs	111ns	673ns	42.64 KB
master	`StringConcatBenchmark`	net472	37.7μs	73.8ns	266ns	62.24 KB
master	`StringConcatAspectBenchmark`	net6.0	277μs	7.32μs	70.5μs	213.75 KB
master	`StringConcatAspectBenchmark`	netcoreapp3.1	289μs	2.76μs	25μs	212.7 KB
master	`StringConcatAspectBenchmark`	net472	253μs	4.7μs	45.3μs	221.18 KB
#5099	`StringConcatBenchmark`	net6.0	53.9μs	169ns	586ns	43.44 KB
#5099	`StringConcatBenchmark`	netcoreapp3.1	53.1μs	184ns	637ns	42.64 KB
#5099	`StringConcatBenchmark`	net472	37.3μs	130ns	488ns	62.07 KB
#5099	`StringConcatAspectBenchmark`	net6.0	270μs	5.83μs	54.4μs	204.34 KB
#5099	`StringConcatAspectBenchmark`	netcoreapp3.1	287μs	3.98μs	36.7μs	214.05 KB
#5099	`StringConcatAspectBenchmark`	net472	247μs	5.7μs	54.6μs	221.18 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.6μs	1.02ns	3.81ns	0.0221	1.57 KB
master	`EnrichedLog`	netcoreapp3.1	2.28μs	2.97ns	10.7ns	0.0205	1.57 KB
master	`EnrichedLog`	net472	2.62μs	2.09ns	8.08ns	0.237	1.5 KB
#5099	`EnrichedLog`	net6.0	1.44μs	1.91ns	7.13ns	0.0219	1.57 KB
#5099	`EnrichedLog`	netcoreapp3.1	2.28μs	0.909ns	3.28ns	0.0205	1.57 KB
#5099	`EnrichedLog`	net472	2.61μs	1.61ns	6.23ns	0.237	1.5 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	113μs	96.1ns	372ns	0.056	0	4.21 KB
master	`EnrichedLog`	netcoreapp3.1	118μs	90.4ns	338ns	0.0589	0	4.21 KB
master	`EnrichedLog`	net472	150μs	173ns	646ns	0.672	0.224	4.39 KB
#5099	`EnrichedLog`	net6.0	112μs	100ns	389ns	0.0561	0	4.21 KB
#5099	`EnrichedLog`	netcoreapp3.1	118μs	162ns	628ns	0.0587	0	4.21 KB
#5099	`EnrichedLog`	net472	149μs	229ns	889ns	0.676	0.225	4.39 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.94μs	1.18ns	4.41ns	0.0299	2.13 KB
master	`EnrichedLog`	netcoreapp3.1	4.11μs	1.32ns	5.12ns	0.0287	2.13 KB
master	`EnrichedLog`	net472	4.84μs	1.9ns	7.37ns	0.307	1.95 KB
#5099	`EnrichedLog`	net6.0	3.04μs	5.84ns	22.6ns	0.0303	2.13 KB
#5099	`EnrichedLog`	netcoreapp3.1	4.16μs	0.842ns	3.15ns	0.027	2.13 KB
#5099	`EnrichedLog`	net472	4.73μs	2.06ns	7.72ns	0.309	1.95 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.38μs	0.303ns	1.17ns	0.0153	1.1 KB
master	`SendReceive`	netcoreapp3.1	1.87μs	0.788ns	2.95ns	0.0149	1.1 KB
master	`SendReceive`	net472	2.25μs	3.39ns	13.1ns	0.176	1.12 KB
#5099	`SendReceive`	net6.0	1.39μs	0.557ns	2.16ns	0.0154	1.1 KB
#5099	`SendReceive`	netcoreapp3.1	1.78μs	1.2ns	4.63ns	0.0145	1.1 KB
#5099	`SendReceive`	net472	2.16μs	3ns	11.6ns	0.177	1.12 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.81μs	0.669ns	2.59ns	0.0213	1.53 KB
master	`EnrichedLog`	netcoreapp3.1	3.89μs	1.07ns	4.13ns	0.0215	1.58 KB
master	`EnrichedLog`	net472	4.19μs	2.12ns	8.2ns	0.312	1.97 KB
#5099	`EnrichedLog`	net6.0	2.58μs	0.686ns	2.57ns	0.0206	1.53 KB
#5099	`EnrichedLog`	netcoreapp3.1	3.96μs	1.08ns	4.05ns	0.0218	1.58 KB
#5099	`EnrichedLog`	net472	4.4μs	1.78ns	6.65ns	0.312	1.97 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5099

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472	1.147	794.92	693.04

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	511ns	0.229ns	0.858ns	0.00746	536 B
master	`StartFinishSpan`	netcoreapp3.1	711ns	1.79ns	6.95ns	0.00723	536 B
master	`StartFinishSpan`	net472	795ns	0.283ns	1.09ns	0.0851	538 B
master	`StartFinishScope`	net6.0	600ns	0.192ns	0.745ns	0.00922	656 B
master	`StartFinishScope`	netcoreapp3.1	833ns	0.785ns	3.04ns	0.00893	656 B
master	`StartFinishScope`	net472	947ns	0.5ns	1.94ns	0.0979	618 B
#5099	`StartFinishSpan`	net6.0	464ns	0.192ns	0.744ns	0.00754	536 B
#5099	`StartFinishSpan`	netcoreapp3.1	728ns	0.552ns	2.14ns	0.00692	536 B
#5099	`StartFinishSpan`	net472	693ns	0.191ns	0.741ns	0.0854	538 B
#5099	`StartFinishScope`	net6.0	592ns	0.386ns	1.49ns	0.00913	656 B
#5099	`StartFinishScope`	netcoreapp3.1	868ns	0.405ns	1.57ns	0.00896	656 B
#5099	`StartFinishScope`	net472	955ns	0.641ns	2.31ns	0.098	618 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	718ns	0.318ns	1.23ns	0.00902	656 B
master	`RunOnMethodBegin`	netcoreapp3.1	981ns	3.83ns	14.8ns	0.00877	656 B
master	`RunOnMethodBegin`	net472	1.08μs	0.287ns	1.11ns	0.098	618 B
#5099	`RunOnMethodBegin`	net6.0	656ns	0.236ns	0.915ns	0.00922	656 B
#5099	`RunOnMethodBegin`	netcoreapp3.1	960ns	1.22ns	4.71ns	0.00919	656 B
#5099	`RunOnMethodBegin`	net472	1.09μs	0.609ns	2.36ns	0.0982	618 B

GreenMatan changed the title ~~[Dynamic Instrumentation] Fixed members grow~~ [Dynamic Instrumentation] Made members size flexible due to IndexOutOfRangeException Jan 23, 2024

github-actions bot added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:debugger labels Jan 23, 2024

GreenMatan changed the title ~~[Dynamic Instrumentation] Made members size flexible due to IndexOutOfRangeException~~ [Dynamic Instrumentation] Changed the captured members size flexible due to IndexOutOfRangeException Jan 23, 2024

GreenMatan marked this pull request as ready for review January 23, 2024 09:47

GreenMatan requested a review from a team as a code owner January 23, 2024 09:47

GreenMatan requested a review from dudikeleti January 23, 2024 09:47

GreenMatan changed the title ~~[Dynamic Instrumentation] Changed the captured members size flexible due to IndexOutOfRangeException~~ [Dynamic Instrumentation] Made the captured members size flexible due to IndexOutOfRangeException Jan 23, 2024

GreenMatan changed the title ~~[Dynamic Instrumentation] Made the captured members size flexible due to IndexOutOfRangeException~~ [Dynamic Instrumentation] Made the captured members size flexible due to IndexOutOfRangeException Jan 23, 2024

Fixed IndexOutOfBoundException that was thrown in Async Method scenar…

7260bde

…ios when there was no PDB

GreenMatan force-pushed the matang/temp-fix-members-grow branch from 6e2609a to 7260bde Compare January 23, 2024 10:07

dudikeleti approved these changes Jan 23, 2024

View reviewed changes

GreenMatan merged commit 29ceca1 into master Jan 23, 2024
58 of 60 checks passed

GreenMatan deleted the matang/temp-fix-members-grow branch January 23, 2024 13:18

github-actions bot added this to the vNext milestone Jan 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dynamic Instrumentation] Made the captured members size flexible due to `IndexOutOfRangeException` #5099

[Dynamic Instrumentation] Made the captured members size flexible due to `IndexOutOfRangeException` #5099

GreenMatan commented Jan 23, 2024 •

edited

Loading

datadog-ddstaging bot commented Jan 23, 2024 •

edited

Loading

andrewlock commented Jan 23, 2024 •

edited

Loading

andrewlock commented Jan 23, 2024

Raw results

Raw results

Faster 🎉 in #5099

Raw results

Faster 🎉 in #5099

Raw results

Raw results

Fewer allocations 🎉 in #5099

Raw results

Raw results

Raw results

Raw results

Raw results

More allocations ⚠️ in #5099

Fewer allocations 🎉 in #5099

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5099

Raw results

Raw results

[Dynamic Instrumentation] Made the captured members size flexible due to IndexOutOfRangeException #5099

[Dynamic Instrumentation] Made the captured members size flexible due to IndexOutOfRangeException #5099

Conversation

GreenMatan commented Jan 23, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

datadog-ddstaging bot commented Jan 23, 2024 • edited Loading

Datadog Report

andrewlock commented Jan 23, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Jan 23, 2024

Benchmarks Report 🐌

Benchmark details

Raw results

Raw results

Faster 🎉 in #5099

Raw results

Faster 🎉 in #5099

Raw results

Raw results

Fewer allocations 🎉 in #5099

Raw results

Raw results

Raw results

Raw results

Raw results

More allocations ⚠️ in #5099

Fewer allocations 🎉 in #5099

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5099

Raw results

Raw results

[Dynamic Instrumentation] Made the captured members size flexible due to `IndexOutOfRangeException` #5099

[Dynamic Instrumentation] Made the captured members size flexible due to `IndexOutOfRangeException` #5099

GreenMatan commented Jan 23, 2024 •

edited

Loading

datadog-ddstaging bot commented Jan 23, 2024 •

edited

Loading

andrewlock commented Jan 23, 2024 •

edited

Loading