-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIVisibility] - Add support for GZip compression in Multipart payloads #5060
[CIVisibility] - Add support for GZip compression in Multipart payloads #5060
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm sad there's no tests 🙁😉
tracer/src/Datadog.Trace/Agent/Transports/GzipCompressedContent.cs
Outdated
Show resolved
Hide resolved
Datadog ReportBranch report: ✅ 0 Failed, 306284 Passed, 1000 Skipped, 31m 41.86s Wall Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5060) - mean (70ms) : 57, 83
. : milestone, 70,
master - mean (72ms) : 62, 82
. : milestone, 72,
section CallTarget+Inlining+NGEN
This PR (5060) - mean (1,013ms) : 985, 1042
. : milestone, 1013,
master - mean (1,021ms) : 995, 1047
. : milestone, 1021,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5060) - mean (105ms) : 101, 109
. : milestone, 105,
master - mean (106ms) : 102, 110
. : milestone, 106,
section CallTarget+Inlining+NGEN
This PR (5060) - mean (726ms) : 703, 748
. : milestone, 726,
master - mean (727ms) : 705, 750
. : milestone, 727,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5060) - mean (89ms) : 84, 93
. : milestone, 89,
master - mean (90ms) : 86, 93
. : milestone, 90,
section CallTarget+Inlining+NGEN
This PR (5060) - mean (682ms) : 660, 705
. : milestone, 682,
master - mean (691ms) : 666, 717
. : milestone, 691,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5060) - mean (189ms) : 185, 192
. : milestone, 189,
master - mean (188ms) : 185, 190
. : milestone, 188,
section CallTarget+Inlining+NGEN
This PR (5060) - mean (1,132ms) : 1109, 1154
. : milestone, 1132,
master - mean (1,127ms) : 1103, 1151
. : milestone, 1127,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5060) - mean (272ms) : 267, 276
. : milestone, 272,
master - mean (271ms) : 267, 276
. : milestone, 271,
section CallTarget+Inlining+NGEN
This PR (5060) - mean (1,085ms) : 1064, 1105
. : milestone, 1085,
master - mean (1,083ms) : 1063, 1104
. : milestone, 1083,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5060) - mean (261ms) : 258, 264
. : milestone, 261,
master - mean (261ms) : 258, 264
. : milestone, 261,
section CallTarget+Inlining+NGEN
This PR (5060) - mean (1,056ms) : 1031, 1080
. : milestone, 1056,
master - mean (1,052ms) : 1023, 1082
. : milestone, 1052,
|
Summary of changes
This PR enables Gzip compression on the Code Coverage track using Multipart-Form
Backend compression support:
Reason for change
Currently we are sending all the code coverage data uncompressed to the backend, because these payload could potentially be huge we are enabling gzip support on upload only when we are in agentless mode.
Implementation details
Changes a little bit the internal api to select wether we want compression or not, and implement the compression algorithm in both HttpClient and ApiClient factories.
Test coverage
Tested manually, and added a new test for the Gzipped multipart form post in the
HttpClientRequest
object, other tests will be done in thetest-environment
repo.