Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic smoke tests for .NET chiseled containers #4805

Merged
merged 18 commits into from
Nov 3, 2023
Merged

Basic smoke tests for .NET chiseled containers #4805

merged 18 commits into from
Nov 3, 2023

Conversation

andrewlock
Copy link
Member

Summary of changes

Adds basic smoke tests on .NET 8 chiseled containers

Reason for change

In .NET 8, Microsoft GA'd their support for chiseled containers (I wrote about them recently). We want to make sure that we can run correctly on chiseled containers

Implementation details

Add additional stages for chiseled containers. Unfortunately, our existing dockerfile build process wouldn't work with them (because you can't RUN anything), so it was easiest to create separate tests. This PR adds

  • Installer (tar.gz only, because that's all you can use!) tests for linux-x64 and linux-arm64
  • dd-dotnet tests (via the tar.gz) for linux-x64 and linux-arm64

Theoretically, we should also test:

  • The NuGet bundle. This is functionally identical to the installer tests, so not worth the hassle right now IMO
  • The dd-trace global tool. It isn't practical use the global tool in production chiseled images, so I don't think this one matters (and don't know how I would do it)
  • The dd-trace standalone tool. This one is interesting. When I try to test it in a .NET 8 chiseled container I get:
Failure processing application bundle.
Couldn't open host binary for reading contents

I think this is the "self-extracting" part of the "self-contained single-file" app failing, so this seems like a fundamental limitation.

Test coverage

Ran a test using binaries from master and it works

Other details

I know... everyone was thinking it... more stages in the pipeline that's definitely what we need

@andrewlock andrewlock added area:builds project files, build scripts, pipelines, versioning, releases, packages area:tests unit tests, integration tests labels Nov 2, 2023
@andrewlock andrewlock requested a review from a team as a code owner November 2, 2023 14:32
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Nov 2, 2023 •
edited
Loading

Datadog Report

Branch report: andrew/ci/chiseled-containers
Commit report: 61b9a7b

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 292330 Passed, 940 Skipped, 36m 47.39s Wall Time

@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4805) - mean (72ms)  : 63, 80
     .   : milestone, 72,
    master - mean (71ms)  : 62, 79
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (4805) - mean (993ms)  : 972, 1014
     .   : milestone, 993,
    master - mean (992ms)  : 972, 1012
     .   : milestone, 992,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4805) - mean (106ms)  : 103, 109
     .   : milestone, 106,
    master - mean (106ms)  : 102, 109
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (4805) - mean (687ms)  : 661, 713
     .   : milestone, 687,
    master - mean (680ms)  : 666, 694
     .   : milestone, 680,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4805) - mean (89ms)  : 86, 92
     .   : milestone, 89,
    master - mean (89ms)  : 86, 92
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (4805) - mean (657ms)  : 635, 679
     .   : milestone, 657,
    master - mean (652ms)  : 631, 672
     .   : milestone, 652,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4805) - mean (188ms)  : 185, 191
     .   : milestone, 188,
    master - mean (188ms)  : 185, 190
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (4805) - mean (1,132ms)  : 1115, 1150
     .   : milestone, 1132,
    master - mean (1,140ms)  : 1120, 1161
     .   : milestone, 1140,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4805) - mean (272ms)  : 268, 276
     .   : milestone, 272,
    master - mean (271ms)  : 268, 274
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (4805) - mean (1,103ms)  : 1079, 1128
     .   : milestone, 1103,
    master - mean (1,094ms)  : 1068, 1121
     .   : milestone, 1094,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4805) - mean (262ms)  : 259, 265
     .   : milestone, 262,
    master - mean (262ms)  : 259, 265
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (4805) - mean (1,068ms)  : 1043, 1093
     .   : milestone, 1068,
    master - mean (1,069ms)  : 1038, 1101
     .   : milestone, 1069,
Loading

@andrewlock
Copy link
Member Author

Benchmarks Report 🐌

Benchmarks for #4805 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.225
  • 1 benchmarks are slower, with geometric mean 1.207
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.17μs 43.4ns 230ns 0.0286 0.0123 0 7.29 KB
master StartStopWithChild netcoreapp3.1 10.1μs 54.1ns 296ns 0.0243 0.00973 0 7.38 KB
master StartStopWithChild net472 15.6μs 62.4ns 242ns 1.3 0.336 0.107 7.66 KB
#4805 StartStopWithChild net6.0 8.18μs 42.4ns 203ns 0.0204 0.00817 0 7.28 KB
#4805 StartStopWithChild netcoreapp3.1 9.98μs 55.4ns 342ns 0.0243 0.00971 0 7.38 KB
#4805 StartStopWithChild net472 15.4μs 52.8ns 204ns 1.28 0.303 0.0856 7.65 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 487μs 229ns 858ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 654μs 178ns 667ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 801μs 287ns 1.03μs 0.398 0 0 3.3 KB
#4805 WriteAndFlushEnrichedTraces net6.0 479μs 265ns 956ns 0 0 0 2.7 KB
#4805 WriteAndFlushEnrichedTraces netcoreapp3.1 648μs 144ns 556ns 0 0 0 2.7 KB
#4805 WriteAndFlushEnrichedTraces net472 805μs 434ns 1.68μs 0.401 0 0 3.3 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 43.7μs 85.9ns 298ns 0.0219 0 0 2.03 KB
master AllCycleSimpleBody netcoreapp3.1 44.7μs 148ns 574ns 0.0225 0 0 2.01 KB
master AllCycleSimpleBody net472 46.5μs 68.5ns 265ns 0.328 0 0 2.08 KB
master AllCycleMoreComplexBody net6.0 229μs 200ns 775ns 0.115 0 0 8.63 KB
master AllCycleMoreComplexBody netcoreapp3.1 233μs 127ns 490ns 0.117 0 0 8.52 KB
master AllCycleMoreComplexBody net472 237μs 115ns 447ns 1.31 0 0 8.7 KB
master ObjectExtractorSimpleBody net6.0 119ns 0.109ns 0.421ns 0.00397 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 170ns 0.444ns 1.72ns 0.00374 0 0 272 B
master ObjectExtractorSimpleBody net472 145ns 0.111ns 0.43ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3.05μs 1.21ns 4.54ns 0.0546 0 0 3.88 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.14μs 0.962ns 3.6ns 0.0518 0 0 3.78 KB
master ObjectExtractorMoreComplexBody net472 4.16μs 3.31ns 12.8ns 0.616 0.00625 0 3.89 KB
#4805 AllCycleSimpleBody net6.0 42.9μs 76ns 284ns 0.0214 0 0 2.03 KB
#4805 AllCycleSimpleBody netcoreapp3.1 45.7μs 192ns 742ns 0.0224 0 0 2.01 KB
#4805 AllCycleSimpleBody net472 47.6μs 124ns 480ns 0.324 0 0 2.08 KB
#4805 AllCycleMoreComplexBody net6.0 229μs 114ns 441ns 0.115 0 0 8.63 KB
#4805 AllCycleMoreComplexBody netcoreapp3.1 234μs 73ns 273ns 0 0 0 8.52 KB
#4805 AllCycleMoreComplexBody net472 238μs 90.4ns 350ns 1.31 0 0 8.7 KB
#4805 ObjectExtractorSimpleBody net6.0 119ns 0.0644ns 0.249ns 0.00392 0 0 280 B
#4805 ObjectExtractorSimpleBody netcoreapp3.1 184ns 0.136ns 0.526ns 0.0037 0 0 272 B
#4805 ObjectExtractorSimpleBody net472 145ns 0.11ns 0.426ns 0.0446 0 0 281 B
#4805 ObjectExtractorMoreComplexBody net6.0 3.04μs 0.732ns 2.74ns 0.0548 0 0 3.88 KB
#4805 ObjectExtractorMoreComplexBody netcoreapp3.1 4.08μs 1.75ns 6.77ns 0.0512 0 0 3.78 KB
#4805 ObjectExtractorMoreComplexBody net472 4.15μs 2.84ns 10.6ns 0.618 0.00622 0 3.89 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWaf(args=NestedMap (10)) net6.0 12.4μs 3.96ns 14.8ns 0.13 0 0 9.42 KB
master RunWaf(args=NestedMap (10)) netcoreapp3.1 19.4μs 11.3ns 40.8ns 0.126 0 0 9.42 KB
master RunWaf(args=NestedMap (10)) net472 28.2μs 10.1ns 37.6ns 1.49 0 0 9.48 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 75.1μs 45.5ns 158ns 0.19 0 0 15.77 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 86.7μs 207ns 803ns 0.215 0 0 15.72 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 98.6μs 108ns 405ns 2.52 0 0 16.04 KB
master RunWaf(args=NestedMap (100)) net6.0 24.1μs 7.74ns 27.9ns 0.276 0 0 19.66 KB
master RunWaf(args=NestedMap (100)) netcoreapp3.1 38.6μs 11.3ns 42.2ns 0.27 0 0 20.42 KB
master RunWaf(args=NestedMap (100)) net472 55.1μs 31.8ns 123ns 3.27 0.0275 0 20.63 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 92.1μs 35.9ns 124ns 0.365 0 0 26.01 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 109μs 201ns 753ns 0.328 0 0 26.72 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net472 131μs 91.9ns 356ns 4.28 0.0649 0 27.19 KB
master RunWaf(args=NestedMap (20)) net6.0 24.2μs 7.76ns 30ns 0.278 0 0 19.4 KB
master RunWaf(args=NestedMap (20)) netcoreapp3.1 38μs 20.4ns 79ns 0.265 0 0 19.84 KB
master RunWaf(args=NestedMap (20)) net472 53.5μs 27.8ns 104ns 3.17 0.0537 0 20.04 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 93.8μs 46.4ns 174ns 0.33 0 0 25.74 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 109μs 232ns 869ns 0.328 0 0 26.14 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 132μs 74.6ns 279ns 4.2 0.0657 0 26.6 KB
#4805 RunWaf(args=NestedMap (10)) net6.0 12.7μs 4.82ns 17.4ns 0.134 0 0 9.42 KB
#4805 RunWaf(args=NestedMap (10)) netcoreapp3.1 19.9μs 43.7ns 158ns 0.128 0 0 9.42 KB
#4805 RunWaf(args=NestedMap (10)) net472 28.3μs 14.5ns 54.1ns 1.5 0 0 9.48 KB
#4805 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 74.8μs 35ns 131ns 0.224 0 0 15.77 KB
#4805 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 86.3μs 37.7ns 131ns 0.216 0 0 15.72 KB
#4805 RunWafWithAttack(args=Neste(...)tack) [22]) net472 99.1μs 209ns 809ns 2.52 0 0 16.04 KB
#4805 RunWaf(args=NestedMap (100)) net6.0 24μs 9.77ns 36.6ns 0.276 0 0 19.66 KB
#4805 RunWaf(args=NestedMap (100)) netcoreapp3.1 38.2μs 18ns 69.5ns 0.267 0 0 20.42 KB
#4805 RunWaf(args=NestedMap (100)) net472 53.8μs 24ns 89.6ns 3.27 0.054 0 20.63 KB
#4805 RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 91.5μs 60.7ns 219ns 0.321 0 0 26.01 KB
#4805 RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 109μs 158ns 612ns 0.327 0 0 26.72 KB
#4805 RunWafWithAttack(args=Neste(...)tack) [23]) net472 131μs 76.9ns 298ns 4.32 0.0654 0 27.19 KB
#4805 RunWaf(args=NestedMap (20)) net6.0 24.1μs 7.22ns 27ns 0.266 0 0 19.4 KB
#4805 RunWaf(args=NestedMap (20)) netcoreapp3.1 38.3μs 8.58ns 29.7ns 0.268 0 0 19.84 KB
#4805 RunWaf(args=NestedMap (20)) net472 54.2μs 34.5ns 134ns 3.17 0.0541 0 20.04 KB
#4805 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 93.9μs 126ns 490ns 0.33 0 0 25.74 KB
#4805 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 107μs 153ns 592ns 0.326 0 0 26.14 KB
#4805 RunWafWithAttack(args=Neste(...)tack) [22]) net472 129μs 39.6ns 153ns 4.18 0.0653 0 26.6 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 169μs 221ns 857ns 0.17 0 0 18.04 KB
master SendRequest netcoreapp3.1 191μs 234ns 906ns 0.19 0 0 20.2 KB
master SendRequest net472 0.000659ns 0.00028ns 0.00109ns 0 0 0 0 b
#4805 SendRequest net6.0 168μs 117ns 455ns 0.252 0 0 18.04 KB
#4805 SendRequest netcoreapp3.1 188μs 332ns 1.29μs 0.189 0 0 20.2 KB
#4805 SendRequest net472 0.000184ns 0.000125ns 0.000466ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #4805

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.87 KB 41.65 KB -224 B -0.53%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 568μs 2.11μs 7.9μs 0.534 0 0 41.87 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 661μs 1.95μs 7.57μs 0.326 0 0 41.81 KB
master WriteAndFlushEnrichedTraces net472 829μs 3.48μs 13.5μs 8.17 2.45 0.408 53.24 KB
#4805 WriteAndFlushEnrichedTraces net6.0 557μs 210ns 726ns 0.553 0 0 41.65 KB
#4805 WriteAndFlushEnrichedTraces netcoreapp3.1 657μs 944ns 3.53μs 0.329 0 0 41.82 KB
#4805 WriteAndFlushEnrichedTraces net472 831μs 3.94μs 16.7μs 8.28 2.48 0.414 53.21 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.1μs 0.59ns 2.29ns 0.011 0 0 768 B
master ExecuteNonQuery netcoreapp3.1 1.26μs 1.68ns 6.52ns 0.0106 0 0 768 B
master ExecuteNonQuery net472 1.65μs 0.601ns 2.33ns 0.115 0 0 730 B
#4805 ExecuteNonQuery net6.0 1μs 0.631ns 2.44ns 0.0106 0 0 768 B
#4805 ExecuteNonQuery netcoreapp3.1 1.28μs 0.613ns 2.3ns 0.0105 0 0 768 B
#4805 ExecuteNonQuery net472 1.64μs 1.07ns 4.15ns 0.116 0 0 730 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.14μs 0.619ns 2.4ns 0.0131 0 0 936 B
master CallElasticsearch netcoreapp3.1 1.36μs 1.05ns 4.08ns 0.0123 0 0 936 B
master CallElasticsearch net472 2.33μs 0.978ns 3.53ns 0.151 0 0 955 B
master CallElasticsearchAsync net6.0 1.2μs 0.452ns 1.75ns 0.0126 0 0 912 B
master CallElasticsearchAsync netcoreapp3.1 1.37μs 0.793ns 3.07ns 0.0131 0 0 984 B
master CallElasticsearchAsync net472 2.55μs 2ns 7.75ns 0.16 0 0 1.01 KB
#4805 CallElasticsearch net6.0 1.16μs 0.752ns 2.91ns 0.0133 0 0 936 B
#4805 CallElasticsearch netcoreapp3.1 1.44μs 3.51ns 13.1ns 0.0126 0 0 936 B
#4805 CallElasticsearch net472 2.29μs 0.561ns 2.1ns 0.151 0 0 955 B
#4805 CallElasticsearchAsync net6.0 1.16μs 0.509ns 1.91ns 0.0128 0 0 912 B
#4805 CallElasticsearchAsync netcoreapp3.1 1.47μs 0.592ns 2.21ns 0.0131 0 0 984 B
#4805 CallElasticsearchAsync net472 2.48μs 1.53ns 5.92ns 0.161 0 0 1.01 KB
Benchmarks.Trace.GraphQLBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4805

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 1.225 1,313.94 1,072.77

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.31μs 0.647ns 2.42ns 0.0125 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.47μs 0.686ns 2.57ns 0.0125 0 0 912 B
master ExecuteAsync net472 1.77μs 1.44ns 5.56ns 0.138 0 0 875 B
#4805 ExecuteAsync net6.0 1.07μs 0.524ns 1.96ns 0.0129 0 0 912 B
#4805 ExecuteAsync netcoreapp3.1 1.47μs 0.943ns 3.65ns 0.0125 0 0 912 B
#4805 ExecuteAsync net472 1.61μs 0.592ns 2.22ns 0.139 0 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 3.7μs 1.07ns 4.14ns 0.026 0 0 1.9 KB
master SendAsync netcoreapp3.1 4.55μs 2.74ns 10.6ns 0.0317 0 0 2.43 KB
master SendAsync net472 7.01μs 1.95ns 7.57ns 0.474 0 0 2.99 KB
#4805 SendAsync net6.0 3.74μs 2.1ns 8.12ns 0.0261 0 0 1.9 KB
#4805 SendAsync netcoreapp3.1 4.44μs 1.4ns 5.43ns 0.0313 0 0 2.43 KB
#4805 SendAsync net472 7.04μs 3.54ns 13.7ns 0.475 0 0 2.99 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.36μs 0.965ns 3.74ns 0.0218 0 0 1.57 KB
master EnrichedLog netcoreapp3.1 1.87μs 0.652ns 2.53ns 0.0216 0 0 1.57 KB
master EnrichedLog net472 2.3μs 2.08ns 8.05ns 0.237 0 0 1.49 KB
#4805 EnrichedLog net6.0 1.27μs 0.411ns 1.54ns 0.0224 0 0 1.57 KB
#4805 EnrichedLog netcoreapp3.1 1.9μs 2.98ns 11.1ns 0.0208 0 0 1.57 KB
#4805 EnrichedLog net472 2.26μs 2.27ns 8.48ns 0.236 0 0 1.49 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 111μs 265ns 1.03μs 0.0554 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 118μs 193ns 749ns 0.0594 0 0 4.21 KB
master EnrichedLog net472 145μs 59.1ns 213ns 0.658 0.219 0 4.38 KB
#4805 EnrichedLog net6.0 112μs 130ns 487ns 0.0557 0 0 4.21 KB
#4805 EnrichedLog netcoreapp3.1 119μs 204ns 789ns 0 0 0 4.21 KB
#4805 EnrichedLog net472 149μs 153ns 594ns 0.664 0.221 0 4.38 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.93μs 1.57ns 6.09ns 0.0294 0 0 2.13 KB
master EnrichedLog netcoreapp3.1 3.88μs 1.71ns 6.41ns 0.029 0 0 2.13 KB
master EnrichedLog net472 4.52μs 1.85ns 7.17ns 0.305 0 0 1.93 KB
#4805 EnrichedLog net6.0 2.94μs 0.826ns 3.09ns 0.0295 0 0 2.13 KB
#4805 EnrichedLog netcoreapp3.1 3.82μs 1.7ns 6.36ns 0.0285 0 0 2.13 KB
#4805 EnrichedLog net472 4.45μs 2.07ns 7.73ns 0.307 0 0 1.93 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.22μs 0.333ns 1.29ns 0.0153 0 0 1.1 KB
master SendReceive netcoreapp3.1 1.65μs 4.88ns 18.9ns 0.0148 0 0 1.1 KB
master SendReceive net472 1.89μs 2.18ns 7.85ns 0.177 0 0 1.12 KB
#4805 SendReceive net6.0 1.23μs 0.61ns 2.36ns 0.0154 0 0 1.1 KB
#4805 SendReceive netcoreapp3.1 1.63μs 0.725ns 2.81ns 0.0155 0 0 1.1 KB
#4805 SendReceive net472 1.88μs 2.09ns 8.11ns 0.177 0 0 1.12 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.58μs 2.6ns 9.02ns 0.0219 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.59μs 3.31ns 12.8ns 0.0212 0 0 1.58 KB
master EnrichedLog net472 4μs 2.49ns 9.32ns 0.311 0 0 1.96 KB
#4805 EnrichedLog net6.0 2.65μs 0.857ns 3.32ns 0.0213 0 0 1.53 KB
#4805 EnrichedLog netcoreapp3.1 3.34μs 1.18ns 4.41ns 0.0201 0 0 1.58 KB
#4805 EnrichedLog net472 4.02μs 1.35ns 5.22ns 0.31 0 0 1.96 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4805

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.207 554.29 669.28

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 465ns 0.147ns 0.551ns 0.00745 0 0 536 B
master StartFinishSpan netcoreapp3.1 570ns 2.08ns 8.06ns 0.00728 0 0 536 B
master StartFinishSpan net472 554ns 0.262ns 1.01ns 0.0853 0 0 538 B
master StartFinishScope net6.0 562ns 0.362ns 1.35ns 0.0093 0 0 656 B
master StartFinishScope netcoreapp3.1 711ns 0.178ns 0.641ns 0.00896 0 0 656 B
master StartFinishScope net472 911ns 0.793ns 2.97ns 0.0978 0 0 618 B
#4805 StartFinishSpan net6.0 514ns 0.148ns 0.556ns 0.00747 0 0 536 B
#4805 StartFinishSpan netcoreapp3.1 615ns 0.912ns 3.53ns 0.00726 0 0 536 B
#4805 StartFinishSpan net472 669ns 0.18ns 0.673ns 0.0851 0 0 538 B
#4805 StartFinishScope net6.0 628ns 1.46ns 5.65ns 0.0091 0 0 656 B
#4805 StartFinishScope netcoreapp3.1 765ns 0.4ns 1.55ns 0.00912 0 0 656 B
#4805 StartFinishScope net472 911ns 0.448ns 1.73ns 0.0981 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 621ns 0.322ns 1.25ns 0.00937 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 779ns 0.227ns 0.877ns 0.00887 0 0 656 B
master RunOnMethodBegin net472 1.01μs 0.365ns 1.41ns 0.098 0 0 618 B
#4805 RunOnMethodBegin net6.0 606ns 0.213ns 0.798ns 0.00909 0 0 656 B
#4805 RunOnMethodBegin netcoreapp3.1 814ns 3.29ns 12.3ns 0.00898 0 0 656 B
#4805 RunOnMethodBegin net472 988ns 0.457ns 1.77ns 0.098 0 0 618 B

@andrewlock
Copy link
Member Author

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4805) (11.042M)   : 0, 11042154
    master (11.393M)   : 0, 11392757
    benchmarks/2.38.0 (11.867M)   : 0, 11866956
    benchmarks/2.9.0 (10.921M)   : 0, 10920504

    section Automatic
    This PR (4805) (7.540M)   : crit ,0, 7540107
    master (7.942M)   : 0, 7941784
    benchmarks/2.38.0 (8.176M)   : 0, 8175636
    benchmarks/2.9.0 (7.899M)   : 0, 7898906

    section Trace stats
    This PR (4805) (7.950M)   : 0, 7950326
    master (8.283M)   : 0, 8282593
    benchmarks/2.38.0 (8.450M)   : 0, 8450370

    section Manual
    This PR (4805) (9.764M)   : 0, 9763905
    master (10.078M)   : 0, 10077955
    benchmarks/2.38.0 (10.334M)   : 0, 10334368

    section Manual + Automatic
    This PR (4805) (7.245M)   : 0, 7244623
    master (7.538M)   : 0, 7538297
    benchmarks/2.38.0 (7.750M)   : 0, 7750484

    section Version Conflict
    This PR (4805) (6.556M)   : crit ,0, 6556353
    master (7.019M)   : 0, 7018962
    benchmarks/2.38.0 (7.137M)   : 0, 7136691
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4805) (9.388M)   : 0, 9387868
    master (9.602M)   : 0, 9601657
    benchmarks/2.38.0 (9.548M)   : 0, 9548121
    benchmarks/2.9.0 (9.696M)   : 0, 9695973

    section Automatic
    This PR (4805) (6.567M)   : 0, 6566927
    master (6.729M)   : 0, 6729327
    benchmarks/2.38.0 (6.747M)   : 0, 6747227

    section Trace stats
    This PR (4805) (6.746M)   : 0, 6746227
    master (6.952M)   : 0, 6951660
    benchmarks/2.38.0 (6.815M)   : 0, 6814846

    section Manual
    This PR (4805) (8.253M)   : 0, 8252515
    master (8.462M)   : 0, 8461837
    benchmarks/2.38.0 (8.263M)   : 0, 8263131

    section Manual + Automatic
    This PR (4805) (6.311M)   : 0, 6311352
    master (6.179M)   : 0, 6179146
    benchmarks/2.38.0 (6.275M)   : 0, 6275411

    section Version Conflict
    This PR (4805) (5.613M)   : 0, 5613218
    master (5.874M)   : 0, 5874022
    benchmarks/2.38.0 (5.670M)   : 0, 5669744
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4805) (9.320M)   : 0, 9319558
    master (9.200M)   : 0, 9199633
    benchmarks/2.38.0 (9.007M)   : 0, 9007066
    benchmarks/2.9.0 (9.586M)   : 0, 9585650

    section Automatic
    This PR (4805) (6.637M)   : 0, 6637443
    master (6.653M)   : 0, 6652769
    benchmarks/2.38.0 (6.423M)   : 0, 6422756
    benchmarks/2.9.0 (7.033M)   : 0, 7033199

    section Trace stats
    This PR (4805) (6.762M)   : 0, 6762172
    master (6.854M)   : 0, 6854485
    benchmarks/2.38.0 (6.721M)   : 0, 6720838

    section Manual
    This PR (4805) (8.236M)   : 0, 8236044
    master (8.182M)   : 0, 8181925
    benchmarks/2.38.0 (7.977M)   : 0, 7977494

    section Manual + Automatic
    This PR (4805) (6.349M)   : 0, 6348717
    master (6.404M)   : 0, 6404402
    benchmarks/2.38.0 (6.349M)   : 0, 6349066

    section Version Conflict
    This PR (4805) (5.840M)   : 0, 5839864
    master (5.914M)   : 0, 5914289
    benchmarks/2.38.0 (5.682M)   : 0, 5681654
Loading 
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    master (7.582M)   : 0, 7581636
    benchmarks/2.38.0 (7.578M)   : 0, 7577544
    benchmarks/2.9.0 (8.040M)   : 0, 8039615

    section No attack
    master (2.177M)   : 0, 2176500
    benchmarks/2.38.0 (2.184M)   : 0, 2184279
    benchmarks/2.9.0 (3.290M)   : 0, 3289982

    section Attack
    master (1.712M)   : 0, 1712498
    benchmarks/2.38.0 (1.711M)   : 0, 1710542
    benchmarks/2.9.0 (2.581M)   : 0, 2581167

    section Blocking
    master (3.456M)   : 0, 3456373
    benchmarks/2.38.0 (3.486M)   : 0, 3486124

    section IAST default
    master (6.923M)   : 0, 6923039

    section IAST full
    master (6.270M)   : 0, 6270368

    section Base vuln
    master (0.976M)   : 0, 975959

    section IAST vuln
    master (0.930M)   : 0, 930321
Loading

@andrewlock andrewlock merged commit 37edb88 into master Nov 3, 2023
@andrewlock andrewlock deleted the andrew/ci/chiseled-containers branch November 3, 2023 12:18
@github-actions github-actions bot added this to the vNext milestone Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevingosse kevingosse kevingosse approved these changes

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages area:tests unit tests, integration tests
Projects
None yet
Milestone
2.41.0
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewlock @kevingosse