Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update python packages and use the new image in gitlab #4794

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Update python packages and use the new image in gitlab #4794

merged 1 commit into from
Nov 1, 2023

Conversation

andrewlock
Copy link
Member

Summary of changes

Update the python packages to match the agent build images https://github.com/DataDog/datadog-agent-buildimages

Reason for change

Some packages were out of date and we got update suggestions

Implementation details

Copy-paste mostly

Test coverage

Ran a manual build in GitLab, and all looks good

Other details

I bumped the urllib3 version by a patch release compared to the agent versions

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Nov 1, 2023
@andrewlock andrewlock requested a review from a team as a code owner November 1, 2023 10:42
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Nov 1, 2023 •
edited
Loading

Datadog Report

Branch report: andrew/ci/update-python
Commit report: 37672fd

❄️ dd-trace-dotnet: 0 Failed, 1 New Flaky, 300801 Passed, 943 Skipped, 35m 51.97s Wall Time

New Flaky Tests (1)

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsKinesisTests - Last Failure

    Expand for error 
     Expected relevantSpans to contain at least 5 item(s) because we want to ensure that we don't timeout while waiting for spans from the mock tracer agent, but found 0: {empty}.

@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4794) - mean (71ms)  : 63, 78
     .   : milestone, 71,
    master - mean (71ms)  : 63, 78
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (4794) - mean (995ms)  : 974, 1017
     .   : milestone, 995,
    master - mean (1,003ms)  : 979, 1027
     .   : milestone, 1003,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4794) - mean (105ms)  : 102, 108
     .   : milestone, 105,
    master - mean (106ms)  : 103, 108
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (4794) - mean (683ms)  : 661, 704
     .   : milestone, 683,
    master - mean (684ms)  : 663, 705
     .   : milestone, 684,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4794) - mean (89ms)  : 86, 93
     .   : milestone, 89,
    master - mean (90ms)  : 87, 93
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (4794) - mean (659ms)  : 633, 684
     .   : milestone, 659,
    master - mean (658ms)  : 629, 686
     .   : milestone, 658,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4794) - mean (188ms)  : 185, 191
     .   : milestone, 188,
    master - mean (189ms)  : 185, 192
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (4794) - mean (1,141ms)  : 1121, 1162
     .   : milestone, 1141,
    master - mean (1,146ms)  : 1125, 1167
     .   : milestone, 1146,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4794) - mean (272ms)  : 268, 275
     .   : milestone, 272,
    master - mean (271ms)  : 267, 276
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (4794) - mean (1,095ms)  : 1069, 1121
     .   : milestone, 1095,
    master - mean (1,096ms)  : 1072, 1120
     .   : milestone, 1096,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4794) - mean (262ms)  : 259, 265
     .   : milestone, 262,
    master - mean (262ms)  : 259, 266
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (4794) - mean (1,068ms)  : 1041, 1095
     .   : milestone, 1068,
    master - mean (1,066ms)  : 1037, 1095
     .   : milestone, 1066,
Loading

@andrewlock
Copy link
Member Author

Benchmarks Report 🐌

Benchmarks for #4794 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.152
  • 2 benchmarks are slower, with geometric mean 1.179
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.13μs 44.6ns 267ns 0.0343 0.0153 0 7.29 KB
master StartStopWithChild netcoreapp3.1 9.95μs 45.1ns 163ns 0.0245 0.00981 0 7.38 KB
master StartStopWithChild net472 15.6μs 36.9ns 143ns 1.28 0.315 0.107 7.67 KB
#4794 StartStopWithChild net6.0 8.08μs 42ns 252ns 0.0152 0.0076 0 7.29 KB
#4794 StartStopWithChild netcoreapp3.1 10.1μs 52.9ns 270ns 0.0286 0.0143 0 7.38 KB
#4794 StartStopWithChild net472 15.7μs 50.7ns 196ns 1.3 0.345 0.11 7.67 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 479μs 335ns 1.3μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 666μs 3.06μs 11.9μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 790μs 383ns 1.43μs 0.393 0 0 3.3 KB
#4794 WriteAndFlushEnrichedTraces net6.0 461μs 249ns 965ns 0 0 0 2.7 KB
#4794 WriteAndFlushEnrichedTraces netcoreapp3.1 640μs 285ns 1.1μs 0 0 0 2.7 KB
#4794 WriteAndFlushEnrichedTraces net472 792μs 225ns 870ns 0.393 0 0 3.3 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 43.8μs 30.8ns 119ns 0.0213 0 0 2.03 KB
master AllCycleSimpleBody netcoreapp3.1 45.6μs 84.6ns 328ns 0.023 0 0 2.01 KB
master AllCycleSimpleBody net472 45.9μs 17.8ns 64.1ns 0.322 0 0 2.08 KB
master AllCycleMoreComplexBody net6.0 231μs 95ns 368ns 0 0 0 8.63 KB
master AllCycleMoreComplexBody netcoreapp3.1 236μs 121ns 468ns 0 0 0 8.52 KB
master AllCycleMoreComplexBody net472 241μs 61.4ns 230ns 1.33 0 0 8.7 KB
master ObjectExtractorSimpleBody net6.0 124ns 0.0968ns 0.362ns 0.00397 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 177ns 0.0805ns 0.29ns 0.00377 0 0 272 B
master ObjectExtractorSimpleBody net472 145ns 0.115ns 0.445ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3.03μs 2.1ns 8.15ns 0.0545 0 0 3.88 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.19μs 1.72ns 6.45ns 0.0524 0 0 3.78 KB
master ObjectExtractorMoreComplexBody net472 4.18μs 3.13ns 11.7ns 0.618 0.0062 0 3.89 KB
#4794 AllCycleSimpleBody net6.0 43.4μs 43.3ns 168ns 0.0217 0 0 2.03 KB
#4794 AllCycleSimpleBody netcoreapp3.1 45.7μs 55.4ns 214ns 0.0228 0 0 2.01 KB
#4794 AllCycleSimpleBody net472 48μs 27.4ns 106ns 0.329 0 0 2.08 KB
#4794 AllCycleMoreComplexBody net6.0 231μs 444ns 1.66μs 0.113 0 0 8.63 KB
#4794 AllCycleMoreComplexBody netcoreapp3.1 235μs 99.5ns 385ns 0 0 0 8.52 KB
#4794 AllCycleMoreComplexBody net472 238μs 191ns 740ns 1.3 0 0 8.7 KB
#4794 ObjectExtractorSimpleBody net6.0 121ns 0.045ns 0.168ns 0.00392 0 0 280 B
#4794 ObjectExtractorSimpleBody netcoreapp3.1 176ns 0.077ns 0.298ns 0.00373 0 0 272 B
#4794 ObjectExtractorSimpleBody net472 150ns 0.129ns 0.466ns 0.0446 0 0 281 B
#4794 ObjectExtractorMoreComplexBody net6.0 3.05μs 0.89ns 3.33ns 0.0549 0 0 3.88 KB
#4794 ObjectExtractorMoreComplexBody netcoreapp3.1 4.03μs 1.53ns 5.73ns 0.0504 0 0 3.78 KB
#4794 ObjectExtractorMoreComplexBody net472 4.11μs 3.91ns 15.1ns 0.618 0.00618 0 3.89 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWaf(args=NestedMap (10)) net6.0 12.7μs 5.66ns 21.2ns 0.134 0 0 9.42 KB
master RunWaf(args=NestedMap (10)) netcoreapp3.1 19.7μs 12.3ns 47.7ns 0.128 0 0 9.42 KB
master RunWaf(args=NestedMap (10)) net472 28.2μs 28.3ns 110ns 1.51 0 0 9.48 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 76.1μs 55.7ns 216ns 0.189 0 0 15.77 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 86.3μs 54ns 187ns 0.211 0 0 15.72 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 98.4μs 53.8ns 194ns 2.54 0 0 16.04 KB
master RunWaf(args=NestedMap (100)) net6.0 24.1μs 9.44ns 36.6ns 0.275 0 0 19.66 KB
master RunWaf(args=NestedMap (100)) netcoreapp3.1 38.7μs 13.8ns 53.3ns 0.271 0 0 20.42 KB
master RunWaf(args=NestedMap (100)) net472 56.8μs 32.1ns 111ns 3.27 0.0284 0 20.63 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 91.6μs 19.8ns 71.6ns 0.362 0 0 26.01 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 108μs 194ns 673ns 0.328 0 0 26.72 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net472 133μs 240ns 930ns 4.26 0.0666 0 27.19 KB
master RunWaf(args=NestedMap (20)) net6.0 25.5μs 66.3ns 257ns 0.264 0 0 19.4 KB
master RunWaf(args=NestedMap (20)) netcoreapp3.1 37.8μs 17.7ns 68.6ns 0.265 0 0 19.84 KB
master RunWaf(args=NestedMap (20)) net472 57.2μs 15.9ns 57.3ns 3.16 0.0575 0 20.04 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 92.6μs 274ns 987ns 0.327 0 0 25.74 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 107μs 240ns 896ns 0.327 0 0 26.14 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 130μs 189ns 731ns 4.21 0.0648 0 26.6 KB
#4794 RunWaf(args=NestedMap (10)) net6.0 12.7μs 15ns 56.3ns 0.133 0 0 9.42 KB
#4794 RunWaf(args=NestedMap (10)) netcoreapp3.1 19.6μs 4.82ns 18.7ns 0.128 0 0 9.42 KB
#4794 RunWaf(args=NestedMap (10)) net472 28.9μs 12.3ns 45.9ns 1.5 0 0 9.48 KB
#4794 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 76.8μs 55.1ns 213ns 0.187 0 0 15.77 KB
#4794 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 85.9μs 196ns 733ns 0.211 0 0 15.72 KB
#4794 RunWafWithAttack(args=Neste(...)tack) [22]) net472 98.8μs 204ns 791ns 2.53 0 0 16.04 KB
#4794 RunWaf(args=NestedMap (100)) net6.0 23.8μs 3.22ns 11.1ns 0.275 0 0 19.66 KB
#4794 RunWaf(args=NestedMap (100)) netcoreapp3.1 38.3μs 16.1ns 60.3ns 0.268 0 0 20.42 KB
#4794 RunWaf(args=NestedMap (100)) net472 55.1μs 35.5ns 137ns 3.26 0.0276 0 20.63 KB
#4794 RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 89.7μs 101ns 349ns 0.366 0 0 26.01 KB
#4794 RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 110μs 111ns 401ns 0.328 0 0 26.72 KB
#4794 RunWafWithAttack(args=Neste(...)tack) [23]) net472 132μs 70.9ns 275ns 4.27 0.0648 0 27.19 KB
#4794 RunWaf(args=NestedMap (20)) net6.0 23.7μs 6.43ns 24.1ns 0.272 0 0 19.4 KB
#4794 RunWaf(args=NestedMap (20)) netcoreapp3.1 37.4μs 22.4ns 86.8ns 0.262 0 0 19.84 KB
#4794 RunWaf(args=NestedMap (20)) net472 54.4μs 50.4ns 195ns 3.18 0.0543 0 20.04 KB
#4794 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 93.1μs 47.7ns 185ns 0.329 0 0 25.74 KB
#4794 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 107μs 71.8ns 259ns 0.321 0 0 26.14 KB
#4794 RunWafWithAttack(args=Neste(...)tack) [22]) net472 132μs 201ns 779ns 4.17 0.0652 0 26.6 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 171μs 216ns 808ns 0.172 0 0 18.04 KB
master SendRequest netcoreapp3.1 190μs 191ns 715ns 0.189 0 0 20.2 KB
master SendRequest net472 0.000115ns 7.57E‑05ns 0.000293ns 0 0 0 0 b
#4794 SendRequest net6.0 166μs 130ns 504ns 0.248 0 0 18.04 KB
#4794 SendRequest netcoreapp3.1 190μs 337ns 1.3μs 0.191 0 0 20.2 KB
#4794 SendRequest net472 0.000473ns 0.000123ns 0.000445ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 558μs 427ns 1.65μs 0.558 0 0 41.83 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 670μs 830ns 3.21μs 0.329 0 0 41.82 KB
master WriteAndFlushEnrichedTraces net472 829μs 4.02μs 16.6μs 8.08 2.55 0.425 53.23 KB
#4794 WriteAndFlushEnrichedTraces net6.0 558μs 1.25μs 4.68μs 0.563 0 0 41.87 KB
#4794 WriteAndFlushEnrichedTraces netcoreapp3.1 664μs 551ns 2.06μs 0.336 0 0 41.74 KB
#4794 WriteAndFlushEnrichedTraces net472 839μs 3.68μs 14.2μs 8.12 2.44 0.406 53.25 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 991ns 0.32ns 1.24ns 0.0109 0 0 768 B
master ExecuteNonQuery netcoreapp3.1 1.4μs 0.507ns 1.83ns 0.0106 0 0 768 B
master ExecuteNonQuery net472 1.58μs 2.22ns 8ns 0.116 0 0 730 B
#4794 ExecuteNonQuery net6.0 1.02μs 0.385ns 1.49ns 0.0106 0 0 768 B
#4794 ExecuteNonQuery netcoreapp3.1 1.33μs 0.506ns 1.96ns 0.0106 0 0 768 B
#4794 ExecuteNonQuery net472 1.62μs 0.384ns 1.44ns 0.116 0 0 730 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4794

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑netcoreapp3.1 1.179 1,408.49 1,660.74

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.13μs 0.457ns 1.71ns 0.0129 0 0 936 B
master CallElasticsearch netcoreapp3.1 1.42μs 3.06ns 11.4ns 0.0124 0 0 936 B
master CallElasticsearch net472 2.32μs 0.717ns 2.78ns 0.151 0 0 955 B
master CallElasticsearchAsync net6.0 1.25μs 0.541ns 2.02ns 0.0126 0 0 912 B
master CallElasticsearchAsync netcoreapp3.1 1.41μs 0.836ns 3.13ns 0.0135 0 0 984 B
master CallElasticsearchAsync net472 2.45μs 1.36ns 5.25ns 0.161 0 0 1.01 KB
#4794 CallElasticsearch net6.0 1.13μs 0.507ns 1.9ns 0.0132 0 0 936 B
#4794 CallElasticsearch netcoreapp3.1 1.49μs 0.792ns 3.07ns 0.0127 0 0 936 B
#4794 CallElasticsearch net472 2.41μs 0.415ns 1.61ns 0.152 0 0 955 B
#4794 CallElasticsearchAsync net6.0 1.23μs 0.446ns 1.73ns 0.0128 0 0 912 B
#4794 CallElasticsearchAsync netcoreapp3.1 1.66μs 1.18ns 4.55ns 0.0133 0 0 984 B
#4794 CallElasticsearchAsync net472 2.53μs 1.41ns 5.48ns 0.16 0 0 1.01 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.21μs 0.549ns 2.13ns 0.0126 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.39μs 0.6ns 2.16ns 0.0126 0 0 912 B
master ExecuteAsync net472 1.69μs 0.602ns 2.17ns 0.139 0.00084 0 875 B
#4794 ExecuteAsync net6.0 1.21μs 0.835ns 3.23ns 0.0127 0 0 912 B
#4794 ExecuteAsync netcoreapp3.1 1.39μs 0.877ns 3.28ns 0.0124 0 0 912 B
#4794 ExecuteAsync net472 1.72μs 0.966ns 3.62ns 0.139 0 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 3.91μs 2.22ns 8.31ns 0.0254 0 0 1.9 KB
master SendAsync netcoreapp3.1 4.48μs 1.66ns 6.43ns 0.0331 0 0 2.43 KB
master SendAsync net472 7.13μs 3.15ns 12.2ns 0.474 0 0 2.99 KB
#4794 SendAsync net6.0 3.69μs 3.37ns 12.6ns 0.0258 0 0 1.9 KB
#4794 SendAsync netcoreapp3.1 4.57μs 2.19ns 8.47ns 0.0321 0 0 2.43 KB
#4794 SendAsync net472 7.14μs 18.5ns 71.5ns 0.473 0 0 2.99 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.28μs 0.48ns 1.86ns 0.0219 0 0 1.57 KB
master EnrichedLog netcoreapp3.1 1.97μs 0.751ns 2.81ns 0.0206 0 0 1.57 KB
master EnrichedLog net472 2.3μs 2ns 7.73ns 0.237 0 0 1.49 KB
#4794 EnrichedLog net6.0 1.27μs 0.761ns 2.95ns 0.0219 0 0 1.57 KB
#4794 EnrichedLog netcoreapp3.1 1.96μs 0.615ns 2.22ns 0.0216 0 0 1.57 KB
#4794 EnrichedLog net472 2.29μs 1.04ns 3.75ns 0.236 0 0 1.49 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 112μs 118ns 427ns 0.0558 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 118μs 222ns 861ns 0 0 0 4.21 KB
master EnrichedLog net472 149μs 204ns 791ns 0.663 0.221 0 4.38 KB
#4794 EnrichedLog net6.0 111μs 168ns 630ns 0.0556 0 0 4.21 KB
#4794 EnrichedLog netcoreapp3.1 119μs 229ns 887ns 0 0 0 4.21 KB
#4794 EnrichedLog net472 147μs 112ns 435ns 0.66 0.22 0 4.38 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.86μs 4.64ns 17.4ns 0.0296 0 0 2.13 KB
master EnrichedLog netcoreapp3.1 3.71μs 1.05ns 3.8ns 0.0297 0 0 2.13 KB
master EnrichedLog net472 4.6μs 1.44ns 5.57ns 0.306 0 0 1.93 KB
#4794 EnrichedLog net6.0 2.87μs 0.911ns 3.53ns 0.0301 0 0 2.13 KB
#4794 EnrichedLog netcoreapp3.1 3.75μs 6.92ns 24.9ns 0.0281 0 0 2.13 KB
#4794 EnrichedLog net472 4.63μs 2.42ns 9.37ns 0.307 0 0 1.93 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.21μs 0.602ns 2.25ns 0.015 0 0 1.1 KB
master SendReceive netcoreapp3.1 1.53μs 0.638ns 2.3ns 0.0146 0 0 1.1 KB
master SendReceive net472 2.01μs 1.83ns 7.1ns 0.177 0 0 1.12 KB
#4794 SendReceive net6.0 1.25μs 0.578ns 2.16ns 0.0157 0 0 1.1 KB
#4794 SendReceive netcoreapp3.1 1.67μs 0.623ns 2.41ns 0.0151 0 0 1.1 KB
#4794 SendReceive net472 2.08μs 1.9ns 6.85ns 0.177 0.00103 0 1.12 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.64μs 0.52ns 1.94ns 0.0212 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.78μs 2.08ns 8.05ns 0.0208 0 0 1.58 KB
master EnrichedLog net472 4.01μs 0.728ns 2.62ns 0.311 0 0 1.96 KB
#4794 EnrichedLog net6.0 2.54μs 0.932ns 3.61ns 0.0216 0 0 1.53 KB
#4794 EnrichedLog netcoreapp3.1 3.56μs 1.64ns 6.13ns 0.0213 0 0 1.58 KB
#4794 EnrichedLog net472 4.03μs 0.773ns 2.89ns 0.31 0 0 1.96 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4794

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.178 466.53 549.78

Faster 🎉 in #4794

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.124 659.16 586.33

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 483ns 0.366ns 1.42ns 0.0075 0 0 536 B
master StartFinishSpan netcoreapp3.1 563ns 0.16ns 0.618ns 0.00711 0 0 536 B
master StartFinishSpan net472 659ns 0.108ns 0.403ns 0.0854 0 0 538 B
master StartFinishScope net6.0 467ns 0.12ns 0.45ns 0.00919 0 0 656 B
master StartFinishScope netcoreapp3.1 656ns 0.228ns 0.855ns 0.00876 0 0 656 B
master StartFinishScope net472 824ns 0.746ns 2.89ns 0.0982 0 0 618 B
#4794 StartFinishSpan net6.0 455ns 0.14ns 0.523ns 0.00748 0 0 536 B
#4794 StartFinishSpan netcoreapp3.1 583ns 2.06ns 7.98ns 0.00712 0 0 536 B
#4794 StartFinishSpan net472 587ns 0.253ns 0.979ns 0.0853 0 0 538 B
#4794 StartFinishScope net6.0 550ns 0.204ns 0.79ns 0.00905 0 0 656 B
#4794 StartFinishScope netcoreapp3.1 688ns 0.22ns 0.854ns 0.00895 0 0 656 B
#4794 StartFinishScope net472 803ns 0.487ns 1.89ns 0.0981 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4794

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.181 653.83 553.70

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 653ns 1.24ns 4.78ns 0.00927 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 843ns 0.163ns 0.588ns 0.0088 0 0 656 B
master RunOnMethodBegin net472 1.08μs 0.876ns 3.39ns 0.0982 0 0 618 B
#4794 RunOnMethodBegin net6.0 554ns 0.155ns 0.601ns 0.00923 0 0 656 B
#4794 RunOnMethodBegin netcoreapp3.1 852ns 2.83ns 10.9ns 0.00856 0 0 656 B
#4794 RunOnMethodBegin net472 1.02μs 1.39ns 5.38ns 0.098 0 0 618 B

@andrewlock
Copy link
Member Author

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4794) (11.144M)   : 0, 11143907
    master (11.399M)   : 0, 11398875
    benchmarks/2.38.0 (11.867M)   : 0, 11866956
    benchmarks/2.9.0 (10.958M)   : 0, 10957550

    section Automatic
    This PR (4794) (7.715M)   : 0, 7714695
    master (7.836M)   : 0, 7836035
    benchmarks/2.38.0 (8.176M)   : 0, 8175636
    benchmarks/2.9.0 (7.908M)   : 0, 7907971

    section Trace stats
    This PR (4794) (8.109M)   : 0, 8109091
    master (8.152M)   : 0, 8152024
    benchmarks/2.38.0 (8.450M)   : 0, 8450370

    section Manual
    This PR (4794) (9.903M)   : 0, 9903454
    master (9.935M)   : 0, 9934703
    benchmarks/2.38.0 (10.334M)   : 0, 10334368

    section Manual + Automatic
    This PR (4794) (7.349M)   : 0, 7348919
    master (7.416M)   : 0, 7416442
    benchmarks/2.38.0 (7.750M)   : 0, 7750484

    section Version Conflict
    This PR (4794) (6.747M)   : 0, 6747013
    master (6.605M)   : 0, 6604940
    benchmarks/2.38.0 (7.137M)   : 0, 7136691
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4794) (9.553M)   : 0, 9552565
    master (9.510M)   : 0, 9509705
    benchmarks/2.38.0 (9.548M)   : 0, 9548121
    benchmarks/2.9.0 (9.589M)   : 0, 9589306

    section Automatic
    This PR (4794) (6.699M)   : 0, 6698794
    master (6.679M)   : 0, 6679016
    benchmarks/2.38.0 (6.747M)   : 0, 6747227

    section Trace stats
    This PR (4794) (6.816M)   : 0, 6816435
    master (6.722M)   : 0, 6721893
    benchmarks/2.38.0 (6.815M)   : 0, 6814846

    section Manual
    This PR (4794) (8.322M)   : 0, 8322045
    master (8.395M)   : 0, 8394690
    benchmarks/2.38.0 (8.263M)   : 0, 8263131

    section Manual + Automatic
    This PR (4794) (6.353M)   : 0, 6352611
    master (6.164M)   : 0, 6163785
    benchmarks/2.38.0 (6.275M)   : 0, 6275411

    section Version Conflict
    This PR (4794) (5.636M)   : 0, 5635783
    master (5.900M)   : 0, 5900403
    benchmarks/2.38.0 (5.670M)   : 0, 5669744
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4794) (9.184M)   : 0, 9184430
    master (9.305M)   : 0, 9304747
    benchmarks/2.38.0 (9.007M)   : 0, 9007066
    benchmarks/2.9.0 (9.595M)   : 0, 9594704

    section Automatic
    This PR (4794) (6.647M)   : 0, 6647442
    master (6.676M)   : 0, 6676077
    benchmarks/2.38.0 (6.423M)   : 0, 6422756
    benchmarks/2.9.0 (7.049M)   : 0, 7048800

    section Trace stats
    This PR (4794) (6.964M)   : 0, 6964159
    master (6.969M)   : 0, 6968808
    benchmarks/2.38.0 (6.721M)   : 0, 6720838

    section Manual
    This PR (4794) (8.408M)   : 0, 8408086
    master (8.187M)   : 0, 8186835
    benchmarks/2.38.0 (7.977M)   : 0, 7977494

    section Manual + Automatic
    This PR (4794) (6.513M)   : 0, 6513380
    master (6.492M)   : 0, 6491775
    benchmarks/2.38.0 (6.349M)   : 0, 6349066

    section Version Conflict
    This PR (4794) (5.885M)   : 0, 5884885
    master (5.980M)   : 0, 5979666
    benchmarks/2.38.0 (5.682M)   : 0, 5681654
Loading 
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    master (7.817M)   : 0, 7817450
    benchmarks/2.38.0 (7.578M)   : 0, 7577544
    benchmarks/2.9.0 (7.477M)   : 0, 7476547

    section No attack
    master (2.271M)   : 0, 2271057
    benchmarks/2.38.0 (2.184M)   : 0, 2184279
    benchmarks/2.9.0 (3.151M)   : 0, 3151044

    section Attack
    master (1.796M)   : 0, 1796312
    benchmarks/2.38.0 (1.711M)   : 0, 1710542
    benchmarks/2.9.0 (2.361M)   : 0, 2361022

    section Blocking
    master (3.546M)   : 0, 3546275
    benchmarks/2.38.0 (3.486M)   : 0, 3486124

    section IAST default
    master (7.099M)   : 0, 7099200

    section IAST full
    master (6.437M)   : 0, 6437099

    section Base vuln
    master (0.989M)   : 0, 988686

    section IAST vuln
    master (0.947M)   : 0, 947078
Loading

@andrewlock andrewlock merged commit 8398901 into master Nov 1, 2023
@andrewlock andrewlock deleted the andrew/ci/update-python branch November 1, 2023 16:28
@github-actions github-actions bot added this to the vNext milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes

@bouwkast bouwkast bouwkast approved these changes

@lucaspimentel lucaspimentel lucaspimentel approved these changes

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Milestone
2.41.0
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewlock @lucaspimentel @bouwkast @zacharycmontoya