Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error message when IIS is not found #4774

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Add error message when IIS is not found #4774

merged 1 commit into from
Nov 2, 2023

Conversation

kevingosse
Copy link
Collaborator

Summary of changes

Display a specific message when IIS is not installed.

Reason for change

It looks like some people are trying to run the tool without installing IIS.

Implementation details

Asked some people to give me the error code then pasted it in the code.

Test coverage

That's difficult to test, short of asking some people to run it on their machine.

@kevingosse kevingosse requested a review from a team as a code owner October 27, 2023 12:27
andrewlock
andrewlock approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some people approve

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Oct 27, 2023 •
edited
Loading

Datadog Report

Branch report: kevin/dd-dotnet-andrew
Commit report: ebd793b

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 295611 Passed, 942 Skipped, 26m 34.31s Wall Time

@andrewlock
Copy link
Member

andrewlock commented Oct 27, 2023 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4774) - mean (71ms)  : 63, 79
     .   : milestone, 71,
    master - mean (71ms)  : 62, 79
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (4774) - mean (997ms)  : 976, 1019
     .   : milestone, 997,
    master - mean (992ms)  : 972, 1012
     .   : milestone, 992,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4774) - mean (106ms)  : 102, 109
     .   : milestone, 106,
    master - mean (106ms)  : 102, 109
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (4774) - mean (681ms)  : 664, 699
     .   : milestone, 681,
    master - mean (680ms)  : 666, 694
     .   : milestone, 680,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4774) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (89ms)  : 86, 92
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (4774) - mean (654ms)  : 633, 676
     .   : milestone, 654,
    master - mean (652ms)  : 631, 672
     .   : milestone, 652,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4774) - mean (188ms)  : 186, 190
     .   : milestone, 188,
    master - mean (188ms)  : 185, 190
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (4774) - mean (1,141ms)  : 1120, 1162
     .   : milestone, 1141,
    master - mean (1,140ms)  : 1120, 1161
     .   : milestone, 1140,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4774) - mean (271ms)  : 266, 275
     .   : milestone, 271,
    master - mean (271ms)  : 268, 274
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (4774) - mean (1,098ms)  : 1072, 1123
     .   : milestone, 1098,
    master - mean (1,094ms)  : 1068, 1121
     .   : milestone, 1094,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4774) - mean (262ms)  : 258, 265
     .   : milestone, 262,
    master - mean (262ms)  : 259, 265
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (4774) - mean (1,067ms)  : 1039, 1095
     .   : milestone, 1067,
    master - mean (1,069ms)  : 1038, 1101
     .   : milestone, 1069,
Loading

@andrewlock
Copy link
Member

Benchmarks Report 🐌

Benchmarks for #4774 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.236
  • 1 benchmarks are slower, with geometric mean 1.114
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.08μs 43.4ns 242ns 0.0242 0.0121 0 7.29 KB
master StartStopWithChild netcoreapp3.1 9.81μs 50.2ns 230ns 0.0342 0.0147 0 7.38 KB
master StartStopWithChild net472 15.6μs 57.1ns 221ns 1.28 0.315 0.0845 7.67 KB
#4774 StartStopWithChild net6.0 8.16μs 40.1ns 165ns 0.0246 0.00821 0 7.28 KB
#4774 StartStopWithChild netcoreapp3.1 9.72μs 46ns 230ns 0.025 0.00999 0 7.39 KB
#4774 StartStopWithChild net472 15.4μs 54.8ns 212ns 1.29 0.325 0.101 7.65 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 481μs 357ns 1.38μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 643μs 485ns 1.82μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 790μs 392ns 1.52μs 0.396 0 0 3.3 KB
#4774 WriteAndFlushEnrichedTraces net6.0 463μs 293ns 1.1μs 0 0 0 2.7 KB
#4774 WriteAndFlushEnrichedTraces netcoreapp3.1 643μs 159ns 573ns 0 0 0 2.7 KB
#4774 WriteAndFlushEnrichedTraces net472 794μs 222ns 829ns 0.396 0 0 3.3 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 43.1μs 101ns 393ns 0.0218 0 0 2.03 KB
master AllCycleSimpleBody netcoreapp3.1 45μs 37ns 143ns 0.0229 0 0 2.01 KB
master AllCycleSimpleBody net472 46.5μs 95.8ns 359ns 0.321 0 0 2.08 KB
master AllCycleMoreComplexBody net6.0 229μs 132ns 510ns 0.114 0 0 8.63 KB
master AllCycleMoreComplexBody netcoreapp3.1 234μs 118ns 427ns 0.117 0 0 8.52 KB
master AllCycleMoreComplexBody net472 240μs 105ns 406ns 1.35 0 0 8.7 KB
master ObjectExtractorSimpleBody net6.0 121ns 0.0983ns 0.381ns 0.00397 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 178ns 0.308ns 1.19ns 0.00374 0 0 272 B
master ObjectExtractorSimpleBody net472 146ns 0.0743ns 0.288ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3.05μs 1.78ns 6.65ns 0.0548 0 0 3.88 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.19μs 1.32ns 5.12ns 0.0515 0 0 3.78 KB
master ObjectExtractorMoreComplexBody net472 4.13μs 1.46ns 5.47ns 0.617 0.00619 0 3.89 KB
#4774 AllCycleSimpleBody net6.0 44.4μs 117ns 439ns 0.0217 0 0 2.03 KB
#4774 AllCycleSimpleBody netcoreapp3.1 45.2μs 101ns 379ns 0.0226 0 0 2.01 KB
#4774 AllCycleSimpleBody net472 46.9μs 16.1ns 60.1ns 0.308 0 0 2.08 KB
#4774 AllCycleMoreComplexBody net6.0 228μs 68ns 255ns 0.114 0 0 8.63 KB
#4774 AllCycleMoreComplexBody netcoreapp3.1 234μs 117ns 439ns 0.117 0 0 8.52 KB
#4774 AllCycleMoreComplexBody net472 239μs 96.4ns 361ns 1.31 0 0 8.7 KB
#4774 ObjectExtractorSimpleBody net6.0 122ns 0.0539ns 0.209ns 0.00395 0 0 280 B
#4774 ObjectExtractorSimpleBody netcoreapp3.1 179ns 0.0819ns 0.307ns 0.00378 0 0 272 B
#4774 ObjectExtractorSimpleBody net472 148ns 0.101ns 0.392ns 0.0446 0 0 281 B
#4774 ObjectExtractorMoreComplexBody net6.0 3.04μs 0.749ns 2.8ns 0.0549 0 0 3.88 KB
#4774 ObjectExtractorMoreComplexBody netcoreapp3.1 4.07μs 1.25ns 4.84ns 0.0511 0 0 3.78 KB
#4774 ObjectExtractorMoreComplexBody net472 4.15μs 3.3ns 12.8ns 0.618 0.00622 0 3.89 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWaf(args=NestedMap (10)) net6.0 12.7μs 3.04ns 11ns 0.133 0 0 9.42 KB
master RunWaf(args=NestedMap (10)) netcoreapp3.1 19.4μs 7.47ns 28ns 0.126 0 0 9.42 KB
master RunWaf(args=NestedMap (10)) net472 28μs 6.63ns 25.7ns 1.5 0 0 9.48 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 75.7μs 214ns 829ns 0.193 0 0 15.77 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 87.1μs 51ns 198ns 0.174 0 0 15.72 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 98.9μs 135ns 525ns 2.5 0 0 16.04 KB
master RunWaf(args=NestedMap (100)) net6.0 24.4μs 9ns 34.9ns 0.28 0 0 19.66 KB
master RunWaf(args=NestedMap (100)) netcoreapp3.1 38.1μs 9.16ns 34.3ns 0.268 0 0 20.42 KB
master RunWaf(args=NestedMap (100)) net472 57.7μs 22.1ns 82.8ns 3.25 0.0288 0 20.63 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 91.6μs 214ns 827ns 0.361 0 0 26.01 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 108μs 92.4ns 346ns 0.322 0 0 26.72 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net472 130μs 209ns 809ns 4.26 0.0645 0 27.19 KB
master RunWaf(args=NestedMap (20)) net6.0 24.1μs 7.33ns 28.4ns 0.265 0 0 19.4 KB
master RunWaf(args=NestedMap (20)) netcoreapp3.1 37.8μs 13.5ns 50.5ns 0.264 0 0 19.84 KB
master RunWaf(args=NestedMap (20)) net472 54.3μs 57.7ns 224ns 3.17 0.0546 0 20.04 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 90.7μs 148ns 555ns 0.318 0 0 25.74 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 111μs 112ns 435ns 0.334 0 0 26.14 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 132μs 260ns 1.01μs 4.19 0.0654 0 26.6 KB
#4774 RunWaf(args=NestedMap (10)) net6.0 12.9μs 2.51ns 9.39ns 0.134 0 0 9.42 KB
#4774 RunWaf(args=NestedMap (10)) netcoreapp3.1 19.3μs 4.54ns 15.7ns 0.116 0 0 9.42 KB
#4774 RunWaf(args=NestedMap (10)) net472 28.3μs 14ns 54.4ns 1.5 0 0 9.48 KB
#4774 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 77.4μs 124ns 480ns 0.193 0 0 15.77 KB
#4774 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 86.4μs 75.6ns 293ns 0.172 0 0 15.72 KB
#4774 RunWafWithAttack(args=Neste(...)tack) [22]) net472 99.1μs 39.1ns 151ns 2.53 0 0 16.04 KB
#4774 RunWaf(args=NestedMap (100)) net6.0 24.3μs 6.84ns 26.5ns 0.267 0 0 19.66 KB
#4774 RunWaf(args=NestedMap (100)) netcoreapp3.1 38.4μs 29.1ns 113ns 0.287 0 0 20.42 KB
#4774 RunWaf(args=NestedMap (100)) net472 54.7μs 25ns 96.8ns 3.25 0.0274 0 20.63 KB
#4774 RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 92.6μs 41.6ns 161ns 0.369 0 0 26.01 KB
#4774 RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 109μs 83.3ns 323ns 0.325 0 0 26.72 KB
#4774 RunWafWithAttack(args=Neste(...)tack) [23]) net472 130μs 109ns 423ns 4.31 0.0643 0 27.19 KB
#4774 RunWaf(args=NestedMap (20)) net6.0 24μs 10.3ns 39.8ns 0.263 0 0 19.4 KB
#4774 RunWaf(args=NestedMap (20)) netcoreapp3.1 38.3μs 12.5ns 48.6ns 0.267 0 0 19.84 KB
#4774 RunWaf(args=NestedMap (20)) net472 53.9μs 45.2ns 175ns 3.17 0.0538 0 20.04 KB
#4774 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 91.8μs 233ns 903ns 0.363 0 0 25.74 KB
#4774 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 109μs 116ns 417ns 0.328 0 0 26.14 KB
#4774 RunWafWithAttack(args=Neste(...)tack) [22]) net472 131μs 206ns 800ns 4.22 0.0649 0 26.6 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 167μs 259ns 1μs 0.168 0 0 18.04 KB
master SendRequest netcoreapp3.1 190μs 296ns 1.15μs 0.19 0 0 20.2 KB
master SendRequest net472 0.000667ns 0.00019ns 0.000736ns 0 0 0 0 b
#4774 SendRequest net6.0 168μs 191ns 740ns 0.251 0 0 18.04 KB
#4774 SendRequest netcoreapp3.1 191μs 312ns 1.21μs 0.189 0 0 20.2 KB
#4774 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 541μs 732ns 2.84μs 0.541 0 0 41.53 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 659μs 2.1μs 8.15μs 0.329 0 0 41.7 KB
master WriteAndFlushEnrichedTraces net472 823μs 3.72μs 14.4μs 8.17 2.45 0.408 53.24 KB
#4774 WriteAndFlushEnrichedTraces net6.0 547μs 486ns 1.88μs 0.553 0 0 41.49 KB
#4774 WriteAndFlushEnrichedTraces netcoreapp3.1 650μs 447ns 1.61μs 0.326 0 0 41.6 KB
#4774 WriteAndFlushEnrichedTraces net472 845μs 4.19μs 18.8μs 8.39 2.52 0.419 53.24 KB
Benchmarks.Trace.DbCommandBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4774

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.114 987.96 1,101.04

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 988ns 0.525ns 1.96ns 0.011 0 0 768 B
master ExecuteNonQuery netcoreapp3.1 1.3μs 0.853ns 3.19ns 0.0104 0 0 768 B
master ExecuteNonQuery net472 1.6μs 0.348ns 1.35ns 0.115 0 0 730 B
#4774 ExecuteNonQuery net6.0 1.1μs 0.632ns 2.36ns 0.0105 0 0 768 B
#4774 ExecuteNonQuery netcoreapp3.1 1.29μs 0.526ns 2.04ns 0.0103 0 0 768 B
#4774 ExecuteNonQuery net472 1.61μs 1.43ns 4.96ns 0.116 0 0 730 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.07μs 0.463ns 1.73ns 0.0129 0 0 936 B
master CallElasticsearch netcoreapp3.1 1.43μs 0.386ns 1.39ns 0.0121 0 0 936 B
master CallElasticsearch net472 2.33μs 0.831ns 3ns 0.152 0 0 955 B
master CallElasticsearchAsync net6.0 1.17μs 0.761ns 2.95ns 0.0124 0 0 912 B
master CallElasticsearchAsync netcoreapp3.1 1.59μs 0.49ns 1.9ns 0.0127 0 0 984 B
master CallElasticsearchAsync net472 2.43μs 0.761ns 2.63ns 0.16 0 0 1.01 KB
#4774 CallElasticsearch net6.0 1.17μs 0.63ns 2.44ns 0.0129 0 0 936 B
#4774 CallElasticsearch netcoreapp3.1 1.41μs 0.653ns 2.53ns 0.0127 0 0 936 B
#4774 CallElasticsearch net472 2.37μs 1.38ns 5.35ns 0.151 0 0 955 B
#4774 CallElasticsearchAsync net6.0 1.23μs 0.669ns 2.5ns 0.0124 0 0 912 B
#4774 CallElasticsearchAsync netcoreapp3.1 1.5μs 1.2ns 4.66ns 0.0129 0 0 984 B
#4774 CallElasticsearchAsync net472 2.43μs 1.14ns 4.27ns 0.161 0 0 1.01 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.19μs 1.02ns 3.94ns 0.0131 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.58μs 0.806ns 3.02ns 0.0118 0 0 912 B
master ExecuteAsync net472 1.74μs 0.336ns 1.21ns 0.138 0 0 875 B
#4774 ExecuteAsync net6.0 1.19μs 1.47ns 5.7ns 0.013 0 0 912 B
#4774 ExecuteAsync netcoreapp3.1 1.53μs 0.893ns 3.46ns 0.0123 0 0 912 B
#4774 ExecuteAsync net472 1.76μs 1.82ns 7.05ns 0.139 0 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 3.89μs 3.11ns 12.1ns 0.0254 0 0 1.9 KB
master SendAsync netcoreapp3.1 4.39μs 2.25ns 8.41ns 0.0328 0 0 2.43 KB
master SendAsync net472 7.04μs 2.23ns 8.34ns 0.475 0 0 2.99 KB
#4774 SendAsync net6.0 3.88μs 2.07ns 8.02ns 0.0252 0 0 1.9 KB
#4774 SendAsync netcoreapp3.1 4.43μs 0.962ns 3.73ns 0.0333 0 0 2.43 KB
#4774 SendAsync net472 7.01μs 3.24ns 12.6ns 0.475 0 0 2.99 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.39μs 0.826ns 3.2ns 0.0221 0 0 1.57 KB
master EnrichedLog netcoreapp3.1 1.9μs 1.22ns 4.73ns 0.0208 0 0 1.57 KB
master EnrichedLog net472 2.31μs 3.72ns 14.4ns 0.236 0 0 1.49 KB
#4774 EnrichedLog net6.0 1.31μs 0.456ns 1.7ns 0.0218 0 0 1.57 KB
#4774 EnrichedLog netcoreapp3.1 2μs 0.632ns 2.45ns 0.0209 0 0 1.57 KB
#4774 EnrichedLog net472 2.31μs 1.34ns 5.01ns 0.236 0 0 1.49 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 111μs 55ns 206ns 0.0558 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 117μs 129ns 501ns 0 0 0 4.21 KB
master EnrichedLog net472 147μs 90.9ns 352ns 0.66 0.22 0 4.38 KB
#4774 EnrichedLog net6.0 113μs 96.3ns 373ns 0.0571 0 0 4.21 KB
#4774 EnrichedLog netcoreapp3.1 117μs 146ns 565ns 0 0 0 4.21 KB
#4774 EnrichedLog net472 147μs 162ns 628ns 0.663 0.221 0 4.38 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.9μs 1.27ns 4.91ns 0.0304 0 0 2.13 KB
master EnrichedLog netcoreapp3.1 3.97μs 1.1ns 4.25ns 0.0278 0 0 2.13 KB
master EnrichedLog net472 4.59μs 1.6ns 6.21ns 0.307 0 0 1.93 KB
#4774 EnrichedLog net6.0 3.14μs 1.13ns 4.38ns 0.0296 0 0 2.13 KB
#4774 EnrichedLog netcoreapp3.1 4.03μs 1.77ns 6.64ns 0.0282 0 0 2.13 KB
#4774 EnrichedLog net472 4.57μs 2.35ns 9.11ns 0.306 0 0 1.93 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.3μs 0.458ns 1.77ns 0.0156 0 0 1.1 KB
master SendReceive netcoreapp3.1 1.56μs 0.583ns 2.1ns 0.0149 0 0 1.1 KB
master SendReceive net472 2.01μs 1.94ns 7.27ns 0.177 0 0 1.12 KB
#4774 SendReceive net6.0 1.24μs 0.584ns 2.26ns 0.0155 0 0 1.1 KB
#4774 SendReceive netcoreapp3.1 1.59μs 2.16ns 8.38ns 0.015 0 0 1.1 KB
#4774 SendReceive net472 1.97μs 0.972ns 3.51ns 0.177 0 0 1.12 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.61μs 0.746ns 2.89ns 0.0209 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.7μs 2.02ns 7.82ns 0.0203 0 0 1.58 KB
master EnrichedLog net472 3.91μs 2.2ns 7.94ns 0.309 0 0 1.96 KB
#4774 EnrichedLog net6.0 2.73μs 1.4ns 5.25ns 0.0204 0 0 1.53 KB
#4774 EnrichedLog netcoreapp3.1 3.61μs 1.27ns 4.9ns 0.0217 0 0 1.58 KB
#4774 EnrichedLog net472 3.99μs 1.44ns 5.19ns 0.311 0 0 1.96 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4774

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.236 636.19 514.71

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 507ns 0.692ns 2.59ns 0.00742 0 0 536 B
master StartFinishSpan netcoreapp3.1 636ns 0.164ns 0.634ns 0.0074 0 0 536 B
master StartFinishSpan net472 661ns 0.248ns 0.96ns 0.0852 0 0 538 B
master StartFinishScope net6.0 520ns 0.263ns 1.02ns 0.0092 0 0 656 B
master StartFinishScope netcoreapp3.1 699ns 0.235ns 0.879ns 0.0087 0 0 656 B
master StartFinishScope net472 822ns 0.405ns 1.57ns 0.0981 0 0 618 B
#4774 StartFinishSpan net6.0 457ns 0.141ns 0.526ns 0.00743 0 0 536 B
#4774 StartFinishSpan netcoreapp3.1 515ns 0.118ns 0.441ns 0.00723 0 0 536 B
#4774 StartFinishSpan net472 598ns 0.194ns 0.727ns 0.0854 0 0 538 B
#4774 StartFinishScope net6.0 555ns 0.252ns 0.977ns 0.00918 0 0 656 B
#4774 StartFinishScope netcoreapp3.1 709ns 1.78ns 6.9ns 0.00877 0 0 656 B
#4774 StartFinishScope net472 838ns 0.686ns 2.66ns 0.0978 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 540ns 0.433ns 1.68ns 0.0092 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 784ns 0.313ns 1.21ns 0.00903 0 0 656 B
master RunOnMethodBegin net472 1.05μs 0.486ns 1.88ns 0.098 0 0 618 B
#4774 RunOnMethodBegin net6.0 527ns 0.204ns 0.791ns 0.00929 0 0 656 B
#4774 RunOnMethodBegin netcoreapp3.1 861ns 0.666ns 2.58ns 0.00857 0 0 656 B
#4774 RunOnMethodBegin net472 1.01μs 0.419ns 1.62ns 0.0981 0 0 618 B

@kevingosse kevingosse force-pushed the kevin/dd-dotnet-andrew branch from 56af1df to ebd793b Compare November 2, 2023 11:37
@kevingosse kevingosse merged commit d32974e into master Nov 2, 2023
@kevingosse kevingosse deleted the kevin/dd-dotnet-andrew branch November 2, 2023 13:50
@github-actions github-actions bot added this to the vNext milestone Nov 2, 2023
@andrewlock andrewlock added type:enhancement Improvement to an existing feature area:tools labels Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes

Assignees
No one assigned
Labels
area:tools type:enhancement Improvement to an existing feature
Projects
None yet
Milestone
2.41.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kevingosse @andrewlock @zacharycmontoya