Rename TelemetryV2 to Telemetry #4751

andrewlock · 2023-10-23T16:44:48Z

Summary of changes

Rename everything with a v2 suffix

Reason for change

We only have one version of telemetry now, and it's confusing enough without the extra suffixes

Implementation details

Renamed all the types that had V2 suffixes, so TelemetryDataV2 -> TelemetryData
Removed the TelemetryWrapper abstraction used in integration tests, as we only produce one type of data now

Test coverage

All covered by existing tests

Other details

Stacked on

Delete Telemetry V1 implementation #4750

andrewlock · 2023-10-23T17:08:54Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4751) - mean (68ms)  : 65, 71
     .   : milestone, 68,
    master - mean (68ms)  : 66, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (4751) - mean (982ms)  : 965, 999
     .   : milestone, 982,
    master - mean (983ms)  : 961, 1006
     .   : milestone, 983,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4751) - mean (106ms)  : 103, 109
     .   : milestone, 106,
    master - mean (106ms)  : 103, 109
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (4751) - mean (676ms)  : 659, 693
     .   : milestone, 676,
    master - mean (679ms)  : 656, 703
     .   : milestone, 679,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4751) - mean (90ms)  : 87, 93
     .   : milestone, 90,
    master - mean (90ms)  : 88, 92
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (4751) - mean (645ms)  : 622, 668
     .   : milestone, 645,
    master - mean (638ms)  : 619, 656
     .   : milestone, 638,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4751) - mean (188ms)  : 185, 190
     .   : milestone, 188,
    master - mean (189ms)  : 186, 191
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (4751) - mean (1,131ms)  : 1116, 1147
     .   : milestone, 1131,
    master - mean (1,132ms)  : 1109, 1154
     .   : milestone, 1132,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4751) - mean (271ms)  : 267, 275
     .   : milestone, 271,
    master - mean (272ms)  : 268, 275
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (4751) - mean (1,092ms)  : 1070, 1114
     .   : milestone, 1092,
    master - mean (1,090ms)  : 1065, 1116
     .   : milestone, 1090,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4751) - mean (262ms)  : 258, 265
     .   : milestone, 262,
    master - mean (262ms)  : 259, 265
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (4751) - mean (1,064ms)  : 1043, 1085
     .   : milestone, 1064,
    master - mean (1,056ms)  : 1033, 1078
     .   : milestone, 1056,

datadog-ddstaging · 2023-10-23T17:10:52Z

Datadog Report

Branch report: andrew/telemetry/rename-v2-to-v1
Commit report: 63ff23a

❄️ dd-trace-dotnet: 0 Failed, 1 New Flaky, 301808 Passed, 905 Skipped, 1 Regression, 59m 0.44s Wall Time

New Flaky Tests (1)

WorkingWithContinuousProfiler - Datadog.Trace.Tools.dd_dotnet.ArtifactTests.Checks.ProcessBasicChecksTests

⌛ Performance Regressions vs Default Branch (1)

Baseline_contention - scenarios 1.02s (+14.22ms, +1%)

andrewlock · 2023-10-23T18:07:33Z

Benchmarks Report 🐌

Benchmarks for #4751 compared to master:

4 benchmarks are faster, with geometric mean 1.148
1 benchmarks are slower, with geometric mean 1.173
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.11μs	45.6ns	316ns	0.0197	0.00787	0	7.29 KB
master	`StartStopWithChild`	netcoreapp3.1	10μs	50.1ns	218ns	0.0246	0.00983	0	7.38 KB
master	`StartStopWithChild`	net472	15.3μs	39ns	151ns	1.28	0.306	0.0994	7.66 KB
#4751	`StartStopWithChild`	net6.0	8.24μs	44ns	241ns	0.0164	0.00821	0	7.29 KB
#4751	`StartStopWithChild`	netcoreapp3.1	10.3μs	58.1ns	390ns	0.0347	0.0149	0	7.38 KB
#4751	`StartStopWithChild`	net472	15.7μs	46.2ns	179ns	1.3	0.339	0.108	7.67 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	476μs	120ns	464ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	621μs	418ns	1.62μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	787μs	383ns	1.48μs	0.393	3.3 KB
#4751	`WriteAndFlushEnrichedTraces`	net6.0	479μs	230ns	891ns	0	2.7 KB
#4751	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	634μs	318ns	1.23μs	0	2.7 KB
#4751	`WriteAndFlushEnrichedTraces`	net472	784μs	347ns	1.3μs	0.391	3.3 KB

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`AllCycleSimpleBody`	net6.0	43.2μs	29.9ns	112ns	0.0216	0	2.03 KB
master	`AllCycleSimpleBody`	netcoreapp3.1	46.1μs	58.3ns	226ns	0.0229	0	2.01 KB
master	`AllCycleSimpleBody`	net472	46.5μs	22.4ns	86.9ns	0.324	0	2.08 KB
master	`AllCycleMoreComplexBody`	net6.0	230μs	83.4ns	312ns	0.114	0	8.63 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	233μs	120ns	465ns	0.117	0	8.52 KB
master	`AllCycleMoreComplexBody`	net472	237μs	45.7ns	177ns	1.3	0	8.7 KB
master	`ObjectExtractorSimpleBody`	net6.0	120ns	0.0661ns	0.247ns	0.00395	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	177ns	0.137ns	0.529ns	0.00375	0	272 B
master	`ObjectExtractorSimpleBody`	net472	146ns	0.0998ns	0.387ns	0.0446	0	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	3.03μs	0.914ns	3.54ns	0.0546	0	3.88 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	4.04μs	1.66ns	6.44ns	0.0525	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	net472	4.11μs	4.04ns	15.7ns	0.618	0.00614	3.89 KB
#4751	`AllCycleSimpleBody`	net6.0	44.1μs	63.7ns	247ns	0.0221	0	2.03 KB
#4751	`AllCycleSimpleBody`	netcoreapp3.1	44.8μs	111ns	432ns	0.0226	0	2.01 KB
#4751	`AllCycleSimpleBody`	net472	46.4μs	58.3ns	218ns	0.32	0	2.08 KB
#4751	`AllCycleMoreComplexBody`	net6.0	229μs	124ns	482ns	0.114	0	8.63 KB
#4751	`AllCycleMoreComplexBody`	netcoreapp3.1	233μs	114ns	440ns	0.117	0	8.52 KB
#4751	`AllCycleMoreComplexBody`	net472	239μs	236ns	914ns	1.3	0	8.7 KB
#4751	`ObjectExtractorSimpleBody`	net6.0	119ns	0.0577ns	0.216ns	0.00391	0	280 B
#4751	`ObjectExtractorSimpleBody`	netcoreapp3.1	173ns	0.331ns	1.28ns	0.00374	0	272 B
#4751	`ObjectExtractorSimpleBody`	net472	150ns	0.0525ns	0.203ns	0.0446	0	281 B
#4751	`ObjectExtractorMoreComplexBody`	net6.0	3μs	1.63ns	6.1ns	0.0539	0	3.88 KB
#4751	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	4.08μs	1.21ns	4.53ns	0.051	0	3.78 KB
#4751	`ObjectExtractorMoreComplexBody`	net472	4.2μs	3.04ns	11.8ns	0.617	0.00625	3.89 KB

Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`RunWaf(args=NestedMap (10))`	net6.0	12.6μs	3.02ns	11.3ns	0.133	0	9.42 KB
master	`RunWaf(args=NestedMap (10))`	netcoreapp3.1	19.5μs	5.06ns	18.2ns	0.126	0	9.42 KB
master	`RunWaf(args=NestedMap (10))`	net472	27.9μs	10.3ns	38.5ns	1.5	0	9.48 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	76.5μs	49.9ns	187ns	0.194	0	15.77 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	86μs	190ns	709ns	0.175	0	15.72 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	97.7μs	96ns	346ns	2.5	0	16.04 KB
master	`RunWaf(args=NestedMap (100))`	net6.0	24.2μs	9.56ns	37ns	0.278	0	19.66 KB
master	`RunWaf(args=NestedMap (100))`	netcoreapp3.1	38.1μs	8.54ns	32ns	0.268	0	20.42 KB
master	`RunWaf(args=NestedMap (100))`	net472	55.4μs	27.4ns	103ns	3.26	0.0553	20.63 KB
master	`RunWafWithAttack(args=Neste(...)tack) [23])`	net6.0	93.4μs	43.9ns	170ns	0.369	0	26.01 KB
master	`RunWafWithAttack(args=Neste(...)tack) [23])`	netcoreapp3.1	112μs	113ns	438ns	0.334	0	26.72 KB
master	`RunWafWithAttack(args=Neste(...)tack) [23])`	net472	130μs	342ns	1.32μs	4.29	0.065	27.19 KB
master	`RunWaf(args=NestedMap (20))`	net6.0	23.9μs	7.15ns	25.8ns	0.274	0	19.4 KB
master	`RunWaf(args=NestedMap (20))`	netcoreapp3.1	37.6μs	11.5ns	44.6ns	0.262	0	19.84 KB
master	`RunWaf(args=NestedMap (20))`	net472	53.9μs	32.8ns	123ns	3.16	0.0536	20.04 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	91.2μs	38.2ns	148ns	0.365	0	25.74 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	109μs	193ns	748ns	0.33	0	26.14 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	133μs	26.1ns	90.4ns	4.22	0.0659	26.6 KB
#4751	`RunWaf(args=NestedMap (10))`	net6.0	12.7μs	5.23ns	19.6ns	0.133	0	9.42 KB
#4751	`RunWaf(args=NestedMap (10))`	netcoreapp3.1	19.4μs	9.18ns	34.4ns	0.126	0	9.42 KB
#4751	`RunWaf(args=NestedMap (10))`	net472	28.3μs	10.5ns	40.6ns	1.5	0	9.48 KB
#4751	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	76.1μs	58.4ns	226ns	0.188	0	15.77 KB
#4751	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	86.5μs	174ns	650ns	0.175	0	15.72 KB
#4751	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	98.3μs	194ns	727ns	2.53	0	16.04 KB
#4751	`RunWaf(args=NestedMap (100))`	net6.0	24.8μs	7.28ns	28.2ns	0.27	0	19.66 KB
#4751	`RunWaf(args=NestedMap (100))`	netcoreapp3.1	37.6μs	11.2ns	43.5ns	0.264	0	20.42 KB
#4751	`RunWaf(args=NestedMap (100))`	net472	53.8μs	15ns	58.1ns	3.26	0.0269	20.63 KB
#4751	`RunWafWithAttack(args=Neste(...)tack) [23])`	net6.0	94μs	146ns	567ns	0.324	0	26.01 KB
#4751	`RunWafWithAttack(args=Neste(...)tack) [23])`	netcoreapp3.1	110μs	141ns	546ns	0.33	0	26.72 KB
#4751	`RunWafWithAttack(args=Neste(...)tack) [23])`	net472	134μs	170ns	659ns	4.29	0.0661	27.19 KB
#4751	`RunWaf(args=NestedMap (20))`	net6.0	23.7μs	7.57ns	29.3ns	0.273	0	19.4 KB
#4751	`RunWaf(args=NestedMap (20))`	netcoreapp3.1	37.7μs	15.4ns	59.5ns	0.264	0	19.84 KB
#4751	`RunWaf(args=NestedMap (20))`	net472	55.3μs	10.4ns	37.6ns	3.17	0.0552	20.04 KB
#4751	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	90.5μs	49.3ns	191ns	0.362	0	25.74 KB
#4751	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	108μs	121ns	468ns	0.323	0	26.14 KB
#4751	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	130μs	225ns	870ns	4.18	0.0642	26.6 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	169μs	228ns	884ns	0.255	18.04 KB
master	`SendRequest`	netcoreapp3.1	188μs	337ns	1.3μs	0.187	20.2 KB
master	`SendRequest`	net472	0.000143ns	9.65E‑05ns	0.000361ns	0	0 b
#4751	`SendRequest`	net6.0	169μs	149ns	579ns	0.254	18.04 KB
#4751	`SendRequest`	netcoreapp3.1	188μs	233ns	901ns	0.188	20.2 KB
#4751	`SendRequest`	net472	0.000763ns	0.000245ns	0.00095ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #4751

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.89 KB	41.67 KB	-213 B	-0.51%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	537μs	2.5μs	10.3μs	0.539	0	0	41.66 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	647μs	248ns	860ns	0.327	0	0	41.89 KB
master	`WriteAndFlushEnrichedTraces`	net472	855μs	4.02μs	15.6μs	8.45	2.53	0.422	53.24 KB
#4751	`WriteAndFlushEnrichedTraces`	net6.0	541μs	193ns	694ns	0.536	0	0	41.52 KB
#4751	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	654μs	652ns	2.44μs	0.326	0	0	41.67 KB
#4751	`WriteAndFlushEnrichedTraces`	net472	852μs	4.14μs	16.5μs	8.13	2.57	0.428	53.22 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.1μs	0.505ns	1.96ns	0.0104	768 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.3μs	0.366ns	1.42ns	0.0104	768 B
master	`ExecuteNonQuery`	net472	1.63μs	0.698ns	2.61ns	0.116	730 B
#4751	`ExecuteNonQuery`	net6.0	1.07μs	0.432ns	1.62ns	0.0107	768 B
#4751	`ExecuteNonQuery`	netcoreapp3.1	1.29μs	4ns	15.5ns	0.0104	768 B
#4751	`ExecuteNonQuery`	net472	1.67μs	3.31ns	12.8ns	0.115	730 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.29μs	0.97ns	3.63ns	0.0129	936 B
master	`CallElasticsearch`	netcoreapp3.1	1.51μs	1.02ns	3.94ns	0.0121	936 B
master	`CallElasticsearch`	net472	2.44μs	0.934ns	3.62ns	0.151	955 B
master	`CallElasticsearchAsync`	net6.0	1.3μs	0.65ns	2.52ns	0.0124	912 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.52μs	1.39ns	5.37ns	0.0129	984 B
master	`CallElasticsearchAsync`	net472	2.5μs	1.06ns	3.82ns	0.16	1.01 KB
#4751	`CallElasticsearch`	net6.0	1.21μs	0.543ns	2.03ns	0.0133	936 B
#4751	`CallElasticsearch`	netcoreapp3.1	1.38μs	0.438ns	1.69ns	0.0123	936 B
#4751	`CallElasticsearch`	net472	2.31μs	0.611ns	2.37ns	0.151	955 B
#4751	`CallElasticsearchAsync`	net6.0	1.22μs	1.81ns	7ns	0.0129	912 B
#4751	`CallElasticsearchAsync`	netcoreapp3.1	1.52μs	0.695ns	2.6ns	0.0131	984 B
#4751	`CallElasticsearchAsync`	net472	2.5μs	1.16ns	4.48ns	0.16	1.01 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.25μs	0.721ns	2.79ns	0.0125	912 B
master	`ExecuteAsync`	netcoreapp3.1	1.49μs	0.66ns	2.38ns	0.012	912 B
master	`ExecuteAsync`	net472	1.66μs	0.52ns	1.95ns	0.138	875 B
#4751	`ExecuteAsync`	net6.0	1.25μs	0.947ns	3.54ns	0.0127	912 B
#4751	`ExecuteAsync`	netcoreapp3.1	1.45μs	0.806ns	3.01ns	0.0122	912 B
#4751	`ExecuteAsync`	net472	1.74μs	0.857ns	3.09ns	0.139	875 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	3.72μs	0.939ns	3.39ns	0.0263	1.9 KB
master	`SendAsync`	netcoreapp3.1	4.4μs	1.74ns	6.74ns	0.033	2.43 KB
master	`SendAsync`	net472	7.13μs	3.07ns	11.9ns	0.473	2.99 KB
#4751	`SendAsync`	net6.0	3.75μs	2.82ns	10.9ns	0.0262	1.9 KB
#4751	`SendAsync`	netcoreapp3.1	4.53μs	2.52ns	9.09ns	0.0318	2.43 KB
#4751	`SendAsync`	net472	7μs	2.78ns	10.8ns	0.475	2.99 KB

Benchmarks.Trace.ILoggerBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4751

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1	1.141	2,122.51	1,860.64

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.42μs	0.7ns	2.62ns	0.0221	1.57 KB
master	`EnrichedLog`	netcoreapp3.1	2.12μs	1.22ns	4.57ns	0.0212	1.57 KB
master	`EnrichedLog`	net472	2.23μs	2.93ns	11.3ns	0.237	1.49 KB
#4751	`EnrichedLog`	net6.0	1.32μs	0.481ns	1.73ns	0.0221	1.57 KB
#4751	`EnrichedLog`	netcoreapp3.1	1.86μs	1.98ns	7.39ns	0.0213	1.57 KB
#4751	`EnrichedLog`	net472	2.26μs	1.52ns	5.49ns	0.236	1.49 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	112μs	132ns	510ns	0	0	4.21 KB
master	`EnrichedLog`	netcoreapp3.1	119μs	246ns	954ns	0.0599	0	4.21 KB
master	`EnrichedLog`	net472	146μs	62.3ns	225ns	0.661	0.22	4.38 KB
#4751	`EnrichedLog`	net6.0	113μs	73.1ns	273ns	0.0555	0	4.21 KB
#4751	`EnrichedLog`	netcoreapp3.1	117μs	55.9ns	194ns	0.0583	0	4.21 KB
#4751	`EnrichedLog`	net472	147μs	127ns	493ns	0.663	0.221	4.38 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.82μs	1.23ns	4.42ns	0.0295	2.13 KB
master	`EnrichedLog`	netcoreapp3.1	3.9μs	1.7ns	6.34ns	0.0272	2.13 KB
master	`EnrichedLog`	net472	4.69μs	1.87ns	7.01ns	0.307	1.93 KB
#4751	`EnrichedLog`	net6.0	2.87μs	1.33ns	4.96ns	0.0302	2.13 KB
#4751	`EnrichedLog`	netcoreapp3.1	3.79μs	1.53ns	5.51ns	0.0283	2.13 KB
#4751	`EnrichedLog`	net472	4.5μs	1.43ns	5.54ns	0.306	1.93 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.32μs	0.403ns	1.45ns	0.0152	1.1 KB
master	`SendReceive`	netcoreapp3.1	1.59μs	1.7ns	6.58ns	0.0148	1.1 KB
master	`SendReceive`	net472	1.99μs	2.48ns	8.93ns	0.177	1.12 KB
#4751	`SendReceive`	net6.0	1.37μs	0.778ns	2.91ns	0.0158	1.1 KB
#4751	`SendReceive`	netcoreapp3.1	1.58μs	0.632ns	2.45ns	0.015	1.1 KB
#4751	`SendReceive`	net472	2μs	4.35ns	16.3ns	0.177	1.12 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.49μs	0.837ns	3.24ns	0.0214	1.53 KB
master	`EnrichedLog`	netcoreapp3.1	3.57μs	1.43ns	5.55ns	0.0215	1.58 KB
master	`EnrichedLog`	net472	3.97μs	1.16ns	4.33ns	0.31	1.96 KB
#4751	`EnrichedLog`	net6.0	2.54μs	0.669ns	2.5ns	0.0216	1.53 KB
#4751	`EnrichedLog`	netcoreapp3.1	3.52μs	1.42ns	5.51ns	0.0209	1.58 KB
#4751	`EnrichedLog`	net472	4.02μs	1.39ns	5.37ns	0.31	1.96 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4751

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.173	395.70	464.26

Faster 🎉 in #4751

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1	1.186	789.72	665.72
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.129	518.82	459.35

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	396ns	0.349ns	1.31ns	0.00753	536 B
master	`StartFinishSpan`	netcoreapp3.1	545ns	0.191ns	0.74ns	0.00738	536 B
master	`StartFinishSpan`	net472	624ns	0.263ns	1.02ns	0.0854	538 B
master	`StartFinishScope`	net6.0	519ns	0.107ns	0.414ns	0.00929	656 B
master	`StartFinishScope`	netcoreapp3.1	788ns	1.75ns	6.77ns	0.00901	656 B
master	`StartFinishScope`	net472	885ns	0.538ns	2.08ns	0.098	618 B
#4751	`StartFinishSpan`	net6.0	464ns	0.153ns	0.572ns	0.00737	536 B
#4751	`StartFinishSpan`	netcoreapp3.1	563ns	0.135ns	0.468ns	0.00707	536 B
#4751	`StartFinishSpan`	net472	645ns	0.408ns	1.58ns	0.0854	538 B
#4751	`StartFinishScope`	net6.0	459ns	0.101ns	0.392ns	0.00909	656 B
#4751	`StartFinishScope`	netcoreapp3.1	666ns	0.26ns	0.974ns	0.0088	656 B
#4751	`StartFinishScope`	net472	860ns	0.334ns	1.29ns	0.0981	618 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4751

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.137	611.50	538.04

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	611ns	0.168ns	0.65ns	0.00914	656 B
master	`RunOnMethodBegin`	netcoreapp3.1	798ns	0.11ns	0.411ns	0.00872	656 B
master	`RunOnMethodBegin`	net472	941ns	0.314ns	1.17ns	0.0979	618 B
#4751	`RunOnMethodBegin`	net6.0	538ns	0.217ns	0.842ns	0.00912	656 B
#4751	`RunOnMethodBegin`	netcoreapp3.1	726ns	0.732ns	2.83ns	0.00881	656 B
#4751	`RunOnMethodBegin`	net472	936ns	0.447ns	1.73ns	0.0981	618 B

andrewlock · 2023-10-24T22:27:39Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4751) (11.146M)   : 0, 11145985
    master (11.211M)   : 0, 11211102
    benchmarks/2.38.0 (11.867M)   : 0, 11866956
    benchmarks/2.9.0 (10.896M)   : 0, 10896496

    section Automatic
    This PR (4751) (7.878M)   : 0, 7878487
    master (7.742M)   : 0, 7742331
    benchmarks/2.38.0 (8.176M)   : 0, 8175636
    benchmarks/2.9.0 (8.125M)   : 0, 8125054

    section Trace stats
    This PR (4751) (8.198M)   : 0, 8198340
    master (8.202M)   : 0, 8201502
    benchmarks/2.38.0 (8.450M)   : 0, 8450370

    section Manual
    This PR (4751) (9.850M)   : 0, 9850079
    master (10.170M)   : 0, 10169527
    benchmarks/2.38.0 (10.334M)   : 0, 10334368

    section Manual + Automatic
    This PR (4751) (7.417M)   : 0, 7416532
    master (7.564M)   : 0, 7563638
    benchmarks/2.38.0 (7.750M)   : 0, 7750484

    section Version Conflict
    This PR (4751) (6.780M)   : 0, 6779544
    master (6.936M)   : 0, 6935807
    benchmarks/2.38.0 (7.137M)   : 0, 7136691

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4751) (9.716M)   : 0, 9716197
    master (9.615M)   : 0, 9614769
    benchmarks/2.38.0 (9.548M)   : 0, 9548121
    benchmarks/2.9.0 (9.477M)   : 0, 9477392

    section Automatic
    This PR (4751) (6.569M)   : 0, 6569384
    master (6.707M)   : 0, 6706891
    benchmarks/2.38.0 (6.747M)   : 0, 6747227

    section Trace stats
    This PR (4751) (6.808M)   : 0, 6808398
    master (6.868M)   : 0, 6867968
    benchmarks/2.38.0 (6.815M)   : 0, 6814846

    section Manual
    This PR (4751) (8.424M)   : 0, 8423666
    master (8.523M)   : 0, 8522840
    benchmarks/2.38.0 (8.263M)   : 0, 8263131

    section Manual + Automatic
    This PR (4751) (6.294M)   : 0, 6293719
    master (6.085M)   : 0, 6084767
    benchmarks/2.38.0 (6.275M)   : 0, 6275411

    section Version Conflict
    This PR (4751) (5.875M)   : 0, 5875454
    master (5.947M)   : 0, 5946576
    benchmarks/2.38.0 (5.670M)   : 0, 5669744

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4751) (9.614M)   : 0, 9613741
    master (9.327M)   : 0, 9327438
    benchmarks/2.38.0 (9.007M)   : 0, 9007066
    benchmarks/2.9.0 (9.459M)   : 0, 9458597

    section Automatic
    This PR (4751) (6.753M)   : 0, 6753185
    master (6.719M)   : 0, 6719189
    benchmarks/2.38.0 (6.423M)   : 0, 6422756
    benchmarks/2.9.0 (6.995M)   : 0, 6994572

    section Trace stats
    This PR (4751) (6.958M)   : 0, 6958041
    master (6.902M)   : 0, 6901701
    benchmarks/2.38.0 (6.721M)   : 0, 6720838

    section Manual
    This PR (4751) (8.391M)   : 0, 8390950
    master (8.333M)   : 0, 8333196
    benchmarks/2.38.0 (7.977M)   : 0, 7977494

    section Manual + Automatic
    This PR (4751) (6.467M)   : 0, 6466767
    master (6.445M)   : 0, 6444999
    benchmarks/2.38.0 (6.349M)   : 0, 6349066

    section Version Conflict
    This PR (4751) (5.928M)   : 0, 5927927
    master (5.843M)   : 0, 5843173
    benchmarks/2.38.0 (5.682M)   : 0, 5681654

gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    master (7.531M)   : 0, 7530734
    benchmarks/2.38.0 (7.578M)   : 0, 7577544
    benchmarks/2.9.0 (7.897M)   : 0, 7897465

    section No attack
    master (2.161M)   : 0, 2160878
    benchmarks/2.38.0 (2.184M)   : 0, 2184279
    benchmarks/2.9.0 (3.208M)   : 0, 3207532

    section Attack
    master (1.708M)   : 0, 1708423
    benchmarks/2.38.0 (1.711M)   : 0, 1710542
    benchmarks/2.9.0 (2.553M)   : 0, 2553477

    section Blocking
    master (3.431M)   : 0, 3430604
    benchmarks/2.38.0 (3.486M)   : 0, 3486124

    section IAST default
    master (6.887M)   : 0, 6887158

    section IAST full
    master (6.163M)   : 0, 6162549

    section Base vuln
    master (0.966M)   : 0, 966408

    section IAST vuln
    master (0.939M)   : 0, 939437

This was an abstraction over TelemetryDataV1 and TelemetryDataV2, so it's not needed now and just adds complexity

andrewlock added type:cleanup Minor code clean up area:telemetry labels Oct 23, 2023

andrewlock requested a review from a team as a code owner October 23, 2023 16:44

andrewlock mentioned this pull request Oct 23, 2023

Delete Telemetry V1 implementation #4750

Merged

kevingosse approved these changes Oct 23, 2023

View reviewed changes

andrewlock force-pushed the andrew/telemetry/delete-v1 branch from a8bce25 to eb2d3a9 Compare October 24, 2023 16:24

andrewlock requested a review from a team as a code owner October 24, 2023 16:24

andrewlock force-pushed the andrew/telemetry/delete-v1 branch from eb2d3a9 to 6564ceb Compare October 24, 2023 16:26

andrewlock force-pushed the andrew/telemetry/rename-v2-to-v1 branch from e0e6042 to 4b7989d Compare October 24, 2023 16:28

andrewlock changed the title ~~Rename TelemetryV2 to TelemetryV1~~ Rename TelemetryV2 to Telemetry Oct 25, 2023

lucaspimentel approved these changes Oct 25, 2023

View reviewed changes

andrewlock force-pushed the andrew/telemetry/rename-v2-to-v1 branch from 4b7989d to b248714 Compare October 26, 2023 10:07

andrewlock force-pushed the andrew/telemetry/delete-v1 branch from 6564ceb to 2f5e192 Compare October 26, 2023 10:07

andrewlock force-pushed the andrew/telemetry/rename-v2-to-v1 branch from b248714 to aebcb97 Compare October 26, 2023 12:25

andrewlock force-pushed the andrew/telemetry/delete-v1 branch 2 times, most recently from 8301fd3 to dee34cb Compare October 26, 2023 14:12

andrewlock force-pushed the andrew/telemetry/rename-v2-to-v1 branch from aebcb97 to 6e9e891 Compare October 26, 2023 14:12

andrewlock force-pushed the andrew/telemetry/delete-v1 branch from dee34cb to be4c119 Compare October 26, 2023 15:20

andrewlock force-pushed the andrew/telemetry/rename-v2-to-v1 branch from 6e9e891 to b49efc0 Compare October 26, 2023 15:20

andrewlock force-pushed the andrew/telemetry/delete-v1 branch from be4c119 to ac7bb9d Compare October 26, 2023 17:13

andrewlock force-pushed the andrew/telemetry/rename-v2-to-v1 branch from b49efc0 to 0c926d9 Compare October 26, 2023 17:13

andrewlock force-pushed the andrew/telemetry/delete-v1 branch from ac7bb9d to fef9ccb Compare October 27, 2023 08:18

andrewlock force-pushed the andrew/telemetry/rename-v2-to-v1 branch from 0c926d9 to 63d7b1b Compare October 27, 2023 08:18

andrewlock force-pushed the andrew/telemetry/delete-v1 branch from fef9ccb to 901a2c9 Compare October 27, 2023 09:55

andrewlock force-pushed the andrew/telemetry/rename-v2-to-v1 branch from 63d7b1b to 43a0a57 Compare October 27, 2023 09:55

Base automatically changed from andrew/telemetry/delete-v1 to master October 27, 2023 13:52

andrewlock added 3 commits October 27, 2023 14:58

Remove V2 suffixes from classes

774e689

Remove TelemetryWrapper in favour of TelemetryData

5a9b697

This was an abstraction over TelemetryDataV1 and TelemetryDataV2, so it's not needed now and just adds complexity

Remove unused ConfigTelemetryData keys

63ff23a

andrewlock force-pushed the andrew/telemetry/rename-v2-to-v1 branch from 43a0a57 to 63ff23a Compare October 27, 2023 13:58

andrewlock merged commit 274c384 into master Oct 30, 2023

andrewlock deleted the andrew/telemetry/rename-v2-to-v1 branch October 30, 2023 10:30

github-actions bot added this to the vNext milestone Oct 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename TelemetryV2 to Telemetry #4751

Rename TelemetryV2 to Telemetry #4751

andrewlock commented Oct 23, 2023

andrewlock commented Oct 23, 2023 •

edited

Loading

datadog-ddstaging bot commented Oct 23, 2023 •

edited

Loading

andrewlock commented Oct 23, 2023 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #4751

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #4751

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #4751

Faster 🎉 in #4751

Raw results

Faster 🎉 in #4751

Raw results

andrewlock commented Oct 24, 2023

Rename TelemetryV2 to Telemetry #4751

Rename TelemetryV2 to Telemetry #4751

Conversation

andrewlock commented Oct 23, 2023

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

andrewlock commented Oct 23, 2023 • edited Loading

Execution-Time Benchmarks Report ⏱️

datadog-ddstaging bot commented Oct 23, 2023 • edited Loading

Datadog Report

New Flaky Tests (1)

⌛ Performance Regressions vs Default Branch (1)

andrewlock commented Oct 23, 2023 • edited Loading

Benchmarks Report 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #4751

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #4751

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #4751

Faster 🎉 in #4751

Raw results

Faster 🎉 in #4751

Raw results

andrewlock commented Oct 24, 2023

Throughput/Crank Report:zap:

andrewlock commented Oct 23, 2023 •

edited

Loading

datadog-ddstaging bot commented Oct 23, 2023 •

edited

Loading

andrewlock commented Oct 23, 2023 •

edited

Loading