Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the version of GRPC tested by default (in Windows) #4542

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Bump the version of GRPC tested by default (in Windows) #4542

merged 1 commit into from
Aug 24, 2023

Conversation

andrewlock
Copy link
Member

Summary of changes

  • Bumps the version of GrpcDotNet tested on Windows (where we don't do multi-versions)

Reason for change

The version we were previously using has (known) bugs which can cause flaky tests

Implementation details

Bumped to the first known good version and updated the condition checks

Test coverage

Covered by existing

Other details

Saw this flake recently

@andrewlock andrewlock added the area:tests unit tests, integration tests label Aug 23, 2023
@andrewlock andrewlock requested a review from a team as a code owner August 23, 2023 14:48
@andrewlock andrewlock added the area:test-apps apps used to test integrations label Aug 23, 2023
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Aug 23, 2023 •
edited
Loading

Datadog Report

Branch report: andrew/ci/bump-grpc-version
Commit report: e46c7a9

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 298953 Passed, 1115 Skipped, 21m 52.99s Wall Time

@andrewlock
Copy link
Member Author

andrewlock commented Aug 23, 2023 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4542) - mean (77ms)  : 61, 93
     .   : milestone, 77,
    master - mean (69ms)  : 64, 74
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (4542) - mean (1,039ms)  : 1002, 1076
     .   : milestone, 1039,
    master - mean (1,033ms)  : 1004, 1062
     .   : milestone, 1033,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4542) - mean (105ms)  : 103, 108
     .   : milestone, 105,
    master - mean (105ms)  : 100, 111
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (4542) - mean (732ms)  : 702, 762
     .   : milestone, 732,
    master - mean (733ms)  : 700, 766
     .   : milestone, 733,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4542) - mean (90ms)  : 82, 97
     .   : milestone, 90,
    master - mean (90ms)  : 83, 97
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (4542) - mean (695ms)  : 669, 722
     .   : milestone, 695,
    master - mean (689ms)  : 666, 711
     .   : milestone, 689,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4542) - mean (190ms)  : 184, 196
     .   : milestone, 190,
    master - mean (188ms)  : 183, 193
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (4542) - mean (1,128ms)  : 1096, 1161
     .   : milestone, 1128,
    master - mean (1,127ms)  : 1087, 1168
     .   : milestone, 1127,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4542) - mean (270ms)  : 264, 277
     .   : milestone, 270,
    master - mean (271ms)  : 263, 278
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (4542) - mean (1,100ms)  : 1059, 1141
     .   : milestone, 1100,
    master - mean (1,077ms)  : 1049, 1105
     .   : milestone, 1077,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4542) - mean (261ms)  : 248, 275
     .   : milestone, 261,
    master - mean (257ms)  : 249, 266
     .   : milestone, 257,

    section CallTarget+Inlining+NGEN
    This PR (4542) - mean (1,035ms)  : 1003, 1066
     .   : milestone, 1035,
    master - mean (1,033ms)  : 994, 1072
     .   : milestone, 1033,
Loading

@andrewlock
Copy link
Member Author

Benchmarks Report 🐌

Benchmarks for #4542 compared to master:

  • 4 benchmarks are faster, with geometric mean 1.244
  • 1 benchmarks are slower, with geometric mean 1.256
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 481μs 610ns 2.11μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 640μs 123ns 478ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 794μs 462ns 1.79μs 0.396 0 0 3.3 KB
#4542 WriteAndFlushEnrichedTraces net6.0 472μs 111ns 430ns 0 0 0 2.7 KB
#4542 WriteAndFlushEnrichedTraces netcoreapp3.1 649μs 213ns 795ns 0 0 0 2.7 KB
#4542 WriteAndFlushEnrichedTraces net472 812μs 264ns 1.02μs 0.403 0 0 3.3 KB
Benchmarks.Trace.AppSecBodyBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4542

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑net6.0 1.429 171.32 119.89

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 39.5μs 27.6ns 103ns 0 0 0 1.69 KB
master AllCycleSimpleBody netcoreapp3.1 42.1μs 50.2ns 181ns 0.0207 0 0 1.67 KB
master AllCycleSimpleBody net472 43.8μs 13.4ns 50.1ns 0.258 0 0 1.73 KB
master AllCycleMoreComplexBody net6.0 231μs 204ns 790ns 0.116 0 0 9.26 KB
master AllCycleMoreComplexBody netcoreapp3.1 240μs 383ns 1.48μs 0.119 0 0 9.16 KB
master AllCycleMoreComplexBody net472 249μs 106ns 409ns 1.37 0 0 9.33 KB
master ObjectExtractorSimpleBody net6.0 171ns 0.0742ns 0.277ns 0.00395 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 176ns 0.0938ns 0.351ns 0.00373 0 0 272 B
master ObjectExtractorSimpleBody net472 146ns 0.338ns 1.22ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3.2μs 1.62ns 5.84ns 0.0543 0 0 3.88 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.1μs 1.9ns 7.1ns 0.0512 0 0 3.78 KB
master ObjectExtractorMoreComplexBody net472 4.13μs 4.11ns 15.9ns 0.617 0.00624 0 3.89 KB
#4542 AllCycleSimpleBody net6.0 39.6μs 60.4ns 226ns 0.0195 0 0 1.69 KB
#4542 AllCycleSimpleBody netcoreapp3.1 41.5μs 45.7ns 177ns 0.0208 0 0 1.67 KB
#4542 AllCycleSimpleBody net472 43.1μs 104ns 404ns 0.262 0 0 1.73 KB
#4542 AllCycleMoreComplexBody net6.0 232μs 66.5ns 257ns 0.116 0 0 9.26 KB
#4542 AllCycleMoreComplexBody netcoreapp3.1 241μs 189ns 731ns 0 0 0 9.16 KB
#4542 AllCycleMoreComplexBody net472 251μs 99.1ns 384ns 1.38 0 0 9.33 KB
#4542 ObjectExtractorSimpleBody net6.0 120ns 0.103ns 0.357ns 0.00392 0 0 280 B
#4542 ObjectExtractorSimpleBody netcoreapp3.1 176ns 0.108ns 0.402ns 0.00373 0 0 272 B
#4542 ObjectExtractorSimpleBody net472 148ns 0.16ns 0.62ns 0.0446 0 0 281 B
#4542 ObjectExtractorMoreComplexBody net6.0 3.14μs 1.21ns 4.54ns 0.0551 0 0 3.88 KB
#4542 ObjectExtractorMoreComplexBody netcoreapp3.1 3.99μs 2.13ns 8.23ns 0.0519 0 0 3.78 KB
#4542 ObjectExtractorMoreComplexBody net472 4.19μs 6.67ns 25.8ns 0.618 0.00627 0 3.89 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 168μs 146ns 565ns 0.251 0 0 18.08 KB
master SendRequest netcoreapp3.1 192μs 306ns 1.15μs 0.191 0 0 20.14 KB
master SendRequest net472 0.000947ns 0.000235ns 0.00088ns 0 0 0 0 b
#4542 SendRequest net6.0 171μs 255ns 987ns 0.254 0 0 18.08 KB
#4542 SendRequest netcoreapp3.1 188μs 239ns 896ns 0.187 0 0 20.14 KB
#4542 SendRequest net472 0.00126ns 0.000309ns 0.00111ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 533μs 218ns 815ns 0.519 0 0 41.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 633μs 1.6μs 6.2μs 0.317 0 0 41.63 KB
master WriteAndFlushEnrichedTraces net472 801μs 2.38μs 9.21μs 8.31 2.37 0.396 53.23 KB
#4542 WriteAndFlushEnrichedTraces net6.0 523μs 170ns 658ns 0.502 0 0 41.61 KB
#4542 WriteAndFlushEnrichedTraces netcoreapp3.1 629μs 533ns 2.06μs 0.309 0 0 41.71 KB
#4542 WriteAndFlushEnrichedTraces net472 804μs 2.45μs 9.5μs 8.41 2.4 0.401 53.24 KB
Benchmarks.Trace.DbCommandBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4542

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.153 1,150.56 997.93

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.15μs 0.36ns 1.4ns 0.0106 0 0 768 B
master ExecuteNonQuery netcoreapp3.1 1.43μs 0.615ns 2.38ns 0.01 0 0 768 B
master ExecuteNonQuery net472 1.64μs 0.576ns 2.23ns 0.116 0.000823 0 730 B
#4542 ExecuteNonQuery net6.0 998ns 0.3ns 1.16ns 0.0106 0 0 768 B
#4542 ExecuteNonQuery netcoreapp3.1 1.3μs 0.363ns 1.36ns 0.00984 0 0 768 B
#4542 ExecuteNonQuery net472 1.58μs 0.545ns 2.04ns 0.116 0.000792 0 730 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.19μs 0.547ns 1.97ns 0.0138 0 0 992 B
master CallElasticsearch netcoreapp3.1 1.44μs 0.461ns 1.72ns 0.013 0 0 992 B
master CallElasticsearch net472 2.26μs 0.519ns 1.94ns 0.159 0.00113 0 1 KB
master CallElasticsearchAsync net6.0 1.28μs 0.917ns 3.55ns 0.0134 0 0 968 B
master CallElasticsearchAsync netcoreapp3.1 1.57μs 0.895ns 3.47ns 0.0142 0 0 1.04 KB
master CallElasticsearchAsync net472 2.58μs 0.914ns 3.42ns 0.168 0.00129 0 1.06 KB
#4542 CallElasticsearch net6.0 1.09μs 0.499ns 1.87ns 0.0137 0 0 992 B
#4542 CallElasticsearch netcoreapp3.1 1.45μs 1.15ns 4.29ns 0.013 0 0 992 B
#4542 CallElasticsearch net472 2.37μs 0.731ns 2.83ns 0.158 0 0 1 KB
#4542 CallElasticsearchAsync net6.0 1.2μs 0.418ns 1.56ns 0.0138 0 0 968 B
#4542 CallElasticsearchAsync netcoreapp3.1 1.6μs 1.14ns 4.4ns 0.0144 0 0 1.04 KB
#4542 CallElasticsearchAsync net472 2.45μs 0.563ns 2.18ns 0.167 0 0 1.06 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.24μs 0.606ns 2.35ns 0.0129 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.49μs 3.26ns 12.6ns 0.0118 0 0 912 B
master ExecuteAsync net472 1.72μs 1.8ns 6.98ns 0.138 0.000849 0 875 B
#4542 ExecuteAsync net6.0 1.16μs 0.884ns 3.42ns 0.0128 0 0 912 B
#4542 ExecuteAsync netcoreapp3.1 1.55μs 0.617ns 2.39ns 0.0123 0 0 912 B
#4542 ExecuteAsync net472 1.75μs 0.903ns 3.38ns 0.139 0.000863 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.01μs 1.58ns 5.71ns 0.026 0 0 1.94 KB
master SendAsync netcoreapp3.1 4.54μs 1.34ns 5.02ns 0.0333 0 0 2.48 KB
master SendAsync net472 7.05μs 2.6ns 10.1ns 0.483 0 0 3.05 KB
#4542 SendAsync net6.0 3.83μs 1.91ns 7.39ns 0.0267 0 0 1.94 KB
#4542 SendAsync netcoreapp3.1 4.64μs 1.8ns 6.74ns 0.0325 0 0 2.48 KB
#4542 SendAsync net472 7.07μs 2.05ns 7.94ns 0.484 0 0 3.05 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.37μs 0.536ns 2.01ns 0.0226 0 0 1.62 KB
master EnrichedLog netcoreapp3.1 2.01μs 0.929ns 3.48ns 0.0221 0 0 1.62 KB
master EnrichedLog net472 2.35μs 1.25ns 4.84ns 0.245 0 0 1.54 KB
#4542 EnrichedLog net6.0 1.46μs 0.492ns 1.84ns 0.0227 0 0 1.62 KB
#4542 EnrichedLog netcoreapp3.1 1.87μs 1.32ns 4.93ns 0.0223 0 0 1.62 KB
#4542 EnrichedLog net472 2.29μs 1.58ns 5.9ns 0.244 0 0 1.54 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 114μs 147ns 570ns 0.0564 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 120μs 283ns 1.1μs 0 0 0 4.21 KB
master EnrichedLog net472 148μs 172ns 666ns 0.665 0.222 0 4.38 KB
#4542 EnrichedLog net6.0 114μs 258ns 1E+03ns 0.0566 0 0 4.21 KB
#4542 EnrichedLog netcoreapp3.1 120μs 148ns 573ns 0.0599 0 0 4.21 KB
#4542 EnrichedLog net472 148μs 159ns 596ns 0.658 0.219 0 4.38 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.92μs 1.09ns 4.21ns 0.0306 0 0 2.18 KB
master EnrichedLog netcoreapp3.1 4.03μs 1.44ns 5.4ns 0.0282 0 0 2.18 KB
master EnrichedLog net472 4.58μs 1.01ns 3.9ns 0.315 0 0 1.99 KB
#4542 EnrichedLog net6.0 2.83μs 0.526ns 1.97ns 0.0298 0 0 2.18 KB
#4542 EnrichedLog netcoreapp3.1 4.06μs 1.98ns 7.66ns 0.0304 0 0 2.18 KB
#4542 EnrichedLog net472 4.64μs 1.01ns 3.93ns 0.316 0 0 1.99 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.39μs 0.427ns 1.65ns 0.0161 0 0 1.16 KB
master SendReceive netcoreapp3.1 1.57μs 0.573ns 2.15ns 0.0158 0 0 1.16 KB
master SendReceive net472 2.14μs 0.806ns 2.91ns 0.184 0 0 1.16 KB
#4542 SendReceive net6.0 1.35μs 1.55ns 5.8ns 0.0163 0 0 1.16 KB
#4542 SendReceive netcoreapp3.1 1.66μs 0.795ns 3.08ns 0.0158 0 0 1.16 KB
#4542 SendReceive net472 2.02μs 1.1ns 4.13ns 0.185 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.61μs 0.967ns 3.74ns 0.0209 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.65μs 2.42ns 9.36ns 0.02 0 0 1.58 KB
master EnrichedLog net472 4.09μs 2.37ns 9.19ns 0.311 0 0 1.96 KB
#4542 EnrichedLog net6.0 2.59μs 0.493ns 1.91ns 0.0207 0 0 1.53 KB
#4542 EnrichedLog netcoreapp3.1 3.58μs 3.17ns 12.3ns 0.0215 0 0 1.58 KB
#4542 EnrichedLog net472 4.04μs 1.45ns 5.63ns 0.311 0 0 1.96 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4542

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.256 522.48 656.01

Faster 🎉 in #4542

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.196 727.60 608.58

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 447ns 0.152ns 0.568ns 0.00741 0 0 536 B
master StartFinishSpan netcoreapp3.1 548ns 0.276ns 1.07ns 0.00712 0 0 536 B
master StartFinishSpan net472 727ns 0.274ns 1.02ns 0.0851 0 0 538 B
master StartFinishScope net6.0 523ns 0.383ns 1.43ns 0.00921 0 0 656 B
master StartFinishScope netcoreapp3.1 746ns 0.195ns 0.755ns 0.00877 0 0 656 B
master StartFinishScope net472 885ns 0.627ns 2.35ns 0.0978 0 0 618 B
#4542 StartFinishSpan net6.0 451ns 0.131ns 0.49ns 0.0074 0 0 536 B
#4542 StartFinishSpan netcoreapp3.1 536ns 0.357ns 1.34ns 0.00724 0 0 536 B
#4542 StartFinishSpan net472 609ns 0.0951ns 0.368ns 0.0852 0 0 538 B
#4542 StartFinishScope net6.0 656ns 0.134ns 0.482ns 0.00921 0 0 656 B
#4542 StartFinishScope netcoreapp3.1 731ns 0.291ns 1.09ns 0.00887 0 0 656 B
#4542 StartFinishScope net472 844ns 0.631ns 2.36ns 0.0978 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4542

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.217 615.41 505.59

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 616ns 0.299ns 1.04ns 0.00913 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 750ns 2.4ns 9.3ns 0.00898 0 0 656 B
master RunOnMethodBegin net472 1.04μs 0.479ns 1.73ns 0.0981 0 0 618 B
#4542 RunOnMethodBegin net6.0 506ns 0.134ns 0.5ns 0.0093 0 0 656 B
#4542 RunOnMethodBegin netcoreapp3.1 815ns 0.515ns 1.99ns 0.00898 0 0 656 B
#4542 RunOnMethodBegin net472 1.01μs 0.611ns 2.29ns 0.098 0 0 618 B

@andrewlock
Copy link
Member Author

andrewlock commented Aug 23, 2023 •
edited
Loading

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4542) (11.261M)   : 0, 11260827
    master (11.644M)   : 0, 11644043
    benchmarks/2.36.0 (11.752M)   : 0, 11752454
    benchmarks/2.9.0 (11.752M)   : 0, 11752427

    section Automatic
    This PR (4542) (7.873M)   : crit ,0, 7873285
    master (8.291M)   : 0, 8291142
    benchmarks/2.36.0 (8.280M)   : 0, 8280416
    benchmarks/2.9.0 (8.494M)   : 0, 8494490

    section Trace stats
    master (8.262M)   : 0, 8262399
    benchmarks/2.36.0 (8.148M)   : 0, 8147852

    section Manual
    This PR (4542) (10.015M)   : 0, 10015235
    master (10.527M)   : 0, 10527241
    benchmarks/2.36.0 (10.336M)   : 0, 10335525

    section Manual + Automatic
    This PR (4542) (7.623M)   : 0, 7622767
    master (7.944M)   : 0, 7944369
    benchmarks/2.36.0 (7.907M)   : 0, 7907307

    section Version Conflict
    master (7.251M)   : 0, 7250761
    benchmarks/2.36.0 (7.084M)   : 0, 7084420
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4542) (9.386M)   : 0, 9386087
    master (9.600M)   : 0, 9599884
    benchmarks/2.36.0 (9.582M)   : 0, 9582169
    benchmarks/2.9.0 (9.455M)   : 0, 9455151

    section Automatic
    This PR (4542) (6.699M)   : 0, 6698519
    master (6.795M)   : 0, 6794541
    benchmarks/2.36.0 (6.775M)   : 0, 6775278

    section Trace stats
    master (6.671M)   : 0, 6671385
    benchmarks/2.36.0 (6.725M)   : 0, 6725030

    section Manual
    This PR (4542) (8.509M)   : 0, 8509070
    master (8.468M)   : 0, 8467833
    benchmarks/2.36.0 (8.664M)   : 0, 8663817

    section Manual + Automatic
    This PR (4542) (6.477M)   : 0, 6476596
    master (6.192M)   : 0, 6191835
    benchmarks/2.36.0 (6.670M)   : 0, 6669993

    section Version Conflict
    master (5.780M)   : 0, 5780026
    benchmarks/2.36.0 (5.931M)   : 0, 5931025
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4542) (10.223M)   : 0, 10223481
    master (10.358M)   : 0, 10357887
    benchmarks/2.36.0 (10.209M)   : 0, 10209016
    benchmarks/2.9.0 (10.103M)   : 0, 10102653

    section Automatic
    This PR (4542) (7.516M)   : 0, 7515768
    master (7.273M)   : 0, 7273411
    benchmarks/2.36.0 (7.281M)   : 0, 7280896
    benchmarks/2.9.0 (7.341M)   : 0, 7340763

    section Trace stats
    master (7.316M)   : 0, 7316175
    benchmarks/2.36.0 (7.267M)   : 0, 7267042

    section Manual
    This PR (4542) (9.196M)   : 0, 9196342
    master (9.235M)   : 0, 9234639
    benchmarks/2.36.0 (9.078M)   : 0, 9077794

    section Manual + Automatic
    This PR (4542) (7.327M)   : 0, 7327272
    master (7.227M)   : 0, 7227130
    benchmarks/2.36.0 (7.075M)   : 0, 7075480

    section Version Conflict
    master (6.644M)   : 0, 6643598
    benchmarks/2.36.0 (6.479M)   : 0, 6478676
Loading 
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4542) (7.384M)   : 0, 7384345
    master (7.438M)   : 0, 7437662
    benchmarks/2.36.0 (7.453M)   : 0, 7453304
    benchmarks/2.9.0 (7.826M)   : 0, 7825811

    section No attack
    This PR (4542) (2.101M)   : 0, 2101061
    master (2.151M)   : 0, 2150930
    benchmarks/2.36.0 (2.136M)   : 0, 2136014
    benchmarks/2.9.0 (3.260M)   : 0, 3260143

    section Attack
    This PR (4542) (1.663M)   : 0, 1663254
    master (1.670M)   : 0, 1669947
    benchmarks/2.36.0 (1.687M)   : 0, 1687301
    benchmarks/2.9.0 (2.532M)   : 0, 2532213

    section Blocking
    This PR (4542) (3.096M)   : 0, 3095615
    master (3.105M)   : 0, 3105259
    benchmarks/2.36.0 (3.104M)   : 0, 3103809
Loading

@andrewlock
Bump the version of GRPC tested by default (in Windows)
e46c7a9 
The earlier version has (known) bugs which can cause flaky tests
@andrewlock andrewlock force-pushed the andrew/ci/bump-grpc-version branch from 07accd4 to e46c7a9 Compare August 24, 2023 10:58
@andrewlock andrewlock merged commit f6a9428 into master Aug 24, 2023
@andrewlock andrewlock deleted the andrew/ci/bump-grpc-version branch August 24, 2023 15:56
@github-actions github-actions bot added this to the vNext milestone Aug 24, 2023
NachoEchevarria pushed a commit that referenced this pull request Aug 29, 2023
@andrewlock @NachoEchevarria
Bump the version of GRPC tested by default (in Windows) (#4542)
c58e305 
The earlier version has (known) bugs which can cause flaky tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouwkast bouwkast bouwkast approved these changes

@lucaspimentel lucaspimentel lucaspimentel approved these changes

Assignees
No one assigned
Labels
area:test-apps apps used to test integrations area:tests unit tests, integration tests
Projects
None yet
Milestone
2.37.0
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewlock @lucaspimentel @bouwkast