Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create_draft_release when not specifying a specific commit #4446

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

andrewlock
Copy link
Member

Summary of changes

Add step to calculate sha to use in create_draft_release GH Action

Reason for change

The existing script assumes you will always force a specific commit, but that's not required

Implementation details

Added a small bash script to choose whether to use the "default" sha or the forced one, and reuse the output throughout the script

Test coverage

Did some (safe) test runs to confirm the correct value is used when doing forced version (here) and non-forced version (here)

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Jul 26, 2023
@andrewlock andrewlock requested a review from a team as a code owner July 26, 2023 09:42
Copy link
Collaborator

@pierotibou pierotibou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks.
As discussed offline, I think we should remove this from the critical path of the release and do it a posteriori, with a release trigger. We can discuss with R&P if needed

@andrewlock andrewlock force-pushed the andrew/ci/fix-create-release branch from f1c6c30 to a5094f5 Compare July 26, 2023 12:21
@andrewlock andrewlock merged commit 6f6d97b into master Jul 27, 2023
@andrewlock andrewlock deleted the andrew/ci/fix-create-release branch July 27, 2023 12:59
@github-actions github-actions bot added this to the vNext milestone Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants