Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aspect definition order once and for all #4438

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

andrewlock
Copy link
Member

Summary of changes

  • Fixes the aspect generator order so it stops changing

Reason for change

It keeps changing. Note the confidence in this PR title. It definitely isn't unfounded. Nothing can possibly go wrong this time

Implementation details

Use StringComparer.Ordinal

Test coverage

This is the test

Other details

Nice blog about sorting: https://blog.jetbrains.com/dotnet/2020/05/13/sorting-order-depends-runtime-operating-system/

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Jul 24, 2023
@andrewlock andrewlock requested a review from a team as a code owner July 24, 2023 13:27
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jul 24, 2023

Datadog Report

Branch report: andrew/ci/fix-aspects-sorting
Commit report: 2550cf6

dd-trace-dotnet: 0 Failed, 0 New Flaky, 295946 Passed, 1091 Skipped, 31m 23.9s Wall Time

Copy link
Contributor

@daniel-romano-DD daniel-romano-DD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@andrewlock
Copy link
Member Author

andrewlock commented Jul 24, 2023

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4438) - mean (3,009ms)  : 2947, 3072
     .   : milestone, 3009,
    master - mean (3,000ms)  : 2918, 3082
     .   : milestone, 3000,

    section CallTarget+Inlining+NGEN
    This PR (4438) - mean (3,813ms)  : 3750, 3876
     .   : milestone, 3813,
    master - mean (3,820ms)  : 3748, 3891
     .   : milestone, 3820,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4438) - mean (3,130ms)  : 3051, 3210
     .   : milestone, 3130,
    master - mean (3,122ms)  : 2995, 3250
     .   : milestone, 3122,

    section CallTarget+Inlining+NGEN
    This PR (4438) - mean (3,605ms)  : 3538, 3672
     .   : milestone, 3605,
    master - mean (3,597ms)  : 3540, 3653
     .   : milestone, 3597,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4438) - mean (3,098ms)  : 3023, 3173
     .   : milestone, 3098,
    master - mean (3,113ms)  : 3042, 3184
     .   : milestone, 3113,

    section CallTarget+Inlining+NGEN
    This PR (4438) - mean (3,579ms)  : 3518, 3639
     .   : milestone, 3579,
    master - mean (3,571ms)  : 3507, 3635
     .   : milestone, 3571,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4438) - mean (191ms)  : 188, 195
     .   : milestone, 191,
    master - mean (192ms)  : 186, 197
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (4438) - mean (1,119ms)  : 1094, 1144
     .   : milestone, 1119,
    master - mean (1,111ms)  : 1080, 1142
     .   : milestone, 1111,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4438) - mean (374ms)  : 369, 378
     .   : milestone, 374,
    master - mean (372ms)  : 364, 380
     .   : milestone, 372,

    section CallTarget+Inlining+NGEN
    This PR (4438) - mean (1,174ms)  : 1142, 1206
     .   : milestone, 1174,
    master - mean (1,176ms)  : 1148, 1203
     .   : milestone, 1176,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4438) - mean (362ms)  : 356, 368
     .   : milestone, 362,
    master - mean (361ms)  : 356, 367
     .   : milestone, 361,

    section CallTarget+Inlining+NGEN
    This PR (4438) - mean (1,128ms)  : 1105, 1152
     .   : milestone, 1128,
    master - mean (1,129ms)  : 1091, 1166
     .   : milestone, 1129,

Loading

@andrewlock
Copy link
Member Author

andrewlock commented Jul 24, 2023

Benchmarks Report 🐌

Benchmarks for #4438 compared to master:

  • 4 benchmarks are faster, with geometric mean 1.152
  • 2 benchmarks are slower, with geometric mean 1.152
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 496μs 91.5ns 342ns 0 0 0 2.62 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 627μs 291ns 1.09μs 0 0 0 2.63 KB
master WriteAndFlushEnrichedTraces net472 801μs 343ns 1.28μs 0.398 0 0 3.22 KB
#4438 WriteAndFlushEnrichedTraces net6.0 498μs 221ns 827ns 0 0 0 2.62 KB
#4438 WriteAndFlushEnrichedTraces netcoreapp3.1 635μs 171ns 662ns 0 0 0 2.63 KB
#4438 WriteAndFlushEnrichedTraces net472 808μs 249ns 933ns 0.403 0 0 3.22 KB
Benchmarks.Trace.AppSecBodyBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4438

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑net6.0 1.143 125.24 143.18

Faster 🎉 in #4438

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody‑net472 1.159 4,696.33 4,051.87
Benchmarks.Trace.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 1.137 272,476.95 239,675.95

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 39μs 57ns 221ns 0.0196 0 0 1.65 KB
master AllCycleSimpleBody netcoreapp3.1 40.7μs 70.2ns 263ns 0.0203 0 0 1.63 KB
master AllCycleSimpleBody net472 41.6μs 12.2ns 45.6ns 0.248 0 0 1.69 KB
master AllCycleMoreComplexBody net6.0 224μs 92.4ns 346ns 0.111 0 0 9.22 KB
master AllCycleMoreComplexBody netcoreapp3.1 231μs 93.2ns 336ns 0.116 0 0 9.12 KB
master AllCycleMoreComplexBody net472 272μs 87.1ns 326ns 1.44 0 0 9.28 KB
master ObjectExtractorSimpleBody net6.0 125ns 0.05ns 0.194ns 0.00393 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 172ns 0.0661ns 0.247ns 0.00372 0 0 272 B
master ObjectExtractorSimpleBody net472 147ns 0.0772ns 0.289ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 2.97μs 1.33ns 4.99ns 0.055 0 0 3.88 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.06μs 1.45ns 5.44ns 0.0507 0 0 3.78 KB
master ObjectExtractorMoreComplexBody net472 4.68μs 15.9ns 61.7ns 0.617 0.00701 0 3.89 KB
#4438 AllCycleSimpleBody net6.0 38.4μs 15.8ns 61.2ns 0.0196 0 0 1.65 KB
#4438 AllCycleSimpleBody netcoreapp3.1 41.5μs 37.2ns 139ns 0.0204 0 0 1.63 KB
#4438 AllCycleSimpleBody net472 42.5μs 142ns 552ns 0.249 0 0 1.69 KB
#4438 AllCycleMoreComplexBody net6.0 221μs 89.5ns 335ns 0.111 0 0 9.22 KB
#4438 AllCycleMoreComplexBody netcoreapp3.1 230μs 232ns 868ns 0.114 0 0 9.12 KB
#4438 AllCycleMoreComplexBody net472 240μs 78.8ns 295ns 1.44 0 0 9.28 KB
#4438 ObjectExtractorSimpleBody net6.0 143ns 0.0344ns 0.129ns 0.00394 0 0 280 B
#4438 ObjectExtractorSimpleBody netcoreapp3.1 173ns 0.138ns 0.533ns 0.00375 0 0 272 B
#4438 ObjectExtractorSimpleBody net472 148ns 0.128ns 0.495ns 0.0446 0 0 281 B
#4438 ObjectExtractorMoreComplexBody net6.0 3.15μs 1.27ns 4.76ns 0.0547 0 0 3.88 KB
#4438 ObjectExtractorMoreComplexBody netcoreapp3.1 4.06μs 1.56ns 6.03ns 0.0508 0 0 3.78 KB
#4438 ObjectExtractorMoreComplexBody net472 4.05μs 1.57ns 5.65ns 0.617 0.00605 0 3.89 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 164μs 150ns 582ns 0.163 0 0 17.66 KB
master SendRequest netcoreapp3.1 184μs 494ns 1.91μs 0.182 0 0 19.65 KB
master SendRequest net472 0.00103ns 0.000327ns 0.00126ns 0 0 0 0 b
#4438 SendRequest net6.0 165μs 151ns 585ns 0.165 0 0 17.66 KB
#4438 SendRequest netcoreapp3.1 183μs 128ns 480ns 0.184 0 0 19.65 KB
#4438 SendRequest net472 0.000287ns 0.000132ns 0.000476ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 526μs 447ns 1.55μs 0.521 0 0 41.63 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 616μs 647ns 2.42μs 0.309 0 0 41.96 KB
master WriteAndFlushEnrichedTraces net472 804μs 2.25μs 8.4μs 8.36 2.39 0.398 53.22 KB
#4438 WriteAndFlushEnrichedTraces net6.0 516μs 1.45μs 5.63μs 0.502 0 0 41.84 KB
#4438 WriteAndFlushEnrichedTraces netcoreapp3.1 627μs 654ns 2.53μs 0.309 0 0 41.78 KB
#4438 WriteAndFlushEnrichedTraces net472 793μs 2.12μs 8.22μs 8.25 2.36 0.393 53.22 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 887ns 0.416ns 1.56ns 0.0106 0 0 768 B
master ExecuteNonQuery netcoreapp3.1 1.15μs 0.485ns 1.88ns 0.0104 0 0 768 B
master ExecuteNonQuery net472 1.52μs 0.57ns 2.21ns 0.116 0 0 730 B
#4438 ExecuteNonQuery net6.0 922ns 0.648ns 2.51ns 0.0105 0 0 768 B
#4438 ExecuteNonQuery netcoreapp3.1 1.17μs 0.658ns 2.55ns 0.0105 0 0 768 B
#4438 ExecuteNonQuery net472 1.48μs 0.787ns 3.05ns 0.115 0 0 730 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.1μs 0.332ns 1.24ns 0.0138 0 0 992 B
master CallElasticsearch netcoreapp3.1 1.28μs 0.33ns 1.19ns 0.0134 0 0 992 B
master CallElasticsearch net472 2.17μs 1.47ns 5.69ns 0.159 0.00109 0 1 KB
master CallElasticsearchAsync net6.0 1.17μs 0.626ns 2.34ns 0.0133 0 0 968 B
master CallElasticsearchAsync netcoreapp3.1 1.48μs 0.294ns 1.1ns 0.0141 0 0 1.04 KB
master CallElasticsearchAsync net472 2.26μs 1.76ns 6.6ns 0.168 0.00113 0 1.06 KB
#4438 CallElasticsearch net6.0 1.09μs 0.411ns 1.59ns 0.0138 0 0 992 B
#4438 CallElasticsearch netcoreapp3.1 1.38μs 0.368ns 1.38ns 0.0139 0 0 992 B
#4438 CallElasticsearch net472 2.01μs 0.361ns 1.35ns 0.159 0 0 1 KB
#4438 CallElasticsearchAsync net6.0 1.06μs 0.369ns 1.43ns 0.0138 0 0 968 B
#4438 CallElasticsearchAsync netcoreapp3.1 1.38μs 1.19ns 4.59ns 0.0145 0 0 1.04 KB
#4438 CallElasticsearchAsync net472 2.28μs 0.51ns 1.91ns 0.168 0.00114 0 1.06 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.19μs 0.733ns 2.84ns 0.0129 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.32μs 0.461ns 1.66ns 0.0119 0 0 912 B
master ExecuteAsync net472 1.58μs 3.11ns 12.1ns 0.139 0.00077 0 875 B
#4438 ExecuteAsync net6.0 1.09μs 0.172ns 0.622ns 0.0126 0 0 912 B
#4438 ExecuteAsync netcoreapp3.1 1.38μs 0.388ns 1.45ns 0.0118 0 0 912 B
#4438 ExecuteAsync net472 1.53μs 0.533ns 1.99ns 0.139 0.000768 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 2.8μs 1.05ns 3.93ns 0.021 0 0 1.53 KB
master SendAsync netcoreapp3.1 3.52μs 1.56ns 5.85ns 0.0264 0 0 1.99 KB
master SendAsync net472 5.36μs 7.09ns 24.6ns 0.346 0 0 2.18 KB
#4438 SendAsync net6.0 2.83μs 1.04ns 4.03ns 0.0212 0 0 1.53 KB
#4438 SendAsync netcoreapp3.1 3.41μs 3.87ns 15ns 0.0272 0 0 1.99 KB
#4438 SendAsync net472 5.42μs 1.99ns 7.71ns 0.346 0 0 2.18 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.31μs 0.666ns 2.58ns 0.023 0 0 1.62 KB
master EnrichedLog netcoreapp3.1 1.71μs 0.737ns 2.86ns 0.0222 0 0 1.62 KB
master EnrichedLog net472 2.26μs 1.02ns 3.96ns 0.245 0 0 1.54 KB
#4438 EnrichedLog net6.0 1.28μs 0.465ns 1.8ns 0.0227 0 0 1.62 KB
#4438 EnrichedLog netcoreapp3.1 1.8μs 0.926ns 3.47ns 0.0216 0 0 1.62 KB
#4438 EnrichedLog net472 2.21μs 1.29ns 4.83ns 0.244 0 0 1.54 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 112μs 114ns 441ns 0.0562 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 116μs 134ns 520ns 0 0 0 4.21 KB
master EnrichedLog net472 147μs 165ns 639ns 0.66 0.22 0 4.38 KB
#4438 EnrichedLog net6.0 112μs 83.7ns 313ns 0.0557 0 0 4.21 KB
#4438 EnrichedLog netcoreapp3.1 118μs 140ns 541ns 0 0 0 4.21 KB
#4438 EnrichedLog net472 147μs 149ns 578ns 0.661 0.22 0 4.38 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.76μs 0.936ns 3.5ns 0.0304 0 0 2.18 KB
master EnrichedLog netcoreapp3.1 3.75μs 1.88ns 7.03ns 0.0282 0 0 2.18 KB
master EnrichedLog net472 4.51μs 2.96ns 11.4ns 0.315 0 0 1.99 KB
#4438 EnrichedLog net6.0 2.9μs 1.14ns 4.26ns 0.0303 0 0 2.18 KB
#4438 EnrichedLog netcoreapp3.1 3.73μs 1.55ns 5.81ns 0.0279 0 0 2.18 KB
#4438 EnrichedLog net472 4.5μs 2.99ns 11.6ns 0.316 0 0 1.99 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.21μs 0.628ns 2.26ns 0.0162 0 0 1.16 KB
master SendReceive netcoreapp3.1 1.49μs 0.828ns 3.1ns 0.0155 0 0 1.16 KB
master SendReceive net472 1.74μs 1.83ns 6.84ns 0.185 0.000876 0 1.16 KB
#4438 SendReceive net6.0 1.15μs 0.513ns 1.92ns 0.0162 0 0 1.16 KB
#4438 SendReceive netcoreapp3.1 1.53μs 0.583ns 2.1ns 0.0159 0 0 1.16 KB
#4438 SendReceive net472 1.86μs 0.652ns 2.35ns 0.185 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.58μs 0.951ns 3.56ns 0.0206 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.48μs 4.13ns 16ns 0.0209 0 0 1.58 KB
master EnrichedLog net472 3.97μs 1.46ns 5.26ns 0.309 0 0 1.96 KB
#4438 EnrichedLog net6.0 2.47μs 0.946ns 3.54ns 0.0211 0 0 1.53 KB
#4438 EnrichedLog netcoreapp3.1 3.58μs 0.668ns 2.41ns 0.0197 0 0 1.58 KB
#4438 EnrichedLog net472 3.92μs 1.31ns 4.9ns 0.31 0 0 1.96 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4438

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.161 579.53 672.89

Faster 🎉 in #4438

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.117 560.03 501.23

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 408ns 0.112ns 0.434ns 0.00749 0 0 536 B
master StartFinishSpan netcoreapp3.1 560ns 0.326ns 1.22ns 0.00719 0 0 536 B
master StartFinishSpan net472 600ns 0.114ns 0.412ns 0.0853 0 0 538 B
master StartFinishScope net6.0 452ns 0.193ns 0.746ns 0.00928 0 0 656 B
master StartFinishScope netcoreapp3.1 580ns 0.209ns 0.783ns 0.00905 0 0 656 B
master StartFinishScope net472 759ns 0.714ns 2.76ns 0.0981 0 0 618 B
#4438 StartFinishSpan net6.0 380ns 0.121ns 0.454ns 0.00752 0 0 536 B
#4438 StartFinishSpan netcoreapp3.1 501ns 0.15ns 0.56ns 0.00734 0 0 536 B
#4438 StartFinishSpan net472 664ns 0.246ns 0.919ns 0.0853 0 0 538 B
#4438 StartFinishScope net6.0 500ns 0.12ns 0.45ns 0.00906 0 0 656 B
#4438 StartFinishScope netcoreapp3.1 673ns 0.486ns 1.82ns 0.00889 0 0 656 B
#4438 StartFinishScope net472 820ns 0.291ns 1.09ns 0.0979 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4438

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.196 585.71 489.58

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 586ns 0.27ns 1.05ns 0.00932 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 773ns 0.314ns 1.18ns 0.00881 0 0 656 B
master RunOnMethodBegin net472 945ns 0.273ns 1.06ns 0.0978 0 0 618 B
#4438 RunOnMethodBegin net6.0 490ns 0.154ns 0.576ns 0.00912 0 0 656 B
#4438 RunOnMethodBegin netcoreapp3.1 851ns 0.521ns 1.95ns 0.00885 0 0 656 B
#4438 RunOnMethodBegin net472 925ns 1.04ns 3.75ns 0.0982 0 0 618 B

@andrewlock
Copy link
Member Author

andrewlock commented Jul 24, 2023

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4438) (11.364M)   : 0, 11364389
    master (11.092M)   : 0, 11092303
    benchmarks/2.33.0 (11.157M)   : 0, 11156685
    benchmarks/2.9.0 (11.180M)   : 0, 11180316

    section Automatic
    This PR (4438) (8.019M)   : 0, 8018837
    master (7.899M)   : 0, 7898506
    benchmarks/2.33.0 (7.759M)   : 0, 7758975
    benchmarks/2.9.0 (8.118M)   : 0, 8117702

    section Trace stats
    master (7.845M)   : 0, 7845210
    benchmarks/2.33.0 (7.761M)   : 0, 7760502

    section Manual
    This PR (4438) (10.202M)   : 0, 10202447
    master (9.915M)   : 0, 9915280
    benchmarks/2.33.0 (9.991M)   : 0, 9991023

    section Manual + Automatic
    This PR (4438) (7.568M)   : 0, 7568028
    master (7.485M)   : 0, 7485418
    benchmarks/2.33.0 (7.517M)   : 0, 7517119

    section Version Conflict
    master (6.719M)   : 0, 6719301
    benchmarks/2.33.0 (6.674M)   : 0, 6674489

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4438) (9.602M)   : 0, 9602402
    master (9.583M)   : 0, 9583491
    benchmarks/2.33.0 (9.547M)   : 0, 9547169
    benchmarks/2.9.0 (9.753M)   : 0, 9753052

    section Automatic
    This PR (4438) (6.741M)   : 0, 6741297
    master (6.849M)   : 0, 6849176
    benchmarks/2.33.0 (6.748M)   : 0, 6748132

    section Trace stats
    master (6.788M)   : 0, 6788291
    benchmarks/2.33.0 (6.679M)   : 0, 6678668

    section Manual
    This PR (4438) (8.448M)   : 0, 8447932
    master (8.521M)   : 0, 8521266
    benchmarks/2.33.0 (8.513M)   : 0, 8513138

    section Manual + Automatic
    This PR (4438) (6.481M)   : 0, 6480894
    master (6.554M)   : 0, 6553554
    benchmarks/2.33.0 (6.511M)   : 0, 6510702

    section Version Conflict
    master (5.803M)   : 0, 5803157
    benchmarks/2.33.0 (5.790M)   : 0, 5789875

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4438) (10.492M)   : 0, 10491509
    master (10.149M)   : 0, 10148953
    benchmarks/2.33.0 (10.242M)   : 0, 10241972
    benchmarks/2.9.0 (10.172M)   : 0, 10171958

    section Automatic
    This PR (4438) (7.370M)   : 0, 7369817
    master (7.402M)   : 0, 7402113
    benchmarks/2.33.0 (7.374M)   : 0, 7373893
    benchmarks/2.9.0 (7.504M)   : 0, 7503872

    section Trace stats
    master (7.511M)   : 0, 7511033
    benchmarks/2.33.0 (7.277M)   : 0, 7277270

    section Manual
    This PR (4438) (9.168M)   : 0, 9168457
    master (9.484M)   : 0, 9483677
    benchmarks/2.33.0 (9.163M)   : 0, 9163360

    section Manual + Automatic
    This PR (4438) (7.270M)   : 0, 7270247
    master (7.450M)   : 0, 7450224
    benchmarks/2.33.0 (7.173M)   : 0, 7172915

    section Version Conflict
    master (6.750M)   : 0, 6750044
    benchmarks/2.33.0 (6.599M)   : 0, 6598779

Loading
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4438) (7.756M)   : 0, 7756458
    master (7.453M)   : 0, 7452692
    benchmarks/2.33.0 (7.689M)   : 0, 7688992
    benchmarks/2.9.0 (8.035M)   : 0, 8035249

    section No attack
    This PR (4438) (2.218M)   : 0, 2218056
    master (2.218M)   : 0, 2217932
    benchmarks/2.33.0 (2.211M)   : 0, 2210506
    benchmarks/2.9.0 (3.332M)   : 0, 3332227

    section Attack
    This PR (4438) (1.903M)   : 0, 1903339
    master (1.898M)   : 0, 1898175
    benchmarks/2.33.0 (1.908M)   : 0, 1908362
    benchmarks/2.9.0 (2.634M)   : 0, 2634464

    section Blocking
    This PR (4438) (3.868M)   : 0, 3868457
    master (3.789M)   : 0, 3788832
    benchmarks/2.33.0 (3.840M)   : 0, 3839512

Loading

@andrewlock andrewlock requested a review from a team as a code owner July 24, 2023 15:57
@andrewlock andrewlock merged commit 7146e0d into master Jul 25, 2023
@andrewlock andrewlock deleted the andrew/ci/fix-aspects-sorting branch July 25, 2023 18:12
@github-actions github-actions bot added this to the vNext milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants