Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[ASM] Waf version upgrade to 1.11.0 (#4355)" #4430

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Revert "[ASM] Waf version upgrade to 1.11.0 (#4355)" #4430

merged 1 commit into from
Jul 21, 2023

Conversation

daniel-romano-DD
Copy link
Contributor

@daniel-romano-DD daniel-romano-DD commented Jul 21, 2023 •
edited
Loading

This reverts commit 72e9635.

due to strange behavior of the waf in macos

@github-actions
Copy link
Contributor

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

2 occurrences of :

-        "_dd.appsec.waf.version": "1.11.0",
+        "_dd.appsec.waf.version": "1.10.0",

8 occurrences of :

-      _dd.appsec.waf.version: 1.11.0,
+      _dd.appsec.waf.version: 1.10.0,

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4430) - mean (2,982ms)  : 2879, 3084
     .   : milestone, 2982,
    master - mean (3,003ms)  : 2913, 3094
     .   : milestone, 3003,

    section CallTarget+Inlining+NGEN
    This PR (4430) - mean (3,828ms)  : 3726, 3931
     .   : milestone, 3828,
    master - mean (3,829ms)  : 3737, 3921
     .   : milestone, 3829,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4430) - mean (3,118ms)  : 3035, 3202
     .   : milestone, 3118,
    master - mean (3,113ms)  : 3003, 3222
     .   : milestone, 3113,

    section CallTarget+Inlining+NGEN
    This PR (4430) - mean (3,618ms)  : 3527, 3710
     .   : milestone, 3618,
    master - mean (3,610ms)  : 3540, 3681
     .   : milestone, 3610,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4430) - mean (3,101ms)  : 3011, 3192
     .   : milestone, 3101,
    master - mean (3,105ms)  : 3035, 3174
     .   : milestone, 3105,

    section CallTarget+Inlining+NGEN
    This PR (4430) - mean (3,575ms)  : 3519, 3631
     .   : milestone, 3575,
    master - mean (3,579ms)  : 3516, 3642
     .   : milestone, 3579,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4430) - mean (192ms)  : 187, 198
     .   : milestone, 192,
    master - mean (190ms)  : 186, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (4430) - mean (1,126ms)  : 1101, 1151
     .   : milestone, 1126,
    master - mean (1,116ms)  : 1080, 1152
     .   : milestone, 1116,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4430) - mean (376ms)  : 368, 383
     .   : milestone, 376,
    master - mean (372ms)  : 366, 379
     .   : milestone, 372,

    section CallTarget+Inlining+NGEN
    This PR (4430) - mean (1,190ms)  : 1159, 1220
     .   : milestone, 1190,
    master - mean (1,183ms)  : 1149, 1216
     .   : milestone, 1183,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4430) - mean (364ms)  : 356, 372
     .   : milestone, 364,
    master - mean (360ms)  : 353, 367
     .   : milestone, 360,

    section CallTarget+Inlining+NGEN
    This PR (4430) - mean (1,135ms)  : 1109, 1160
     .   : milestone, 1135,
    master - mean (1,134ms)  : 1101, 1167
     .   : milestone, 1134,
Loading

@andrewlock
Copy link
Member

Benchmarks Report 🐌

Benchmarks for #4430 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.127
  • 1 benchmarks are slower, with geometric mean 1.132
  • 4 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 494μs 474ns 1.84μs 0 0 0 2.62 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 641μs 136ns 509ns 0 0 0 2.62 KB
master WriteAndFlushEnrichedTraces net472 799μs 360ns 1.35μs 0.398 0 0 3.22 KB
#4430 WriteAndFlushEnrichedTraces net6.0 483μs 147ns 569ns 0 0 0 2.62 KB
#4430 WriteAndFlushEnrichedTraces netcoreapp3.1 633μs 1.32μs 5.11μs 0 0 0 2.63 KB
#4430 WriteAndFlushEnrichedTraces net472 805μs 261ns 1.01μs 0.401 0 0 3.22 KB
Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #4430

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 9.33 KB 9.28 KB -48 B -0.51%
Benchmarks.Trace.AppSecBodyBenchmark.AllCycleSimpleBody‑net6.0 1.69 KB 1.65 KB -40 B -2.37%
Benchmarks.Trace.AppSecBodyBenchmark.AllCycleSimpleBody‑netcoreapp3.1 1.67 KB 1.63 KB -40 B -2.39%
Benchmarks.Trace.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 1.73 KB 1.69 KB -48 B -2.77%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 38.1μs 57.6ns 223ns 0.019 0 0 1.69 KB
master AllCycleSimpleBody netcoreapp3.1 40.4μs 23.7ns 85.5ns 0.0199 0 0 1.67 KB
master AllCycleSimpleBody net472 41.5μs 14.2ns 53.3ns 0.269 0 0 1.73 KB
master AllCycleMoreComplexBody net6.0 217μs 71.2ns 266ns 0.109 0 0 9.26 KB
master AllCycleMoreComplexBody netcoreapp3.1 226μs 323ns 1.25μs 0.112 0 0 9.16 KB
master AllCycleMoreComplexBody net472 235μs 373ns 1.45μs 1.42 0 0 9.33 KB
master ObjectExtractorSimpleBody net6.0 118ns 0.0382ns 0.143ns 0.00396 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 176ns 0.0756ns 0.272ns 0.00363 0 0 272 B
master ObjectExtractorSimpleBody net472 146ns 0.11ns 0.424ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3μs 1.17ns 4.36ns 0.0541 0 0 3.88 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.01μs 1.18ns 4.27ns 0.0522 0 0 3.78 KB
master ObjectExtractorMoreComplexBody net472 4.12μs 1.68ns 6.04ns 0.617 0.00619 0 3.89 KB
#4430 AllCycleSimpleBody net6.0 39.5μs 5.64ns 19.5ns 0.0197 0 0 1.65 KB
#4430 AllCycleSimpleBody netcoreapp3.1 41.6μs 26.1ns 97.7ns 0.0206 0 0 1.63 KB
#4430 AllCycleSimpleBody net472 42.2μs 49.5ns 192ns 0.267 0 0 1.69 KB
#4430 AllCycleMoreComplexBody net6.0 221μs 58.7ns 203ns 0.11 0 0 9.22 KB
#4430 AllCycleMoreComplexBody netcoreapp3.1 231μs 239ns 955ns 0 0 0 9.12 KB
#4430 AllCycleMoreComplexBody net472 241μs 80.8ns 313ns 1.44 0 0 9.28 KB
#4430 ObjectExtractorSimpleBody net6.0 117ns 0.0658ns 0.255ns 0.00396 0 0 280 B
#4430 ObjectExtractorSimpleBody netcoreapp3.1 176ns 0.0935ns 0.362ns 0.0038 0 0 272 B
#4430 ObjectExtractorSimpleBody net472 148ns 0.217ns 0.839ns 0.0446 0 0 281 B
#4430 ObjectExtractorMoreComplexBody net6.0 3.07μs 1.25ns 4.85ns 0.0538 0 0 3.88 KB
#4430 ObjectExtractorMoreComplexBody netcoreapp3.1 4.1μs 1.23ns 4.58ns 0.0511 0 0 3.78 KB
#4430 ObjectExtractorMoreComplexBody net472 4.02μs 1.71ns 6.63ns 0.618 0.00604 0 3.89 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 166μs 111ns 429ns 0.25 0 0 18.08 KB
master SendRequest netcoreapp3.1 189μs 389ns 1.51μs 0.144 0 0 20.16 KB
master SendRequest net472 0.000899ns 0.000391ns 0.00146ns 0 0 0 0 b
#4430 SendRequest net6.0 166μs 171ns 661ns 0.166 0 0 18.08 KB
#4430 SendRequest netcoreapp3.1 190μs 249ns 965ns 0.187 0 0 20.14 KB
#4430 SendRequest net472 0.000291ns 0.000108ns 0.000391ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 530μs 413ns 1.6μs 0.765 0 0 41.79 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 618μs 2.21μs 8.57μs 0.308 0 0 41.61 KB
master WriteAndFlushEnrichedTraces net472 783μs 2.75μs 10.6μs 8.25 2.36 0.393 53.23 KB
#4430 WriteAndFlushEnrichedTraces net6.0 512μs 312ns 1.21μs 0.51 0 0 41.69 KB
#4430 WriteAndFlushEnrichedTraces netcoreapp3.1 616μs 1.62μs 6.28μs 0.312 0 0 41.79 KB
#4430 WriteAndFlushEnrichedTraces net472 815μs 1.96μs 7.05μs 8.28 2.48 0.414 53.35 KB
Benchmarks.Trace.DbCommandBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4430

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1 1.126 1,322.74 1,174.28

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 973ns 0.326ns 1.26ns 0.0108 0 0 768 B
master ExecuteNonQuery netcoreapp3.1 1.32μs 0.365ns 1.31ns 0.0106 0 0 768 B
master ExecuteNonQuery net472 1.44μs 0.759ns 2.84ns 0.115 0 0 730 B
#4430 ExecuteNonQuery net6.0 1.03μs 0.35ns 1.35ns 0.0104 0 0 768 B
#4430 ExecuteNonQuery netcoreapp3.1 1.17μs 0.407ns 1.52ns 0.0106 0 0 768 B
#4430 ExecuteNonQuery net472 1.52μs 0.692ns 2.68ns 0.116 0.000758 0 730 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.12μs 0.369ns 1.28ns 0.0139 0 0 992 B
master CallElasticsearch netcoreapp3.1 1.33μs 0.714ns 2.77ns 0.0134 0 0 992 B
master CallElasticsearch net472 2.01μs 0.519ns 1.94ns 0.159 0 0 1 KB
master CallElasticsearchAsync net6.0 1.09μs 0.358ns 1.34ns 0.0133 0 0 968 B
master CallElasticsearchAsync netcoreapp3.1 1.36μs 1.55ns 5.98ns 0.0137 0 0 1.04 KB
master CallElasticsearchAsync net472 2.34μs 0.751ns 2.81ns 0.168 0.00117 0 1.06 KB
#4430 CallElasticsearch net6.0 1.12μs 0.365ns 1.41ns 0.014 0 0 992 B
#4430 CallElasticsearch netcoreapp3.1 1.29μs 0.757ns 2.93ns 0.0131 0 0 992 B
#4430 CallElasticsearch net472 2.16μs 0.744ns 2.88ns 0.159 0.00108 0 1 KB
#4430 CallElasticsearchAsync net6.0 1.1μs 0.41ns 1.53ns 0.0134 0 0 968 B
#4430 CallElasticsearchAsync netcoreapp3.1 1.42μs 0.954ns 3.44ns 0.0135 0 0 1.04 KB
#4430 CallElasticsearchAsync net472 2.21μs 0.335ns 1.21ns 0.167 0.00111 0 1.06 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.07μs 0.6ns 2.24ns 0.0125 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.44μs 0.5ns 1.94ns 0.0123 0 0 912 B
master ExecuteAsync net472 1.53μs 0.626ns 2.26ns 0.139 0.000767 0 875 B
#4430 ExecuteAsync net6.0 1.1μs 0.509ns 1.97ns 0.013 0 0 912 B
#4430 ExecuteAsync netcoreapp3.1 1.41μs 0.708ns 2.74ns 0.0121 0 0 912 B
#4430 ExecuteAsync net472 1.52μs 0.607ns 2.35ns 0.139 0.000758 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 3.65μs 1.58ns 5.71ns 0.0275 0 0 1.94 KB
master SendAsync netcoreapp3.1 4.3μs 1.57ns 6.09ns 0.0322 0 0 2.48 KB
master SendAsync net472 6.95μs 3.15ns 12.2ns 0.482 0 0 3.05 KB
#4430 SendAsync net6.0 3.59μs 0.939ns 3.39ns 0.0271 0 0 1.94 KB
#4430 SendAsync netcoreapp3.1 4.18μs 1.22ns 4.55ns 0.0336 0 0 2.48 KB
#4430 SendAsync net472 6.92μs 4.55ns 17.6ns 0.484 0 0 3.05 KB
Benchmarks.Trace.ILoggerBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4430

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.132 1,242.73 1,406.20

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.24μs 0.596ns 2.23ns 0.0228 0 0 1.62 KB
master EnrichedLog netcoreapp3.1 2.07μs 0.976ns 3.52ns 0.0215 0 0 1.62 KB
master EnrichedLog net472 2.23μs 2.69ns 10.4ns 0.244 0 0 1.54 KB
#4430 EnrichedLog net6.0 1.41μs 0.673ns 2.52ns 0.0226 0 0 1.62 KB
#4430 EnrichedLog netcoreapp3.1 1.88μs 0.854ns 3.2ns 0.0225 0 0 1.62 KB
#4430 EnrichedLog net472 2.27μs 1.83ns 6.83ns 0.244 0 0 1.54 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 111μs 103ns 398ns 0.0554 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 116μs 162ns 629ns 0 0 0 4.21 KB
master EnrichedLog net472 146μs 132ns 513ns 0.657 0.219 0 4.38 KB
#4430 EnrichedLog net6.0 111μs 123ns 475ns 0.0552 0 0 4.21 KB
#4430 EnrichedLog netcoreapp3.1 117μs 263ns 1.02μs 0 0 0 4.21 KB
#4430 EnrichedLog net472 145μs 63.3ns 237ns 0.654 0.218 0 4.38 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.86μs 6.11ns 22ns 0.03 0 0 2.18 KB
master EnrichedLog netcoreapp3.1 3.75μs 1.08ns 3.75ns 0.0283 0 0 2.18 KB
master EnrichedLog net472 4.39μs 1.73ns 6.69ns 0.315 0 0 1.99 KB
#4430 EnrichedLog net6.0 2.87μs 1.06ns 3.96ns 0.03 0 0 2.18 KB
#4430 EnrichedLog netcoreapp3.1 3.91μs 13.8ns 47.7ns 0.0285 0 0 2.18 KB
#4430 EnrichedLog net472 4.6μs 0.802ns 2.89ns 0.315 0 0 1.99 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.24μs 0.411ns 1.42ns 0.0161 0 0 1.16 KB
master SendReceive netcoreapp3.1 1.49μs 0.573ns 2.22ns 0.0157 0 0 1.16 KB
master SendReceive net472 1.85μs 1.19ns 4.6ns 0.185 0 0 1.16 KB
#4430 SendReceive net6.0 1.23μs 0.961ns 3.72ns 0.0159 0 0 1.16 KB
#4430 SendReceive netcoreapp3.1 1.48μs 0.725ns 2.71ns 0.0155 0 0 1.16 KB
#4430 SendReceive net472 1.86μs 0.883ns 3.3ns 0.184 0.000925 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.37μs 0.563ns 2.18ns 0.0213 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.48μs 2.07ns 8.03ns 0.0208 0 0 1.58 KB
master EnrichedLog net472 3.84μs 1.46ns 5.67ns 0.31 0 0 1.96 KB
#4430 EnrichedLog net6.0 2.43μs 0.405ns 1.52ns 0.0212 0 0 1.53 KB
#4430 EnrichedLog netcoreapp3.1 3.44μs 1.62ns 6.08ns 0.0205 0 0 1.58 KB
#4430 EnrichedLog net472 3.97μs 1.59ns 6.17ns 0.309 0 0 1.96 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4430

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.128 513.25 454.99

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 441ns 0.131ns 0.506ns 0.0075 0 0 536 B
master StartFinishSpan netcoreapp3.1 510ns 0.423ns 1.58ns 0.00712 0 0 536 B
master StartFinishSpan net472 583ns 0.0738ns 0.276ns 0.0854 0 0 538 B
master StartFinishScope net6.0 513ns 0.185ns 0.691ns 0.00914 0 0 656 B
master StartFinishScope netcoreapp3.1 673ns 0.205ns 0.766ns 0.00877 0 0 656 B
master StartFinishScope net472 796ns 0.888ns 3.44ns 0.098 0 0 618 B
#4430 StartFinishSpan net6.0 415ns 0.349ns 1.26ns 0.00745 0 0 536 B
#4430 StartFinishSpan netcoreapp3.1 531ns 0.248ns 0.928ns 0.00721 0 0 536 B
#4430 StartFinishSpan net472 608ns 0.0975ns 0.365ns 0.0853 0 0 538 B
#4430 StartFinishScope net6.0 455ns 0.116ns 0.42ns 0.00915 0 0 656 B
#4430 StartFinishScope netcoreapp3.1 707ns 2.22ns 7.99ns 0.00863 0 0 656 B
#4430 StartFinishScope net472 778ns 0.249ns 0.964ns 0.0982 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 620ns 0.255ns 0.987ns 0.00931 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 765ns 0.233ns 0.839ns 0.00901 0 0 656 B
master RunOnMethodBegin net472 980ns 0.252ns 0.944ns 0.0978 0 0 618 B
#4430 RunOnMethodBegin net6.0 621ns 0.147ns 0.551ns 0.00934 0 0 656 B
#4430 RunOnMethodBegin netcoreapp3.1 802ns 0.696ns 2.61ns 0.00877 0 0 656 B
#4430 RunOnMethodBegin net472 887ns 0.264ns 0.99ns 0.098 0 0 618 B

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jul 21, 2023 •
edited
Loading

Datadog Report

Branch report: dani/asm/waf_v1_11_rollback
Commit report: 2ddbd99

❄️ dd-trace-dotnet: 0 Failed, 1 New Flaky, 301117 Passed, 2133 Skipped, 28m 5.12s Wall Time

New Flaky Tests (1)

  • NoExceptions - Datadog.Trace.ClrProfiler.IntegrationTests.SmokeTests.AssemblyResolveMscorlibResourcesInfiniteRecursionCrashSmokeTest - Last Failure

    Expand for error 
     Expected no errors in smoke test: open(/proc/4974/mem) FAILED 2 (No such file or directory)
 
 Expected: True
 Actual:   False

@andrewlock
Copy link
Member

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4430) (11.390M)   : 0, 11389838
    master (11.374M)   : 0, 11373764
    benchmarks/2.33.0 (11.263M)   : 0, 11262915
    benchmarks/2.9.0 (11.187M)   : 0, 11187179

    section Automatic
    This PR (4430) (7.918M)   : 0, 7917962
    master (7.946M)   : 0, 7946352
    benchmarks/2.33.0 (7.723M)   : 0, 7722859
    benchmarks/2.9.0 (8.063M)   : 0, 8063253

    section Trace stats
    master (8.083M)   : 0, 8083305
    benchmarks/2.33.0 (7.766M)   : 0, 7765746

    section Manual
    This PR (4430) (10.044M)   : 0, 10044213
    master (10.495M)   : 0, 10494672
    benchmarks/2.33.0 (9.885M)   : 0, 9885187

    section Manual + Automatic
    This PR (4430) (7.680M)   : 0, 7679699
    master (7.812M)   : 0, 7812351
    benchmarks/2.33.0 (7.380M)   : 0, 7380165

    section Version Conflict
    master (7.094M)   : 0, 7093913
    benchmarks/2.33.0 (6.688M)   : 0, 6687945
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4430) (9.799M)   : 0, 9799091
    master (9.669M)   : 0, 9669305
    benchmarks/2.33.0 (9.572M)   : 0, 9572324
    benchmarks/2.9.0 (9.692M)   : 0, 9692314

    section Automatic
    This PR (4430) (6.773M)   : 0, 6773222
    master (6.605M)   : 0, 6605213
    benchmarks/2.33.0 (6.758M)   : 0, 6757848

    section Trace stats
    master (6.584M)   : 0, 6584108
    benchmarks/2.33.0 (6.781M)   : 0, 6780787

    section Manual
    This PR (4430) (8.348M)   : 0, 8347922
    master (8.280M)   : 0, 8280457
    benchmarks/2.33.0 (8.412M)   : 0, 8411981

    section Manual + Automatic
    This PR (4430) (6.525M)   : 0, 6524689
    master (6.566M)   : 0, 6566270
    benchmarks/2.33.0 (6.480M)   : 0, 6480397

    section Version Conflict
    master (5.954M)   : 0, 5953551
    benchmarks/2.33.0 (5.549M)   : 0, 5548633
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4430) (10.781M)   : 0, 10781102
    master (10.516M)   : 0, 10516344
    benchmarks/2.33.0 (10.359M)   : 0, 10358689
    benchmarks/2.9.0 (10.321M)   : 0, 10321166

    section Automatic
    This PR (4430) (7.634M)   : 0, 7633803
    master (7.836M)   : 0, 7836255
    benchmarks/2.33.0 (7.455M)   : 0, 7454994
    benchmarks/2.9.0 (7.426M)   : 0, 7426440

    section Trace stats
    master (7.576M)   : 0, 7576029
    benchmarks/2.33.0 (7.453M)   : 0, 7453375

    section Manual
    This PR (4430) (9.820M)   : 0, 9819747
    master (9.606M)   : 0, 9605964
    benchmarks/2.33.0 (9.308M)   : 0, 9307869

    section Manual + Automatic
    This PR (4430) (7.330M)   : 0, 7330366
    master (7.536M)   : 0, 7536010
    benchmarks/2.33.0 (7.325M)   : 0, 7325142

    section Version Conflict
    master (6.846M)   : 0, 6846477
    benchmarks/2.33.0 (6.615M)   : 0, 6615307
Loading 
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4430) (7.406M)   : 0, 7406415
    master (7.336M)   : 0, 7335873
    benchmarks/2.33.0 (7.536M)   : 0, 7535707
    benchmarks/2.9.0 (7.795M)   : 0, 7795313

    section No attack
    This PR (4430) (2.131M)   : 0, 2131352
    master (2.078M)   : 0, 2077995
    benchmarks/2.33.0 (2.162M)   : 0, 2161945
    benchmarks/2.9.0 (3.229M)   : 0, 3228901

    section Attack
    This PR (4430) (1.839M)   : 0, 1838839
    master (1.646M)   : 0, 1645615
    benchmarks/2.33.0 (1.846M)   : 0, 1846404
    benchmarks/2.9.0 (2.520M)   : 0, 2520025

    section Blocking
    This PR (4430) (3.720M)   : 0, 3720009
    master (3.117M)   : 0, 3116678
    benchmarks/2.33.0 (3.670M)   : 0, 3670146
Loading

@daniel-romano-DD daniel-romano-DD marked this pull request as ready for review July 21, 2023 15:10
@daniel-romano-DD daniel-romano-DD requested review from a team as code owners July 21, 2023 15:10
robertpi
robertpi approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@robertpi robertpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it's generated automatically and seems to undo the change without conflict, so LGTM.

Thanks for the reactivity.

andrewlock
andrewlock approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 (I'm assuming it's a straight revert with no other changes!)

@daniel-romano-DD daniel-romano-DD merged commit aac88a6 into master Jul 21, 2023
@daniel-romano-DD daniel-romano-DD deleted the dani/asm/waf_v1_11_rollback branch July 21, 2023 15:36
@github-actions github-actions bot added this to the vNext milestone Jul 21, 2023
bouwkast pushed a commit that referenced this pull request Jul 31, 2023
@daniel-romano-DD @bouwkast
Revert "[ASM] Waf version upgrade to 1.11.0 (#4355)" (#4430)
672c842 
This reverts commit 72e9635.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

@robertpi robertpi robertpi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.34.0
Development

Successfully merging this pull request may close these issues.
3 participants
@daniel-romano-DD @andrewlock @robertpi