Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AWS Lambda integration tests for <net6.0 #4391

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Remove AWS Lambda integration tests for <net6.0 #4391

merged 1 commit into from
Jul 13, 2023

Conversation

andrewlock
Copy link
Member

@andrewlock andrewlock commented Jul 12, 2023 •
edited by lucaspimentel
Loading

Summary of changes

  • Removes AWS Lambda testing on netcoreapp3.1 and net5.0

Reason for change

These runtimes are in phase2 deprecation in AWS Lambda (customers can't create or update functions using these), so there's not much point testing on them

Implementation details

A lot of find and replace + delete

Test coverage

Less, naturally

Other details

cc @lucaspimentel

@andrewlock andrewlock added area:tests unit tests, integration tests area:test-apps apps used to test integrations area:serverless labels Jul 12, 2023
@andrewlock andrewlock requested review from a team as code owners July 12, 2023 14:50
bouwkast
bouwkast reviewed Jul 12, 2023
View reviewed changes
Copy link
Contributor

@bouwkast bouwkast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@lucaspimentel lucaspimentel changed the title Remove integration tests for <net6.0 Remove AWS Lambda integration tests for <net6.0 Jul 12, 2023
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jul 12, 2023 •
edited
Loading

Datadog Report

Branch report: andrew/remove-netcoreapp31-serverless
Commit report: 8c883bb

❄️ dd-trace-dotnet: 0 Failed, 15 New Flaky, 291182 Passed, 1091 Skipped, 28m 38.39s Wall Time

New Flaky Tests (15)

  • CheckCpuTimeForGcThreadsIsReported - Datadog.Profiler.IntegrationTests.GarbageCollections.GarbageCollectorCpuTimeTest - Last Failure

    Expand for error 
     Expected SamplesHelper.GetSamples(runner.Environment.PprofDir) {(|lm:System.Private.CoreLib |ns:System.Diagnostics.Tracing |ct:EventSource |cg: |fn:GetCustomAttributeHelper |fg: |sg:(System.Reflection.MemberInfo member, System.Type attributeType, System.Diagnostics.Tracing.EventManifestOptions flags)
 |lm:System.Private.CoreLib |ns:System.Diagnostics.Tracing |ct:EventSource |cg: |fn:CreateManifestAndDescriptors |fg: |sg:(System.Type eventSourceType, string eventSourceDllName, System.Diagnostics.Tracing.EventSource source, System.Diagnostics.Tracing.EventManifestOptions flags)
 |lm:System.Private.CoreLib |ns:System.Diagnostics.Tracing |ct:EventSource |cg: |fn:EnsureDescriptorsInitialized |fg: |sg:()
 |lm:System.Private.CoreLib |ns:System.Diagnostics.Tracing |ct:EventSource |cg: |fn:DoCommand |fg: |sg:(System.Diagnostics.Tracing.EventCommandEventArgs commandArgs)
 |lm:System.Private.CoreLib |ns:System.Diagnostics.Tracing |ct:EventSource |cg: |fn:Initialize |fg: |sg:(System.Guid eventSourceGuid, string eventSourceName, string[] traits)
 |lm:System.Private.CoreLib |ns:System.Diagnostics.Tracing |ct:NativeRuntimeEventSource |cg: |fn:.ctor |fg: |sg:()
 |lm:System.Private.CoreLib |ns:System.Diagnostics.Tracing |ct:NativeRuntimeEventSource |cg: |fn:.cctor |fg: |sg:()
 |lm:System.Private.CoreLib |ns:System.Diagnostics.Tracing |ct:EventListener |cg: |fn:get_EventListenersLock |fg: |sg:()
 |lm:System.Private.CoreLib |ns:System.Diagnostics.Tracing |ct:EventSource |cg: |fn:Initialize |fg: |sg:(System.Guid eventSourceGuid, string eventSourceName, string[] traits)
 |lm:System.Private.CoreLib |ns:System.Diagnostics.Tracing |ct:RuntimeEventSource |cg: |fn:.ctor |fg: |sg:()
 ...

  • SubmitTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AerospikeTests - Last Failure

    Expand for error 
     Expected exit code: 0, actual exit code: 134.

  • SubmitTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AerospikeTests - Last Failure

    Expand for error 
     Expected exit code: 0, actual exit code: 134.

  • SubmitTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AerospikeTests - Last Failure

    Expand for error 
     Expected exit code: 0, actual exit code: 134.

  • SubmitTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AerospikeTests - Last Failure

    Expand for error 
     Expected exit code: 0, actual exit code: 134.

@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock andrewlock force-pushed the andrew/remove-netcoreapp31-serverless branch from 3354ef0 to 8c883bb Compare July 13, 2023 09:09
@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4391) - mean (2,986ms)  : 2882, 3089
     .   : milestone, 2986,
    master - mean (3,017ms)  : 2943, 3090
     .   : milestone, 3017,

    section CallTarget+Inlining+NGEN
    This PR (4391) - mean (3,843ms)  : 3752, 3934
     .   : milestone, 3843,
    master - mean (3,839ms)  : 3746, 3933
     .   : milestone, 3839,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4391) - mean (3,123ms)  : 3043, 3203
     .   : milestone, 3123,
    master - mean (3,107ms)  : 2990, 3224
     .   : milestone, 3107,

    section CallTarget+Inlining+NGEN
    This PR (4391) - mean (3,626ms)  : 3564, 3688
     .   : milestone, 3626,
    master - mean (3,630ms)  : 3588, 3672
     .   : milestone, 3630,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4391) - mean (3,093ms)  : 3016, 3169
     .   : milestone, 3093,
    master - mean (3,095ms)  : 2999, 3191
     .   : milestone, 3095,

    section CallTarget+Inlining+NGEN
    This PR (4391) - mean (3,596ms)  : 3517, 3674
     .   : milestone, 3596,
    master - mean (3,591ms)  : 3551, 3631
     .   : milestone, 3591,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4391) - mean (189ms)  : 186, 193
     .   : milestone, 189,
    master - mean (189ms)  : 185, 193
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (4391) - mean (1,124ms)  : 1098, 1150
     .   : milestone, 1124,
    master - mean (1,134ms)  : 1107, 1162
     .   : milestone, 1134,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4391) - mean (371ms)  : 364, 378
     .   : milestone, 371,
    master - mean (372ms)  : 368, 376
     .   : milestone, 372,

    section CallTarget+Inlining+NGEN
    This PR (4391) - mean (1,188ms)  : 1166, 1210
     .   : milestone, 1188,
    master - mean (1,193ms)  : 1164, 1223
     .   : milestone, 1193,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4391) - mean (360ms)  : 353, 367
     .   : milestone, 360,
    master - mean (357ms)  : 352, 363
     .   : milestone, 357,

    section CallTarget+Inlining+NGEN
    This PR (4391) - mean (1,144ms)  : 1129, 1158
     .   : milestone, 1144,
    master - mean (1,143ms)  : 1119, 1167
     .   : milestone, 1143,
Loading

@andrewlock
Copy link
Member Author

Benchmarks Report 🐌

Benchmarks for #4391 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.164
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 470μs 127ns 441ns 0 0 0 2.62 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 639μs 156ns 605ns 0 0 0 2.63 KB
master WriteAndFlushEnrichedTraces net472 805μs 414ns 1.6μs 0.403 0 0 3.22 KB
#4391 WriteAndFlushEnrichedTraces net6.0 501μs 335ns 1.3μs 0 0 0 2.62 KB
#4391 WriteAndFlushEnrichedTraces netcoreapp3.1 642μs 330ns 1.28μs 0 0 0 2.63 KB
#4391 WriteAndFlushEnrichedTraces net472 818μs 347ns 1.3μs 0.403 0 0 3.22 KB
Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 38.7μs 23.5ns 91.2ns 0.0194 0 0 1.65 KB
master AllCycleSimpleBody netcoreapp3.1 41.2μs 39.3ns 147ns 0.0204 0 0 1.63 KB
master AllCycleSimpleBody net472 42μs 19.9ns 77.1ns 0.249 0 0 1.69 KB
master AllCycleMoreComplexBody net6.0 221μs 377ns 1.31μs 0.11 0 0 9.22 KB
master AllCycleMoreComplexBody netcoreapp3.1 229μs 285ns 1.1μs 0.114 0 0 9.12 KB
master AllCycleMoreComplexBody net472 237μs 92.5ns 358ns 1.42 0 0 9.28 KB
master ObjectExtractorSimpleBody net6.0 129ns 0.0382ns 0.143ns 0.00392 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 180ns 0.0309ns 0.116ns 0.00363 0 0 272 B
master ObjectExtractorSimpleBody net472 172ns 1.17ns 11.7ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 2.93μs 0.739ns 2.77ns 0.0544 0 0 3.88 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 3.95μs 1.48ns 5.53ns 0.0512 0 0 3.78 KB
master ObjectExtractorMoreComplexBody net472 4.08μs 2.07ns 8.03ns 0.617 0.00611 0 3.89 KB
#4391 AllCycleSimpleBody net6.0 39.3μs 33.8ns 127ns 0.0199 0 0 1.65 KB
#4391 AllCycleSimpleBody netcoreapp3.1 41.1μs 85.5ns 320ns 0.0201 0 0 1.63 KB
#4391 AllCycleSimpleBody net472 42.8μs 27ns 101ns 0.249 0 0 1.69 KB
#4391 AllCycleMoreComplexBody net6.0 221μs 64.2ns 249ns 0.111 0 0 9.22 KB
#4391 AllCycleMoreComplexBody netcoreapp3.1 230μs 234ns 877ns 0.114 0 0 9.12 KB
#4391 AllCycleMoreComplexBody net472 237μs 81.7ns 317ns 1.42 0 0 9.28 KB
#4391 ObjectExtractorSimpleBody net6.0 118ns 0.0316ns 0.118ns 0.00394 0 0 280 B
#4391 ObjectExtractorSimpleBody netcoreapp3.1 173ns 0.0462ns 0.173ns 0.00365 0 0 272 B
#4391 ObjectExtractorSimpleBody net472 173ns 1.02ns 10.1ns 0.0446 0 0 281 B
#4391 ObjectExtractorMoreComplexBody net6.0 2.99μs 1.26ns 4.71ns 0.0537 0 0 3.88 KB
#4391 ObjectExtractorMoreComplexBody netcoreapp3.1 4.05μs 1.31ns 4.73ns 0.0506 0 0 3.78 KB
#4391 ObjectExtractorMoreComplexBody net472 4.53μs 20.1ns 85.2ns 0.618 0.00689 0 3.89 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 167μs 114ns 442ns 0.167 0 0 18.03 KB
master SendRequest netcoreapp3.1 189μs 223ns 863ns 0.188 0 0 20.09 KB
master SendRequest net472 0.000529ns 0.000255ns 0.000884ns 0 0 0 0 b
#4391 SendRequest net6.0 166μs 116ns 450ns 0.25 0 0 18.03 KB
#4391 SendRequest netcoreapp3.1 188μs 260ns 1.01μs 0.187 0 0 20.09 KB
#4391 SendRequest net472 0.00014ns 9.17E‑05ns 0.000343ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #4391

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.82 KB 41.53 KB -292 B -0.70%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 528μs 1.35μs 5.05μs 0.543 0 0 41.82 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 627μs 610ns 2.36μs 0.311 0 0 41.81 KB
master WriteAndFlushEnrichedTraces net472 807μs 2.78μs 10.8μs 8.31 2.37 0.396 53.24 KB
#4391 WriteAndFlushEnrichedTraces net6.0 507μs 1.17μs 4.53μs 0.504 0 0 41.53 KB
#4391 WriteAndFlushEnrichedTraces netcoreapp3.1 619μs 1.5μs 5.82μs 0.309 0 0 41.77 KB
#4391 WriteAndFlushEnrichedTraces net472 789μs 2.78μs 10.8μs 8.25 2.36 0.393 53.24 KB
Benchmarks.Trace.DbCommandBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4391

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.164 993.95 853.87

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 994ns 0.401ns 1.55ns 0.00995 0 0 720 B
master ExecuteNonQuery netcoreapp3.1 1.21μs 1.86ns 6.97ns 0.00961 0 0 720 B
master ExecuteNonQuery net472 1.41μs 0.413ns 1.49ns 0.108 0.000712 0 682 B
#4391 ExecuteNonQuery net6.0 854ns 0.18ns 0.673ns 0.0098 0 0 720 B
#4391 ExecuteNonQuery netcoreapp3.1 1.09μs 0.326ns 1.26ns 0.00958 0 0 720 B
#4391 ExecuteNonQuery net472 1.36μs 0.241ns 0.934ns 0.108 0 0 682 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1μs 0.434ns 1.68ns 0.0131 0 0 944 B
master CallElasticsearch netcoreapp3.1 1.22μs 0.314ns 1.17ns 0.0128 0 0 944 B
master CallElasticsearch net472 2.07μs 0.483ns 1.81ns 0.151 0.00103 0 955 B
master CallElasticsearchAsync net6.0 1.07μs 0.491ns 1.84ns 0.0128 0 0 920 B
master CallElasticsearchAsync netcoreapp3.1 1.28μs 1.24ns 4.28ns 0.0134 0 0 992 B
master CallElasticsearchAsync net472 2.16μs 1.03ns 3.84ns 0.16 0 0 1.01 KB
#4391 CallElasticsearch net6.0 993ns 0.401ns 1.55ns 0.0134 0 0 944 B
#4391 CallElasticsearch netcoreapp3.1 1.3μs 0.779ns 3.02ns 0.0128 0 0 944 B
#4391 CallElasticsearch net472 1.98μs 0.66ns 2.47ns 0.151 0.000988 0 955 B
#4391 CallElasticsearchAsync net6.0 1.06μs 0.434ns 1.56ns 0.0128 0 0 920 B
#4391 CallElasticsearchAsync netcoreapp3.1 1.36μs 0.51ns 1.84ns 0.0136 0 0 992 B
#4391 CallElasticsearchAsync net472 2.14μs 0.443ns 1.6ns 0.161 0.00107 0 1.01 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.08μs 0.367ns 1.42ns 0.0127 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.42μs 0.258ns 0.931ns 0.012 0 0 912 B
master ExecuteAsync net472 1.56μs 0.471ns 1.82ns 0.138 0.000781 0 875 B
#4391 ExecuteAsync net6.0 1.1μs 0.471ns 1.83ns 0.0126 0 0 912 B
#4391 ExecuteAsync netcoreapp3.1 1.3μs 1.34ns 5.01ns 0.0124 0 0 912 B
#4391 ExecuteAsync net472 1.54μs 0.471ns 1.76ns 0.138 0.000768 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 3.61μs 0.993ns 3.71ns 0.0269 0 0 1.9 KB
master SendAsync netcoreapp3.1 4.23μs 1.59ns 5.97ns 0.0319 0 0 2.43 KB
master SendAsync net472 6.75μs 1.39ns 5.19ns 0.474 0 0 3 KB
#4391 SendAsync net6.0 3.74μs 1.5ns 5.6ns 0.0262 0 0 1.9 KB
#4391 SendAsync netcoreapp3.1 4.32μs 4.4ns 16.5ns 0.0323 0 0 2.43 KB
#4391 SendAsync net472 6.89μs 0.953ns 3.69ns 0.475 0 0 3 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.29μs 0.42ns 1.52ns 0.0226 0 0 1.62 KB
master EnrichedLog netcoreapp3.1 1.97μs 1.96ns 7.58ns 0.0225 0 0 1.62 KB
master EnrichedLog net472 2.19μs 1.62ns 6.27ns 0.245 0 0 1.54 KB
#4391 EnrichedLog net6.0 1.3μs 0.442ns 1.65ns 0.0225 0 0 1.62 KB
#4391 EnrichedLog netcoreapp3.1 1.94μs 0.815ns 3.16ns 0.0222 0 0 1.62 KB
#4391 EnrichedLog net472 2.32μs 5.42ns 21ns 0.244 0 0 1.54 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 110μs 112ns 435ns 0.0545 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 116μs 110ns 412ns 0 0 0 4.21 KB
master EnrichedLog net472 144μs 46.9ns 162ns 0.647 0.216 0 4.38 KB
#4391 EnrichedLog net6.0 111μs 139ns 520ns 0.0555 0 0 4.21 KB
#4391 EnrichedLog netcoreapp3.1 117μs 134ns 503ns 0 0 0 4.21 KB
#4391 EnrichedLog net472 145μs 92.8ns 359ns 0.65 0.217 0 4.38 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.94μs 1.01ns 3.8ns 0.0309 0 0 2.18 KB
master EnrichedLog netcoreapp3.1 3.93μs 8.35ns 32.3ns 0.0291 0 0 2.18 KB
master EnrichedLog net472 4.44μs 1.22ns 4.72ns 0.315 0 0 1.99 KB
#4391 EnrichedLog net6.0 2.79μs 1.09ns 4.07ns 0.0307 0 0 2.18 KB
#4391 EnrichedLog netcoreapp3.1 3.9μs 1.46ns 5.25ns 0.0292 0 0 2.18 KB
#4391 EnrichedLog net472 4.39μs 2.56ns 9.93ns 0.315 0 0 1.99 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.28μs 0.633ns 2.37ns 0.0153 0 0 1.11 KB
master SendReceive netcoreapp3.1 1.54μs 0.697ns 2.51ns 0.0154 0 0 1.11 KB
master SendReceive net472 1.71μs 1.06ns 3.81ns 0.177 0 0 1.12 KB
#4391 SendReceive net6.0 1.17μs 0.424ns 1.64ns 0.0152 0 0 1.11 KB
#4391 SendReceive netcoreapp3.1 1.43μs 0.233ns 0.808ns 0.015 0 0 1.11 KB
#4391 SendReceive net472 1.81μs 1.01ns 3.76ns 0.177 0 0 1.12 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.64μs 0.597ns 2.23ns 0.0211 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.72μs 1.22ns 4.56ns 0.0204 0 0 1.58 KB
master EnrichedLog net472 4.03μs 2.01ns 7.77ns 0.309 0 0 1.96 KB
#4391 EnrichedLog net6.0 2.55μs 0.506ns 1.82ns 0.0216 0 0 1.53 KB
#4391 EnrichedLog netcoreapp3.1 3.71μs 2.84ns 11ns 0.0202 0 0 1.58 KB
#4391 EnrichedLog net472 4.06μs 2.7ns 10.5ns 0.31 0 0 1.96 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 404ns 0.0869ns 0.325ns 0.00749 0 0 536 B
master StartFinishSpan netcoreapp3.1 510ns 0.153ns 0.573ns 0.00726 0 0 536 B
master StartFinishSpan net472 597ns 0.261ns 0.977ns 0.0854 0 0 538 B
master StartFinishScope net6.0 451ns 0.116ns 0.432ns 0.00925 0 0 656 B
master StartFinishScope netcoreapp3.1 599ns 0.247ns 0.957ns 0.00872 0 0 656 B
master StartFinishScope net472 807ns 0.313ns 1.13ns 0.0981 0 0 618 B
#4391 StartFinishSpan net6.0 377ns 0.104ns 0.388ns 0.00745 0 0 536 B
#4391 StartFinishSpan netcoreapp3.1 503ns 0.536ns 2.08ns 0.00713 0 0 536 B
#4391 StartFinishSpan net472 597ns 0.262ns 0.981ns 0.0852 0 0 538 B
#4391 StartFinishScope net6.0 463ns 0.16ns 0.619ns 0.00913 0 0 656 B
#4391 StartFinishScope netcoreapp3.1 643ns 0.471ns 1.7ns 0.00886 0 0 656 B
#4391 StartFinishScope net472 788ns 0.318ns 1.19ns 0.0978 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 579ns 0.251ns 0.939ns 0.00933 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 841ns 0.734ns 2.64ns 0.00897 0 0 656 B
master RunOnMethodBegin net472 878ns 0.384ns 1.33ns 0.0982 0 0 618 B
#4391 RunOnMethodBegin net6.0 590ns 0.134ns 0.485ns 0.00919 0 0 656 B
#4391 RunOnMethodBegin netcoreapp3.1 818ns 0.297ns 1.15ns 0.00883 0 0 656 B
#4391 RunOnMethodBegin net472 906ns 0.269ns 0.969ns 0.098 0 0 618 B

@andrewlock
Copy link
Member Author

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4391) (10.860M)   : 0, 10860161
    master (11.239M)   : 0, 11239401
    benchmarks/2.33.0 (10.950M)   : 0, 10949608
    benchmarks/2.9.0 (10.855M)   : 0, 10855456

    section Automatic
    This PR (4391) (7.768M)   : 0, 7767735
    master (7.667M)   : 0, 7667457
    benchmarks/2.33.0 (7.621M)   : 0, 7620707
    benchmarks/2.9.0 (7.997M)   : 0, 7997440

    section Trace stats
    master (7.684M)   : 0, 7684251
    benchmarks/2.33.0 (7.602M)   : 0, 7602038

    section Manual
    This PR (4391) (9.865M)   : 0, 9864822
    master (9.818M)   : 0, 9817691
    benchmarks/2.33.0 (9.770M)   : 0, 9770235

    section Manual + Automatic
    This PR (4391) (7.331M)   : 0, 7330603
    master (7.344M)   : 0, 7343501
    benchmarks/2.33.0 (7.189M)   : 0, 7188658

    section Version Conflict
    master (6.583M)   : 0, 6582812
    benchmarks/2.33.0 (6.553M)   : 0, 6553316
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4391) (9.209M)   : 0, 9209012
    master (9.589M)   : 0, 9588633
    benchmarks/2.33.0 (9.426M)   : 0, 9425603
    benchmarks/2.9.0 (9.535M)   : 0, 9535154

    section Automatic
    This PR (4391) (6.731M)   : 0, 6731442
    master (6.812M)   : 0, 6811970
    benchmarks/2.33.0 (6.803M)   : 0, 6802932

    section Trace stats
    master (6.757M)   : 0, 6757291
    benchmarks/2.33.0 (6.810M)   : 0, 6810447

    section Manual
    This PR (4391) (8.480M)   : 0, 8479856
    master (8.601M)   : 0, 8600770
    benchmarks/2.33.0 (8.435M)   : 0, 8434569

    section Manual + Automatic
    This PR (4391) (6.579M)   : 0, 6579471
    master (6.535M)   : 0, 6534861
    benchmarks/2.33.0 (6.465M)   : 0, 6465149

    section Version Conflict
    master (5.946M)   : 0, 5945904
    benchmarks/2.33.0 (5.807M)   : 0, 5806690
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4391) (8.801M)   : 0, 8800818
    master (10.803M)   : 0, 10803147
    benchmarks/2.33.0 (9.426M)   : 0, 9426080
    benchmarks/2.9.0 (10.532M)   : 0, 10532348

    section Automatic
    This PR (4391) (7.648M)   : 0, 7648003
    master (7.731M)   : 0, 7730799
    benchmarks/2.33.0 (6.469M)   : 0, 6468939
    benchmarks/2.9.0 (7.564M)   : 0, 7563925

    section Trace stats
    master (7.719M)   : 0, 7719325
    benchmarks/2.33.0 (6.830M)   : 0, 6830314

    section Manual
    This PR (4391) (9.679M)   : 0, 9678830
    master (9.653M)   : 0, 9652952
    benchmarks/2.33.0 (8.108M)   : 0, 8108026

    section Manual + Automatic
    This PR (4391) (7.398M)   : 0, 7398356
    master (7.447M)   : 0, 7447383
    benchmarks/2.33.0 (6.856M)   : 0, 6856379

    section Version Conflict
    master (6.988M)   : 0, 6987835
    benchmarks/2.33.0 (5.893M)   : 0, 5893016
Loading 
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4391) (6.862M)   : 0, 6861970
    master (7.645M)   : 0, 7645287
    benchmarks/2.33.0 (7.765M)   : 0, 7764607
    benchmarks/2.9.0 (8.117M)   : 0, 8117090

    section No attack
    This PR (4391) (2.228M)   : 0, 2228176
    master (2.207M)   : 0, 2206640
    benchmarks/2.33.0 (2.209M)   : 0, 2208725
    benchmarks/2.9.0 (3.354M)   : 0, 3353501

    section Attack
    This PR (4391) (1.914M)   : 0, 1913642
    master (1.920M)   : 0, 1920460
    benchmarks/2.33.0 (1.911M)   : 0, 1910909
    benchmarks/2.9.0 (2.630M)   : 0, 2630367

    section Blocking
    This PR (4391) (3.883M)   : 0, 3882967
    master (3.834M)   : 0, 3834194
    benchmarks/2.33.0 (3.861M)   : 0, 3860900
Loading

@andrewlock andrewlock merged commit ef9d76f into master Jul 13, 2023
@andrewlock andrewlock deleted the andrew/remove-netcoreapp31-serverless branch July 13, 2023 15:12
@github-actions github-actions bot added this to the vNext milestone Jul 13, 2023
bouwkast pushed a commit that referenced this pull request Jul 31, 2023
@andrewlock @bouwkast
Remove integration tests for <net6.0 (#4391)
1f48ae6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouwkast bouwkast bouwkast left review comments

@pierotibou pierotibou pierotibou approved these changes

@lucaspimentel lucaspimentel lucaspimentel approved these changes

Assignees
No one assigned
Labels
area:serverless area:test-apps apps used to test integrations area:tests unit tests, integration tests
Projects
None yet
Milestone
2.34.0
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewlock @lucaspimentel @bouwkast @pierotibou