Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profiler] Fix flacky test #4383

Merged
merged 2 commits into from
Jul 12, 2023
Merged

[Profiler] Fix flacky test #4383

merged 2 commits into from
Jul 12, 2023

Conversation

gleocadie
Copy link
Collaborator

@gleocadie gleocadie commented Jul 11, 2023 •
edited
Loading

Summary of changes

Fix Profiler flacky tests.

@github-actions github-actions bot added the area:profiler Issues related to the continous-profiler label Jul 11, 2023
@gleocadie gleocadie force-pushed the gleocadie/fix-flacky-test branch from 05c9111 to dd3a4cd Compare July 11, 2023 08:24
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@gleocadie gleocadie force-pushed the gleocadie/fix-flacky-test branch from 001b044 to 9ea3c18 Compare July 12, 2023 09:39
@gleocadie gleocadie marked this pull request as ready for review July 12, 2023 09:39
@gleocadie gleocadie requested a review from a team as a code owner July 12, 2023 09:39
andrewlock
andrewlock approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

chrisnas
chrisnas approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@chrisnas chrisnas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4383) - mean (3,007ms)  : 2933, 3080
     .   : milestone, 3007,
    master - mean (3,006ms)  : 2921, 3091
     .   : milestone, 3006,

    section CallTarget+Inlining+NGEN
    This PR (4383) - mean (3,854ms)  : 3761, 3948
     .   : milestone, 3854,
    master - mean (3,841ms)  : 3779, 3902
     .   : milestone, 3841,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4383) - mean (3,122ms)  : 3038, 3206
     .   : milestone, 3122,
    master - mean (3,116ms)  : 3031, 3200
     .   : milestone, 3116,

    section CallTarget+Inlining+NGEN
    This PR (4383) - mean (3,625ms)  : 3567, 3682
     .   : milestone, 3625,
    master - mean (3,625ms)  : 3559, 3691
     .   : milestone, 3625,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4383) - mean (3,104ms)  : 3034, 3174
     .   : milestone, 3104,
    master - mean (3,116ms)  : 3034, 3198
     .   : milestone, 3116,

    section CallTarget+Inlining+NGEN
    This PR (4383) - mean (3,606ms)  : 3535, 3677
     .   : milestone, 3606,
    master - mean (3,597ms)  : 3541, 3653
     .   : milestone, 3597,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4383) - mean (191ms)  : 186, 196
     .   : milestone, 191,
    master - mean (190ms)  : 186, 195
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (4383) - mean (1,131ms)  : 1101, 1161
     .   : milestone, 1131,
    master - mean (1,129ms)  : 1103, 1155
     .   : milestone, 1129,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4383) - mean (371ms)  : 362, 380
     .   : milestone, 371,
    master - mean (372ms)  : 365, 379
     .   : milestone, 372,

    section CallTarget+Inlining+NGEN
    This PR (4383) - mean (1,195ms)  : 1171, 1219
     .   : milestone, 1195,
    master - mean (1,197ms)  : 1168, 1225
     .   : milestone, 1197,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4383) - mean (359ms)  : 355, 364
     .   : milestone, 359,
    master - mean (360ms)  : 353, 366
     .   : milestone, 360,

    section CallTarget+Inlining+NGEN
    This PR (4383) - mean (1,149ms)  : 1119, 1178
     .   : milestone, 1149,
    master - mean (1,145ms)  : 1128, 1163
     .   : milestone, 1145,
Loading

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jul 12, 2023 •
edited
Loading

Datadog Report

Branch report: gleocadie/fix-flacky-test
Commit report: 9ea3c18

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 291186 Passed, 1091 Skipped, 28m 44.84s Wall Time

@andrewlock
Copy link
Member

Benchmarks Report 🐌

Benchmarks for #4383 compared to master:

  • 4 benchmarks are faster, with geometric mean 1.180
  • 1 benchmarks are slower, with geometric mean 1.212
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 474μs 154ns 575ns 0 0 0 2.62 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 647μs 296ns 1.11μs 0 0 0 2.63 KB
master WriteAndFlushEnrichedTraces net472 794μs 409ns 1.59μs 0.396 0 0 3.22 KB
#4383 WriteAndFlushEnrichedTraces net6.0 468μs 297ns 1.11μs 0 0 0 2.62 KB
#4383 WriteAndFlushEnrichedTraces netcoreapp3.1 667μs 929ns 3.48μs 0 0 0 2.62 KB
#4383 WriteAndFlushEnrichedTraces net472 799μs 507ns 1.96μs 0.398 0 0 3.22 KB
Benchmarks.Trace.AppSecBodyBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4383

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑net472 1.302 187.47 143.97
Benchmarks.Trace.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑net6.0 1.144 132.88 116.19

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 38.9μs 23.3ns 90.4ns 0.0195 0 0 1.65 KB
master AllCycleSimpleBody netcoreapp3.1 41.2μs 144ns 559ns 0.0207 0 0 1.63 KB
master AllCycleSimpleBody net472 42.3μs 126ns 487ns 0.249 0 0 1.69 KB
master AllCycleMoreComplexBody net6.0 222μs 81.9ns 317ns 0.111 0 0 9.22 KB
master AllCycleMoreComplexBody netcoreapp3.1 234μs 99.6ns 345ns 0.117 0 0 9.12 KB
master AllCycleMoreComplexBody net472 240μs 79.6ns 308ns 1.43 0 0 9.28 KB
master ObjectExtractorSimpleBody net6.0 133ns 0.0862ns 0.322ns 0.00396 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 167ns 0.0591ns 0.229ns 0.00363 0 0 272 B
master ObjectExtractorSimpleBody net472 188ns 0.194ns 0.75ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3μs 1.52ns 5.91ns 0.054 0 0 3.88 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.12μs 2.33ns 9.01ns 0.0516 0 0 3.78 KB
master ObjectExtractorMoreComplexBody net472 4.09μs 1.69ns 6.33ns 0.617 0.00612 0 3.89 KB
#4383 AllCycleSimpleBody net6.0 39.3μs 19.4ns 72.5ns 0.0195 0 0 1.65 KB
#4383 AllCycleSimpleBody netcoreapp3.1 40.6μs 85.2ns 330ns 0.0202 0 0 1.63 KB
#4383 AllCycleSimpleBody net472 42.5μs 42.7ns 165ns 0.254 0 0 1.69 KB
#4383 AllCycleMoreComplexBody net6.0 225μs 63.2ns 245ns 0.112 0 0 9.22 KB
#4383 AllCycleMoreComplexBody netcoreapp3.1 233μs 178ns 642ns 0.115 0 0 9.12 KB
#4383 AllCycleMoreComplexBody net472 239μs 144ns 557ns 1.43 0 0 9.28 KB
#4383 ObjectExtractorSimpleBody net6.0 116ns 0.0338ns 0.127ns 0.00395 0 0 280 B
#4383 ObjectExtractorSimpleBody netcoreapp3.1 178ns 0.0644ns 0.241ns 0.00369 0 0 272 B
#4383 ObjectExtractorSimpleBody net472 144ns 0.429ns 1.66ns 0.0446 0 0 281 B
#4383 ObjectExtractorMoreComplexBody net6.0 3.02μs 1.06ns 3.98ns 0.0544 0 0 3.88 KB
#4383 ObjectExtractorMoreComplexBody netcoreapp3.1 4.15μs 2.01ns 7.51ns 0.0498 0 0 3.78 KB
#4383 ObjectExtractorMoreComplexBody net472 4.04μs 3.2ns 12.4ns 0.618 0.00612 0 3.89 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 170μs 74.8ns 290ns 0.255 0 0 18.03 KB
master SendRequest netcoreapp3.1 187μs 288ns 1.12μs 0.186 0 0 20.09 KB
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#4383 SendRequest net6.0 169μs 134ns 518ns 0.169 0 0 18.03 KB
#4383 SendRequest netcoreapp3.1 188μs 123ns 462ns 0.187 0 0 20.09 KB
#4383 SendRequest net472 0.00135ns 0.000503ns 0.00195ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #4383

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.95 KB 41.46 KB -487 B -1.16%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 514μs 2.52μs 10.4μs 0.492 0 0 41.95 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 621μs 1.88μs 7.27μs 0.316 0 0 42.02 KB
master WriteAndFlushEnrichedTraces net472 767μs 2.43μs 9.4μs 8.38 2.67 0.381 53.25 KB
#4383 WriteAndFlushEnrichedTraces net6.0 505μs 249ns 930ns 0.498 0 0 41.46 KB
#4383 WriteAndFlushEnrichedTraces netcoreapp3.1 644μs 965ns 3.61μs 0.324 0 0 41.91 KB
#4383 WriteAndFlushEnrichedTraces net472 808μs 3.86μs 15.4μs 8.06 2.42 0.403 53.27 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 841ns 0.228ns 0.822ns 0.0101 0 0 720 B
master ExecuteNonQuery netcoreapp3.1 1.25μs 0.336ns 1.26ns 0.00944 0 0 720 B
master ExecuteNonQuery net472 1.35μs 0.491ns 1.9ns 0.108 0 0 682 B
#4383 ExecuteNonQuery net6.0 911ns 0.198ns 0.742ns 0.00996 0 0 720 B
#4383 ExecuteNonQuery netcoreapp3.1 1.19μs 2.43ns 9.42ns 0.01 0 0 720 B
#4383 ExecuteNonQuery net472 1.44μs 0.373ns 1.44ns 0.108 0 0 682 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.08μs 0.2ns 0.721ns 0.013 0 0 944 B
master CallElasticsearch netcoreapp3.1 1.24μs 0.855ns 3.2ns 0.0125 0 0 944 B
master CallElasticsearch net472 2.1μs 0.71ns 2.75ns 0.151 0.00104 0 955 B
master CallElasticsearchAsync net6.0 987ns 0.216ns 0.748ns 0.0129 0 0 920 B
master CallElasticsearchAsync netcoreapp3.1 1.31μs 0.543ns 2.1ns 0.0132 0 0 992 B
master CallElasticsearchAsync net472 2.11μs 0.533ns 2.06ns 0.161 0.00105 0 1.01 KB
#4383 CallElasticsearch net6.0 988ns 0.246ns 0.922ns 0.013 0 0 944 B
#4383 CallElasticsearch netcoreapp3.1 1.21μs 0.319ns 1.15ns 0.0128 0 0 944 B
#4383 CallElasticsearch net472 2μs 0.624ns 2.42ns 0.151 0.001 0 955 B
#4383 CallElasticsearchAsync net6.0 1.06μs 0.374ns 1.4ns 0.0128 0 0 920 B
#4383 CallElasticsearchAsync netcoreapp3.1 1.32μs 0.528ns 1.97ns 0.0136 0 0 992 B
#4383 CallElasticsearchAsync net472 2.12μs 0.471ns 1.82ns 0.161 0.00106 0 1.01 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.11μs 0.279ns 1.04ns 0.0125 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.38μs 0.448ns 1.68ns 0.0124 0 0 912 B
master ExecuteAsync net472 1.57μs 0.376ns 1.46ns 0.139 0.000771 0 875 B
#4383 ExecuteAsync net6.0 1.22μs 1.38ns 5.16ns 0.0129 0 0 912 B
#4383 ExecuteAsync netcoreapp3.1 1.4μs 2.06ns 7.97ns 0.0125 0 0 912 B
#4383 ExecuteAsync net472 1.59μs 0.967ns 3.75ns 0.138 0.000799 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 3.48μs 1.9ns 7.1ns 0.026 0 0 1.9 KB
master SendAsync netcoreapp3.1 4.26μs 1.3ns 4.67ns 0.0322 0 0 2.43 KB
master SendAsync net472 6.91μs 1.77ns 6.86ns 0.477 0 0 3 KB
#4383 SendAsync net6.0 3.67μs 7.87ns 30.5ns 0.0256 0 0 1.9 KB
#4383 SendAsync netcoreapp3.1 4.31μs 1.94ns 7.26ns 0.0323 0 0 2.43 KB
#4383 SendAsync net472 6.79μs 1.82ns 7.07ns 0.476 0 0 3 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.23μs 0.746ns 2.79ns 0.0229 0 0 1.62 KB
master EnrichedLog netcoreapp3.1 1.96μs 1.73ns 6.71ns 0.0214 0 0 1.62 KB
master EnrichedLog net472 2.29μs 1.69ns 6.31ns 0.244 0 0 1.54 KB
#4383 EnrichedLog net6.0 1.3μs 0.344ns 1.29ns 0.0227 0 0 1.62 KB
#4383 EnrichedLog netcoreapp3.1 1.83μs 0.895ns 3.23ns 0.0219 0 0 1.62 KB
#4383 EnrichedLog net472 2.37μs 1.2ns 4.65ns 0.244 0 0 1.54 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 113μs 91.7ns 355ns 0.0564 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 116μs 167ns 648ns 0 0 0 4.21 KB
master EnrichedLog net472 148μs 173ns 670ns 0.662 0.221 0 4.38 KB
#4383 EnrichedLog net6.0 113μs 68.7ns 257ns 0.0562 0 0 4.21 KB
#4383 EnrichedLog netcoreapp3.1 116μs 239ns 896ns 0 0 0 4.21 KB
#4383 EnrichedLog net472 148μs 115ns 432ns 0.662 0.221 0 4.38 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.86μs 0.604ns 2.18ns 0.0301 0 0 2.18 KB
master EnrichedLog netcoreapp3.1 3.83μs 1.23ns 4.61ns 0.029 0 0 2.18 KB
master EnrichedLog net472 4.52μs 1.14ns 4.43ns 0.315 0 0 1.99 KB
#4383 EnrichedLog net6.0 2.8μs 0.826ns 3.2ns 0.0308 0 0 2.18 KB
#4383 EnrichedLog netcoreapp3.1 3.7μs 1.29ns 4.84ns 0.0296 0 0 2.18 KB
#4383 EnrichedLog net472 4.56μs 0.85ns 3.06ns 0.315 0 0 1.99 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.12μs 0.536ns 2.08ns 0.0155 0 0 1.11 KB
master SendReceive netcoreapp3.1 1.39μs 0.55ns 2.06ns 0.0147 0 0 1.11 KB
master SendReceive net472 1.83μs 0.807ns 3.02ns 0.177 0 0 1.12 KB
#4383 SendReceive net6.0 1.06μs 0.561ns 2.1ns 0.0154 0 0 1.11 KB
#4383 SendReceive netcoreapp3.1 1.49μs 0.546ns 2.04ns 0.0149 0 0 1.11 KB
#4383 SendReceive net472 1.77μs 1.08ns 4.04ns 0.176 0 0 1.12 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.6μs 1.26ns 4.89ns 0.0209 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.54μs 1.11ns 4.14ns 0.0213 0 0 1.58 KB
master EnrichedLog net472 4.23μs 21ns 91.5ns 0.31 0 0 1.96 KB
#4383 EnrichedLog net6.0 2.51μs 0.699ns 2.71ns 0.0214 0 0 1.53 KB
#4383 EnrichedLog netcoreapp3.1 3.54μs 1.35ns 5.05ns 0.0212 0 0 1.58 KB
#4383 EnrichedLog net472 4.1μs 1.89ns 7.08ns 0.309 0 0 1.96 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4383

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.212 511.72 620.30

Faster 🎉 in #4383

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.135 748.83 659.53

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 386ns 0.129ns 0.465ns 0.0075 0 0 536 B
master StartFinishSpan netcoreapp3.1 583ns 0.49ns 1.83ns 0.00731 0 0 536 B
master StartFinishSpan net472 554ns 0.0567ns 0.196ns 0.0852 0 0 538 B
master StartFinishScope net6.0 512ns 0.178ns 0.666ns 0.00915 0 0 656 B
master StartFinishScope netcoreapp3.1 749ns 0.204ns 0.764ns 0.00861 0 0 656 B
master StartFinishScope net472 806ns 0.264ns 0.987ns 0.098 0 0 618 B
#4383 StartFinishSpan net6.0 395ns 0.2ns 0.774ns 0.00741 0 0 536 B
#4383 StartFinishSpan netcoreapp3.1 602ns 0.167ns 0.625ns 0.00729 0 0 536 B
#4383 StartFinishSpan net472 554ns 0.12ns 0.451ns 0.0853 0 0 538 B
#4383 StartFinishScope net6.0 620ns 0.149ns 0.557ns 0.00911 0 0 656 B
#4383 StartFinishScope netcoreapp3.1 660ns 0.423ns 1.53ns 0.00891 0 0 656 B
#4383 StartFinishScope net472 821ns 1.06ns 4.11ns 0.0978 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4383

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.146 673.98 588.32

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 674ns 0.47ns 1.63ns 0.00918 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 756ns 0.31ns 1.12ns 0.00879 0 0 656 B
master RunOnMethodBegin net472 935ns 0.211ns 0.817ns 0.0979 0 0 618 B
#4383 RunOnMethodBegin net6.0 588ns 0.173ns 0.669ns 0.00923 0 0 656 B
#4383 RunOnMethodBegin netcoreapp3.1 771ns 0.773ns 2.89ns 0.00891 0 0 656 B
#4383 RunOnMethodBegin net472 930ns 0.462ns 1.79ns 0.098 0 0 618 B

@andrewlock
Copy link
Member

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4383) (11.177M)   : 0, 11177092
    master (11.039M)   : 0, 11038648
    benchmarks/2.33.0 (10.950M)   : 0, 10949608
    benchmarks/2.9.0 (11.003M)   : 0, 11003334

    section Automatic
    This PR (4383) (7.727M)   : 0, 7727037
    master (7.701M)   : 0, 7701120
    benchmarks/2.33.0 (7.621M)   : 0, 7620707
    benchmarks/2.9.0 (7.928M)   : 0, 7927595

    section Trace stats
    master (7.716M)   : 0, 7716275
    benchmarks/2.33.0 (7.602M)   : 0, 7602038

    section Manual
    This PR (4383) (9.877M)   : 0, 9876660
    master (9.985M)   : 0, 9984799
    benchmarks/2.33.0 (9.770M)   : 0, 9770235

    section Manual + Automatic
    This PR (4383) (7.395M)   : 0, 7395085
    master (7.390M)   : 0, 7389573
    benchmarks/2.33.0 (7.189M)   : 0, 7188658

    section Version Conflict
    master (6.712M)   : 0, 6712363
    benchmarks/2.33.0 (6.553M)   : 0, 6553316
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4383) (9.747M)   : 0, 9747424
    master (9.765M)   : 0, 9764849
    benchmarks/2.33.0 (9.426M)   : 0, 9425603
    benchmarks/2.9.0 (9.605M)   : 0, 9604953

    section Automatic
    This PR (4383) (6.877M)   : 0, 6877059
    master (6.735M)   : 0, 6734547
    benchmarks/2.33.0 (6.803M)   : 0, 6802932

    section Trace stats
    master (6.702M)   : 0, 6702121
    benchmarks/2.33.0 (6.810M)   : 0, 6810447

    section Manual
    This PR (4383) (8.433M)   : 0, 8433436
    master (8.572M)   : 0, 8572415
    benchmarks/2.33.0 (8.435M)   : 0, 8434569

    section Manual + Automatic
    This PR (4383) (6.307M)   : 0, 6307211
    master (6.616M)   : 0, 6616222
    benchmarks/2.33.0 (6.465M)   : 0, 6465149

    section Version Conflict
    master (5.860M)   : 0, 5860102
    benchmarks/2.33.0 (5.807M)   : 0, 5806690
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4383) (9.230M)   : 0, 9230106
    master (9.976M)   : 0, 9976017
    benchmarks/2.33.0 (9.426M)   : 0, 9426080
    benchmarks/2.9.0 (8.999M)   : 0, 8999461

    section Automatic
    This PR (4383) (6.871M)   : 0, 6871487
    master (7.092M)   : 0, 7091991
    benchmarks/2.33.0 (6.469M)   : 0, 6468939
    benchmarks/2.9.0 (6.913M)   : 0, 6912666

    section Trace stats
    master (7.239M)   : 0, 7238581
    benchmarks/2.33.0 (6.830M)   : 0, 6830314

    section Manual
    This PR (4383) (8.247M)   : 0, 8246702
    master (8.535M)   : 0, 8534813
    benchmarks/2.33.0 (8.108M)   : 0, 8108026

    section Manual + Automatic
    This PR (4383) (6.505M)   : crit ,0, 6505240
    master (6.990M)   : 0, 6990093
    benchmarks/2.33.0 (6.856M)   : 0, 6856379

    section Version Conflict
    master (6.339M)   : 0, 6339396
    benchmarks/2.33.0 (5.893M)   : 0, 5893016
Loading 
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4383) (7.752M)   : 0, 7752223
    master (7.739M)   : 0, 7738834
    benchmarks/2.33.0 (7.765M)   : 0, 7764607
    benchmarks/2.9.0 (8.089M)   : 0, 8088812

    section No attack
    This PR (4383) (2.237M)   : 0, 2237304
    master (2.207M)   : 0, 2207260
    benchmarks/2.33.0 (2.209M)   : 0, 2208725
    benchmarks/2.9.0 (3.319M)   : 0, 3319024

    section Attack
    This PR (4383) (1.901M)   : 0, 1901065
    master (1.933M)   : 0, 1932642
    benchmarks/2.33.0 (1.911M)   : 0, 1910909
    benchmarks/2.9.0 (2.631M)   : 0, 2630747

    section Blocking
    This PR (4383) (3.885M)   : 0, 3884956
    master (3.845M)   : 0, 3844841
    benchmarks/2.33.0 (3.861M)   : 0, 3860900
Loading

@gleocadie gleocadie merged commit 128daa2 into master Jul 12, 2023
@gleocadie gleocadie deleted the gleocadie/fix-flacky-test branch July 12, 2023 13:26
@github-actions github-actions bot added this to the vNext milestone Jul 12, 2023
bouwkast pushed a commit that referenced this pull request Jul 31, 2023
@gleocadie @bouwkast
[Profiler] Fix flacky test (#4383)
55b6edf 
* Fix flacky test
* Change scenario pour GitMetadata tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

@chrisnas chrisnas chrisnas approved these changes

Assignees
No one assigned
Labels
area:profiler Issues related to the continous-profiler
Projects
None yet
Milestone
2.34.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gleocadie @andrewlock @chrisnas