Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version/license/description to .deb and .rpm packages #4377

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Add version/license/description to .deb and .rpm packages #4377

merged 1 commit into from
Jul 14, 2023

Conversation

randomanderson
Copy link
Contributor

Summary of changes

Add version/license/description to .deb and .rpm packages

Reason for change

They are expected by package users. The change was suggested on the original PR (#4303) and I thought it was applied.

@randomanderson randomanderson requested a review from a team as a code owner July 7, 2023 17:27
pierotibou
pierotibou approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@pierotibou pierotibou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I thought I had applied it as well. My bad

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jul 7, 2023 •
edited
Loading

Datadog Report

Branch report: landerson/add-info-to-packge
Commit report: 47301c8

❄️ dd-trace-dotnet: 0 Failed, 1 New Flaky, 291182 Passed, 1091 Skipped, 25m 14.48s Wall Time

New Flaky Tests (1)

  • NamedPipesSubmitsMetrics - Datadog.Trace.ClrProfiler.IntegrationTests.RuntimeMetricsTests - Last Failure

    Expand for error 
     Assert.Empty() Failure
 Expected: <empty>
 Actual:   [System.Exception: Less bytes were sent than we counted. 0 read versus 597 expected.
              at Datadog.Trace.TestHelpers.MockTracerAgent.ReadStreamBody(MockHttpRequest request) in D:\a\1\s\tracer\test\Datadog.Trace.TestHelpers\MockTracerAgent.cs:line 884
              at Datadog.Trace.TestHelpers.MockTracerAgent.HandlePotentialRemoteConfig(MockHttpRequest request) in D:\a\1\s\tracer\test\Datadog.Trace.TestHelpers\MockTracerAgent.cs:line 706
              at Datadog.Trace.TestHelpers.MockTracerAgent.HandleHttpRequest(MockHttpRequest request) in D:\a\1\s\tracer\test\Datadog.Trace.TestHelpers\MockTracerAgent.cs:line 497
              at Datadog.Trace.TestHelpers.MockTracerAgent.NamedPipeAgent.<HandleNamedPipeTraces>d__11.MoveNext() in D:\a\1\s\tracer\test\Datadog.Trace.TestHelpers\MockTracerAgent.cs:line 1221
           --- End of stack trace from previous location where exception was thrown ---
              at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
              at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
 ...

@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
andrewlock
andrewlock reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this process, but out of interest

  1. Why do we need to repackage these? Is it just to add the auto_inject-dotnet.version file? If so, could we not include that in the original deb
  2. Do we set the url/license/description in the original deb/rpm packages too?

@randomanderson
Copy link
Contributor Author

@andrewlock The main changes are:

  • renaming the package
  • adding the version file
  • signing

We created a separate package to move fast while releasing the autoinject tooling. The eventual goal is that there would only be one package created.

Here is an excerpt from the relevant doc:

Dotnet already has a package called “​​datadog-dotnet-apm”. This package isn’t published in any package repository. In the proposed naming convention, the name would be datadog-apm-library-dotnet instead
Resolution:

  • Create the new datadog-apm-library-dotnet package that will ship files in the proper location
  • Keep releasing the old datadog-dotnet-apm package for some time (it's only released through attaching it to Github releases right now AFAICS) - since these 2 packages will live in different locations, we can keep releasing both for a transitional period of time.
  • As soon as the new package is out, tell customers to start using it instead.
  • After the transitional period of time (to be defined by the APM team), we can stop releasing the datadog-dotnet-apm package and set "Obsoletes" tag on datadog-apm-library-dotnet, which will effectively mean that installing datadog-apm-library-dotnet will uninstall datadog-dotnet-apm.

@randomanderson
Copy link
Contributor Author

@pierotibou or @andrewlock can either of you babysit and merge this? I don't have the appropriate permissions to rerun the unit tests

@andrewlock
Copy link
Member

adding the version file

We can easily add that to our build steps, so we should probably do that soon 🙂

Keep releasing the old datadog-dotnet-apm package for some time (it's only released through attaching it to Github releases right now AFAICS) - since these 2 packages will live in different locations, we can keep releasing both for a transitional period of time.

IMO, if we want to transition customers to the new naming, we should be uploading the new packages to GitHub too. Customers are already primarily installing via GitHub releases (because that's all we had previously), so getting them to use an entirely new install process, while preferable, seems harder than getting them to find-and-replace a different filename in their scripts?

The downside is our already-too-long list of installers would get even longer 🤦‍♂️

As soon as the new package is out, tell customers to start using it instead

Have we done that? Is it "out" yet? 😄

After the transitional period of time (to be defined by the APM team), we can stop releasing the datadog-dotnet-apm package and set "Obsoletes" tag on datadog-apm-library-dotnet, which will effectively mean that installing datadog-apm-library-dotnet will uninstall datadog-dotnet-apm.

I find it hard to believe essentially any transitional period of time will be sufficient for this not to be massively breaking for customers unfortunately...

@andrewlock andrewlock force-pushed the landerson/add-info-to-packge branch from c2c7710 to 47301c8 Compare July 14, 2023 09:53
@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4377) - mean (2,990ms)  : 2922, 3058
     .   : milestone, 2990,
    master - mean (2,988ms)  : 2892, 3084
     .   : milestone, 2988,

    section CallTarget+Inlining+NGEN
    This PR (4377) - mean (3,819ms)  : 3751, 3887
     .   : milestone, 3819,
    master - mean (3,853ms)  : 3753, 3953
     .   : milestone, 3853,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4377) - mean (3,112ms)  : 3010, 3214
     .   : milestone, 3112,
    master - mean (3,118ms)  : 3046, 3190
     .   : milestone, 3118,

    section CallTarget+Inlining+NGEN
    This PR (4377) - mean (3,634ms)  : 3550, 3718
     .   : milestone, 3634,
    master - mean (3,632ms)  : 3581, 3683
     .   : milestone, 3632,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4377) - mean (3,097ms)  : 2999, 3194
     .   : milestone, 3097,
    master - mean (3,085ms)  : 2989, 3181
     .   : milestone, 3085,

    section CallTarget+Inlining+NGEN
    This PR (4377) - mean (3,606ms)  : 3550, 3663
     .   : milestone, 3606,
    master - mean (3,592ms)  : 3522, 3663
     .   : milestone, 3592,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4377) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (191ms)  : 187, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (4377) - mean (1,127ms)  : 1099, 1154
     .   : milestone, 1127,
    master - mean (1,131ms)  : 1105, 1157
     .   : milestone, 1131,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4377) - mean (394ms)  : 320, 468
     .   : milestone, 394,
    master - mean (374ms)  : 369, 379
     .   : milestone, 374,

    section CallTarget+Inlining+NGEN
    This PR (4377) - mean (1,191ms)  : 1167, 1214
     .   : milestone, 1191,
    master - mean (1,194ms)  : 1170, 1218
     .   : milestone, 1194,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4377) - mean (363ms)  : 355, 370
     .   : milestone, 363,
    master - mean (360ms)  : 355, 365
     .   : milestone, 360,

    section CallTarget+Inlining+NGEN
    This PR (4377) - mean (1,147ms)  : 1118, 1176
     .   : milestone, 1147,
    master - mean (1,140ms)  : 1112, 1168
     .   : milestone, 1140,
Loading

@andrewlock
Copy link
Member

Benchmarks Report 🐌

Benchmarks for #4377 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.172
  • 1 benchmarks are slower, with geometric mean 1.129
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 457μs 318ns 1.23μs 0 0 0 2.62 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 637μs 271ns 1.01μs 0 0 0 2.63 KB
master WriteAndFlushEnrichedTraces net472 815μs 189ns 707ns 0.403 0 0 3.22 KB
#4377 WriteAndFlushEnrichedTraces net6.0 471μs 85.4ns 308ns 0 0 0 2.62 KB
#4377 WriteAndFlushEnrichedTraces netcoreapp3.1 636μs 141ns 529ns 0 0 0 2.63 KB
#4377 WriteAndFlushEnrichedTraces net472 813μs 317ns 1.23μs 0.406 0 0 3.22 KB
Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 39μs 41ns 159ns 0.0197 0 0 1.65 KB
master AllCycleSimpleBody netcoreapp3.1 40.8μs 86.2ns 334ns 0.0204 0 0 1.63 KB
master AllCycleSimpleBody net472 41.8μs 16.2ns 60.5ns 0.249 0 0 1.69 KB
master AllCycleMoreComplexBody net6.0 225μs 70.3ns 263ns 0.11 0 0 9.22 KB
master AllCycleMoreComplexBody netcoreapp3.1 226μs 111ns 385ns 0.114 0 0 9.12 KB
master AllCycleMoreComplexBody net472 238μs 183ns 710ns 1.42 0 0 9.28 KB
master ObjectExtractorSimpleBody net6.0 115ns 0.0263ns 0.0985ns 0.00394 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 175ns 0.0415ns 0.155ns 0.00372 0 0 272 B
master ObjectExtractorSimpleBody net472 176ns 1.03ns 9ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3μs 0.746ns 2.89ns 0.054 0 0 3.88 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 3.95μs 1.29ns 4.65ns 0.0514 0 0 3.78 KB
master ObjectExtractorMoreComplexBody net472 4.53μs 23.4ns 112ns 0.618 0.00653 0 3.89 KB
#4377 AllCycleSimpleBody net6.0 38.8μs 25ns 96.9ns 0.0195 0 0 1.65 KB
#4377 AllCycleSimpleBody netcoreapp3.1 40.6μs 190ns 737ns 0.0205 0 0 1.63 KB
#4377 AllCycleSimpleBody net472 42μs 40.4ns 145ns 0.267 0 0 1.69 KB
#4377 AllCycleMoreComplexBody net6.0 219μs 71.3ns 276ns 0.109 0 0 9.22 KB
#4377 AllCycleMoreComplexBody netcoreapp3.1 228μs 228ns 885ns 0.114 0 0 9.12 KB
#4377 AllCycleMoreComplexBody net472 238μs 374ns 1.4μs 1.42 0 0 9.28 KB
#4377 ObjectExtractorSimpleBody net6.0 119ns 0.0632ns 0.237ns 0.00392 0 0 280 B
#4377 ObjectExtractorSimpleBody netcoreapp3.1 178ns 0.153ns 0.573ns 0.00377 0 0 272 B
#4377 ObjectExtractorSimpleBody net472 178ns 1.05ns 9.97ns 0.0446 0 0 281 B
#4377 ObjectExtractorMoreComplexBody net6.0 3.07μs 0.739ns 2.86ns 0.0536 0 0 3.88 KB
#4377 ObjectExtractorMoreComplexBody netcoreapp3.1 4.06μs 1.64ns 6.34ns 0.0527 0 0 3.78 KB
#4377 ObjectExtractorMoreComplexBody net472 4.06μs 1.57ns 6.08ns 0.618 0.00608 0 3.89 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 169μs 134ns 518ns 0.169 0 0 18.03 KB
master SendRequest netcoreapp3.1 187μs 267ns 1.03μs 0.187 0 0 20.09 KB
master SendRequest net472 0.00132ns 0.000362ns 0.0014ns 0 0 0 0 b
#4377 SendRequest net6.0 167μs 71.8ns 278ns 0.168 0 0 18.03 KB
#4377 SendRequest netcoreapp3.1 188μs 258ns 1E+03ns 0.187 0 0 20.09 KB
#4377 SendRequest net472 0.000276ns 0.00019ns 0.000711ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 523μs 767ns 2.77μs 0.494 0 0 41.52 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 629μs 604ns 2.26μs 0.322 0 0 41.72 KB
master WriteAndFlushEnrichedTraces net472 770μs 2.54μs 9.16μs 8.28 2.64 0.377 53.23 KB
#4377 WriteAndFlushEnrichedTraces net6.0 521μs 1μs 3.61μs 0.525 0 0 41.42 KB
#4377 WriteAndFlushEnrichedTraces netcoreapp3.1 626μs 1.4μs 5.42μs 0.309 0 0 41.76 KB
#4377 WriteAndFlushEnrichedTraces net472 769μs 2.34μs 9.06μs 8.44 2.68 0.383 53.25 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 854ns 0.288ns 1.08ns 0.0102 0 0 720 B
master ExecuteNonQuery netcoreapp3.1 1.2μs 0.811ns 3.14ns 0.00971 0 0 720 B
master ExecuteNonQuery net472 1.4μs 0.283ns 1.06ns 0.108 0.000707 0 682 B
#4377 ExecuteNonQuery net6.0 942ns 0.405ns 1.57ns 0.01 0 0 720 B
#4377 ExecuteNonQuery netcoreapp3.1 1.14μs 0.329ns 1.27ns 0.00977 0 0 720 B
#4377 ExecuteNonQuery net472 1.44μs 0.443ns 1.66ns 0.108 0.000724 0 682 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 967ns 0.207ns 0.747ns 0.0132 0 0 944 B
master CallElasticsearch netcoreapp3.1 1.23μs 0.437ns 1.64ns 0.0129 0 0 944 B
master CallElasticsearch net472 1.95μs 0.501ns 1.94ns 0.151 0.000974 0 955 B
master CallElasticsearchAsync net6.0 1.03μs 0.343ns 1.24ns 0.0131 0 0 920 B
master CallElasticsearchAsync netcoreapp3.1 1.35μs 0.429ns 1.61ns 0.0135 0 0 992 B
master CallElasticsearchAsync net472 2.21μs 0.672ns 2.51ns 0.161 0 0 1.01 KB
#4377 CallElasticsearch net6.0 932ns 0.324ns 1.25ns 0.0131 0 0 944 B
#4377 CallElasticsearch netcoreapp3.1 1.29μs 0.538ns 2.08ns 0.0129 0 0 944 B
#4377 CallElasticsearch net472 2.12μs 0.487ns 1.75ns 0.152 0.00106 0 955 B
#4377 CallElasticsearchAsync net6.0 1.11μs 0.626ns 2.42ns 0.0128 0 0 920 B
#4377 CallElasticsearchAsync netcoreapp3.1 1.38μs 1.08ns 4.06ns 0.0137 0 0 992 B
#4377 CallElasticsearchAsync net472 2.18μs 1.36ns 5.28ns 0.16 0.00109 0 1.01 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.15μs 0.776ns 3.01ns 0.0126 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.43μs 0.357ns 1.34ns 0.0125 0 0 912 B
master ExecuteAsync net472 1.58μs 0.241ns 0.901ns 0.139 0.000792 0 875 B
#4377 ExecuteAsync net6.0 1.16μs 0.635ns 2.38ns 0.0124 0 0 912 B
#4377 ExecuteAsync netcoreapp3.1 1.36μs 0.468ns 1.62ns 0.0122 0 0 912 B
#4377 ExecuteAsync net472 1.58μs 0.582ns 2.25ns 0.139 0.000793 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 3.52μs 1.18ns 4.42ns 0.0265 0 0 1.9 KB
master SendAsync netcoreapp3.1 4.28μs 1.07ns 3.71ns 0.0321 0 0 2.43 KB
master SendAsync net472 6.71μs 1.79ns 6.92ns 0.476 0 0 3 KB
#4377 SendAsync net6.0 3.67μs 1.28ns 4.79ns 0.0258 0 0 1.9 KB
#4377 SendAsync netcoreapp3.1 4.21μs 2.26ns 8.14ns 0.0315 0 0 2.43 KB
#4377 SendAsync net472 6.75μs 2.69ns 10.1ns 0.475 0 0 3 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.24μs 0.696ns 2.6ns 0.023 0 0 1.62 KB
master EnrichedLog netcoreapp3.1 2.05μs 5.4ns 20.9ns 0.0216 0 0 1.62 KB
master EnrichedLog net472 2.26μs 0.807ns 2.8ns 0.245 0 0 1.54 KB
#4377 EnrichedLog net6.0 1.29μs 0.652ns 2.44ns 0.0225 0 0 1.62 KB
#4377 EnrichedLog netcoreapp3.1 1.93μs 0.897ns 3.36ns 0.0222 0 0 1.62 KB
#4377 EnrichedLog net472 2.31μs 1.6ns 5.76ns 0.244 0 0 1.54 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 112μs 206ns 800ns 0.0555 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 116μs 111ns 431ns 0 0 0 4.21 KB
master EnrichedLog net472 146μs 101ns 379ns 0.658 0.219 0 4.38 KB
#4377 EnrichedLog net6.0 111μs 142ns 549ns 0.0559 0 0 4.21 KB
#4377 EnrichedLog netcoreapp3.1 115μs 70.7ns 265ns 0 0 0 4.21 KB
#4377 EnrichedLog net472 145μs 131ns 508ns 0.652 0.217 0 4.38 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.8μs 1.06ns 4.1ns 0.0307 0 0 2.18 KB
master EnrichedLog netcoreapp3.1 3.93μs 1.91ns 6.87ns 0.0294 0 0 2.18 KB
master EnrichedLog net472 4.66μs 1.75ns 6.78ns 0.316 0 0 1.99 KB
#4377 EnrichedLog net6.0 2.84μs 1ns 3.62ns 0.0301 0 0 2.18 KB
#4377 EnrichedLog netcoreapp3.1 3.83μs 1.38ns 5.16ns 0.0289 0 0 2.18 KB
#4377 EnrichedLog net472 4.5μs 1.28ns 4.79ns 0.316 0 0 1.99 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.13μs 0.508ns 1.97ns 0.0157 0 0 1.11 KB
master SendReceive netcoreapp3.1 1.45μs 0.699ns 2.52ns 0.0152 0 0 1.11 KB
master SendReceive net472 1.7μs 1.7ns 6.58ns 0.177 0 0 1.12 KB
#4377 SendReceive net6.0 1.12μs 0.532ns 1.99ns 0.0153 0 0 1.11 KB
#4377 SendReceive netcoreapp3.1 1.4μs 0.66ns 2.47ns 0.0149 0 0 1.11 KB
#4377 SendReceive net472 1.65μs 0.387ns 1.45ns 0.177 0.000821 0 1.12 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.57μs 1.19ns 4.44ns 0.0206 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.5μs 1.31ns 4.89ns 0.021 0 0 1.58 KB
master EnrichedLog net472 3.93μs 2.69ns 10.4ns 0.31 0 0 1.96 KB
#4377 EnrichedLog net6.0 2.43μs 1.03ns 3.56ns 0.0208 0 0 1.53 KB
#4377 EnrichedLog netcoreapp3.1 3.64μs 4.83ns 18.7ns 0.0208 0 0 1.58 KB
#4377 EnrichedLog net472 3.86μs 0.884ns 3.31ns 0.311 0 0 1.96 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4377

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.129 698.86 789.21

Faster 🎉 in #4377

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.201 557.21 463.80

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 432ns 0.147ns 0.55ns 0.00755 0 0 536 B
master StartFinishSpan netcoreapp3.1 599ns 0.144ns 0.558ns 0.00739 0 0 536 B
master StartFinishSpan net472 616ns 0.365ns 1.37ns 0.0852 0 0 538 B
master StartFinishScope net6.0 557ns 0.174ns 0.652ns 0.0093 0 0 656 B
master StartFinishScope netcoreapp3.1 699ns 0.284ns 1.06ns 0.00884 0 0 656 B
master StartFinishScope net472 806ns 1.09ns 4.23ns 0.0982 0 0 618 B
#4377 StartFinishSpan net6.0 474ns 0.186ns 0.722ns 0.0076 0 0 536 B
#4377 StartFinishSpan netcoreapp3.1 560ns 0.265ns 0.992ns 0.00719 0 0 536 B
#4377 StartFinishSpan net472 621ns 0.146ns 0.547ns 0.0854 0 0 538 B
#4377 StartFinishScope net6.0 464ns 0.132ns 0.493ns 0.00921 0 0 656 B
#4377 StartFinishScope netcoreapp3.1 789ns 0.248ns 0.894ns 0.00917 0 0 656 B
#4377 StartFinishScope net472 853ns 0.16ns 0.62ns 0.098 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4377

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.143 578.28 506.07

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 578ns 0.283ns 1.02ns 0.00931 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 761ns 0.331ns 1.28ns 0.00888 0 0 656 B
master RunOnMethodBegin net472 897ns 0.429ns 1.66ns 0.0982 0 0 618 B
#4377 RunOnMethodBegin net6.0 506ns 0.233ns 0.873ns 0.00922 0 0 656 B
#4377 RunOnMethodBegin netcoreapp3.1 763ns 0.24ns 0.898ns 0.00881 0 0 656 B
#4377 RunOnMethodBegin net472 897ns 0.51ns 1.84ns 0.0979 0 0 618 B

@andrewlock
Copy link
Member

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4377) (11.048M)   : 0, 11048443
    master (10.902M)   : 0, 10901521
    benchmarks/2.33.0 (10.950M)   : 0, 10949608
    benchmarks/2.9.0 (10.949M)   : 0, 10948638

    section Automatic
    This PR (4377) (7.717M)   : 0, 7716890
    master (7.534M)   : 0, 7533509
    benchmarks/2.33.0 (7.621M)   : 0, 7620707
    benchmarks/2.9.0 (7.869M)   : 0, 7869138

    section Trace stats
    master (7.595M)   : 0, 7595057
    benchmarks/2.33.0 (7.602M)   : 0, 7602038

    section Manual
    This PR (4377) (9.961M)   : 0, 9961318
    master (9.815M)   : 0, 9814905
    benchmarks/2.33.0 (9.770M)   : 0, 9770235

    section Manual + Automatic
    This PR (4377) (7.429M)   : 0, 7428784
    master (7.255M)   : 0, 7254836
    benchmarks/2.33.0 (7.189M)   : 0, 7188658

    section Version Conflict
    master (6.579M)   : 0, 6579121
    benchmarks/2.33.0 (6.553M)   : 0, 6553316
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4377) (9.648M)   : 0, 9648191
    master (9.667M)   : 0, 9666802
    benchmarks/2.33.0 (9.426M)   : 0, 9425603
    benchmarks/2.9.0 (9.651M)   : 0, 9650936

    section Automatic
    This PR (4377) (6.576M)   : 0, 6576054
    master (6.755M)   : 0, 6754566
    benchmarks/2.33.0 (6.803M)   : 0, 6802932

    section Trace stats
    master (6.777M)   : 0, 6776538
    benchmarks/2.33.0 (6.810M)   : 0, 6810447

    section Manual
    This PR (4377) (8.483M)   : 0, 8483324
    master (8.561M)   : 0, 8561047
    benchmarks/2.33.0 (8.435M)   : 0, 8434569

    section Manual + Automatic
    This PR (4377) (6.383M)   : 0, 6383497
    master (6.332M)   : 0, 6331957
    benchmarks/2.33.0 (6.465M)   : 0, 6465149

    section Version Conflict
    master (5.975M)   : 0, 5975266
    benchmarks/2.33.0 (5.807M)   : 0, 5806690
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4377) (10.738M)   : 0, 10738165
    master (10.104M)   : 0, 10103707
    benchmarks/2.33.0 (9.426M)   : 0, 9426080
    benchmarks/2.9.0 (9.867M)   : 0, 9866970

    section Automatic
    This PR (4377) (7.568M)   : 0, 7568271
    master (6.982M)   : 0, 6982306
    benchmarks/2.33.0 (6.469M)   : 0, 6468939
    benchmarks/2.9.0 (7.247M)   : 0, 7247453

    section Trace stats
    master (7.247M)   : 0, 7246697
    benchmarks/2.33.0 (6.830M)   : 0, 6830314

    section Manual
    This PR (4377) (9.397M)   : 0, 9397061
    master (9.251M)   : 0, 9251104
    benchmarks/2.33.0 (8.108M)   : 0, 8108026

    section Manual + Automatic
    This PR (4377) (7.392M)   : 0, 7391615
    master (6.956M)   : 0, 6956130
    benchmarks/2.33.0 (6.856M)   : 0, 6856379

    section Version Conflict
    master (6.380M)   : 0, 6380435
    benchmarks/2.33.0 (5.893M)   : 0, 5893016
Loading 
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4377) (7.761M)   : 0, 7761142
    master (7.605M)   : 0, 7605248
    benchmarks/2.33.0 (7.765M)   : 0, 7764607
    benchmarks/2.9.0 (8.067M)   : 0, 8066743

    section No attack
    This PR (4377) (2.202M)   : 0, 2201733
    master (2.207M)   : 0, 2207340
    benchmarks/2.33.0 (2.209M)   : 0, 2208725
    benchmarks/2.9.0 (3.337M)   : 0, 3336566

    section Attack
    This PR (4377) (1.915M)   : 0, 1914600
    master (1.918M)   : 0, 1917897
    benchmarks/2.33.0 (1.911M)   : 0, 1910909
    benchmarks/2.9.0 (2.611M)   : 0, 2611151

    section Blocking
    This PR (4377) (3.860M)   : 0, 3859753
    master (3.854M)   : 0, 3854094
    benchmarks/2.33.0 (3.861M)   : 0, 3860900
Loading

@andrewlock andrewlock merged commit 09a3082 into master Jul 14, 2023
@andrewlock andrewlock deleted the landerson/add-info-to-packge branch July 14, 2023 16:01
@github-actions github-actions bot added this to the vNext milestone Jul 14, 2023
bouwkast pushed a commit that referenced this pull request Jul 31, 2023
@randomanderson @bouwkast
Add version/license/description to .deb and .rpm packages (#4377)
99393aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock left review comments

@pierotibou pierotibou pierotibou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.34.0
Development

Successfully merging this pull request may close these issues.
3 participants
@randomanderson @andrewlock @pierotibou